spreewald 4.4.1 → 4.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 892a8b1fc2985989a10ad303aa6be9a65a4ea3542bea9c5d9311fb0f1463b73a
-  data.tar.gz: 2031b66e60406bd9205204a6355fc0f745eed30abf3b14095121f9b04290610e
+  metadata.gz: fafd6c66aa09488c02f829c4b64352d5fc0b8c313cbfcf3da8c8bfc9ef486192
+  data.tar.gz: 2839f5ae1583910b595d9df1166cf3a26696d23a7850c444715e0b965b137782
 SHA512:
-  metadata.gz: e7c84b276c5b1cca99a3beac23d656d206ae68cc8f74b17ca3b316b59703249611c226c85d1cc17305faf588e56a1b689d213b916251db4e876c3644c48ee893
-  data.tar.gz: a61b5d8dd7bf93dca91ea19a69d77de47ddb79b251bacf4ed37b79b1cab91972ea5c2f995d05f9ccf2d83f5a6f37b36882a14ffba178399380da192495a7ac34
+  metadata.gz: e75c55d4e317c6e67fb93f35b0eac0ed1c9aa9bc4b28a6b68f45976734e5e4ad684549052529b2ce3d3fa31e2b3ef2835cbd16da1d91af991b85811e2cfdf2fa
+  data.tar.gz: ab32078bf86d139a1ee68f21b27217a780eaad1784cf7dd1cf777a7fb2a4a0ceed42f7bf58e657fde8f1157984858bcd430c0d81e6dce79d51c2e032e9a20036

data/CHANGELOG.md

@@ -3,6 +3,36 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 4.4.3
+- Improve performance of the `I should (not) see a field ...` step to not retry the query when the element is **not** expected to be there.
+- Improve the `an email should have been sent with` step to ignore successive whitespaces after newlines in HTML mail bodies, effectively improving text matching in formatted HTML-tags.
+
+  For example, when searching for `Test` inside of the following HTML, you **no longer** need to use asterisks, because the leading whitespaces/tabs in front of `Test` are ignored:
+    ```html
+    <dt>
+      Test
+    </dt>
+    ```
+  
+    ```Gherkin
+    Then a mail should have been sent with
+    """
+    Test
+    """
+    ```
+    
+    Up to this version, the plain text was resolved to `\n  Test\n` (not `\nTest\n`) so it was necessary to declare a placeholder (`*`) for whitespaces:
+    ```Gherkin
+    Then a mail should have been sent with
+    """
+    *Test
+    """
+    ```
+
+## 4.4.2
+- Add `ActionController::UrlGenerationError` to `patiently`'s retry errors.
+  - This will solve timing issues when e.g. using step `I should be on ...` after creating a record via AJAX
+
 ## 4.4.1
 - Fix deprecation warning for `ActiveRecord::Base.default_timezone` when running with Rails 7.0 ([#191](https://github.com/makandra/spreewald/issues/191))
 - Fix deprecation warning for using keyword arguments as last argument when running with ruby 2.7 ([#192](https://github.com/makandra/spreewald/issues/192))

data/README.md

@@ -25,7 +25,7 @@ Require all Spreewald steps by putting
 into either your `support/env.rb` or `step_definitions/spreewald_steps.rb`.
 
 Steps are grouped into a number of categories. If you only want to use a subset
-of Spreewald's steps, insead of `require 'spreewald/all_steps'`, you can pick 
+of Spreewald's steps, instead of `require 'spreewald/all_steps'`, you can pick 
 and choose single categories by requiring [single files](https://github.com/makandra/spreewald/tree/master/lib/spreewald) like this:
 
     require 'spreewald/email_steps'
@@ -38,7 +38,7 @@ After that you are good to go and use the steps [described below](#steps).
 We recommend using a `features/support/paths.rb` file in your project to define mappings between verbal phrases and your project's routes. You can then use these phrases in steps like `Then I should be on ...` or `When I go to ...`.
 You can find [an example in this repository](https://github.com/makandra/spreewald/blob/master/examples/paths.rb). Please note that you may have to adapt it depending on the namespaces and other setup of your application's routes.
 
-Similarly, you may define a `features/support/paths.rb` file in your project to define mappings of verbal phrases to CSS selectors. You can also find [an example for that in this repository](https://github.com/makandra/spreewald/blob/master/examples/selectors.rb). These mappings can be used with steps like `Then I should( not)? see (an|the) element for ...` or `When I click on the element for ...`.
+Similarly, you may define a `features/support/selectors.rb` file in your project to define mappings of verbal phrases to CSS selectors. You can also find [an example for that in this repository](https://github.com/makandra/spreewald/blob/master/examples/selectors.rb). These mappings can be used with steps like `Then I should( not)? see (an|the) element for ...` or `When I click on the element for ...`.
 
 We also suggest to look at our [recommended Capybara defaults](#recommended-capybara-defaults) as they impact the behavior of many Spreewald steps.
 

data/lib/spreewald/web_steps.rb

@@ -194,17 +194,12 @@ end.overridable
 
 # Checks for the existance of an input field (given its id or label)
 Then /^I should( not)? see a field "([^"]*)"$/ do |negate, name|
-  expectation = negate ? :not_to : :to
-  patiently do
-    begin
-      # In old Capybaras find returns nil, so we assign it to `field`
-      field = find_with_disabled(:field, name)
-    rescue Capybara::ElementNotFound
-      # In Capybara 0.4+ #find raises an error instead of returning nil
-      # We must explicitely reset the field variable from a previous patiently iteration
-      field = nil
+  if negate
+    expect(page).to have_no_field(name)
+  else
+    patiently do
+      expect(page).to have_field(name, disabled: :all)
     end
-    expect(field).send(expectation, be_present)
   end
 end.overridable
 

data/lib/spreewald_support/mail_to_plaintext_converter.rb

@@ -36,7 +36,11 @@ module Spreewald
     end
   
     def text_from_html(html)
-      Nokogiri::HTML(html).at_css('body').text.gsub(/[\r\n]+/, "\n")
+      Nokogiri::HTML(html)
+        .at_css('body')
+        .text
+        .gsub(/[\r\n]+/, "\n")
+        .gsub(/\n\s+/, "\n")
     end
   end
 end

data/lib/spreewald_support/tolerance_for_selenium_sync_issues.rb

@@ -1,5 +1,6 @@
 module ToleranceForSeleniumSyncIssues
   RETRY_ERRORS = %w[
+    ActionController::UrlGenerationError
     Capybara::ElementNotFound
     Spec::Expectations::ExpectationNotMetError
     RSpec::Expectations::ExpectationNotMetError

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '4.4.1'
+  VERSION = '4.4.3'
 end

data/tests/rails-7_capybara-3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (4.4.0)
+    spreewald (4.4.3)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

data/tests/shared/app/views/mailer/html_email_with_linebreaks.html

@@ -1,6 +1,6 @@
 <p>
-Hello!
+  Hello!
 </p>
 <p>
-Bye!
+  Bye!
 </p>

data/tests/shared/features/shared/web_steps.feature

@@ -362,6 +362,7 @@ Feature: Web steps
     When I go to "/forms/disabled_elements"
     Then I should see a field "Enabled field #1"
       And I should see a field "Disabled field #1"
+    But I should not see a field "Non-existing field"
 
 
   Scenario: /^I should( not)? see the (?:number|amount) ([\-\d,\.]+)(?: (.*?))?$/

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreewald
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 4.4.3
 platform: ruby
 authors:
 - Tobias Kraze
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-10 00:00:00.000000000 Z
+date: 2022-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber