spreewald 4.3.3 → 4.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 154442a339318c7f74e490bd7e8783e8abb24820d564b7c52fe6072bfd5cdb2d
-  data.tar.gz: 2351555ffdd10b049ccf1e06e50b5eee41206d15bf716354337c4effb8464d38
+  metadata.gz: 319d2bf7ea1d7a001c53922c7142a1ccad262f3f7da34d48882c2fd9d825c3d6
+  data.tar.gz: cbd10a35c3a70400453854840e4fa0b2fe5c0646e9fec8efa9dc7a057eb109e1
 SHA512:
-  metadata.gz: 4b4534235a684eaeb0f19b08fd207254c4d3bbf87a2a78cbb34bf04414a5addef88624127abfe3b426a5415d3a517a556be569743248aa098b46c69b7013a59e
-  data.tar.gz: fe86089babc5374da459a9305097292a5d47943cd0cabf6932bd88768d7447e8e7424fff7b9c4c0de2ebc00c82cc83e54fa89636f120c89e612a6dddf5a8c4d6
+  metadata.gz: dc7159b50dde000619bbcf67e7fcc8b3623b3e4a8a3924917368475baf8e1a07c0ab81e412b66ca9b38bf8b4e2a344aa008f8c82a4e6a6726a758d46bd765ab6
+  data.tar.gz: aab557914fbde6a4b6affbea66cde6c3a2e325176dd544afc603204cf7800a50a126651ab4aadf48738931cacc1fdd075b3f7c63f43f085f2f923fb77b195ec7

data/CHANGELOG.md

@@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 4.3.6
+- Use capybara's `make_visible` [option](https://github.com/teamcapybara/capybara/blob/0468de5a810aae75ab9de20447e246c5c35473f0/lib/capybara/node/actions.rb#L279) in step `I attach the file "..." to "..."`
+  - This will make CSS-Hacks like setting the opacity in tests obsolete
+
+## 4.3.5
+- Fix deprecation warning for using keyword arguments as last argument when running with ruby 2.7
+
+## 4.3.4
+- Fix "undefined method `build_rb_world_factory` for nil:NilClass" error when running tests on a real project'
+  - The field error class couldn't be required in certain circumstances and so the specs failed
+
 ## 4.3.3
 - Fixes that the `Spreewald.field_error_class` configuration
 did not find the correct elements
@@ -12,7 +23,14 @@ did not find the correct elements
   - `The ... field should have the error ...`
   - `The ... field should have an error`
 - Added the possibility to specify custom error classes and message selectors for these steps
-  using `Spreewald.field_error_class` and `Spreewald.error_message_xpath_selector` in your configuration. 
+  using `Spreewald.field_error_class` and `Spreewald.error_message_xpath_selector` in your configuration.
+
+- We had separate steps for e.g. `I should see ...` and `I should not see ...`. These were merged now:
+  - `I should see "..."` + `I should not see "..."` => `I should( not)? see "..."`
+  - `I should see /.../` + `I should not see /.../` => `I should( not)? see /.../`
+  - `I should see '...'` + `I should not see '...'` => `I should( not)? see '...'`
+- Optional negation was made more consistent. The steps use `"( not)? "` now.
+- The search via `spreewald some query here` includes steps with optional negation now.
 
 ## 4.2.2
 - Fixes the "Show me the email" step (#171)

data/README.md

@@ -4,6 +4,10 @@ Spreewald is a collection of useful steps for cucumber. Feel free to fork.
 
 You can find a list of all contained steps at the end of this README.
 
+## Supported versions
+
+Spreewald is currently tested against and Ruby 2.6.6 and 3.0.0 with Rails 6 and Capybara 3.
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -12,18 +16,7 @@ Add this line to your application's Gemfile:
 
 And then execute:
 
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install spreewald
-
-
-## Supported versions
-
-Spreewald is currently tested against and Ruby 2.6.6 with Rails 6 and Capybara 3.
-
-## Usage
+    $ bundle install
 
 Require all Spreewald steps by putting
 
@@ -32,19 +25,28 @@ Require all Spreewald steps by putting
 into either your `support/env.rb` or `step_definitions/spreewald_steps.rb`.
 
 Steps are grouped into a number of categories. If you only want to use a subset
-of Spreewald's steps, you can pick and choose single categories by requiring
-single files like this:
+of Spreewald's steps, insead of `require 'spreewald/all_steps'`, you can pick 
+and choose single categories by requiring [single files](https://github.com/makandra/spreewald/tree/master/lib/spreewald) like this:
 
     require 'spreewald/email_steps'
     require 'spreewald/web_steps'
 
-Have a look at our [recommended Capybara defaults](#recommended-capybara-defaults) as they impact the behavior of many Spreewald steps.
+After that you are good to go and use the steps [described below](#steps).
+
+### Recommended additional setup
+
+We recommend using a `features/support/paths.rb` file in your project to define mappings between verbal phrases and your project's routes. You can then use these phrases in steps like `Then I should be on ...` or `When I go to ...`.
+You can find [an example in this repository](https://github.com/makandra/spreewald/blob/master/examples/paths.rb). Please note that you may have to adapt it depending on the namespaces and other setup of your application's routes.
+
+Similarly, you may define a `features/support/paths.rb` file in your project to define mappings of verbal phrases to CSS selectors. You can also find [an example for that in this repository](https://github.com/makandra/spreewald/blob/master/examples/selectors.rb). These mappings can be used with steps like `Then I should( not)? see (an|the) element for ...` or `When I click on the element for ...`.
+
+We also suggest to look at our [recommended Capybara defaults](#recommended-capybara-defaults) as they impact the behavior of many Spreewald steps.
 
 ## Spreewald binary
 
 Spreewald comes with a binary that prints a list of all Cucumber steps from
 Spreewald _and your project_. It will filter the list by any string you
-pass it. Example usage:
+pass it. Example usage (e.g. on a linux shell in the root folder of the project which uses Spreewald):
 
 ```bash
 spreewald # lists all steps
@@ -94,7 +96,7 @@ Capybara.default_normalize_ws = true
 
 This will affect all Spreewald steps that are using Capybara's `:text` option.
 
-Furthermore, we recommend setting [Capybara's matching strategy](https://github.com/teamcapybara/capybara/blob/master/README.md#strategy) to `:prefer_exact`. This will positively affect Spreewald steps as it prevents the `Capybara::Ambiguous` error in the edge case when two fields are matching the given name, but one of the matches includes the name only as a substring,
+Furthermore, we recommend setting [Capybara's matching strategy](https://github.com/teamcapybara/capybara/blob/master/README.md#strategy) to `:prefer_exact`. This will positively affect Spreewald steps as it prevents the `Capybara::Ambiguous` error in the edge case when two fields are matching the given name, but one of the matches includes the name only as a substring.
 
 ```ruby
 Capybara.match = :prefer_exact
@@ -119,14 +121,11 @@ Spreewald has different kind of tests:
 
 Run all tests for your current ruby version with `rake` or `rake matrix:tests`. To bundle use `rake matrix:install` first.
 
-Please note that you need [geordi](https://github.com/makandra/geordi) to run the integration tests.
-
-
 ### If you would like to contribute:
 
 - Fork the repository
 - Push your changes with specs
-- Make sure `rake` passes
+- Make sure `rake matrix:tests` passes
 - Regenerate the "Steps" section of this Readme with `rake update_readme`, if needed
 - Make a pull request
 

data/lib/spreewald/web_steps.rb

@@ -160,8 +160,11 @@ end.overridable
 
 # Attach a file to a file upload form field
 When /^(?:|I )attach the file "([^"]*)" to "([^"]*)"$/ do |path, field|
+  options = {}
+  options[:make_visible] = true if javascript_capable?
+
   patiently do
-    attach_file(field, File.expand_path(path))
+    attach_file(field, File.expand_path(path), options)
   end
 end.overridable
 
@@ -486,18 +489,18 @@ end.overridable
 # Checks for the presence of an option in a select
 Then /^"([^"]*)" should( not)? be an option for "([^"]*)"$/ do |value, negate, field|
   finder_arguments = if Spreewald::Comparison.compare_versions(Capybara::VERSION, :<, "2.12")
-    ['option', { :text => value }]
+    { text: value }
   else
-    ['option', { :exact_text => value }]
+    { exact_text: value }
   end
   patiently do
     if negate
       begin
-        expect(find_with_disabled(:field, field)).to have_no_css(*finder_arguments)
+        expect(find_with_disabled(:field, field)).to have_no_css('option', **finder_arguments)
       rescue Capybara::ElementNotFound
       end
     else
-      expect(find_with_disabled(:field, field)).to have_css(*finder_arguments)
+      expect(find_with_disabled(:field, field)).to have_css('option', **finder_arguments)
     end
   end
 end.overridable

data/lib/spreewald.rb

@@ -1,7 +1,6 @@
 # coding: UTF-8
 
 require 'cucumber_priority'
-require "spreewald_support/field_errors"
 require "spreewald_support/version"
 require "spreewald_support/github"
 require "spreewald_support/unsupported_email_header"

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '4.3.3'
+  VERSION = '4.3.6'
 end

data/spreewald.gemspec

@@ -9,6 +9,7 @@ Gem::Specification.new do |gem|
   gem.summary       = %q{Collection of useful cucumber steps.}
   gem.homepage      = "https://github.com/makandra/spreewald"
   gem.license       = 'MIT'
+  gem.metadata = { 'rubygems_mfa_required' => 'true' }
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }

data/tests/rails-6_capybara-3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (4.3.3)
+    spreewald (4.3.6)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreewald
 version: !ruby/object:Gem::Version
-  version: 4.3.3
+  version: 4.3.6
 platform: ruby
 authors:
 - Tobias Kraze
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-26 00:00:00.000000000 Z
+date: 2022-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -334,7 +334,8 @@ files:
 homepage: https://github.com/makandra/spreewald
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths: