spreewald 3.0.3 → 4.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a51defb2267ab0f0f6e9123b474e0069758e59eaa3f18cadefdfdb81a5f5760
-  data.tar.gz: f47297c29b676ee194c1dbc2f335eab608afefa9730e124e8811d4542089031e
+  metadata.gz: 6e425e7e26a5116b37aefcfc41a7350d08392a96e2bfb8a1a90b43299dfad007
+  data.tar.gz: 313450b0319dc774bbc9de556537be45abff675075df3b6e5d8238590ca600ce
 SHA512:
-  metadata.gz: 3b93c18acce9d744364898f65e6f3597d06b37ed85d69bb81e3593521d0433bc56338b974c32133c0fce749190ee8af63c146b355e12601397b3641d4424380d
-  data.tar.gz: b675ad24c9c6e9836880d9111f1538d8f3b5c2d91e390dc5ee5165842cb19298d039fa428405dd47df20daa40b59234f641fcc3e4cab2cf0f6405449ecad981c
+  metadata.gz: 1529fe5cf2bc32e637042b622487dfa43ce3d18ebfe201cf3c97dc6163334c3f70c2560d6a21703c3f141bc07fcec08c1109f84b51dd33d70492007fdf04ced9
+  data.tar.gz: 6b4ab76bd09f08c63a8789c88e1fe65b8888255cf7805cf9dae2b114259801fe97c2a66f3facad97dc18f2f5dee69fe1c7e338fe9594c84a871671e1958238c3

data/.github/workflows/test.yml

@@ -0,0 +1,42 @@
+---
+name: Tests
+'on':
+  push:
+    branches:
+    - master
+  pull_request:
+    branches:
+    - master
+jobs:
+  test:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+        # Test projects
+        - ruby: 2.4.5
+          gemfile: tests/rails-4_capybara-2/Gemfile
+        - ruby: 3.0.0
+          gemfile: tests/rails-6_capybara-3/Gemfile
+        # Used to run rspec and integration tests for spreewald binary:
+        - ruby: 2.4.5
+          gemfile: Gemfile.ruby245
+        - ruby: 2.6.6
+          gemfile: Gemfile.ruby266
+        - ruby: 3.0.0
+          gemfile: Gemfile.ruby300
+    env:
+      BUNDLE_GEMFILE: "${{ matrix.gemfile }}"
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "${{ matrix.ruby }}"
+    - name: Bundle
+      run: |
+        gem install bundler:1.17.3
+        bundle install --no-deployment
+    - name: Run tests
+      run: bundle exec rake matrix:single_test[${{ matrix.gemfile }},${{ matrix.ruby }}]

data/.ruby-version

@@ -1 +1 @@
-2.4.5
+3.0.0

data/CHANGELOG.md

@@ -3,6 +3,37 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 4.2.2
+- Fixes the "Show me the email" step (#171)
+- Fixes the "I follow the link in the email" step. (#172, #173)
+  - It works for emails with and without explicit html parts
+  - There's a better error message if no links are found
+
+## 4.1.2
+- Multiple invocations of console don't raise anymore
+
+## 4.1.1
+- The step `I open .. in a new browser tab` is now using the `noopener` option (see issue [#174])
+
+## 4.1.0
+
+- New steps:
+  - When ... inside the ... iframe
+
+- New steps only available for Capybara 3+:
+  - When I switch to the ... iframe
+  - When I switch back to the whole page
+  - The I switch back to the whole page step does not work reliably with Capybara 2 and lead to StaleReferenceErrors, therefore we decided to not make these steps available for Capybara 2.
+
+- Small improvements:
+  - Trying to match against unsupported email headers will raise an error. Supported headers are "To", "CC", "BCC", "From", "Reply-To", "Subject", "Attachments"
+  - It's now possible to have indented header lines in email steps.
+  - If there's not an explicit text part in a mail, Spreewald determines if the email body is HTML or plaintext and converts it to plaintext accordingly.
+
+## 4.0.0
+
+- Dropped support for capybara 1, Ruby 2.1 and Rails 3.2. 
+
 ## 3.0.3
 
 - The `an email should have been sent with` step now interprets all lines as body when not specifying headers (see issue [#157](https://github.com/makandra/spreewald/issues/157))

data/Gemfile

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
 gem 'rake'
-gem 'gemika'
+gem 'gemika'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    gemika (0.4.0)
+    gemika (0.5.0)
     rake (12.3.2)
 
 PLATFORMS
@@ -12,4 +12,4 @@ DEPENDENCIES
   rake
 
 BUNDLED WITH
-   1.17.3
+   2.2.3

data/Gemfile.ruby245

@@ -1,7 +1,10 @@
 source 'https://rubygems.org'
 
+gem 'rake'
 gem 'rspec'
 gem 'cucumber'
 gem 'aruba'
 
 gem 'gemika'
+gem 'mail'
+gem 'nokogiri'

data/Gemfile.ruby245.lock

@@ -31,10 +31,16 @@ GEM
     cucumber-wire (0.0.1)
     diff-lcs (1.3)
     ffi (1.10.0)
-    gemika (0.3.4)
+    gemika (0.5.0)
     gherkin (5.1.0)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    mini_mime (1.0.1)
+    mini_portile2 (2.4.0)
     multi_json (1.13.1)
     multi_test (0.1.2)
+    nokogiri (1.10.10)
+      mini_portile2 (~> 2.4.0)
     rake (12.3.2)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
@@ -58,7 +64,10 @@ DEPENDENCIES
   aruba
   cucumber
   gemika
+  mail
+  nokogiri
+  rake
   rspec
 
 BUNDLED WITH
-   1.17.3
+   2.2.4

data/Gemfile.ruby266

@@ -2,8 +2,11 @@ source 'https://rubygems.org'
 
 ruby '2.6.6'
 
+gem 'rake'
 gem 'rspec'
 gem 'cucumber'
 gem 'aruba'
 
 gem 'gemika'
+gem 'mail'
+gem 'nokogiri'

data/Gemfile.ruby266.lock

@@ -30,10 +30,17 @@ GEM
     cucumber-wire (0.0.1)
     diff-lcs (1.3)
     ffi (1.12.2)
-    gemika (0.4.0)
+    gemika (0.5.0)
     gherkin (5.1.0)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    mini_mime (1.0.2)
     multi_json (1.14.1)
     multi_test (0.1.2)
+    nokogiri (1.11.1-x86_64-linux)
+      racc (~> 1.4)
+    racc (1.5.2)
+    rake (13.0.3)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -56,10 +63,13 @@ DEPENDENCIES
   aruba
   cucumber
   gemika
+  mail
+  nokogiri
+  rake
   rspec
 
 RUBY VERSION
    ruby 2.6.6p146
 
 BUNDLED WITH
-   2.1.4
+   2.2.14

data/{Gemfile.ruby218 → Gemfile.ruby300}

@@ -1,7 +1,12 @@
 source 'https://rubygems.org'
 
+ruby '3.0.0'
+
+gem 'rake'
 gem 'rspec'
-gem 'cucumber', '<3'
+gem 'cucumber'
 gem 'aruba'
 
 gem 'gemika'
+gem 'mail'
+gem 'nokogiri'

data/Gemfile.ruby300.lock

@@ -0,0 +1,108 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (6.1.3.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    aruba (1.0.4)
+      childprocess (>= 2.0, < 5.0)
+      contracts (~> 0.16.0)
+      cucumber (>= 2.4, < 6.0)
+      rspec-expectations (~> 3.4)
+      thor (~> 1.0)
+    builder (3.2.4)
+    childprocess (4.0.0)
+    concurrent-ruby (1.1.8)
+    contracts (0.16.0)
+    cucumber (5.3.0)
+      builder (~> 3.2, >= 3.2.4)
+      cucumber-core (~> 8.0, >= 8.0.1)
+      cucumber-create-meta (~> 2.0, >= 2.0.2)
+      cucumber-cucumber-expressions (~> 10.3, >= 10.3.0)
+      cucumber-gherkin (~> 15.0, >= 15.0.2)
+      cucumber-html-formatter (~> 9.0, >= 9.0.0)
+      cucumber-messages (~> 13.1, >= 13.1.0)
+      cucumber-wire (~> 4.0, >= 4.0.1)
+      diff-lcs (~> 1.4, >= 1.4.4)
+      multi_test (~> 0.1, >= 0.1.2)
+      sys-uname (~> 1.2, >= 1.2.1)
+    cucumber-core (8.0.1)
+      cucumber-gherkin (~> 15.0, >= 15.0.2)
+      cucumber-messages (~> 13.0, >= 13.0.1)
+      cucumber-tag-expressions (~> 2.0, >= 2.0.4)
+    cucumber-create-meta (2.0.4)
+      cucumber-messages (~> 13.1, >= 13.1.0)
+      sys-uname (~> 1.2, >= 1.2.1)
+    cucumber-cucumber-expressions (10.3.0)
+    cucumber-gherkin (15.0.2)
+      cucumber-messages (~> 13.0, >= 13.0.1)
+    cucumber-html-formatter (9.0.0)
+      cucumber-messages (~> 13.0, >= 13.0.1)
+    cucumber-messages (13.2.1)
+      protobuf-cucumber (~> 3.10, >= 3.10.8)
+    cucumber-tag-expressions (2.0.4)
+    cucumber-wire (4.0.1)
+      cucumber-core (~> 8.0, >= 8.0.1)
+      cucumber-cucumber-expressions (~> 10.3, >= 10.3.0)
+      cucumber-messages (~> 13.0, >= 13.0.1)
+    diff-lcs (1.4.4)
+    ffi (1.15.0)
+    gemika (0.5.0)
+    i18n (1.8.10)
+      concurrent-ruby (~> 1.0)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    middleware (0.1.0)
+    mini_mime (1.0.3)
+    minitest (5.14.4)
+    multi_test (0.1.2)
+    nokogiri (1.11.2-x86_64-linux)
+      racc (~> 1.4)
+    protobuf-cucumber (3.10.8)
+      activesupport (>= 3.2)
+      middleware
+      thor
+      thread_safe
+    racc (1.5.2)
+    rake (13.0.3)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    sys-uname (1.2.2)
+      ffi (~> 1.1)
+    thor (1.1.0)
+    thread_safe (0.3.6)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    zeitwerk (2.4.2)
+
+PLATFORMS
+  x86_64-linux
+
+DEPENDENCIES
+  aruba
+  cucumber
+  gemika
+  mail
+  nokogiri
+  rake
+  rspec
+
+RUBY VERSION
+   ruby 3.0.0p0
+
+BUNDLED WITH
+   2.2.3

data/README.md

@@ -19,9 +19,9 @@ Or install it yourself as:
     $ gem install spreewald
 
 
-## Supported RSpec versions
+## Supported versions
 
-Spreewald supports RSpec >= 2.13.0
+Spreewald is currently tested against Ruby 2.4.5 with Rails 4 and Capybara 2 and Ruby 2.6.6 with Rails 6 and Capybara 3.
 
 ## Usage
 
@@ -237,7 +237,9 @@ the step definitions.
   
         """
   
-  You may skip lines in the header, of course.
+  You may skip lines in the header.
+  Please note: In older versions of Spreewald, unmentioned body lines were skipped.
+  Now you have to use the asterisk explicitly to omit lines in the body.
 
 
 * **When I follow the (first|second|third)? link in the e?mail**
@@ -265,6 +267,42 @@ the step definitions.
   This uses the same syntax as `Then an email should have been sent with:`
 
 
+### frame_steps.rb 
+
+* **When ... inside the ... iframe**
+
+  You can append `inside the [name or number] iframe` to any other step.
+  Then the step will operate inside the given iframe.
+  Examples:
+  
+      Then I should see "Kiwi" inside the 1st iframe
+      Then I should see "Cherry" inside the fruits iframe
+      When I press "Save" inside the 2nd iframe
+
+
+
+* **When I switch to the ... iframe**
+
+  This step will switch to the iframe identified by its name or number.
+  All further steps will operate inside the iframe.
+  To switch to operating on the main page again, use the step
+  "I switch back to the whole page".
+  Examples:
+  
+      When I switch to the 1st iframe
+      When I switch to the fruits iframe
+  
+  Please note: This step is only available for Capybara >= 3.
+
+
+* **When I switch back to the whole page**
+
+  This step can be used to switch back to the whole page if you switched
+  to operating inside an iframe before (step `I switch to the ... iframe`)
+  
+  Please note: This step is only available for Capybara >= 3.
+
+
 ### session_steps.rb 
 
 * **When ... in the browser session "..."**

data/Rakefile

@@ -10,28 +10,25 @@ end
 task :default => 'matrix:tests'
 
 namespace :matrix do
+  desc 'Run tests for a single row of the matrix'
+  task :single_test, [:gemfile, :ruby] do |_t, args|
+    gemfile = args[:gemfile]
+    ruby = args[:ruby]
 
-  desc "Run all tests which are available for current Ruby (#{RUBY_VERSION})"
-  task :tests do
-    Gemika::Matrix.from_travis_yml.each do |row|
-      directory = File.dirname(row.gemfile)
-      if directory.start_with?('tests')
-        # Run integration tests (uses embedded projects)
-        system(cucumber_command(directory, row.ruby))
-      else
-        # Run specs and tests for spreewald binary
-        [
-          system("BUNDLE_GEMFILE=#{row.gemfile} bundle exec rspec"),
-          system("BUNDLE_GEMFILE=#{row.gemfile} bundle exec cucumber"),
-        ].all?
-      end
+    if gemfile.nil? || ruby.nil?
+      warn 'Please state the Gemfile and Ruby version to be used for the Testrun!'
+    else
+      run_tests(gemfile, ruby)
     end
-
-    travis_yml = YAML.load_file('.travis.yml')
-    rubies = travis_yml.fetch('rvm') - [RUBY_VERSION]
-    puts "Please remember to run tests for the other ruby versions as well: #{rubies.join(", ")}"
   end
 
+
+  desc "Run all tests which are available for current Ruby (#{RUBY_VERSION})"
+  task :tests, [:gemfile, :ruby] do |_t, args|
+    Gemika::Matrix.from_ci_config.each do |row|
+      run_tests(row.gemfile, row.ruby)
+    end
+  end
 end
 
 
@@ -59,12 +56,30 @@ task :update_readme do
   puts '', '> Done (diff applied).'
 end
 
+def run_tests(gemfile, ruby)
+  directory = File.dirname(gemfile)
+  if directory.start_with?('tests')
+    # Run integration tests (uses embedded projects)
+    system(cucumber_command(directory, ruby))
+  else
+    # Run specs and integration tests for Spreewald binary
+    [
+      system("BUNDLE_GEMFILE=#{gemfile} bundle exec rspec"),
+      system("BUNDLE_GEMFILE=#{gemfile} bundle exec cucumber --publish-quiet"),
+    ].all?
+  end
+end
+
 def cucumber_command(directory, ruby_version)
-  command = "cd #{directory} && BUNDLE_GEMFILE=Gemfile geordi cucumber"
+  command = "cd #{directory} && BUNDLE_GEMFILE=Gemfile bundle exec cucumber --publish-quiet"
   if Gem::Version.new(ruby_version) > Gem::Version.new('2.5')
     # Modern cucumber sees pending tests as failures.
     # We don't want this.
     command << ' --no-strict-pending'
+  else
+    # Ruby < 2.5 means the capybara 2 Test project.
+    # Omit scenarios that only work with modern Capybara.
+    command << ' --tags "not @not-capybara-2"'
   end
   command
 end