spreewald 2.1.3 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 156277b1ff11d278f195b09266237155fa477f7811ed585d3e766431fd1b4e20
-  data.tar.gz: 03573bd49630806f3bbec0f2d073438ed419e81a60c4cc4b3bccc96f26f42439
+SHA1:
+  metadata.gz: c6344c3e67a52d140623e262f62163db7c50d4c8
+  data.tar.gz: 615431258c8bacd8e28459adf8726987226cb348
 SHA512:
-  metadata.gz: 1beb236444cf36b9af9a434f40fd8d28d656daf4eb5e2fa6e7b9dba91ea170e0df8e35d1e9b72b4d0795f9adedd6817090e6f8652810c72e3a660cf295375f62
-  data.tar.gz: bea5a66a9f2bed6098309e974fa7d5f381383885835b47e047d0454e46a1f87357e25df578e40fe70d65aa1fd115a482fa1026b2a7a59fd0342f077222b4303b
+  metadata.gz: d831672bf55cb2b5cdc5fb239dfbc1ac494092e00dc518d8d868513f615416d84dd96b2ea49ac7f1fd9c0f5792c402c9ee36812bdb74aaf25532b5870405ba2b
+  data.tar.gz: dd374015482e0fa3403e4d18ee4885635db1d6295e7f2f2c2626bac6acc4804d0c9cbdce6a41a0d56b08bd4046f13032173dce5b49a6de9cb34c38cc61c22ebb

data/CHANGELOG.md

@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 2.2.0
+- Add a new step `I should( not)? see a link labeled "STRING"`.
+- Refer to Capybara 3's new flag `Capybara.default_normalize_ws = true` in the READNE,
+
 ## 2.1.3
 The `I should(not )? see /REGEXP/` step no longer refuses slashes as part of the regular expression. You can thus match full domains and more.
 

data/README.md

@@ -83,6 +83,17 @@ More info [here](https://makandracards.com/makandra/12139-waiting-for-page-load-
 Thanks to [cucumber_priority](https://github.com/makandra/cucumber_priority) you can override any step definition from Spreewald with your own pattern. Cucumber will not raise `Cucumber::Ambiguous` if your custom steps collide with a Spreewald step.
 
 
+## A note on Capybara 3
+
+If you are upgrading from Capybara 2 to Capybara 3, you might [see failing tests](https://github.com/makandra/spreewald/issues/95) with Spreewald steps like `I should see`. This is caused by a breaking change in [Capybara's Finders](https://www.rubydoc.info/github/jnicklas/capybara/Capybara/Node/Finders) that accept a `:text` option. To activate Capybara 2 behavior globally in your project, enable this flag:
+
+```ruby
+Capybara.default_normalize_ws = true
+````
+
+This will affect all Spreewald steps that are using Capybara's `:text` option.
+
+
 ## Contributing
 
 ### Testing
@@ -390,6 +401,81 @@ deprecation notice. Decide for yourself whether you want to use them:
 * **Then I should not see /.../**
 
 
+* **Then I should( not)? see a field "..."**
+
+  Checks for the existance of an input field (given its id or label)
+
+
+* **Then I should( not)? see the (number|amount) ([\-\d,\.]+)( ...)?**
+
+  Use this step to test for a number or money amount instead of a simple `Then I should see`
+  
+  Checks for an unexpected minus sign, correct decimal places etc.
+  
+  See [here](https://makandracards.com/makandra/1225-test-that-a-number-or-money-amount-is-shown-with-cucumber) for details
+
+
+* **Then I should see '...'**
+
+  Like `Then I should see`, but with single instead of double quotes. In case
+  the expected string contains quotes as well.
+
+
+* **Then I should see "..." in the HTML**
+
+  Check that the raw HTML contains a string
+
+
+* **Then I should not see "..." in the HTML**
+
+
+* **Then I should see an error**
+
+  Checks that status code is 400..599
+
+
+* **Then I should (not )?see (an|the) element "..."**
+
+  Check that an element with the given selector is present on the page.
+  
+  Example:
+  
+      Then I should see an element ".panel"
+      Then I should see the element ".panel"
+      Then I should not see an element ".sidebar"
+      Then I should not see the element ".sidebar"
+
+
+* **Then I should (not )?see (an|the) element for ...**
+
+  Check that an element with the given [selector alias](https://github.com/makandra/spreewald/blob/master/examples/selectors.rb) is present on the page.
+  
+  Example:
+  
+      Then I should see an element for the panel
+      Then I should see the element for the panel
+      Then I should not see an element for the sidebar
+      Then I should not see the element for the sidebar
+
+
+* **Then I should see in this order:?**
+
+  Checks that these strings are rendered in the given order in a single line or in multiple lines
+  
+  Example:
+  
+      Then I should see in this order:
+        | Alpha Group |
+        | Augsburg    |
+        | Berlin      |
+        | Beta Group  |
+
+
+* **Then I should( not)? see a link labeled "..."**
+
+  Checks that the page contains a link with a given text or title attribute.
+
+
 * **Then the "..." field should (not )?contain "..."**
 
   Checks that an input field contains some value (allowing * as wildcard character)
@@ -444,20 +530,6 @@ deprecation notice. Decide for yourself whether you want to use them:
   Open the current Capybara page using the `launchy` or `capybara_screenshot` gem
 
 
-* **Then I should( not)? see a field "..."**
-
-  Checks for the existance of an input field (given its id or label)
-
-
-* **Then I should( not)? see the (number|amount) ([\-\d,\.]+)( ...)?**
-
-  Use this step to test for a number or money amount instead of a simple `Then I should see`
-  
-  Checks for an unexpected minus sign, correct decimal places etc.
-  
-  See [here](https://makandracards.com/makandra/1225-test-that-a-number-or-money-amount-is-shown-with-cucumber) for details
-
-
 * **Then I should get a response with content-type "..."**
 
   Checks `Content-Type` HTTP header
@@ -483,25 +555,6 @@ deprecation notice. Decide for yourself whether you want to use them:
   Checks for the presence of an option in a select
 
 
-* **Then I should see '...'**
-
-  Like `Then I should see`, but with single instead of double quotes. In case
-  the expected string contains quotes as well.
-
-
-* **Then I should see "..." in the HTML**
-
-  Check that the raw HTML contains a string
-
-
-* **Then I should not see "..." in the HTML**
-
-
-* **Then I should see an error**
-
-  Checks that status code is 400..599
-
-
 * **Then the window should be titled "..."**
 
 
@@ -568,30 +621,6 @@ deprecation notice. Decide for yourself whether you want to use them:
          got: "http://makandra.com/" (using =~)
 
 
-* **Then I should (not )?see (an|the) element "..."**
-
-  Check that an element with the given selector is present on the page.
-  
-  Example:
-  
-      Then I should see an element ".panel"
-      Then I should see the element ".panel"
-      Then I should not see an element ".sidebar"
-      Then I should not see the element ".sidebar"
-
-
-* **Then I should (not )?see (an|the) element for ...**
-
-  Check that an element with the given [selector alias](https://github.com/makandra/spreewald/blob/master/examples/selectors.rb) is present on the page.
-  
-  Example:
-  
-      Then I should see an element for the panel
-      Then I should see the element for the panel
-      Then I should not see an element for the sidebar
-      Then I should not see the element for the sidebar
-
-
 * **Then I should get a text response**
 
   Checks that the result has content type `text/plain`
@@ -625,19 +654,6 @@ deprecation notice. Decide for yourself whether you want to use them:
 * **When I switch to the new tab**
 
 
-* **Then I should see in this order:?**
-
-  Checks that these strings are rendered in the given order in a single line or in multiple lines
-  
-  Example:
-  
-      Then I should see in this order:
-        | Alpha Group |
-        | Augsburg    |
-        | Berlin      |
-        | Beta Group  |
-
-
 * **Then the "..." (field|button|checkbox) should( not)? be disabled**
 
   Tests that an input or button with the given label is disabled.

data/lib/spreewald/web_steps.rb

@@ -195,6 +195,123 @@ Then /^(?:|I )should not see \/(.*)\/$/ do |regexp|
   end
 end.overridable
 
+# Checks for the existance of an input field (given its id or label)
+Then /^I should( not)? see a field "([^"]*)"$/ do |negate, name|
+  expectation = negate ? :not_to : :to
+  patiently do
+    begin
+      # In old Capybaras find_field returns nil, so we assign it to `field`
+      field = find_field(name)
+    rescue Capybara::ElementNotFound
+      # In Capybara 0.4+ #find_field raises an error instead of returning nil
+      # We must explicitely reset the field variable from a previous patiently iteration
+      field = nil
+    end
+    expect(field).send(expectation, be_present)
+  end
+end.overridable
+
+# Use this step to test for a number or money amount instead of a simple `Then I should see`
+#
+# Checks for an unexpected minus sign, correct decimal places etc.
+#
+# See [here](https://makandracards.com/makandra/1225-test-that-a-number-or-money-amount-is-shown-with-cucumber) for details
+Then /^I should( not)? see the (?:number|amount) ([\-\d,\.]+)(?: (.*?))?$/ do |negate, amount, unit|
+  no_minus = amount.starts_with?('-') ? '' : '[^\\-]'
+  nbsp = " "
+  regexp = Regexp.new(no_minus + "\\b" + Regexp.quote(amount) + (unit ? "( |#{nbsp}| )(#{unit}|#{Regexp.quote(HTMLEntities.new.encode(unit, :named))})" :"\\b"))
+  expectation = negate ? :not_to : :to
+  patiently do
+    expect(page.body).send(expectation, match(regexp))
+  end
+end.overridable
+
+# Like `Then I should see`, but with single instead of double quotes. In case
+# the expected string contains quotes as well.
+Then /^(?:|I )should see '([^']*)'$/ do |text|
+  patiently do
+    expect(page).to have_content(text)
+  end
+end.overridable
+
+# Check that the raw HTML contains a string
+Then /^I should see "([^\"]*)" in the HTML$/ do |text|
+  patiently do
+    expect(page.body).to include(text)
+  end
+end.overridable
+
+Then /^I should not see "([^\"]*)" in the HTML$/ do |text|
+  patiently do
+    expect(page.body).not_to include(text)
+  end
+end.overridable
+
+# Checks that status code is 400..599
+Then /^I should see an error$/ do
+  expect((400 .. 599)).to include(page.status_code)
+end.overridable
+
+# Check that an element with the given selector is present on the page.
+#
+# Example:
+#
+#     Then I should see an element ".panel"
+#     Then I should see the element ".panel"
+#     Then I should not see an element ".sidebar"
+#     Then I should not see the element ".sidebar"
+Then /^I should (not )?see (?:an|the) element "([^"]+)"$/ do |negate, selector|
+  expectation = negate ? :not_to : :to
+  patiently do
+    expect(page).send(expectation, have_css(selector))
+  end
+end.overridable
+
+# Check that an element with the given [selector alias](https://github.com/makandra/spreewald/blob/master/examples/selectors.rb) is present on the page.
+#
+# Example:
+#
+#     Then I should see an element for the panel
+#     Then I should see the element for the panel
+#     Then I should not see an element for the sidebar
+#     Then I should not see the element for the sidebar
+Then /^I should (not )?see (?:an|the) element for (.*?)$/ do |negate, locator|
+  expectation = negate ? :not_to : :to
+  selector = _selector_for(locator)
+  patiently do
+    expect(page).send(expectation, have_selector(*selector))
+  end
+end.overridable(:priority => -5) # priority must be lower than the "within" step
+
+# Checks that these strings are rendered in the given order in a single line or in multiple lines
+#
+# Example:
+#
+#     Then I should see in this order:
+#       | Alpha Group |
+#       | Augsburg    |
+#       | Berlin      |
+#       | Beta Group  |
+Then /^I should see in this order:?$/ do |text|
+  if text.is_a?(String)
+    lines = text.split(/\n/)
+  else
+    lines = text.raw.flatten
+  end
+  lines = lines.collect { |line| line.gsub(/\s+/, ' ')}.collect(&:strip).reject(&:blank?)
+  pattern = lines.collect(&Regexp.method(:quote)).join('.*?')
+  pattern = Regexp.compile(pattern)
+  patiently do
+    expect(page.text.gsub(/\s+/, ' ')).to match(pattern)
+  end
+end.overridable
+
+# Checks that the page contains a link with a given text or title attribute.
+Then /^I should( not)? see a link labeled "([^"]*)"$/ do |negate, label|
+  expectation = negate ? :not_to : :to
+  link = page.first('a', :text => label, minimum: 0) || page.first(%(a[title="#{label}"]), minimum: 0)
+  expect(link).send(expectation, be_present)
+end
 
 # Checks that an input field contains some value (allowing * as wildcard character)
 Then /^the "([^"]*)" field should (not )?contain "([^"]*)"$/ do |label, negate, expected_string|
@@ -326,38 +443,6 @@ Then /^show me the page$/ do
 end.overridable
 
 
-# Checks for the existance of an input field (given its id or label)
-Then /^I should( not)? see a field "([^"]*)"$/ do |negate, name|
-  expectation = negate ? :not_to : :to
-  patiently do
-    begin
-      # In old Capybaras find_field returns nil, so we assign it to `field`
-      field = find_field(name)
-    rescue Capybara::ElementNotFound
-      # In Capybara 0.4+ #find_field raises an error instead of returning nil
-      # We must explicitely reset the field variable from a previous patiently iteration
-      field = nil
-    end
-    expect(field).send(expectation, be_present)
-  end
-end.overridable
-
-
-# Use this step to test for a number or money amount instead of a simple `Then I should see`
-#
-# Checks for an unexpected minus sign, correct decimal places etc.
-#
-# See [here](https://makandracards.com/makandra/1225-test-that-a-number-or-money-amount-is-shown-with-cucumber) for details
-Then /^I should( not)? see the (?:number|amount) ([\-\d,\.]+)(?: (.*?))?$/ do |negate, amount, unit|
-  no_minus = amount.starts_with?('-') ? '' : '[^\\-]'
-  nbsp = " "
-  regexp = Regexp.new(no_minus + "\\b" + Regexp.quote(amount) + (unit ? "( |#{nbsp}| )(#{unit}|#{Regexp.quote(HTMLEntities.new.encode(unit, :named))})" :"\\b"))
-  expectation = negate ? :not_to : :to
-  patiently do
-    expect(page.body).send(expectation, match(regexp))
-  end
-end.overridable
-
 # Checks `Content-Type` HTTP header
 Then /^I should get a response with content-type "([^\"]*)"$/ do |expected_content_type|
   expect(page.response_headers['Content-Type']).to match /\A#{Regexp.quote(expected_content_type)}($|;)/
@@ -406,32 +491,6 @@ Then /^"([^"]*)" should( not)? be an option for "([^"]*)"$/ do |value, negate, f
   end
 end.overridable
 
-# Like `Then I should see`, but with single instead of double quotes. In case
-# the expected string contains quotes as well.
-Then /^(?:|I )should see '([^']*)'$/ do |text|
-  patiently do
-    expect(page).to have_content(text)
-  end
-end.overridable
-
-# Check that the raw HTML contains a string
-Then /^I should see "([^\"]*)" in the HTML$/ do |text|
-  patiently do
-    expect(page.body).to include(text)
-  end
-end.overridable
-
-Then /^I should not see "([^\"]*)" in the HTML$/ do |text|
-  patiently do
-    expect(page.body).not_to include(text)
-  end
-end.overridable
-
-# Checks that status code is 400..599
-Then /^I should see an error$/ do
-  expect((400 .. 599)).to include(page.status_code)
-end.overridable
-
 Then /^the window should be titled "([^"]*)"$/ do |title|
   patiently do
     expect(pag).to have_css('title', :text => title)
@@ -531,38 +590,6 @@ Then /^"([^"]*)" should link to "([^"]*)"$/ do |link_label, target|
   end
 end.overridable
 
-# Check that an element with the given selector is present on the page.
-#
-# Example:
-#
-#     Then I should see an element ".panel"
-#     Then I should see the element ".panel"
-#     Then I should not see an element ".sidebar"
-#     Then I should not see the element ".sidebar"
-Then /^I should (not )?see (?:an|the) element "([^"]+)"$/ do |negate, selector|
-  expectation = negate ? :not_to : :to
-  patiently do
-    expect(page).send(expectation, have_css(selector))
-  end
-end.overridable
-
-# Check that an element with the given [selector alias](https://github.com/makandra/spreewald/blob/master/examples/selectors.rb) is present on the page.
-#
-# Example:
-#
-#     Then I should see an element for the panel
-#     Then I should see the element for the panel
-#     Then I should not see an element for the sidebar
-#     Then I should not see the element for the sidebar
-Then /^I should (not )?see (?:an|the) element for (.*?)$/ do |negate, locator|
-  expectation = negate ? :not_to : :to
-  selector = _selector_for(locator)
-  patiently do
-    expect(page).send(expectation, have_selector(*selector))
-  end
-end.overridable(:priority => -5) # priority must be lower than the "within" step
-
-
 # Checks that the result has content type `text/plain`
 Then /^I should get a text response$/ do
   step 'I should get a response with content-type "text/plain"'
@@ -625,29 +652,6 @@ When /^I switch to the new tab$/ do
   end
 end.overridable
 
-# Checks that these strings are rendered in the given order in a single line or in multiple lines
-#
-# Example:
-#
-#     Then I should see in this order:
-#       | Alpha Group |
-#       | Augsburg    |
-#       | Berlin      |
-#       | Beta Group  |
-Then /^I should see in this order:?$/ do |text|
-  if text.is_a?(String)
-    lines = text.split(/\n/)
-  else
-    lines = text.raw.flatten
-  end
-  lines = lines.collect { |line| line.gsub(/\s+/, ' ')}.collect(&:strip).reject(&:blank?)
-  pattern = lines.collect(&Regexp.method(:quote)).join('.*?')
-  pattern = Regexp.compile(pattern)
-  patiently do
-    expect(page.text.gsub(/\s+/, ' ')).to match(pattern)
-  end
-end.overridable
-
 # Tests that an input or button with the given label is disabled.
 Then /^the "([^\"]*)" (field|button|checkbox) should( not)? be disabled$/ do |label, kind, negate|
   if kind == 'field' || kind == 'checkbox'

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '2.1.3'
+  VERSION = '2.2.0'
 end

data/tests/rails-4_capybara-3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (2.1.3)
+    spreewald (2.2.0)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

data/tests/shared/app/views/static_pages/links.html.haml

@@ -0,0 +1,5 @@
+.nested-link
+  %a First visible link
+  %a(title="Also matches via the title attribute") Second visible link
+
+.unrelated-element

data/tests/shared/features/shared/web_steps.feature

@@ -244,3 +244,12 @@ Feature: Web steps
   Scenario: /^I should get a download with filename "([^\"]*)"$/
     When I go to "/downloads/spreadsheet"
     Then I should get a download with filename "test.ods"
+
+
+  Scenario: /^I should( not)? see a link labeled "([^"]*)"$/
+    When I am on "/static_pages/links"
+    Then I should see a link labeled "First visible link"
+      And I should see a link labeled "First visible link" within ".nested-link"
+      And I should see a link labeled "Also matches via the title attribute"
+    But I should not see a link labeled "Nonexistent Link"
+      And I should not see a link labeled "First visible link" within ".unrelated-element"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreewald
 version: !ruby/object:Gem::Version
-  version: 2.1.3
+  version: 2.2.0
 platform: ruby
 authors:
 - Tobias Kraze
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-20 00:00:00.000000000 Z
+date: 2019-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -283,6 +283,7 @@ files:
 - tests/shared/app/views/static_pages/click_on.html.haml
 - tests/shared/app/views/static_pages/home.html.haml
 - tests/shared/app/views/static_pages/link_to_home.html.haml
+- tests/shared/app/views/static_pages/links.html.haml
 - tests/shared/app/views/static_pages/overridden.html.haml
 - tests/shared/app/views/static_pages/see_element.html.haml
 - tests/shared/app/views/static_pages/visibility.html.haml
@@ -326,7 +327,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.14.3
 signing_key: 
 specification_version: 4
 summary: Collection of useful cucumber steps.
@@ -437,6 +438,7 @@ test_files:
 - tests/shared/app/views/static_pages/click_on.html.haml
 - tests/shared/app/views/static_pages/home.html.haml
 - tests/shared/app/views/static_pages/link_to_home.html.haml
+- tests/shared/app/views/static_pages/links.html.haml
 - tests/shared/app/views/static_pages/overridden.html.haml
 - tests/shared/app/views/static_pages/see_element.html.haml
 - tests/shared/app/views/static_pages/visibility.html.haml