spreedly_core 0.1.1 → 0.1.2

data/lib/spreedly_core/base.rb

@@ -63,7 +63,8 @@ module SpreedlyCore
         raise InvalidResponse.new(response, "Error retrieving #{path}. Got status of #{response.code}. Expected status to be in #{allowed_codes.join(",")}")
       end
 
-      if options.has_key?(:has_key) && !response.parsed_response.has_key?(options[:has_key])
+      if options.has_key?(:has_key) &&
+          (response.parsed_response.nil? || !response.parsed_response.has_key?(options[:has_key]))
         raise InvalidResponse.new(response, "Expected parsed response to contain key '#{options[:has_key]}'")
       end
 

data/lib/spreedly_core/test_extensions.rb

@@ -1,32 +1,42 @@
 require 'cgi'
+require 'uri'
 
-module SpreedlyCore::TestHelper
-  extend self
-
-  def cc_data(cc_type, options={})
-
-    card_numbers = {:master => [5555555555554444, 5105105105105100],
-      :visa => [4111111111111111, 4012888888881881],
-      :american_express => [378282246310005, 371449635398431],
-      :discover => [6011111111111117, 6011000990139424]
-    }
+module SpreedlyCore
+  module TestHelper
+    extend self
     
-    card_number = options[:card_number] == :failed ? :last : :first
-    number = card_numbers[cc_type].send(card_number)
+    def cc_data(cc_type, options={})
+    
+      card_numbers = {:master => [5555555555554444, 5105105105105100],
+        :visa => [4111111111111111, 4012888888881881],
+        :american_express => [378282246310005, 371449635398431],
+        :discover => [6011111111111117, 6011000990139424]
+      }
+      
+      card_number = options[:card_number] == :failed ? :last : :first
+      number = card_numbers[cc_type].send(card_number)
+      
+      { :credit_card => {
+          :first_name => "John",
+          :last_name => "Foo",
+          :card_type => cc_type,
+          :number => number,
+          :verification_value => 123,
+          :month => 4,
+          :year => Time.now.year + 1 }.merge(options[:credit_card] || {})
+      }
+    end
     
-    { :credit_card => {
-        :first_name => "John",
-        :last_name => "Foo",
-        :card_type => cc_type,
-        :number => number,
-        :verification_value => 123,
-        :month => 4,
-        :year => Time.now.year + 1 }.merge(options[:credit_card] || {})
-    }
+    # Return the base uri as a mocking framework would expect
+    def mocked_base_uri_string
+      uri = URI.parse(Base.base_uri)
+      auth_params = Base.default_options[:basic_auth]
+      uri.user = auth_params[:username]
+      uri.password = auth_params[:password]
+      uri.to_s
+    end
   end
-end
 
-module SpreedlyCore
   class PaymentMethod
 
     # Call spreedly core to create a test token.

data/lib/spreedly_core/version.rb

@@ -1,3 +1,3 @@
 module SpreedlyCore
-  Version = VERSION = "0.1.1"
+  Version = VERSION = "0.1.2"
 end

data/test/spreedly_core_test.rb

@@ -15,6 +15,16 @@ module SpreedlyCore
       PaymentMethod.reset_additional_required_cc_fields
     end
 
+    def test_mocked_500_error
+      with_disabled_network do
+        stub_request(:put, "#{mocked_base_uri_string}/payment_methods/FAKE.xml").
+          to_return(:body => '', :status => 500)
+        assert_raises InvalidResponse do
+          Base.verify_put('/payment_methods/FAKE.xml', :has_key => "test") {}
+        end
+      end
+    end
+
     def test_can_get_payment_token
       payment_method = given_a_payment_method(:master,
                                               :credit_card => {:year => 2015})

data/test/test_helper.rb

@@ -12,8 +12,22 @@ require 'spreedly_core'
 require 'spreedly_core/test_extensions'
 require 'test_factory'
 
+require 'webmock/test_unit'
+# Allow real connections, see https://github.com/bblimke/webmock for more info
+WebMock.allow_net_connect!
+
+require 'webmock'
+
 class Test::Unit::TestCase
   def assert_false(test, failure_message=nil)
     assert(!test, failure_message)
   end
+
+  def with_disabled_network(&block)
+    WebMock.disable_net_connect!
+    block.call
+  ensure
+    WebMock.allow_net_connect!
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: spreedly_core
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 31
   prerelease: 
   segments: 
   - 0
   - 1
-  - 1
-  version: 0.1.1
+  - 2
+  version: 0.1.2
 platform: ruby
 authors: 
 - 403 Labs
@@ -63,6 +63,22 @@ dependencies:
         version: 0.8.7
   type: :development
   version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: webmock
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 11
+        segments: 
+        - 1
+        - 6
+        - 2
+        version: 1.6.2
+  type: :development
+  version_requirements: *id004
 description: 
 email: github@403labs.com
 executables: []