spreedly 2.0.18 → 2.0.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fee7ae1d3bf0eaf6126ead42e28a16367920632f
-  data.tar.gz: b38482be678195d537c456b845fa6f1c33dcf7c7
+  metadata.gz: 0110d918dc588bb377b7d8cfb5071e438cb74103
+  data.tar.gz: 8afcecf45db7a9e8fc7da38d9fdffc7fa8566b8a
 SHA512:
-  metadata.gz: e8637191e25984c4fa21fb0afe9ef517fbfc68c4bd714f9ffb000ace8348d9d91980aded43f8ae30311990791055ac769ff3c1217bc53e0606fd59b9ddc5a626
-  data.tar.gz: ca75c0e0a89f28e5f19c87bea810e0939ae58e6d7d1e921ea0a7ee8e99bcd8dd1596f858032c2f740458c086cbf5035e90930742f738e8d56c2d51b3112728db
+  metadata.gz: 66bbfc2431d1aee375fffda01c43d1dba5b4c3c0440f3b5c24d8ba587bb5ad1521287f6afee507a1f39db8f3baddc615d71c229b6ededf8f0592df42cb6ff300
+  data.tar.gz: 2c3862d8c1eac3d9d5a1c53142210530b11302c70d79f510b51524e746f7368c7f8c606a492e7649f2216af3c51a579f3b10c3a5187b4181a823f7e86cf9bdc6

data/.gitignore

@@ -5,5 +5,6 @@ pkg
 .bundle
 tmp
 vendor/ruby
-test/credentials/personal_credentials.yml
+test/credentials/*.yml
 .ruby-version
+.idea

data/CHANGELOG.md

@@ -0,0 +1,18 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+## [Unreleased]
+
+## [2.0.19] - 2019-06-07
+### Added
+- Lori Holden - Receiver redaction
+- Lancelot Carlson - Recached payment method support
+- @pawel-krysiak and @jeremywrowe - Support 3D-Secure transactions
+
+### Changed
+- @therufs - Expose `display_api_url` on gateway
+- @ZeusPerez - Expose `continue_caching` on transactions
+- @adamcohen - Expose `transaction_type` on transaction
+- @adamcohen - Expose `gateway_specific_response_fields` on transaction
+- @adamcohen - Expose `payment_method_type` on transaction

data/README.md

@@ -273,7 +273,7 @@ Here's how you can do it:
 
 ``` ruby
 options = {
-email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2019, last_name: 'Aybara', first_name: 'Perrin', data: "occupation: Blacksmith"
+email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2023, last_name: 'Aybara', first_name: 'Perrin', data: "occupation: Blacksmith"
 }
 transaction = env.add_credit_card(options)
 
@@ -286,7 +286,7 @@ You can also retain the card immediately like so:
 
 ``` ruby
 options = {
-email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2019, last_name: 'Aybara', first_name: 'Perrin', data: "occupation: Blacksmith", retained: true
+email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2023, last_name: 'Aybara', first_name: 'Perrin', data: "occupation: Blacksmith", retained: true
 }
 transaction = env.add_credit_card(options)
 
@@ -409,3 +409,7 @@ There are two rake tasks to help run the tests:
 rake test:remote  # Run remote tests that actually hit the Spreedly site
 rake test:units   # Run unit tests
 ```
+
+To run remote tests you'll need to copy `test/credentials/credentials.yml.example` to `test/credentials/credentials.yml` and update the values of `environment_key` and `access_secret`.
+
+When you're happy with your change, don't forget to add your contributions to CHANGELOG.md. We follow the changelog format found [here](https://keepachangelog.com/en/1.0.0/).

data/Rakefile

@@ -2,20 +2,10 @@ require "bundler/gem_tasks"
 
 require 'rake/testtask'
 
-# Rake::TestTask.new do |t|
-#   t.libs << 'test'
-# end
-
-# desc "Run tests"
-# task :default => :test
-
-
-
-desc "Run the unit test suite"
-task :default => 'test:units'
+desc 'Run the unit test suite'
+task default: 'test:units'
 
 namespace :test do
-
   Rake::TestTask.new(:units) do |t|
     t.pattern = 'test/unit/**/*_test.rb'
     t.libs << 'test'
@@ -27,6 +17,4 @@ namespace :test do
     t.libs << 'test'
     t.verbose = true
   end
-
 end
-

data/lib/spreedly/environment.rb

@@ -76,11 +76,22 @@ module Spreedly
       Transaction.new_from(xml_doc)
     end
 
+    def recache_payment_method(payment_method_token, options = {})
+      body = recache_payment_method_body(options)
+      xml_doc = ssl_put(recache_payment_method_url(payment_method_token), body, headers)
+      RecacheSensitiveData.new_from(xml_doc)
+    end
+
     def redact_gateway(gateway_token, options = {})
       xml_doc = ssl_put(redact_gateway_url(gateway_token), '', headers)
       Transaction.new_from(xml_doc)
     end
 
+    def redact_receiver(receiver_token, options = {})
+      xml_doc = ssl_put(redact_receiver_url(receiver_token), '', headers)
+      Transaction.new_from(xml_doc)
+    end
+
     def list_transactions(since_token = nil, payment_method_token = nil)
       xml_doc = ssl_get(list_transactions_url(since_token, payment_method_token), headers)
       Transaction.new_list_from(xml_doc)
@@ -205,6 +216,14 @@ module Spreedly
       end
     end
 
+    def recache_payment_method_body(options)
+      build_xml_request('payment_method') do |doc|
+        doc.credit_card do
+          add_to_doc(doc, options, :verification_value)
+        end
+      end
+    end
+
     def add_gateway_body(gateway_type, credentials)
       build_xml_request('gateway') do |doc|
         doc.gateway_type gateway_type
@@ -279,7 +298,8 @@ module Spreedly
       add_gateway_specific_fields(doc, options)
       add_shipping_address_override(doc, options)
       add_to_doc(doc, options, :order_id, :description, :ip, :email, :merchant_name_descriptor,
-                               :merchant_location_descriptor, :redirect_url, :callback_url)
+                               :merchant_location_descriptor, :redirect_url, :callback_url,
+                               :continue_caching, :attempt_3dsecure, :browser_info)
     end
 
     def add_gateway_specific_fields(doc, options)

data/lib/spreedly/gateway_class.rb

@@ -3,7 +3,7 @@ module Spreedly
   class GatewayClass
     include Fields
 
-    field :gateway_type, :name, :homepage, :company_name
+    field :gateway_type, :name, :homepage, :company_name, :display_api_url
     field :supports_purchase, :supports_authorize, :supports_capture, :supports_credit,
           :supports_void, :supports_verify, :supports_reference_purchase,
           :supports_purchase_via_preauthorization, :supports_offsite_purchase,

data/lib/spreedly/payment_methods/payment_method.rb

@@ -6,7 +6,7 @@ module Spreedly
 
     include ErrorsParser
 
-    field :email, :storage_state, :data
+    field :email, :storage_state, :data, :payment_method_type
     attr_reader :errors
 
     def initialize(xml_doc)

data/lib/spreedly/receiver.rb

@@ -3,7 +3,7 @@ module Spreedly
 
   class Receiver < Model
 
-    field :receiver_type, :hostnames
+    field :receiver_type, :hostnames, :state, :company_name
     attr_reader :credentials
 
     def initialize(xml_doc)

data/lib/spreedly/transactions/auth_purchase.rb

@@ -1,8 +1,7 @@
 module Spreedly
-
   class AuthPurchase < GatewayTransaction
-
-    field :currency_code
+    field :currency_code, :checkout_url, :checkout_form, :redirect_url, :callback_url
+    field :required_action, :challenge_form, :challenge_url, :device_fingerprint_form
     field :amount, type: :integer
 
     attr_reader :payment_method
@@ -11,7 +10,5 @@ module Spreedly
       super
       @payment_method = PaymentMethod.new_from(xml_doc.at_xpath('.//payment_method'))
     end
-
   end
-
 end

data/lib/spreedly/transactions/gateway_transaction.rb

@@ -2,11 +2,11 @@ module Spreedly
 
   class GatewayTransaction < Transaction
 
-    field :order_id, :ip, :description, :gateway_token, :gateway_transaction_id, :email
+    field :order_id, :ip, :description, :gateway_token, :gateway_transaction_id, :email, :transaction_type
     field :merchant_name_descriptor, :merchant_location_descriptor
     field :on_test_gateway, type: :boolean
 
-    attr_reader :response, :gateway_specific_fields, :shipping_address
+    attr_reader :response, :gateway_specific_fields, :gateway_specific_response_fields, :shipping_address
 
     def initialize(xml_doc)
       super
@@ -14,13 +14,14 @@ module Spreedly
       shipping_address_xml_doc = xml_doc.at_xpath('.//shipping_address')
       @response = response_xml_doc ? Response.new(response_xml_doc) : nil
       @shipping_address = shipping_address_xml_doc ? ShippingAddress.new(shipping_address_xml_doc) : nil
-      @gateway_specific_fields = parse_gateway_specific_fields(xml_doc)
+      @gateway_specific_fields = parse_gateway_fields(xml_doc, './/gateway_specific_fields')
+      @gateway_specific_response_fields = parse_gateway_fields(xml_doc, './/gateway_specific_response_fields')
     end
 
-    def parse_gateway_specific_fields(xml_doc)
+    def parse_gateway_fields(xml_doc, path)
       result = {}
 
-      xml_doc.at_xpath('.//gateway_specific_fields').xpath('*').each do |node|
+      xml_doc.at_xpath(path).xpath('*').each do |node|
         node_name = node.name.to_sym
         if (node.elements.empty?)
           result[node_name] = node.text

data/lib/spreedly/transactions/purchase.rb

@@ -1,7 +1,4 @@
 module Spreedly
-
   class Purchase < AuthPurchase
-
   end
-
 end

data/lib/spreedly/urls.rb

@@ -50,6 +50,10 @@ module Spreedly
       "#{base_url}/v1/payment_methods/#{payment_method_token}/redact.xml"
     end
 
+    def recache_payment_method_url(payment_method_token)
+      "#{base_url}/v1/payment_methods/#{payment_method_token}/recache.xml"
+    end
+
     def redact_gateway_url(gateway_token)
       "#{base_url}/v1/gateways/#{gateway_token}/redact.xml"
     end
@@ -91,6 +95,10 @@ module Spreedly
       "#{base_url}/v1/receivers.xml"
     end
 
+    def redact_receiver_url(token)
+      "#{base_url}/v1/receivers/#{token}/redact.xml"
+    end
+
     def add_payment_method_url
       "#{base_url}/v1/payment_methods.xml"
     end

data/lib/spreedly/version.rb

@@ -1,3 +1,3 @@
 module Spreedly
-  VERSION = "2.0.18"
+  VERSION = "2.0.19"
 end

data/spreedly.gemspec

@@ -1,30 +1,27 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'spreedly/version'
 
-
 Gem::Specification.new do |s|
-  s.name          = "spreedly"
+  s.name          = 'spreedly'
   s.version       = Spreedly::VERSION
-  s.authors       = ["Spreedly"]
-  s.email         = ["duff@spreedly.com"]
-  s.summary       = "Provides a Ruby wrapper for the Spreedly API."
-  s.description   = "The Spreedly gem provides a convenient Ruby wrapper for the Spreedly API."
-  s.homepage      = "https://github.com/spreedly/spreedly-gem"
-  s.license       = "MIT"
+  s.authors       = ['Spreedly']
+  s.email         = ['duff@spreedly.com', 'doug@spreedly.com', 'jeremy@spreedly.com']
+  s.summary       = 'Provides a Ruby wrapper for the Spreedly API.'
+  s.description   = 'The Spreedly gem provides a convenient Ruby wrapper for the Spreedly API.'
+  s.homepage      = 'https://github.com/spreedly/spreedly-gem'
+  s.license       = 'MIT'
 
-  s.files         = `git ls-files`.split($/)
+  s.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
-  s.require_paths = ["lib"]
+  s.require_paths = ['lib']
 
   s.add_dependency 'nokogiri'
 
-  s.add_development_dependency 'bundler', '~> 1.3'
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'mocha'
-  s.add_development_dependency 'log_buddy'
   s.add_development_dependency 'awesome_print'
+  s.add_development_dependency 'bundler'
+  s.add_development_dependency 'log_buddy'
+  s.add_development_dependency 'mocha'
+  s.add_development_dependency 'rake'
   s.add_development_dependency 'test-unit'
 end
-

data/test/credentials/credentials.yml.example

@@ -0,0 +1,5 @@
+# To run remote tests you'll need to copy this file to credentials.yml
+# in the same directory and change the values to match your spreedly environment. 
+
+environment_key: "YOUR-SPREEDLY-ENVIRONMENT-KEY"
+access_secret: "YOUR-SPREEDLY-ACCESS-SECRET"

data/test/credentials/test_credentials.rb

@@ -23,7 +23,7 @@ module Spreedly
     end
 
     def load_personal_creds
-      return {} unless File.exists?(personal_creds_file)
+      return {} unless File.exist?(personal_creds_file)
 
       personal_creds = YAML.load(File.read(personal_creds_file))
       return {} unless personal_creds

data/test/helpers/creation_helper.rb

@@ -23,7 +23,7 @@ module Spreedly
 
     def default_card_deets
       {
-        email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2019,
+        email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2023,
         last_name: 'Aybara', first_name: 'Perrin', retained: true
       }
     end

data/test/remote/remote_add_credit_card_test.rb

@@ -51,7 +51,7 @@ class RemoteAddCreditCardTest < Test::Unit::TestCase
   end
 
   def test_successfull_add_using_full_name
-    t = @environment.add_credit_card(number: '5555555555554444', month: 1, year: 2019, full_name: "Kvothe Jones")
+    t = @environment.add_credit_card(number: '5555555555554444', month: 1, year: 2023, full_name: "Kvothe Jones")
     assert t.succeeded?
     assert_equal "Kvothe", t.payment_method.first_name
     assert_equal "Jones", t.payment_method.last_name
@@ -62,7 +62,7 @@ class RemoteAddCreditCardTest < Test::Unit::TestCase
   private
   def card_deets(options = {})
     {
-      email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2019,
+      email: 'perrin@wot.com', number: '5555555555554444', month: 1, year: 2023,
       last_name: 'Aybara', first_name: 'Perrin', data: "occupation: Blacksmith"
     }.merge(options)
   end

data/test/remote/remote_add_receiver_test.rb

@@ -25,9 +25,9 @@ class RemoteAddReceiverTest < Test::Unit::TestCase
   end
 
   def test_add_test_receiver
-    receiver = @environment.add_receiver(:test, 'http://testserver.com')
+    receiver = @environment.add_receiver(:test, 'http://spreedly-echo.herokuapp.com')
     assert_equal "test", receiver.receiver_type
-    assert_equal 'http://testserver.com', receiver.hostnames
+    assert_equal 'http://spreedly-echo.herokuapp.com', receiver.hostnames
   end
 
   def test_need_active_account

data/test/remote/remote_deliver_payment_method_test.rb

@@ -38,9 +38,9 @@ class RemoteDeliverPaymentMethodTest < Test::Unit::TestCase
     assert_equal(true, transaction.succeeded?)
     assert_equal(card_token, transaction.payment_method.token)
     assert_equal(receiver_token, transaction.receiver.token)
-    assert_match(/Successfully dumped 0 post variables.*Post body was 109 chars long/m, transaction.response.body)
+    assert_match(/HOST: spreedly-echo.herokuapp.com\nCONNECTION: close/m, transaction.response.body)
     assert_equal('200', transaction.response.status)
-    assert_match(/Server: Apache/m, transaction.response.headers)
+    assert_match(/Server: thin/m, transaction.response.headers)
   end
 
   private
@@ -49,7 +49,7 @@ class RemoteDeliverPaymentMethodTest < Test::Unit::TestCase
   end
 
   def url
-    'http://posttestserver.com/post.php'
+    'https://spreedly-echo.herokuapp.com'
   end
 
   def receiver_test_credentials

data/test/remote/remote_gateway_options_test.rb

@@ -10,7 +10,7 @@ class RemoteGatewayOptionsTest < Test::Unit::TestCase
     gateway_classes = @environment.gateway_options
     braintree = gateway_classes.select { |each| each.name == "Braintree" }.first
     assert_equal "http://www.braintreepaymentsolutions.com/", braintree.homepage
-    assert_equal %w(credit_card third_party_token apple_pay android_pay), braintree.payment_methods
+    assert_equal %w(credit_card third_party_token apple_pay android_pay google_pay), braintree.payment_methods
     assert_equal %w(asia_pacific europe north_america), braintree.regions
     assert_equal %w(orange blue), braintree.auth_modes.map { |e| e.auth_mode_type }
     assert_equal %w(login password), braintree.auth_modes.first.credentials.map { |e| e.name }

data/test/remote/remote_purchase_test.rb

@@ -66,6 +66,29 @@ class RemotePurchaseTest < Test::Unit::TestCase
     assert transaction.checkout_url
   end
 
+  def test_3d_secure_attempt_transaction_arguments
+    gateway_token = @environment.add_gateway(:test).token
+    card_token = create_card_on(@environment, number: '4556761029983886', retained: false).token
+
+    transaction = @environment.purchase_on_gateway(gateway_token, card_token, 344,
+                                                   order_id: "8675",
+                                                   description: "SuperDuper",
+                                                   ip: "183.128.100.103",
+                                                   email: "fred@example.com",
+                                                   merchant_name_descriptor: "Real Stuff",
+                                                   merchant_location_descriptor: "Raleigh",
+                                                   retain_on_success: true,
+                                                   redirect_url: "https://example.com/redirect",
+                                                   callback_url: "https://example.com/callback",
+                                                   attempt_3dsecure: true)
+
+    assert_equal "pending", transaction.state
+    assert "https://example.com/callback", transaction.callback_url
+    assert "https://example.com/redirect", transaction.redirect_url
+    assert_equal '', transaction.checkout_url
+    assert transaction.checkout_form.include?("<form action=\"https://core.spreedly.com/test/#{gateway_token}")
+  end
+
   def test_optional_arguments
     gateway_token = @environment.add_gateway(:test).token
     card_token = create_card_on(@environment, retained: false).token
@@ -89,6 +112,7 @@ class RemotePurchaseTest < Test::Unit::TestCase
     assert_equal "fred@example.com", transaction.email
     assert_equal "perrin@wot.com", transaction.payment_method.email
     assert_match /\d/, transaction.gateway_transaction_id
+    assert_match "Purchase", transaction.transaction_type
   end
 
   def test_gateway_specific_fields

data/test/remote/remote_recache_payment_method_test.rb

@@ -0,0 +1,30 @@
+require 'test_helper'
+
+class RemoteRecachePaymentMethodTest < Test::Unit::TestCase
+
+  def setup
+    @environment = Spreedly::Environment.new(remote_test_environment_key, remote_test_access_secret)
+  end
+
+  def test_invalid_login
+    assert_invalid_login do |environment|
+      environment.recache_payment_method('payment_method_token')
+    end
+  end
+
+  def test_payment_method_token_token_not_found
+    assert_raise_with_message(Spreedly::NotFoundError, "Unable to find the specified payment method.") do
+      @environment.recache_payment_method('unknown_token')
+    end
+  end
+
+  def test_successful_recache
+    card_token = create_card_on(@environment).token
+
+    transaction = @environment.recache_payment_method(card_token, verification_value: '123')
+
+    assert transaction.succeeded?
+    assert_equal 'retained', transaction.payment_method.storage_state
+  end
+
+end

data/test/remote/remote_redact_receiver_test.rb

@@ -0,0 +1,16 @@
+require 'test_helper'
+
+class RemoteRedactReceiverTest < Test::Unit::TestCase
+  def setup
+    @environment = Spreedly::Environment.new(remote_test_environment_key, remote_test_access_secret)
+  end
+
+  def test_successful_redact
+    receiver = @environment.add_receiver(:test, 'https://sandbox.usaepay.com')
+
+    transaction = @environment.redact_receiver(receiver.token)
+
+    assert transaction.succeeded?
+    assert_equal 'redacted', transaction.state
+  end
+end

data/test/remote/remote_update_credit_card_test.rb

@@ -56,7 +56,7 @@ class RemoteUpdateCreditCardTest < Test::Unit::TestCase
   private
   def card_deets(options = {})
     {
-      email: 'cauthon@wot.com', month: 1, year: 2019,
+      email: 'cauthon@wot.com', month: 1, year: 2023,
       last_name: 'Cauthon', first_name: 'Mat',
       eligible_for_card_updater: 'false'
     }.merge(options)

data/test/unit/add_credit_card_test.rb

@@ -24,6 +24,7 @@ class AddCreditCreditCardTest < Test::Unit::TestCase
 
     assert_equal "AXaBXfVUqhaGMg8ytf8isiMAAL9", t.payment_method.token
     assert_equal "Eland Venture", t.payment_method.full_name
+    assert_equal 'credit_card', t.payment_method.payment_method_type
     assert_equal "Don't test everything here, since find_payment_method tests it all.", t.payment_method.data
 
     assert t.payment_method.eligible_for_card_updater
@@ -121,5 +122,3 @@ class AddCreditCreditCardTest < Test::Unit::TestCase
   end
 
 end
-
-

data/test/unit/authorize_test.rb

@@ -28,11 +28,14 @@ class AuthorizeTest < Test::Unit::TestCase
     assert_equal 'Tax Free Zone', t.merchant_location_descriptor
     assert_equal 'YjWxOjbpeieXsZFdAsbhM2DFgLe', t.gateway_token
     assert_equal "44", t.gateway_transaction_id
+    assert_equal "Authorization", t.transaction_type
     assert_equal "TheName", t.gateway_specific_fields[:litle][:descriptor_name]
     assert_equal "33411441", t.gateway_specific_fields[:litle][:descriptor_phone]
     assert_equal "844", t.gateway_specific_fields[:stripe][:application_fee]
+    assert_equal "credit", t.gateway_specific_response_fields[:stripe][:card_funding]
 
     assert_equal 'Nh2Vw0kAoSQvcJDpK52q4dZlrVJ', t.payment_method.token
+    assert_equal 'credit_card', t.payment_method.payment_method_type
     assert_equal 'Forthrast', t.payment_method.last_name
 
     assert t.response.success
@@ -67,7 +70,8 @@ class AuthorizeTest < Test::Unit::TestCase
       [ './merchant_name_descriptor', 'TRain' ],
       [ './merchant_location_descriptor', 'British Colombia' ],
       [ './gateway_specific_fields/braintree/customer_id', '1143' ],
-      [ './retain_on_success', 'true' ]
+      [ './retain_on_success', 'true' ],
+      [ './continue_caching', 'true']
   end
 
 
@@ -88,7 +92,8 @@ class AuthorizeTest < Test::Unit::TestCase
       gateway_specific_fields: {
         braintree: { customer_id: "1143" }
       },
-      retain_on_success: true
+      retain_on_success: true,
+      continue_caching: true
     }
   end
 

data/test/unit/capture_test.rb

@@ -28,6 +28,8 @@ class CaptureTest < Test::Unit::TestCase
     assert_equal 'Tax Free Zone', t.merchant_location_descriptor
     assert_equal 'SoPblCOGDwaRyym68XGWeRiCy1C', t.gateway_token
     assert_equal 'PH6U2tyFWtDSVp88bNW2nnGy5rk', t.reference_token
+    assert_equal 'Capture', t.transaction_type
+    assert_equal "credit", t.gateway_specific_response_fields[:stripe][:card_funding]
 
     assert t.response.success
     assert_equal 'Successful capture', t.response.message

data/test/unit/find_payment_method_test.rb

@@ -22,6 +22,7 @@ class FindPaymentMethodTest < Test::Unit::TestCase
     assert_equal(1369504152, card.created_at.to_i)
     assert_equal(1369508044, card.updated_at.to_i)
     assert_equal('master', card.card_type)
+    assert_equal('credit_card', card.payment_method_type)
     assert_equal('Alcatraz', card.first_name)
     assert_equal('Smedry', card.last_name)
     assert_equal('8', card.month)

data/test/unit/list_payment_methods_test.rb

@@ -23,6 +23,7 @@ class ListPaymentMethodsTest < Test::Unit::TestCase
 
     assert_equal 'Perrin Aybara', list.first.full_name
     assert_equal 'Mat Cauthon', list[1].full_name
+    assert_equal 'credit_card', list.first.payment_method_type
     assert_equal 'test_vault:4111111111111111', list[2].third_party_token
     assert_equal 'retained', list[3].storage_state
     assert_equal '4321', list[4].account_number_display_digits

data/test/unit/purchase_test.rb

@@ -29,6 +29,7 @@ class PurchaseTest < Test::Unit::TestCase
     assert_equal 'YOaCn5a9xRaBTGgmGAWbkgWUuqv', t.gateway_token
     assert_equal '8xXXIPGXTaPXysDA5OUpgnjTEjK', t.payment_method.token
     assert_equal "44", t.gateway_transaction_id
+    assert_equal "Purchase", t.transaction_type
 
     assert t.response.success
     assert_equal 'Successful purchase', t.response.message
@@ -54,6 +55,59 @@ class PurchaseTest < Test::Unit::TestCase
     assert_equal '', t.shipping_address.phone_number
   end
 
+  def test_successful_3dsecure_purchase_attempt
+    t = purchase_using(successful_purchase_3dsecure_attempt_response)
+
+    assert_kind_of(Spreedly::Purchase, t)
+    assert_equal 'Btcyks35m4JLSNOs9ymJoNQLjeX', t.token
+    assert_equal 144, t.amount
+    assert t.on_test_gateway?
+    assert_equal Time.parse("2013-07-31 19:46:26 UTC"), t.created_at
+    assert_equal Time.parse("2013-07-31 19:46:32 UTC"), t.updated_at
+    assert_equal 'USD', t.currency_code
+    assert !t.succeeded?
+    assert_equal 'pending', t.state
+    assert_equal 'none', t.required_action
+    assert_equal 'http://challenge_url.test', t.challenge_url
+    assert_equal 'challenge form data', t.challenge_form
+    assert_equal 'device fingerprint form data', t.device_fingerprint_form
+    assert_equal '', t.order_id
+    assert_equal '', t.ip
+    assert_equal '4 Shardblades', t.description
+    assert_equal '', t.merchant_name_descriptor
+    assert_equal '', t.merchant_location_descriptor
+    assert_equal 'YOaCn5a9xRaBTGgmGAWbkgWUuqv', t.gateway_token
+    assert_equal '8xXXIPGXTaPXysDA5OUpgnjTEjK', t.payment_method.token
+    assert_equal "44", t.gateway_transaction_id
+
+    assert t.response.success
+    assert_equal 'Checked enrollment status', t.response.message
+    assert !t.response.pending
+    assert !t.response.fraud_review
+    assert_equal '', t.response.error_code
+    assert_equal Time.parse('2013-07-31T19:46:26Z'), t.response.created_at
+    assert_equal Time.parse('2013-07-31T19:46:27Z'), t.response.updated_at
+
+    assert_equal 'https://example.com/callback_url', t.callback_url
+    assert_equal 'https://example.com/redirect_url', t.redirect_url
+    assert_equal '', t.checkout_url
+
+    assert t.checkout_form.include?('<form action="https://core.spreedly.com/test/1234/auth/1234" method="POST">')
+    assert t.checkout_form.include?('<input name="PaReq" value="" type="hidden"/>')
+    assert t.checkout_form.include?('<input name="MD" value="" type="hidden"/>')
+    assert t.checkout_form.include?('<input name="TermUrl" value="https://core.spreedly.com/transaction/Btcyks35m4JLSNOs9ymJoNQLjeX/redirect" type="hidden"/>')
+    assert t.checkout_form.include?('<input name="Complete" value="Authorize Transaction" type="submit"/>')
+
+    assert_equal '', t.shipping_address.name
+    assert_equal '', t.shipping_address.address1
+    assert_equal '', t.shipping_address.address2
+    assert_equal '', t.shipping_address.city
+    assert_equal '', t.shipping_address.state
+    assert_equal '', t.shipping_address.zip
+    assert_equal '', t.shipping_address.country
+    assert_equal '', t.shipping_address.phone_number
+  end
+
   def test_failed_purchase
     t = purchase_using(failed_purchase_response)
 
@@ -94,7 +148,8 @@ class PurchaseTest < Test::Unit::TestCase
       [ './ip', '183.128.100.103' ],
       [ './merchant_name_descriptor', 'Real Stuff' ],
       [ './merchant_location_descriptor', 'Raleigh' ],
-      [ './retain_on_success', 'true' ]
+      [ './retain_on_success', 'true' ],
+      [ './continue_caching', 'true']
   end
 
 
@@ -112,7 +167,8 @@ class PurchaseTest < Test::Unit::TestCase
       ip: "183.128.100.103",
       merchant_name_descriptor: "Real Stuff",
       merchant_location_descriptor: "Raleigh",
-      retain_on_success: true
+      retain_on_success: true,
+      continue_caching: true
     }
   end
 

data/test/unit/recache_payment_method_test.rb

@@ -0,0 +1,34 @@
+require 'test_helper'
+require 'unit/response_stubs/recache_payment_method_stubs'
+
+class RecachePaymentMethodTest < Test::Unit::TestCase
+
+  include RecachePaymentMethodStubs
+
+  def setup
+    @environment = Spreedly::Environment.new("key", "secret")
+  end
+
+  def test_successful_recache
+    t = recache_using(successful_recache_payment_method_response)
+
+    assert_kind_of(Spreedly::RecacheSensitiveData, t)
+    assert_equal '2BSe5T6FHpypph3ensF7m3Nb3qk', t.token
+    assert_equal Time.parse('2013-08-05 17:43:41 UTC'), t.created_at
+    assert_equal Time.parse('2013-08-05 17:43:41 UTC'), t.updated_at
+    assert t.succeeded?
+    assert_equal 'Succeeded!', t.message
+    assert_equal 'succeeded', t.state
+    assert_equal 'retained', t.payment_method.storage_state
+    assert_equal 'RvsxKgbAZBmiZHEPhhTcOQzJeC2', t.payment_method.token
+  end
+
+  private
+
+  def recache_using(response)
+    @environment.stubs(:raw_ssl_request).returns(response)
+    @environment.recache_payment_method("IgnoredTokenSinceResponseIsStubbed", verification_value: 'VerificationValue')
+  end
+
+end
+

data/test/unit/refund_test.rb

@@ -28,6 +28,7 @@ class RefundTest < Test::Unit::TestCase
     assert_equal 'Tax Free Zone', t.merchant_location_descriptor
     assert_equal 'XYI0V2l4KC1cAm6Y3c2kG5loJaA', t.gateway_token
     assert_equal 'RkIAltzr49eXuWc7ajBjLLeKZt8', t.reference_token
+    assert_equal 'Credit', t.transaction_type
 
     assert t.response.success
     assert_equal 'Successful credit', t.response.message

data/test/unit/response_stubs/authorization_stubs.rb

@@ -26,8 +26,11 @@ module AuthorizationStubs
             <application_fee>844</application_fee>
           </stripe>
         </gateway_specific_fields>
-        <gateway_specific_fields nil="true"/>
-        <gateway_specific_response_fields nil="true"/>
+        <gateway_specific_response_fields>
+          <stripe>
+            <card_funding>credit</card_funding>
+          </stripe>
+        </gateway_specific_response_fields>
         <message key="messages.transaction_succeeded">Succeeded!</message>
         <gateway_token>YjWxOjbpeieXsZFdAsbhM2DFgLe</gateway_token>
         <gateway_transaction_id>44</gateway_transaction_id>

data/test/unit/response_stubs/capture_stubs.rb

@@ -19,7 +19,11 @@ module CaptureStubs
         <merchant_name_descriptor>My Writeoff Inc.</merchant_name_descriptor>
         <merchant_location_descriptor>Tax Free Zone</merchant_location_descriptor>
         <gateway_specific_fields nil="true"/>
-        <gateway_specific_response_fields nil="true"/>
+        <gateway_specific_response_fields>
+          <stripe>
+            <card_funding>credit</card_funding>
+          </stripe>
+        </gateway_specific_response_fields>
         <message key="messages.transaction_succeeded">Succeeded!</message>
         <gateway_token>SoPblCOGDwaRyym68XGWeRiCy1C</gateway_token>
         <gateway_transaction_id>44</gateway_transaction_id>

data/test/unit/response_stubs/purchase_stubs.rb

@@ -241,4 +241,109 @@ module PurchaseStubs
     XML
   end
 
+  def successful_purchase_3dsecure_attempt_response
+    StubResponse.succeeded <<-XML
+      <transaction>
+        <amount type="integer">144</amount>
+        <on_test_gateway type="boolean">true</on_test_gateway>
+        <created_at type="datetime">2013-07-31T19:46:26Z</created_at>
+        <updated_at type="datetime">2013-07-31T19:46:32Z</updated_at>
+        <currency_code>USD</currency_code>
+        <succeeded type="boolean">false</succeeded>
+        <state>pending</state>
+        <token>Btcyks35m4JLSNOs9ymJoNQLjeX</token>
+        <transaction_type>Purchase</transaction_type>
+        <order_id nil="true"/>
+        <ip nil="true"/>
+        <description>4 Shardblades</description>
+        <merchant_name_descriptor nil="true"/>
+        <merchant_location_descriptor nil="true"/>
+        <gateway_specific_fields nil="true"/>
+        <gateway_specific_response_fields nil="true"/>
+        <message key="messages.transaction_pending">Pending</message>
+        <required_action>none</required_action>
+        <challenge_url>http://challenge_url.test</challenge_url>
+        <challenge_form>challenge form data</challenge_form>
+        <device_fingerprint_form>device fingerprint form data</device_fingerprint_form>
+        <gateway_token>YOaCn5a9xRaBTGgmGAWbkgWUuqv</gateway_token>
+        <gateway_transaction_id>44</gateway_transaction_id>
+        <shipping_address>
+          <name nil="true"/>
+          <address1 nil="true"/>
+          <address2 nil="true"/>
+          <city nil="true"/>
+          <state nil="true"/>
+          <zip nil="true"/>
+          <country nil="true"/>
+          <phone_number nil="true"//>
+        </shipping_address>
+        <response>
+          <success type="boolean">true</success>
+          <message>Checked enrollment status</message>
+          <error_code nil="true"/>
+          <checkout_url nil="true"/>
+          <created_at type="datetime">2013-07-31T19:46:26Z</created_at>
+          <updated_at type="datetime">2013-07-31T19:46:27Z</updated_at>
+        </response>
+        <payment_method>
+          <token>8xXXIPGXTaPXysDA5OUpgnjTEjK</token>
+          <created_at type="datetime">2013-07-31T19:46:25Z</created_at>
+          <updated_at type="datetime">2013-07-31T19:46:26Z</updated_at>
+          <email>perrin@wot.com</email>
+          <data nil="true"/>
+          <storage_state>retained</storage_state>
+          <last_four_digits>4444</last_four_digits>
+          <first_six_digits>411111</first_six_digits>
+          <card_type>master</card_type>
+          <first_name>Perrin</first_name>
+          <last_name>Aybara</last_name>
+          <month type="integer">1</month>
+          <year type="integer">2019</year>
+          <address1 nil="true"/>
+          <address2 nil="true"/>
+          <city nil="true"/>
+          <state nil="true"/>
+          <zip nil="true"/>
+          <country nil="true"/>
+          <phone_number nil="true"/>
+          <company>Acme</company>
+          <full_name>Perrin Aybara</full_name>
+          <payment_method_type>credit_card</payment_method_type>
+          <eligible_for_card_updater type="boolean">true</eligible_for_card_updater>
+          <errors>
+          </errors>
+          <verification_value></verification_value>
+          <fingerprint>ac5579920013cc571e506805f1c8f3220eff</fingerprint>
+          <number>XXXX-XXXX-XXXX-4444</number>
+        </payment_method>
+        <api_urls>
+          <callback_conversations>https://core.spreedly.com/v1/callbacks/12345/conversations.xml</callback_conversations>
+        </api_urls>
+        <callback_url>https://example.com/callback_url</callback_url>
+        <redirect_url>https://example.com/redirect_url</redirect_url>
+        <checkout_url nil="true"/>
+        <checkout_form>
+          <![CDATA[
+          <form action="https://core.spreedly.com/test/1234/auth/1234" method="POST">
+            <div>
+              <input name="PaReq" value="" type="hidden"/>
+              <input name="MD" value="" type="hidden"/>
+              <input name="TermUrl" value="https://core.spreedly.com/transaction/Btcyks35m4JLSNOs9ymJoNQLjeX/redirect" type="hidden"/>
+              <input name="Complete" value="Authorize Transaction" type="submit"/>
+            </div>
+          </form>
+          ]]>
+        </checkout_form>
+        <setup_response>
+          <success type="boolean">true</success>
+          <message>Checked enrollment status</message>
+          <error_code nil="true"/>
+          <checkout_url nil="true"/>
+          <created_at type="datetime">2013-07-31T19:46:26Z</created_at>
+          <updated_at type="datetime">2013-07-31T19:46:27Z</updated_at>
+        </setup_response>
+      </transaction>
+    XML
+  end
+
 end

data/test/unit/response_stubs/recache_payment_method_stubs.rb

@@ -0,0 +1,53 @@
+module RecachePaymentMethodStubs
+
+  def successful_recache_payment_method_response
+    StubResponse.succeeded <<-XML
+      <transaction>
+        <on_test_gateway type="boolean">false</on_test_gateway>
+        <created_at type="datetime">2013-08-05T17:43:41Z</created_at>
+        <updated_at type="datetime">2013-08-05T17:43:41Z</updated_at>
+        <succeeded type="boolean">true</succeeded>
+        <token>2BSe5T6FHpypph3ensF7m3Nb3qk</token>
+        <state>succeeded</state>
+        <gateway_specific_fields nil="true"/>
+        <gateway_specific_response_fields nil="true"/>
+        <transaction_type>RecacheSensitiveData</transaction_type>
+        <order_id nil="true"/>
+        <ip nil="true"/>
+        <message key="messages.transaction_succeeded">Succeeded!</message>
+        <payment_method>
+          <token>RvsxKgbAZBmiZHEPhhTcOQzJeC2</token>
+          <created_at type="datetime">2013-08-05T17:43:41Z</created_at>
+          <updated_at type="datetime">2013-08-05T17:43:41Z</updated_at>
+          <email>perrin@wot.com</email>
+          <data nil="true"/>
+          <storage_state>retained</storage_state>
+          <last_four_digits>4444</last_four_digits>
+          <first_six_digits>411111</first_six_digits>
+          <card_type>master</card_type>
+          <first_name>Perrin</first_name>
+          <last_name>Aybara</last_name>
+          <month type="integer">1</month>
+          <year type="integer">2019</year>
+          <address1 nil="true"/>
+          <address2 nil="true"/>
+          <city nil="true"/>
+          <state nil="true"/>
+          <zip nil="true"/>
+          <country nil="true"/>
+          <phone_number nil="true"/>
+          <company>Acme</company>
+          <full_name>Perrin Aybara</full_name>
+          <payment_method_type>credit_card</payment_method_type>
+          <eligible_for_card_updater type="boolean">true</eligible_for_card_updater>
+          <errors>
+          </errors>
+          <verification_value></verification_value>
+          <fingerprint>ac5579920013cc571e506805f1c8f3220eff</fingerprint>
+          <number>XXXX-XXXX-XXXX-4444</number>
+        </payment_method>
+      </transaction>
+    XML
+  end
+
+end

data/test/unit/verify_test.rb

@@ -26,6 +26,7 @@ class VerifyTest < Test::Unit::TestCase
     assert_equal 'Tax Free Zone', t.merchant_location_descriptor
     assert_equal 'LoxFMxQJD5E1ksAwFWykUamaCKE', t.gateway_token
     assert_equal "49", t.gateway_transaction_id
+    assert_equal 'Verification', t.transaction_type
 
     assert_equal '98626DYInHb4K86dp6GrocnZOW6', t.payment_method.token
     assert_equal 'Aybara', t.payment_method.last_name
@@ -57,7 +58,8 @@ class VerifyTest < Test::Unit::TestCase
       [ './ip', '183.128.100.102' ],
       [ './merchant_name_descriptor', 'TRain' ],
       [ './merchant_location_descriptor', 'British Colombia' ],
-      [ './retain_on_success', 'true' ]
+      [ './retain_on_success', 'true' ],
+      [ './continue_caching', 'true']
   end
 
 
@@ -74,7 +76,8 @@ class VerifyTest < Test::Unit::TestCase
       ip: "183.128.100.102",
       merchant_name_descriptor: "TRain",
       merchant_location_descriptor: "British Colombia",
-      retain_on_success: true
+      retain_on_success: true,
+      continue_caching: true
     }
   end
 

data/test/unit/void_test.rb

@@ -27,6 +27,7 @@ class VoidTest < Test::Unit::TestCase
     assert_equal 'Somewhere', t.merchant_location_descriptor
     assert_equal 'EuXlDMZEMZfrHSvE9tkRzaW8j0z', t.gateway_token
     assert_equal 'CjedAratpuiT3CMmln4t3oZFvOS', t.reference_token
+    assert_equal 'Void', t.transaction_type
 
     assert t.response.success?
     assert_equal 'Successful void', t.response.message

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreedly
 version: !ruby/object:Gem::Version
-  version: 2.0.18
+  version: 2.0.19
 platform: ruby
 authors:
 - Spreedly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-20 00:00:00.000000000 Z
+date: 2019-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -25,21 +25,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: awesome_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: log_buddy
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: log_buddy
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: awesome_print
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -112,11 +112,14 @@ description: The Spreedly gem provides a convenient Ruby wrapper for the Spreedl
   API.
 email:
 - duff@spreedly.com
+- doug@spreedly.com
+- jeremy@spreedly.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - HISTORY.md
 - LICENSE.txt
@@ -162,7 +165,7 @@ files:
 - lib/spreedly/urls.rb
 - lib/spreedly/version.rb
 - spreedly.gemspec
-- test/credentials/credentials.yml
+- test/credentials/credentials.yml.example
 - test/credentials/test_credentials.rb
 - test/helpers/assertions.rb
 - test/helpers/communication_helper.rb
@@ -183,9 +186,11 @@ files:
 - test/remote/remote_list_payment_methods_test.rb
 - test/remote/remote_list_transactions_test.rb
 - test/remote/remote_purchase_test.rb
+- test/remote/remote_recache_payment_method_test.rb
 - test/remote/remote_receiver_options_test.rb
 - test/remote/remote_redact_gateway_test.rb
 - test/remote/remote_redact_payment_method_test.rb
+- test/remote/remote_redact_receiver_test.rb
 - test/remote/remote_refund_test.rb
 - test/remote/remote_retain_test.rb
 - test/remote/remote_store_test.rb
@@ -210,6 +215,7 @@ files:
 - test/unit/list_payment_methods_test.rb
 - test/unit/list_transactions_test.rb
 - test/unit/purchase_test.rb
+- test/unit/recache_payment_method_test.rb
 - test/unit/receiver_options_test.rb
 - test/unit/redact_gateway_test.rb
 - test/unit/redact_payment_method_test.rb
@@ -228,6 +234,7 @@ files:
 - test/unit/response_stubs/list_payment_methods_stubs.rb
 - test/unit/response_stubs/list_transactions_stubs.rb
 - test/unit/response_stubs/purchase_stubs.rb
+- test/unit/response_stubs/recache_payment_method_stubs.rb
 - test/unit/response_stubs/receiver_options_stubs.rb
 - test/unit/response_stubs/redact_gateway_stubs.rb
 - test/unit/response_stubs/redact_payment_method_stubs.rb
@@ -263,12 +270,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Provides a Ruby wrapper for the Spreedly API.
 test_files:
-- test/credentials/credentials.yml
+- test/credentials/credentials.yml.example
 - test/credentials/test_credentials.rb
 - test/helpers/assertions.rb
 - test/helpers/communication_helper.rb
@@ -289,9 +296,11 @@ test_files:
 - test/remote/remote_list_payment_methods_test.rb
 - test/remote/remote_list_transactions_test.rb
 - test/remote/remote_purchase_test.rb
+- test/remote/remote_recache_payment_method_test.rb
 - test/remote/remote_receiver_options_test.rb
 - test/remote/remote_redact_gateway_test.rb
 - test/remote/remote_redact_payment_method_test.rb
+- test/remote/remote_redact_receiver_test.rb
 - test/remote/remote_refund_test.rb
 - test/remote/remote_retain_test.rb
 - test/remote/remote_store_test.rb
@@ -316,6 +325,7 @@ test_files:
 - test/unit/list_payment_methods_test.rb
 - test/unit/list_transactions_test.rb
 - test/unit/purchase_test.rb
+- test/unit/recache_payment_method_test.rb
 - test/unit/receiver_options_test.rb
 - test/unit/redact_gateway_test.rb
 - test/unit/redact_payment_method_test.rb
@@ -334,6 +344,7 @@ test_files:
 - test/unit/response_stubs/list_payment_methods_stubs.rb
 - test/unit/response_stubs/list_transactions_stubs.rb
 - test/unit/response_stubs/purchase_stubs.rb
+- test/unit/response_stubs/recache_payment_method_stubs.rb
 - test/unit/response_stubs/receiver_options_stubs.rb
 - test/unit/response_stubs/redact_gateway_stubs.rb
 - test/unit/response_stubs/redact_payment_method_stubs.rb

data/test/credentials/credentials.yml

@@ -1,9 +0,0 @@
-# This file contains the Spreedly credentials to use when running remote tests.
-# They're working credentials so the remote tests should simply run.
-
-# You may instead choose to use your own credentials for your own Spreedly
-# test environment by copying this file to the gitignored file named
-# personal_credentials.yml located in the same directory as this file.
-
-environment_key: "R7lHscqcYkZeDGGbthKp6GKMu15"
-access_secret: "8sefxO5Q44sLWpmZpalQS3Qlqo03JbCemsqsWJR3YOLCuigOFRlaLSAn0WaL5dWU"