spree_vpago 2.4.0.pre.pre2 → 2.4.0.pre.pre4

data/app/controllers/concerns/spree/mini_app_concern.rb

@@ -0,0 +1,25 @@
+module Spree
+  # Shared by every mini app controller. What lives here is whatever a mini app needs from the
+  # request or gives back in the response, rather than anything one partner does on its own —
+  # today the gate its session service runs the caller through, built from the two things only
+  # the request knows, and the status a refusal answers with.
+  module MiniAppConcern
+    extend ActiveSupport::Concern
+
+    private
+
+    def session_gate(provider)
+      SpreeCmCommissioner::MiniAppProvider::SessionGate.new(
+        provider: provider,
+        api_key: request.headers['X-Api-Key'],
+        ip: request.remote_ip
+      )
+    end
+
+    # A cap or a blocked address is not the payload being wrong, so each answers with its
+    # own status and the partner can tell them apart.
+    def failure_status(result)
+      (result.value.is_a?(Hash) && result.value[:status]) || :unprocessable_entity
+    end
+  end
+end

data/app/controllers/spree/admin/payment_acleda_v2_base_controller.rb

@@ -0,0 +1,21 @@
+module Spree
+  module Admin
+    class PaymentAcledaV2BaseController < Spree::Admin::BaseController
+      include Spree::Backend::Callbacks
+
+      before_action :load_payment, only: %i[show update]
+      before_action :validate_order, only: [:update]
+
+      def validate_order
+        return unless @payment.order.completed?
+
+        flash[:error] = Spree.t('vpago.payments.not_allow_for_order_completed')
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      end
+
+      def load_payment
+        @payment = Payment.find_by!(number: params[:id])
+      end
+    end
+  end
+end

data/app/controllers/spree/admin/payment_acleda_v2_checkers_controller.rb

@@ -0,0 +1,26 @@
+module Spree
+  module Admin
+    class PaymentAcledaV2CheckersController < PaymentAcledaV2BaseController
+      include Spree::Backend::Callbacks
+
+      def update
+        options = {
+          updated_by_user_id: try_spree_current_user.id,
+          updated_reason: Spree.t('vpago.payments.checker_updated_by_description')
+        }
+        spree_updater = Vpago::AcledaV2::PaymentRequestUpdater.new(@payment, options)
+        spree_updater.call
+
+        @payment.reload
+
+        if @payment.order.completed?
+          flash[:success] = Spree.t(:successfully_updated, resource: Spree.t(:payments))
+        else
+          flash[:error] = Spree.t(:unsuccessfully_updated, resource: Spree.t(:payments))
+        end
+
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      end
+    end
+  end
+end

data/app/controllers/spree/admin/payment_acleda_v2_queriers_controller.rb

@@ -0,0 +1,38 @@
+module Spree
+  module Admin
+    class PaymentAcledaV2QueriersController < PaymentAcledaV2BaseController
+      include Spree::Backend::Callbacks
+
+      around_action :set_writing_role, only: %i[show]
+
+      def show
+        tran_status = @payment.payment_method.check_transaction(@payment)
+
+        if tran_status.success?
+          @payment.update_column(:gateway_status, true)
+          flash[:success] =
+            Spree.t('vpago.payments.payment_found_with_result', result: tran_status.json_response)
+        else
+          flash[:error] = Spree.t('vpago.payments.payment_not_found_with_error', error: tran_status.error_message)
+        end
+
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      rescue Faraday::TimeoutError, Faraday::ConnectionFailed => e
+        VpagoLogger.error(
+          label: 'Spree::Admin::PaymentAcledaV2QueriersController#show gateway_timeout',
+          data: { payment_number: @payment.number, error_class: e.class.name, error_message: e.message }
+        )
+        flash[:error] = Spree.t('vpago.payments.gateway_timeout')
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      end
+
+      private
+
+      def set_writing_role
+        ActiveRecord::Base.connected_to(role: :writing) do
+          yield if block_given?
+        end
+      end
+    end
+  end
+end

data/app/controllers/spree/admin/payment_payway_queriers_controller.rb

@@ -16,6 +16,13 @@ module Spree
           flash[:error] = Spree.t('vpago.payments.payment_not_found_with_error', error: tran_status.error_message)
         end
 
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      rescue Faraday::TimeoutError, Faraday::ConnectionFailed => e
+        VpagoLogger.error(
+          label: 'Spree::Admin::PaymentPaywayQueriersController#show gateway_timeout',
+          data: { payment_number: @payment.number, error_class: e.class.name, error_message: e.message }
+        )
+        flash[:error] = Spree.t('vpago.payments.gateway_timeout')
         redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
       end
 

data/app/controllers/spree/admin/payment_vattanac_base_controller.rb

@@ -0,0 +1,21 @@
+module Spree
+  module Admin
+    class PaymentVattanacBaseController < Spree::Admin::BaseController
+      include Spree::Backend::Callbacks
+
+      before_action :load_payment, only: %i[show update]
+      before_action :validate_order, only: [:update]
+
+      def validate_order
+        return unless @payment.order.completed?
+
+        flash[:error] = Spree.t('vpago.payments.not_allow_for_order_completed')
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      end
+
+      def load_payment
+        @payment = Payment.find_by!(number: params[:id])
+      end
+    end
+  end
+end

data/app/controllers/spree/admin/payment_vattanac_checkers_controller.rb

@@ -0,0 +1,26 @@
+module Spree
+  module Admin
+    class PaymentVattanacCheckersController < PaymentVattanacBaseController
+      include Spree::Backend::Callbacks
+
+      def update
+        options = {
+          updated_by_user_id: try_spree_current_user.id,
+          updated_reason: Spree.t('vpago.payments.checker_updated_by_description')
+        }
+        spree_updater = Vpago::Vattanac::PaymentRequestUpdater.new(@payment, options)
+        spree_updater.call
+
+        @payment.reload
+
+        if @payment.order.completed?
+          flash[:success] = Spree.t(:successfully_updated, resource: Spree.t(:payments))
+        else
+          flash[:error] = Spree.t(:unsuccessfully_updated, resource: Spree.t(:payments))
+        end
+
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      end
+    end
+  end
+end

data/app/controllers/spree/admin/payment_vattanac_queriers_controller.rb

@@ -0,0 +1,38 @@
+module Spree
+  module Admin
+    class PaymentVattanacQueriersController < PaymentVattanacBaseController
+      include Spree::Backend::Callbacks
+
+      around_action :set_writing_role, only: %i[show]
+
+      def show
+        tran_status = @payment.payment_method.check_transaction(@payment)
+
+        if tran_status.success?
+          @payment.update_column(:gateway_status, true)
+          flash[:success] =
+            Spree.t('vpago.payments.payment_found_with_result', result: tran_status.json_response)
+        else
+          flash[:error] = Spree.t('vpago.payments.payment_not_found_with_error', error: tran_status.error_message)
+        end
+
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      rescue Faraday::TimeoutError, Faraday::ConnectionFailed => e
+        VpagoLogger.error(
+          label: 'Spree::Admin::PaymentVattanacQueriersController#show gateway_timeout',
+          data: { payment_number: @payment.number, error_class: e.class.name, error_message: e.message }
+        )
+        flash[:error] = Spree.t('vpago.payments.gateway_timeout')
+        redirect_to admin_order_payment_path(order_id: @payment.order.number, id: @payment.number)
+      end
+
+      private
+
+      def set_writing_role
+        ActiveRecord::Base.connected_to(role: :writing) do
+          yield if block_given?
+        end
+      end
+    end
+  end
+end

data/app/controllers/spree/{miniapp → mini_app}/acledas_controller.rb

@@ -1,21 +1,27 @@
 module Spree
-  module Miniapp
+  module MiniApp
     # Partner Session Initialization API (ACLEDA Mini App Integration Spec, Step 01).
-    # ACLEDA (server-to-server) POSTs { phone, first_name, last_name }; we return a
-    # session-based miniAppUrl for ACLEDA to open in the WebView.
+    # ACLEDA POSTs { phone, first_name, last_name } signed with X-Acleda-Signature, and
+    # gets back a session-based miniAppUrl to open in the WebView.
     class AcledasController < Spree::Api::V2::BaseController
-      # POST /miniapp/acleda
+      include Spree::MiniAppConcern
+
+      PROVIDER = 'acleda_bank'.freeze
+
+      # POST /mini_app/acleda
       def create
         result = ::Vpago::AcledaMiniApp::Session::Create.call(
           phone: session_params[:phone],
           first_name: session_params[:first_name],
-          last_name: session_params[:last_name]
+          last_name: session_params[:last_name],
+          signature: request.headers['X-Acleda-Signature'],
+          gate: session_gate(PROVIDER)
         )
 
         if result.success?
           render json: { message: 'SUCCESS', miniAppUrl: result.value[:mini_app_url] }
         else
-          render json: { message: 'FAILED', error: result.error.to_s }, status: :unprocessable_entity
+          render json: { message: 'FAILED', error: result.error.to_s }, status: failure_status(result)
         end
       end
 

data/app/controllers/spree/mini_app/wings_controller.rb

@@ -0,0 +1,58 @@
+module Spree
+  module MiniApp
+    # Wing Mini App WebView entry. Wing opens this page cold — no server-to-server
+    # pre-step like ACLEDA/Vattanac — so the page itself calls getProfile and posts
+    # the signed result to #create.
+    class WingsController < ApplicationController
+      include Spree::MiniAppConcern
+
+      layout 'wing_mini_app'
+
+      PROVIDER = 'wing_bank'.freeze
+
+      # Both actions carry their own HMAC (ProfileVerifier / WebhookVerifier), and
+      # neither has an authenticated session for a CSRF token to protect.
+      skip_before_action :verify_authenticity_token, only: %i[create callback]
+
+      def show; end
+
+      def create
+        result = ::Vpago::WingMiniApp::Session::Create.call(
+          profile: profile_params.to_h,
+          gate: session_gate(PROVIDER)
+        )
+
+        if result.success?
+          render json: { message: 'SUCCESS', miniAppUrl: result.value[:mini_app_url] }
+        else
+          render json: { message: 'FAILED', error: result.error.to_s }, status: failure_status(result)
+        end
+      end
+
+      # Wing POSTs its settlement here. Its own action rather than
+      # VpagoPaymentsController#process_payment, which is shaped around browser
+      # returns from other gateways — return_params merging, the ABA reviewing-mode
+      # branch, the internal_client flag — none of which a server-to-server webhook
+      # sends.
+      def callback
+        payment = ::Vpago::PaymentFinder.new(params.permit!.to_h).find_and_verify
+
+        return render json: { status: 'not_found' }, status: :not_found if payment.nil?
+
+        ::Vpago::PaymentProcessorJob.perform_later(payment_number: payment.number) unless payment.order.paid?
+
+        render json: { status: 'ok' }, status: :ok
+      end
+
+      private
+
+      def profile_params
+        params.require(:profile).permit(
+          :id, :appId, :firstName, :lastName, :middleName, :fullName, :sex, :age, :nationality,
+          :phone, :email, :city, :country, :address, :occupation, :addrCode, :dobFull, :nidNumber,
+          :nidType, :nidExpirationDate, :lang, :appVersion, :osVersion, :secret_key
+        )
+      end
+    end
+  end
+end

data/app/controllers/spree/vpago_payments_controller.rb

@@ -24,6 +24,12 @@ module Spree
     def processing
       @order = @payment.order
 
+      # Common, not an edge case: the gateway callback or the checkout page's transaction
+      # checker often completes the order before the browser lands here. Skipping this page
+      # also skips its Firebase listener, so success must post order_is_completed itself
+      # (render_success_script) or an embedding iframe modal never closes.
+      return redirect_to @payment.success_url, allow_other_host: true if @order.completed?
+
       VpagoLogger.log(label: 'Spree::VpagoPaymentsController#processing', data: vpago_log_context)
     end
 
@@ -60,6 +66,12 @@ module Spree
       else
         render json: { status: :pending }, status: :ok
       end
+    rescue Faraday::TimeoutError, Faraday::ConnectionFailed => e
+      VpagoLogger.error(
+        label: 'Spree::VpagoPaymentsController#check_transaction gateway_timeout',
+        data: vpago_log_context(error_class: e.class.name, error_message: e.message)
+      )
+      render json: { status: :pending }, status: :ok
     end
 
     # POST
@@ -146,9 +158,9 @@ module Spree
       raise ActiveRecord::RecordNotFound unless @payment.present?
     end
 
-    # frame-ancestors (set above) supersedes X-Frame-Options in modern
-    # browsers, but the default SAMEORIGIN header would still block legacy
-    # browsers from embedding these pages, so drop it for the iframe actions.
+    # These pages are embedded in iframes on many partner sites we don't
+    # enumerate, so framing is left unrestricted: no frame-ancestors policy, and
+    # Rails' default SAMEORIGIN header is dropped for the iframe actions.
     def allow_iframe_embedding
       response.headers.delete('X-Frame-Options')
     end

data/app/helpers/vpago/vpago_payments_helper.rb

@@ -13,6 +13,12 @@ module Vpago
       render partial: 'spree/vpago_payments/transaction_checker'
     end
 
+    # Host apps override success.html.erb; call this from every override so an
+    # embedding iframe modal still learns the order completed.
+    def render_success_script
+      render partial: 'spree/vpago_payments/success_script'
+    end
+
     # Each payment method may have their own additional processing script,
     # so we will look for the partial based on the payment method class name.
     #

data/app/models/spree/gateway/acleda_mini_app.rb

@@ -1,18 +1,16 @@
 module Spree
   # ACLEDA Mini App payment method.
   #
-  # Reuses the ACLEDA V2 integration in deeplink mode: the deeplink produced by
-  # ACLEDA's openSessionV2 API is handed to the ACLEDA super-app through the
-  # `acledaJSBridge` (startPayment) instead of redirecting the page. Server-side
-  # verification reuses AcledaV2's #check_transaction (getTxnStatus).
+  # Reuses the ACLEDA V2 integration in deeplink mode: openSessionV2 returns a deeplink the
+  # payment page opens as a top-frame navigation, which ACLEDA's own WebView turns into an app
+  # launch. Server-side verification reuses AcledaV2's #check_transaction (getTxnStatus).
   class Gateway::AcledaMiniApp < Gateway::AcledaV2
     # override: partial to render in admin / checkout form lookup
     def method_type
       'acleda_mini_app'
     end
 
-    # The mini app always uses the deeplink + JS bridge, so admins don't need to
-    # set the ACLEDA V2 mode.
+    # The mini app always pays by deeplink, so admins don't need to set the ACLEDA V2 mode.
     def deeplink?
       true
     end

data/app/models/spree/gateway/wing_mini_app.rb

@@ -0,0 +1,58 @@
+module Spree
+  # Wing Mini App payment method (doPayment). Wing pushes settlement to our webhook,
+  # where Vpago::PaymentFinder checks the secretKey and the amount/currency match
+  # before storing transaction_response — the only place that is verified.
+  class Gateway::WingMiniApp < PaymentMethod
+    def method_type
+      'wing_mini_app'
+    end
+
+    # Read from Wing's mini app row (WingMiniApp::Config), not a payment method preference:
+    # login verifies against the same pair, and a second source could sign payments as a
+    # different partner — a mismatch that first surfaces at the webhook, after the debit.
+    def app_id
+      SpreeCmCommissioner::WingMiniApp::Config.app_id
+    end
+
+    def secret_api_key
+      SpreeCmCommissioner::WingMiniApp::Config.secret_api_key
+    end
+
+    def payment_source_class
+      Spree::VpagoPaymentSource
+    end
+
+    def auto_capture?
+      true
+    end
+
+    # override
+    def purchase(_amount, _source, gateway_options = {})
+      _, payment_number = gateway_options[:order_id].split('-')
+      payment = Spree::Payment.find_by(number: payment_number)
+      response = payment&.transaction_response || {}
+
+      params = { payment_response: response }
+
+      # A present transaction_response is PaymentFinder having already verified this
+      # settlement, so there is nothing left to check.
+      if response.present?
+        ActiveMerchant::Billing::Response.new(true, 'Wing Mini App: Purchased', params)
+      else
+        ActiveMerchant::Billing::Response.new(false, 'Wing Mini App: Purchasing Failed', params)
+      end
+    end
+
+    # override
+    def void(_response_code, _gateway_options)
+      ActiveMerchant::Billing::Response.new(true, 'Wing Mini App order has been voided.')
+    end
+
+    # override
+    # Wing documents no refund API, so this fails rather than returning a no-op success:
+    # refunds stay manual with Wing until they publish one.
+    def cancel(_response_code, _payment)
+      ActiveMerchant::Billing::Response.new(false, 'Wing Mini App: cancel is not supported — no Wing refund API is documented yet.')
+    end
+  end
+end

data/app/models/vpago/payment_decorator.rb

@@ -113,6 +113,10 @@ module Vpago
       payment_method.type_acleda_mini_app?
     end
 
+    def wing_mini_app_payment?
+      payment_method.type_wing_mini_app?
+    end
+
     def check_payment?
       payment_method.type_check?
     end

data/app/models/vpago/payment_method_decorator.rb

@@ -10,6 +10,7 @@ module Vpago
     TYPE_TRUE_MONEY = 'Spree::Gateway::TrueMoney'.freeze
     TYPE_VATTANAC = 'Spree::Gateway::Vattanac'.freeze
     TYPE_VATTANAC_MINI_APP = 'Spree::Gateway::VattanacMiniApp'.freeze
+    TYPE_WING_MINI_APP = 'Spree::Gateway::WingMiniApp'.freeze
     TYPE_CASH_ON = 'Spree::PaymentMethod::CashOn'.freeze
 
     def self.prepended(base)
@@ -28,6 +29,7 @@ module Vpago
           Spree::PaymentMethod::TYPE_ACLEDA_MINI_APP,
           Spree::PaymentMethod::TYPE_VATTANAC,
           Spree::PaymentMethod::TYPE_VATTANAC_MINI_APP,
+          Spree::PaymentMethod::TYPE_WING_MINI_APP,
           Spree::PaymentMethod::TYPE_TRUE_MONEY,
           Spree::PaymentMethod::TYPE_CASH_ON
         ]
@@ -82,6 +84,10 @@ module Vpago
         ::Vpago::Acleda::PaymentRequestUpdater
       elsif type_acleda_mobile?
         ::Vpago::AcledaMobile::PaymentRequestUpdater
+      elsif type_acleda_v2?
+        ::Vpago::AcledaV2::PaymentRequestUpdater
+      elsif type_vattanac?
+        ::Vpago::Vattanac::PaymentRequestUpdater
       end
     end
 
@@ -113,10 +119,18 @@ module Vpago
       type == Spree::PaymentMethod::TYPE_WINGSDK
     end
 
+    def type_vattanac?
+      type == Spree::PaymentMethod::TYPE_VATTANAC
+    end
+
     def type_vattanac_mini_app?
       type == Spree::PaymentMethod::TYPE_VATTANAC_MINI_APP
     end
 
+    def type_wing_mini_app?
+      type == Spree::PaymentMethod::TYPE_WING_MINI_APP
+    end
+
     def type_true_money?
       type == Spree::PaymentMethod::TYPE_TRUE_MONEY
     end

data/app/serializers/spree/v2/storefront/payment_method_serializer_decorator.rb

@@ -14,6 +14,12 @@ module Spree
 
             pref.blank? || pref[:payment_option].blank? ? payment_method.method_type : pref[:payment_option]
           end
+
+          # Overried the payment method type to show all payment methods as one list on App.
+          # Controlled by ENV["PAYMENT_METHOD_VIEW"] = "split" | "join" (default: "join").
+          base.attribute :type do |payment_method|
+            ENV.fetch('PAYMENT_METHOD_VIEW', 'join') == 'split' ? payment_method.type : 'payment_method'
+          end
         end
       end
     end

data/app/services/vpago/acleda_mini_app/session/create.rb

@@ -3,20 +3,32 @@ module Vpago
     module Session
       # Partner Session Initialization (ACLEDA Mini App Integration Spec, Step 01).
       #
-      # ACLEDA calls POST /miniapp/acleda with { phone, first_name, last_name }.
-      # We find or create the customer (tagged with the acleda_bank identity),
-      # mint a session JWT, and return a session-based miniAppUrl for ACLEDA to
-      # open in the WebView. The generic session_id OAuth grant validates the JWT
-      # when the WebView later authenticates.
+      # ACLEDA POSTs { phone, first_name, last_name } with an X-Acleda-Signature HMAC
+      # (see SessionHashValidator), checked before we touch the user so nobody can mint
+      # a session for an arbitrary phone. We then find or create the customer, tag them
+      # with the acleda_bank identity, and hand back a miniAppUrl carrying a session JWT.
       class Create
         prepend Spree::ServiceModule::Base
 
-        def call(phone: nil, first_name: nil, last_name: nil)
+        # `signature`, not `hash`: an attr_reader named `hash` overrides Object#hash and
+        # silently breaks this object as a Hash key.
+        #
+        # `gate` answers who is calling, from where and how often. The controller builds it:
+        # the key header and the address exist only on the request.
+        def call(gate:, phone: nil, first_name: nil, last_name: nil, signature: nil)
           return failure(nil, 'phone is required') if phone.blank?
 
           @phone = phone
           @first_name = first_name
           @last_name = last_name
+          @signature = signature
+          @gate = gate
+
+          return failure({ status: :unauthorized }, 'missing or unknown api key') unless gate.api_key_accepted?
+          return failure({ status: :forbidden }, 'address not allowed') unless gate.address_allowed?
+          return failure(nil, 'invalid signature') unless valid_signature?
+          return failure(nil, 'phone is invalid') if intel_phone.blank?
+          return failure({ status: :too_many_requests }, 'too many requests') if gate.session_exceeded?(phone: intel_phone)
 
           user = find_or_create_user
           return failure(user, 'user creation failed') if user.nil? || !user.persisted?
@@ -26,7 +38,20 @@ module Vpago
 
         private
 
-        attr_reader :phone, :first_name, :last_name
+        attr_reader :phone, :first_name, :last_name, :signature, :gate
+
+        # Only asked where this call would mint an account — the damage a leaked key does.
+        # Returning customers never spend that quota.
+        def new_user_throttled?
+          !acleda_identity.persisted? && find_existing_user.nil? && gate.new_user_exceeded?(phone: intel_phone)
+        end
+
+        def valid_signature?
+          ::Vpago::AcledaMiniApp::SessionHashValidator.new(
+            phone: phone, first_name: first_name, last_name: last_name, hash: signature,
+            secret_key: gate.mini_app&.preferred_secret_key
+          ).call
+        end
 
         def find_or_create_user
           identity = acleda_identity
@@ -34,9 +59,10 @@ module Vpago
           # Returning customer: the ACLEDA identity already points at a user.
           return identity.user if identity.persisted?
 
-          # New to ACLEDA: reuse a customer matched by phone, otherwise build one,
-          # then tag them with the acleda_bank identity so the lookup above hits
-          # next time.
+          return nil if new_user_throttled?
+
+          # New to ACLEDA: reuse a customer matched by phone, otherwise build one, then
+          # tag them so the lookup above hits next time.
           user = find_existing_user || build_user
           identity.name = full_name
           user.user_identity_providers << identity
@@ -45,14 +71,17 @@ module Vpago
           user
         end
 
+        # Memoized: #new_user_throttled? asks the same questions, and this row is the one
+        # that gets tagged onto the user.
         def acleda_identity
-          SpreeCmCommissioner::UserIdentityProvider.acleda_bank.find_or_initialize_by(sub: phone)
+          @acleda_identity ||= SpreeCmCommissioner::UserIdentityProvider.acleda_bank.find_or_initialize_by(sub: phone)
         end
 
         def find_existing_user
-          return if intel_phone.blank?
+          return @find_existing_user if defined?(@find_existing_user)
+          return @find_existing_user = nil if intel_phone.blank?
 
-          Spree::User.by_non_tenant.find_by(intel_phone_number: intel_phone)
+          @find_existing_user = Spree::User.by_non_tenant.find_by(intel_phone_number: intel_phone)
         end
 
         def build_user
@@ -67,15 +96,14 @@ module Vpago
         end
 
         def mini_app_url(user)
-          # A JWT signed with the user's secure_token. Passed as `session_key` (not
-          # `session_id`) so the OAuth grant routes it to the ACLEDA authenticator,
-          # which enforces the signature.
+          # A JWT signed with the user's secure_token. `session_key`, not `session_id`, so
+          # the OAuth grant routes it to the ACLEDA authenticator.
           session_key = SpreeCmCommissioner::UserSessionJwtToken.encode(
             { user_id: user.id },
             user.reload.secure_token
           )
 
-          "#{Spree::Store.default.formatted_url}/mini_app/acleda?session_key=#{session_key}&ds=#{CGI.escape(disable_services)}"
+          "#{Spree::Store.default.formatted_url}/mini_app/acleda?session_key=#{session_key}"
         end
 
         def full_name
@@ -87,12 +115,6 @@ module Vpago
 
           @intel_phone = SpreeCmCommissioner::PhoneNumberParser.call(phone_number: phone).intel_phone_number
         end
-
-        # Services to disable in the mini app storefront. Configurable per ACLEDA's
-        # requirement; defaults to none.
-        def disable_services
-          ENV.fetch('ACLEDA_MINI_APP_DISABLE_SERVICES', '')
-        end
       end
     end
   end