spree_simple_product_translations 0.0.7.beta1 → 0.0.7.beta2

data/README.md

@@ -25,13 +25,17 @@ If you have pre-existing data, you'll need to run this rake task:
     rake spree:extensions:product_translations:globalize_legacy_data
 
 # Open issues
+## Globalize3
 In the current version of [Globalize3](https://github.com/svenfuchs/globalize3) there is an issue with fallbacks. When you add new translations in the forms, but leave some of them blank, they won't fall back to the default locale. This is because [Globalize3](https://github.com/svenfuchs/globalize3) only loads fallbacks when the values are nil. Because of the way Rails handles these attributes, they will be stored as blank strings into the database.
 
 If you are using the fallbacks, you might want to use [my fork](https://github.com/jeroenj/globalize3) of [Globalize3](https://github.com/svenfuchs/globalize3) in your Gemfile until it gets merged into [Globalize3](https://github.com/svenfuchs/globalize3)'s [master branch](https://github.com/svenfuchs/globalize3):
 
     gem 'globalize3', :git => 'git://github.com/jeroenj/globalize3.git', :branch => 'fallbacks-master'
 
-For those interested, you can follow [the pull request here](https://github.com/svenfuchs/globalize3/pull/32).
+For those interested, you can follow [the pull request here](https://github.com/svenfuchs/globalize3/pull/47).
+
+## Empty forms (properties & taxons)
+Spree is using symbols instead of objects to define `form_for`'s for properties and taxons. This causes the forms to be empty. This can be fixed by overriding both edit pages with the changes found in [this pull request](https://github.com/spree/spree/pull/326).
 
 # To add in future releases
 * Add form to:

data/app/views/admin/products/_product_form_left.html.erb

@@ -14,7 +14,7 @@
       <%= f.globalize_fields_for l do |g| %>
         <% default_locale = l.to_sym == I18n.default_locale %>
         <%= f.field_container :name do %>
-          <%= g.label :name, t("name") %> <% if default_locale %><span class="required">*</span><br /><% end %>
+          <%= g.label :name, t("name") %> <% if default_locale %><span class="required">*</span><% end %><br />
           <%= g.text_field :name, :class => 'fullwidth title'  %>
           <%= f.error_message_on :name %>
         <% end %>

data/lib/batch_translation.rb

@@ -9,7 +9,7 @@ module ActionView
         @index = @index ? @index + 1 : 1
         object_name = "#{@object_name}[translations_attributes][#{@index}]"
         form_object = @object || @object_name.to_s.camelize.constantize.new
-        object = form_object.translations.select{|t| t.locale.to_s == locale}.first || form_object.translations.find_by_locale(locale)
+        object = form_object.translations.select{|t| t.locale.to_s == locale.to_s}.first
         @template.concat @template.hidden_field_tag("#{object_name}[id]", object ? object.id : "")
         @template.concat @template.hidden_field_tag("#{object_name}[locale]", locale)
         @template.fields_for(object_name, object, options, &proc)

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: spree_simple_product_translations
 version: !ruby/object:Gem::Version 
-  hash: 62196377
+  hash: 62196383
   prerelease: 6
   segments: 
   - 0
   - 0
   - 7
   - beta
-  - 1
-  version: 0.0.7.beta1
+  - 2
+  version: 0.0.7.beta2
 platform: ruby
 authors: 
 - Jeroen Jacobs
@@ -17,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-18 00:00:00 +02:00
+date: 2011-05-19 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency