spree_purchase_order 3.2.0.rc1 → 3.2.0

data/spec/dummy/db/migrate/20180516182048_fix_adjustment_order_id.spree.rb

@@ -0,0 +1,71 @@
+# This migration comes from spree (originally 20150515211137)
+class FixAdjustmentOrderId < ActiveRecord::Migration[4.2]
+  def change
+    say 'Populate order_id from adjustable_id where appropriate'
+    execute(<<-SQL.squish)
+      UPDATE
+        spree_adjustments
+      SET
+        order_id = adjustable_id
+      WHERE
+        adjustable_type = 'Spree::Order'
+      ;
+    SQL
+
+    # Submitter of change does not care about MySQL, as it is not officially supported.
+    # Still spree officials decided to provide a working code path for MySQL users, hence
+    # submitter made a AR code path he could validate on PostgreSQL.
+    #
+    # Whoever runs a big enough MySQL installation where the AR solution hurts:
+    # Will have to write a better MySQL specific equivalent.
+    if Spree::Order.connection.adapter_name.eql?('MySQL')
+      Spree::Adjustment.where(adjustable_type: 'Spree::LineItem').find_each do |adjustment|
+        adjustment.update_columns(order_id: Spree::LineItem.find(adjustment.adjustable_id).order_id)
+      end
+    else
+      execute(<<-SQL.squish)
+        UPDATE
+          spree_adjustments
+        SET
+          order_id =
+            (SELECT order_id FROM spree_line_items WHERE spree_line_items.id = spree_adjustments.adjustable_id)
+        WHERE
+          adjustable_type = 'Spree::LineItem'
+      SQL
+    end
+
+    say 'Fix schema for spree_adjustments order_id column'
+    change_table :spree_adjustments do |t|
+      t.change :order_id, :integer, null: false
+    end
+
+    # Improved schema for postgresql, uncomment if you like it:
+    #
+    # # Negated Logical implication.
+    # #
+    # # When adjustable_type is 'Spree::Order' (p) the adjustable_id must be order_id (q).
+    # #
+    # # When adjustable_type is NOT 'Spree::Order' the adjustable id allowed to be any value (including of order_id in
+    # # case foreign keys match). XOR does not work here.
+    # #
+    # # Postgresql does not have an operator for logical implication. So we need to build the following truth table
+    # # via AND with OR:
+    # #
+    # #  p q | CHECK = !(p -> q)
+    # #  -----------
+    # #  t t | t
+    # #  t f | f
+    # #  f t | t
+    # #  f f | t
+    # #
+    # # According to de-morgans law the logical implication q -> p is equivalent to !p || q
+    # #
+    # execute(<<-SQL.squish)
+    #   ALTER TABLE ONLY spree_adjustments
+    #    ADD CONSTRAINT fk_spree_adjustments FOREIGN KEY (order_id)
+    #      REFERENCES spree_orders(id) ON UPDATE RESTRICT ON DELETE RESTRICT,
+    #    ADD CONSTRAINT check_spree_adjustments_order_id CHECK
+    #      (adjustable_type <> 'Spree::Order' OR order_id = adjustable_id);
+    # SQL
+  end
+end

data/spec/dummy/db/migrate/20180516182049_add_position_to_spree_payment_methods.spree.rb

@@ -0,0 +1,6 @@
+# This migration comes from spree (originally 20150522071831)
+class AddPositionToSpreePaymentMethods < ActiveRecord::Migration[4.2]
+  def change
+    add_column :spree_payment_methods, :position, :integer, default: 0
+  end
+end

data/spec/dummy/db/migrate/20180516182050_add_deleted_at_to_friendly_id_slugs.spree.rb

@@ -0,0 +1,7 @@
+# This migration comes from spree (originally 20150522181728)
+class AddDeletedAtToFriendlyIdSlugs < ActiveRecord::Migration[4.2]
+  def change
+    add_column :friendly_id_slugs, :deleted_at, :datetime
+    add_index :friendly_id_slugs, :deleted_at
+  end
+end

data/spec/dummy/db/migrate/20180516182051_increase_scale_on_pre_tax_amounts.spree.rb

@@ -0,0 +1,17 @@
+# This migration comes from spree (originally 20150609093816)
+class IncreaseScaleOnPreTaxAmounts < ActiveRecord::Migration[4.2]
+  def change
+    # set pre_tax_amount on shipments to discounted_amount - included_tax_total
+    # so that the null: false option on the shipment pre_tax_amount doesn't generate
+    # errors.
+    #
+    execute(<<-SQL)
+      UPDATE spree_shipments
+      SET pre_tax_amount = (cost + promo_total) - included_tax_total
+      WHERE pre_tax_amount IS NULL;
+    SQL
+
+    change_column :spree_line_items, :pre_tax_amount, :decimal, precision: 12, scale: 4, default: 0.0, null: false
+    change_column :spree_shipments, :pre_tax_amount, :decimal, precision: 12, scale: 4, default: 0.0, null: false
+  end
+end

data/spec/dummy/db/migrate/20180516182052_add_taxable_adjustment_total_to_line_item.spree.rb

@@ -0,0 +1,20 @@
+# This migration comes from spree (originally 20150626181949)
+class AddTaxableAdjustmentTotalToLineItem < ActiveRecord::Migration[4.2]
+  def change
+    add_column :spree_line_items, :taxable_adjustment_total, :decimal,
+               precision: 10, scale: 2, default: 0.0, null: false
+    add_column :spree_line_items, :non_taxable_adjustment_total, :decimal,
+               precision: 10, scale: 2, default: 0.0, null: false
+
+    add_column :spree_shipments, :taxable_adjustment_total, :decimal,
+               precision: 10, scale: 2, default: 0.0, null: false
+    add_column :spree_shipments, :non_taxable_adjustment_total, :decimal,
+               precision: 10, scale: 2, default: 0.0, null: false
+
+    add_column :spree_orders, :taxable_adjustment_total, :decimal,
+               precision: 10, scale: 2, default: 0.0, null: false
+    add_column :spree_orders, :non_taxable_adjustment_total, :decimal,
+               precision: 10, scale: 2, default: 0.0, null: false
+    # TODO migration that updates old orders
+  end
+end

data/spec/dummy/db/migrate/20180516182053_migrate_payment_methods_display.spree.rb

@@ -0,0 +1,13 @@
+# This migration comes from spree (originally 20150627090949)
+class MigratePaymentMethodsDisplay < ActiveRecord::Migration[4.2]
+  def change
+    Spree::PaymentMethod.all.each do |method|
+      if method.display_on.blank?
+        method.display_on = "both"
+        method.save
+      end
+    end
+
+    change_column :spree_payment_methods, :display_on, :string, default: "both"
+  end
+end

data/spec/dummy/db/migrate/20180516182054_enable_acts_as_paranoid_on_calculators.spree.rb

@@ -0,0 +1,7 @@
+# This migration comes from spree (originally 20150707204155)
+class EnableActsAsParanoidOnCalculators < ActiveRecord::Migration[4.2]
+  def change
+    add_column :spree_calculators, :deleted_at, :datetime
+    add_index :spree_calculators, :deleted_at
+  end
+end

data/spec/dummy/db/migrate/20180516182055_spree_payment_method_store_credits.spree.rb

@@ -0,0 +1,13 @@
+# This migration comes from spree (originally 20150714154102)
+class SpreePaymentMethodStoreCredits < ActiveRecord::Migration[4.2]
+  def up
+    # Reload to pick up new position column for acts_as_list
+    Spree::PaymentMethod.reset_column_information
+    Spree::PaymentMethod::StoreCredit.find_or_create_by(name: 'Store Credit', description: 'Store Credit',
+                                                        active: true, display_on: 'back_end')
+  end
+
+  def down
+    Spree::PaymentMethod.find_by(type: 'Spree::PaymentMethod::StoreCredit', name: 'Store Credit').try(&:destroy)
+  end
+end

data/spec/dummy/db/migrate/20180516182056_rename_has_and_belongs_to_associations_to_model_names.spree.rb

@@ -0,0 +1,19 @@
+# This migration comes from spree (originally 20150726141425)
+class RenameHasAndBelongsToAssociationsToModelNames < ActiveRecord::Migration[4.2]
+  def change
+    {
+      'spree_option_types_prototypes' => 'spree_option_type_prototypes',
+      'spree_option_values_variants' => 'spree_option_value_variants',
+      'spree_orders_promotions' => 'spree_order_promotions',
+      'spree_products_promotion_rules' => 'spree_product_promotion_rules',
+      'spree_taxons_promotion_rules' => 'spree_promotion_rule_taxons',
+      'spree_promotion_rules_users' => 'spree_promotion_rule_users',
+      'spree_properties_prototypes' => 'spree_property_prototypes',
+      'spree_taxons_prototypes' => 'spree_prototype_taxons',
+      'spree_roles_users' => 'spree_role_users',
+      'spree_shipping_methods_zones' => 'spree_shipping_method_zones'
+    }.each do |old_name, new_name|
+      rename_table old_name, new_name
+    end
+  end
+end

data/spec/dummy/db/migrate/20180516182057_spree_store_credit_types.spree.rb

@@ -0,0 +1,12 @@
+# This migration comes from spree (originally 20150727191614)
+class SpreeStoreCreditTypes < ActiveRecord::Migration[4.2]
+  def up
+    Spree::StoreCreditType.find_or_create_by(name: 'Expiring', priority: 1)
+    Spree::StoreCreditType.find_or_create_by(name: 'Non-expiring', priority: 2)
+  end
+
+  def down
+    Spree::StoreCreditType.find_by(name: 'Expiring').try(&:destroy)
+    Spree::StoreCreditType.find_by(name: 'Non-expiring').try(&:destroy)
+  end
+end

data/spec/dummy/db/migrate/20180516182058_add_discontinued_to_products_and_variants.spree.rb

@@ -0,0 +1,69 @@
+# This migration comes from spree (originally 20150819154308)
+class AddDiscontinuedToProductsAndVariants < ActiveRecord::Migration[4.2]
+  def up
+    add_column :spree_products, :discontinue_on, :datetime, after: :available_on
+    add_column :spree_variants, :discontinue_on, :datetime, after: :deleted_at
+
+    add_index :spree_products, :discontinue_on
+    add_index :spree_variants, :discontinue_on
+
+    puts "Warning: This migration changes the meaning of 'deleted'. Before this change, 'deleted' meant products that were no longer being sold in your store. After this change, you can only delete a product or variant if it has not already been sold to a customer (a model-level check enforces this). Instead, you should use the new field 'discontinue_on' for products or variants which were sold in the past but no longer for sale. This fixes bugs when other objects are attached to deleted products and variants. (Even though acts_as_paranoid gem keeps the records in the database, most associations are automatically scoped to exclude the deleted records.) In thew meaning of 'deleted,' you can still use the delete function on products & variants which are *truly user-error mistakes*, specifically before an order has been placed or the items have gone on sale. You also must use the soft-delete function (which still works after this change) to clean up slug (product) and SKU (variant) duplicates. Otherwise, you should generally over ever need to discontinue products.
+
+Data Fix: We will attempt to reverse engineer the old meaning of 'deleted' (no longer for sale) to the new database field 'discontinue_on'. However, since Slugs and SKUs cannot be duplicated on Products and Variants, we cannot gaurantee this to be foolproof if you have deteled Products and Variants that have duplicate Slugs or SKUs in non-deleted records. In these cases, we recommend you use the additional rake task to clean up your old records (see rake db:fix_orphan_line_items). If you have such records, this migration will leave them in place, preferring the non-deleted records over the deleted ones. However, since old line items will still be associated with deleted objects, you will still the bugs in your app until you run:
+
+rake db:fix_orphan_line_items
+
+We will print out a report of the data we are fixing now: "
+
+    Spree::Product.only_deleted.each do |product|
+      # determine if there is a slug duplicate
+      the_dup = Spree::Product.find_by(slug: product.slug)
+      if the_dup.nil?
+        # check to see if there are line items attached to any variants
+        if Spree::Variant.with_deleted.where(product_id: product.id).map(&:line_items).any?
+          puts "recovering deleted product id #{product.id} ... this will un-delete the record and set it to be discontinued"
+
+          old_deleted = product.deleted_at
+          product.update_column(:deleted_at, nil) # for some reason .recover doesn't appear to be a method
+          product.update_column(:discontinue_on, old_deleted)
+        else
+          puts "leaving product id #{product.id} deleted because there are no line items attached to it..."
+        end
+      else
+        puts "leaving product id #{product.id} deleted because there is a duplicate slug for '#{product.slug}' (product id #{the_dup.id}) "
+        if product.variants.map(&:line_items).any?
+          puts "WARNING: You may still have bugs with product id #{product.id} (#{product.name}) until you run rake db:fix_orphan_line_items"
+        end
+      end
+    end
+
+    Spree::Variant.only_deleted.each do |variant|
+      # determine if there is a slug duplicate
+      the_dup = Spree::Variant.find_by(sku: variant.sku)
+      if the_dup.nil?
+        # check to see if there are line items attached to any variants
+        if variant.line_items.any?
+          puts "recovering deleted variant id #{variant.id} ... this will un-delete the record and set it to be discontinued"
+          old_deleted = variant.deleted_at
+          variant.update_column(:deleted_at, nil) # for some reason .recover doesn't appear to be a method
+          variant.update_column(:discontinue_on, old_deleted)
+        else
+          puts "leaving variant id #{variant.id} deleted because there are no line items attached to it..."
+        end
+      else
+        puts "leaving variant id #{variant.id} deleted because there is a duplicate SKU for '#{variant.sku}' (variant id #{the_dup.id}) "
+        if variant.line_items.any?
+          puts "WARNING: You may still have bugs with variant id #{variant.id} (#{variant.name}) until you run rake db:fix_orphan_line_items"
+        end
+      end
+    end
+  end
+
+  def down
+    execute "UPDATE spree_products SET deleted_at = discontinue_on WHERE deleted_at IS NULL"
+    execute "UPDATE spree_variants SET deleted_at = discontinue_on WHERE deleted_at IS NULL"
+
+    remove_column :spree_products, :discontinue_on
+    remove_column :spree_variants, :discontinue_on
+  end
+end

data/spec/dummy/db/migrate/20180516182059_remove_shipping_method_id_from_spree_orders.spree.rb

@@ -0,0 +1,14 @@
+# This migration comes from spree (originally 20151220072838)
+class RemoveShippingMethodIdFromSpreeOrders < ActiveRecord::Migration[4.2]
+  def up
+    if column_exists?(:spree_orders, :shipping_method_id, :integer)
+      remove_column :spree_orders, :shipping_method_id, :integer
+    end
+  end
+
+  def down
+    unless column_exists?(:spree_orders, :shipping_method_id, :integer)
+      add_column :spree_orders, :shipping_method_id, :integer
+    end
+  end
+end

data/spec/dummy/db/migrate/20180516182060_add_id_column_to_earlier_habtm_tables.spree.rb

@@ -0,0 +1,17 @@
+# This migration comes from spree (originally 20160207191757)
+class AddIdColumnToEarlierHabtmTables < ActiveRecord::Migration[4.2]
+  def up
+    add_column :spree_option_type_prototypes, :id, :primary_key
+    add_column :spree_option_value_variants, :id, :primary_key
+    add_column :spree_order_promotions, :id, :primary_key
+    add_column :spree_product_promotion_rules, :id, :primary_key
+    add_column :spree_promotion_rule_users, :id, :primary_key
+    add_column :spree_property_prototypes, :id, :primary_key
+    add_column :spree_role_users, :id, :primary_key
+    add_column :spree_shipping_method_zones, :id, :primary_key
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+end

data/spec/dummy/db/migrate/20180516182061_add_indexes.spree.rb

@@ -0,0 +1,15 @@
+# This migration comes from spree (originally 20160219165458)
+class AddIndexes < ActiveRecord::Migration[4.2]
+  def change
+    add_index :spree_assets, :position
+    add_index :spree_option_types, :name
+    add_index :spree_option_values, :name
+    add_index :spree_prices, :variant_id
+    add_index :spree_properties, :name
+    add_index :spree_roles, :name
+    add_index :spree_shipping_categories, :name
+    add_index :spree_taxons, :lft
+    add_index :spree_taxons, :rgt
+    add_index :spree_taxons, :name
+  end
+end

data/spec/dummy/db/migrate/20180516182062_remove_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

@@ -0,0 +1,11 @@
+# This migration comes from spree (originally 20160509064646)
+class RemoveCounterCacheFromSpreeVariantsToSpreeStockItems < ActiveRecord::Migration[4.2]
+  def up
+    if column_exists?(:spree_variants, :stock_items_count)
+      remove_column :spree_variants, :stock_items_count
+    end
+  end
+
+  def down
+  end
+end

data/spec/dummy/db/migrate/20180516182063_acts_as_taggable_on_spree_migration.spree.rb

@@ -0,0 +1,41 @@
+# This migration comes from spree (originally 20160511071954)
+class ActsAsTaggableOnSpreeMigration < ActiveRecord::Migration[4.2]
+  def self.up
+    create_table :spree_tags do |t|
+      t.string :name
+      t.integer :taggings_count, default: 0
+    end
+
+    create_table :spree_taggings do |t|
+      t.references :tag
+
+      # You should make sure that the column created is
+      # long enough to store the required class names.
+      t.references :taggable, polymorphic: true
+      t.references :tagger, polymorphic: true
+
+      # Limit is created to prevent MySQL error on index
+      # length for MyISAM table type: http://bit.ly/vgW2Ql
+      t.string :context, limit: 128
+
+      t.datetime :created_at
+    end
+
+    add_index :spree_tags, :name, unique: true
+    add_index :spree_taggings,
+              [
+                :tag_id,
+                :taggable_id,
+                :taggable_type,
+                :context,
+                :tagger_id,
+                :tagger_type
+              ],
+              unique: true, name: "spree_taggings_idx"
+  end
+
+  def self.down
+    drop_table :spree_taggings
+    drop_table :spree_tags
+  end
+end

data/spec/dummy/db/migrate/20180516182064_change_collation_for_spree_tag_names.spree.rb

@@ -0,0 +1,10 @@
+# This migration comes from spree (originally 20160511072249)
+# This migration is added to circumvent issue #623 and have special characters
+# work properly
+class ChangeCollationForSpreeTagNames < ActiveRecord::Migration[4.2]
+  def up
+    if ActsAsTaggableOn::Utils.using_mysql?
+      execute("ALTER TABLE spree_tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE utf8_bin;")
+    end
+  end
+end

data/spec/dummy/db/migrate/20180516182065_add_missing_indexes_to_spree_taggings.spree.rb

@@ -0,0 +1,15 @@
+# This migration comes from spree (originally 20160511072335)
+class AddMissingIndexesToSpreeTaggings < ActiveRecord::Migration[4.2]
+  def change
+    add_index :spree_taggings, :tag_id
+    add_index :spree_taggings, :taggable_id
+    add_index :spree_taggings, :taggable_type
+    add_index :spree_taggings, :tagger_id
+    add_index :spree_taggings, :context
+
+    add_index :spree_taggings, [:tagger_id, :tagger_type]
+    add_index :spree_taggings,
+              [:taggable_id, :taggable_type, :tagger_id, :context],
+              name: "spree_taggings_idy"
+  end
+end

data/spec/dummy/db/migrate/20180516182066_add_zipcode_required_to_spree_countries.spree.rb

@@ -0,0 +1,8 @@
+# This migration comes from spree (originally 20160608090604)
+class AddZipcodeRequiredToSpreeCountries < ActiveRecord::Migration[4.2]
+  def change
+    add_column :spree_countries, :zipcode_required, :boolean, default: true
+    Spree::Country.reset_column_information
+    Spree::Country.where(iso: Spree::Address::NO_ZIPCODE_ISO_CODES).update_all(zipcode_required: false)
+  end
+end

data/spec/dummy/db/migrate/20180516182067_add_created_at_to_variant.spree.rb

@@ -0,0 +1,9 @@
+# This migration comes from spree (originally 20161014145148)
+class AddCreatedAtToVariant < ActiveRecord::Migration[5.0]
+  def change
+    add_column :spree_variants, :created_at, :datetime
+    Spree::Variant.reset_column_information
+    Spree::Variant.unscoped.where.not(updated_at: nil).update_all('created_at = updated_at')
+    Spree::Variant.unscoped.where(updated_at: nil).update_all(created_at: Time.current, updated_at: Time.current)
+  end
+end

data/spec/dummy/db/migrate/20180516182068_add_null_false_to_spree_variants_timestamps.spree.rb

@@ -0,0 +1,7 @@
+# This migration comes from spree (originally 20161014152814)
+class AddNullFalseToSpreeVariantsTimestamps < ActiveRecord::Migration[5.0]
+  def change
+    change_column_null :spree_variants, :created_at, false
+    change_column_null :spree_variants, :updated_at, false
+  end
+end

data/spec/dummy/db/migrate/20180516182069_create_spree_purchase_orders.spree_purchase_order.rb

@@ -0,0 +1,11 @@
+# This migration comes from spree_purchase_order (originally 20160111123141)
+class CreateSpreePurchaseOrders < ActiveRecord::Migration
+  def change
+    create_table :spree_purchase_orders do |t|
+      t.string :po_number
+      t.string :organization_name
+
+      t.timestamps
+    end
+  end
+end