spree_pinterest 0.2.0 → 0.2.1

data/CHANGELOG.md

@@ -1,6 +1,10 @@
+# 0.2.1
+
+* Make sure `media` URL param is always an absoute URL
+
 # 0.2.0
 
-* Always use product_url when pinning
+* Always use `product_url` when pinning
 
 # 0.1.1
 

data/Guardfile

@@ -1,7 +1,7 @@
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
-guard 'rspec', :version => 2, :cli => "--format Fuubar --fail-fast" do
+guard 'rspec', :version => 2, :cli => "--format Fuubar" do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }

data/app/helpers/spree/pinterest_helper.rb

@@ -4,7 +4,7 @@ module Spree
       return if product.images.empty?
 
       url = escape spree.product_url(product)
-      media = escape product.images.first.attachment.url
+      media = escape absolute_image_url(product.images.first.attachment.url)
       description = escape product.name
 
       link_to("Pin It",
@@ -18,5 +18,11 @@ module Spree
     def escape(string)
       URI.escape string, /[^#{URI::PATTERN::UNRESERVED}]/
     end
+
+    def absolute_image_url(url)
+      return url if url.starts_with? "http"
+
+      request.protocol + request.host + url
+    end
   end
 end

data/lib/spree_pinterest/version.rb

@@ -1,3 +1,3 @@
 module SpreePinterest
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/helpers/spree/pinterest_helper_spec.rb

@@ -20,14 +20,35 @@ module Spree
         end
 
         describe "href" do
-          let(:expected_output) do
-            image = product.images.first
-            "http://pinterest.com/pin/create/button/?url=#{escape(spree.product_url(product, :host => "test.host"))}&media=#{escape(image.attachment.url)}&description=#{escape(product.name)}"
+          context "when image attachment url is a relative url" do
+            before do
+              product.images.first.stub_chain(:attachment, :url).and_return("/path/to/image.png")
+            end
+
+            let(:expected_output) do
+              image = product.images.first
+              "http://pinterest.com/pin/create/button/?url=#{escape(spree.product_url(product, :host => "test.host"))}&media=#{escape("http://test.host#{image.attachment.url}")}&description=#{escape(product.name)}"
+            end
+
+            subject { Nokogiri::HTML(output).xpath("//a/@href").text }
+
+            it { should == expected_output }
           end
 
-          subject { Nokogiri::HTML(output).xpath("//a/@href").text }
+          context "when image attachment url is an absolute url" do
+            before do
+              product.images.first.stub_chain(:attachment, :url).and_return("http://test.host/path/to/image.png")
+            end
 
-          it { should == expected_output }
+            let(:expected_output) do
+              image = product.images.first
+              "http://pinterest.com/pin/create/button/?url=#{escape(spree.product_url(product, :host => "test.host"))}&media=#{escape("http://test.host#{image.attachment.url}")}&description=#{escape(product.name)}"
+            end
+
+            subject { Nokogiri::HTML(output).xpath("//a/@href").text }
+
+            it { should == expected_output }
+          end
 
           def escape(string)
             URI.escape string, /[^#{URI::PATTERN::UNRESERVED}]/

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_pinterest
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree_core
-  requirement: &70100608233560 !ruby/object:Gem::Requirement
+  requirement: &70114289412260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 1.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70100608233560
+  version_requirements: *70114289412260
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &70100608228740 !ruby/object:Gem::Requirement
+  requirement: &70114289411760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -32,10 +32,10 @@ dependencies:
         version: 1.0.1
   type: :development
   prerelease: false
-  version_requirements: *70100608228740
+  version_requirements: *70114289411760
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &70100608227720 !ruby/object:Gem::Requirement
+  requirement: &70114289411380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70100608227720
+  version_requirements: *70114289411380
 - !ruby/object:Gem::Dependency
   name: ffaker
-  requirement: &70100608227020 !ruby/object:Gem::Requirement
+  requirement: &70114289410780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70100608227020
+  version_requirements: *70114289410780
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &70100608226500 !ruby/object:Gem::Requirement
+  requirement: &70114289409980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '2.7'
   type: :development
   prerelease: false
-  version_requirements: *70100608226500
+  version_requirements: *70114289409980
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70100608225820 !ruby/object:Gem::Requirement
+  requirement: &70114289409240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70100608225820
+  version_requirements: *70114289409240
 description: This extension provides a Pinterest "Pin it" button for your Spree product
   images.
 email: chad@genuitytech.com