spree_paypal_api_checkout 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53c335900fbbe782e6fc7cfa78b36f258b514a9d9b9400cef65f7fb8c7cf69c7
-  data.tar.gz: 946f4fa867ded14d6c7f494df8d8e21377721b682df09fe7cffd312540268540
+  metadata.gz: bd7531190eafee3bb5fe40ac3378269b2e9265e4c66773cf2a447f0c1cef757f
+  data.tar.gz: b62014828506b097f6287cfa41ffde2e4638f29e5be241f9746aa28ea23e4e24
 SHA512:
-  metadata.gz: 0d1754cdff574bb9bbe6b798663c02686228ec3a0e7fe30281b87dea2264245d2f296e849ad44145282305766678b5956834a8a44f0ed17c38e6a644abeb0719
-  data.tar.gz: aef76e65dae6694919ddc17f3c290de2a49be957ac913a9a0ba4863bfe0f1a576d7a10c7e7fcce1a658e087c1b48786514f21c329354094024a124b961986801
+  metadata.gz: beaf4e7e206f97393da179553fe15e6548734fffcb62dce78b3b6bdb6dc79d344b83bc8f332900525e586d0575fc0b367cfb21e99781c995d5ec14f07496546d
+  data.tar.gz: da8a449dd52eeb1d1c864b65db9f1bc84e5be991316d7578f90657f1a3eaba7bb384ca9fd21a48165fc997b18b8a09c8fad748e6be4b2b864069d078e3240c2d

data/README.md

@@ -4,7 +4,7 @@
 
 1. Add this extension to your Gemfile with this line:
         
-        gem 'spree_paypal_api_checkout', '~> 0.1.0'
+        gem 'spree_paypal_api_checkout', '~> 0.1.1'
 
 2. Install the gem using Bundler:
 

data/app/controllers/spree/paypal_checkout_controller.rb

@@ -1,6 +1,7 @@
 module Spree
   class PaypalCheckoutController < StoreController
     skip_before_action :verify_authenticity_token
+
     def express
       order = current_order || raise(ActiveRecord::RecordNotFound)
       items = order.line_items.map(&method(:line_item))
@@ -27,22 +28,17 @@ module Spree
         }
       end
 
-      pp_response = provider.create_order(order, express_checkout_request_details(order: order, items: items, tax_adjustments: tax_adjustments, promotion_adjustments: promotion_adjustments))
+      details = express_checkout_request_details(order: order, items: items, tax_adjustments: tax_adjustments, promotion_adjustments: promotion_adjustments)
+      pp_response = provider.parse_response(provider.create_order(order, details))
 
       render json: pp_response
     end
 
     def confirm
       order = current_order || raise(ActiveRecord::RecordNotFound)
-      response = provider.capture_payment(params[:number])
-      order.payments.create!({
-        source: Spree::PaypalApiCheckout.create({
-          token: response['id'],
-          payer_id: response['payer']['payer_id']
-        }),
-        amount: order.total,
-        payment_method: payment_method
-      })
+
+      response = provider.set_payment_records(order, params[:number], payment_method)
+
       render json: response
     end
 

data/app/models/spree/gateway/pay_pal_checkout.rb

@@ -21,38 +21,24 @@ module Spree
     end
 
     def generate_access_token
-      uri = URI.parse("https://#{preferred_server}/v1/oauth2/token")
-      request = Net::HTTP::Post.new(uri)
-      request.basic_auth("#{preferred_api_key}", "#{preferred_secret_key}")
-      request.content_type = 'application/json'
-      request.body = 'grant_type=client_credentials'
-
-      req_options = { use_ssl: uri.scheme == 'https' }
-
-      response = Net::HTTP.start(uri.hostname, uri.port, req_options) do |http|
-        response = http.request(request)
-      end
-      return JSON.parse(response.read_body)['access_token']
+      response = post_response_without_token(api_url('v1/oauth2/token'))
+      return response['access_token']
     end
 
     def generate_client_token
-      uri = URI.parse("https://#{preferred_server}/v1/identity/generate-token")
-      return post_response(uri)
+      post_response(api_url('v1/identity/generate-token'))
     end
 
     def create_order order, body
-      uri = URI.parse("https://#{preferred_server}/v2/checkout/orders")
-      return post_response(uri, body)
+      post_response(api_url('v2/checkout/orders'), body)
     end
 
     def capture_payment order_id
-      uri = URI.parse("https://#{preferred_server}/v2/checkout/orders/#{order_id}/capture")
-      return post_response(uri)
+      post_response(api_url("v2/checkout/orders/#{order_id}/capture"))
     end
 
     def refund_payment id, body
-      uri = URI.parse("https://#{preferred_server}/v2/payments/captures/#{id}/refund")
-      return post_response(uri, body)
+      post_response(api_url("v2/payments/captures/#{id}/refund"), body)
     end
 
     def purchase(amount, express_checkout, gateway_options={})
@@ -78,8 +64,10 @@ module Spree
         refund_type: refund_type,
         refund_source: 'any'
       }
-      refund_transaction_response = refund_payment(payment.source.transaction_id, refund_transaction)
-      if refund_transaction_response['status']=='COMPLETED'
+      refund_entry = refund_payment(payment.source.transaction_id, refund_transaction)
+      refund_transaction_response = parse_response(refund_entry)
+
+      if success_response?(refund_transaction_response)
         payment.source.update({
           :refunded_at => Time.now,
           :refund_transaction_id => refund_transaction_response['id'],
@@ -87,7 +75,7 @@ module Spree
           :refund_type => refund_type
         })
 
-        payment.class.create!(
+        refund_payment = payment.class.create!(
           :order => payment.order,
           :source => payment,
           :payment_method => payment.payment_method,
@@ -95,6 +83,7 @@ module Spree
           :response_code => refund_transaction_response['id'],
           :state => 'completed'
         )
+        refund_payment.log_entries.create!(details: refund_entry.to_yaml)
       end
       refund_transaction_response
     end
@@ -102,14 +91,84 @@ module Spree
     def post_response uri, body={}
       request = Net::HTTP::Post.new(uri)
       request['Authorization'] = "Bearer #{generate_access_token}"
+      request.body = body.to_json if body.present?
+
+      return hit_api(request: request, body: body, uri: uri)
+    end
+
+    def post_response_without_token uri, body={}
+      request = Net::HTTP::Post.new(uri)
+      request.basic_auth("#{preferred_api_key}", "#{preferred_secret_key}")
+      request.body = 'grant_type=client_credentials'
+
+      return parse_response(hit_api(request: request, body: body, uri: uri))
+    end
+
+    def hit_api request:, body:, uri:
       request.content_type = 'application/json'
       req_options = { use_ssl: uri.scheme == 'https' }
 
-      request.body = body.to_json if body.present?
       response = Net::HTTP.start(uri.hostname, uri.port, req_options) do |http|
         response = http.request(request)
       end
-      return JSON.parse(response.read_body)
+      response
+    end
+
+    def parse_response response
+      JSON.parse(response.read_body) rescue response
+    end
+
+    def api_url url
+      URI.parse("https://#{preferred_server}/#{url}")
+    end
+
+    def set_payment_records order, number, payment_method
+      raw_response = response = nil
+      success = false
+      begin
+        payment_entry = capture_payment(number)
+        response = parse_response(payment_entry)
+        success = success_response?(response)
+
+        payment = order.payments.create!({
+          source: Spree::PaypalApiCheckout.create({
+            token: response['id'],
+            payer_id: response['payer']['payer_id']
+          }),
+          amount: order.total,
+          payment_method: payment_method
+        })
+      rescue Exception => e
+        raw_response = e.response.body
+        response = response_error(raw_response)
+      rescue JSON::ParserError
+        response = json_error(raw_response)
+      end
+
+      payment.log_entries.create!(details: payment_entry.to_yaml)
+      response
+    end
+
+    def response_error(raw_response)
+      begin
+        parse(raw_response)
+      rescue JSON::ParserError
+        json_error(raw_response)
+      end
+    end
+
+    def json_error(raw_response)
+      msg = 'Invalid response. Please contact team if you continue to receive this message.'
+      msg += "  (The raw response returned by the API was #{raw_response.inspect})"
+      {
+        "error" => {
+          "message" => msg
+        }
+      }
+    end
+
+    def success_response? response
+      response.key?('status') && response.key?('id') && (response['status'] == 'COMPLETED')
     end
   end
 end

data/app/views/spree/checkout/payment/_paypal_checkout.html.erb

@@ -1,5 +1,5 @@
 <div id="paypal-button-container" class="paypal-button-container"></div>
-<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
+<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
 <script type="text/javascript" src="https://www.paypal.com/sdk/js?client-id=<%= payment_method.preferred_api_key %>&currency=<%= @order.currency %>"></script>
 
 <script type="text/javascript">

data/config/locales/de.yml

@@ -15,6 +15,7 @@ de:
       refund_unsuccessful: "PayPal Erstattung nicht erfolgreich"
       actions:
         refund: "Erstatten"
+      status: 'Toestand'
       flash:
         cancel: "Sie wollen PayPal doch nicht benutzen? Kein Problem."
         connection_failed: "Verbindung zu Paypal nicht erfolgreich."

data/config/locales/en.yml

@@ -15,6 +15,7 @@ en:
       refund_unsuccessful: "PayPal refund unsuccessful"
       actions:
         refund: "Refund"
+      status: Status
       flash:
         cancel: "Don't want to use PayPal? No problems."
         connection_failed: "Could not connect to PayPal."

data/config/locales/es.yml

@@ -15,6 +15,7 @@ es:
       refund_unsuccessful: "No se pudo rembolsar el pago de PayPal"
       actions:
         refund: "Reembolso"
+      status: Estado
       flash:
         cancel: "No quieres usar PayPal? No hay problema."
         connection_failed: "No se pudo conectar con PayPal."

data/config/locales/it.yml

@@ -15,6 +15,7 @@ it:
       refund_unsuccessful: "Rimborso PayPal non completato"
       actions:
         refund: "Rimborso"
+      status: Stato
       flash:
         cancel: "Non vuoi usare PayPal? Nessun problema."
         connection_failed: "Impossibile connettersi a PayPal."

data/config/locales/pl.yml

@@ -15,6 +15,7 @@ pl:
       refund_unsuccessful: "Błąd podczas wykonywania zwrotu PayPal"
       actions:
         refund: "Zwróć Płatność"
+      status: Status
       flash:
         cancel: "Nie chcesz użyć PayPal? Nie ma problemu."
         connection_failed: "Nie można było połączyć się z usługą PayPal."

data/config/locales/pt.yml

@@ -15,6 +15,7 @@ pt:
       refund_unsuccessful: "Não foi possível reembolsar o pagamento de PayPal"
       actions:
         refund: "Reembolso"
+      status: Status
       flash:
         cancel: "Não pretende usar PayPal? Não há problema."
         connection_failed: "Não foi possível estabelecer ligação com o PayPal."

data/lib/spree_paypal_api_checkout/version.rb

@@ -1,3 +1,3 @@
 module SpreePaypalApiCheckout
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spree_paypal_api_checkout.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "spree_paypal_api_checkout".freeze
-  s.version = "0.1.0"
+  s.version = "0.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_paypal_api_checkout
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Spree Commerce