spree_order_reporting 0.0.2 → 0.0.3

data/spec/dummy/db/migrate/{20160707103485_create_spree_stores.spree.rb → 20160708163161_create_spree_stores.spree.rb}

@@ -19,7 +19,7 @@ class CreateSpreeStores < ActiveRecord::Migration
         t.string :code
         t.boolean :default, default: false, null: false
 
-        t.timestamps null: true
+        t.timestamps
       end
     end
   end

data/spec/dummy/db/migrate/{20160707103486_create_store_from_preferences.spree.rb → 20160708163162_create_store_from_preferences.spree.rb}

@@ -1,26 +1,30 @@
 # This migration comes from spree (originally 20140309033438)
 class CreateStoreFromPreferences < ActiveRecord::Migration
-  class Store < ActiveRecord::Base
-    self.table_name = 'spree_stores'
-  end
   def change
+    # workaround for spree_i18n and Store translations
+    Spree::Store.class_eval do
+      def self.translated?(name)
+        false
+      end
+    end
+    
     preference_store = Spree::Preferences::Store.instance
-    if store = Store.where(default: true).first
+    if store = Spree::Store.where(default: true).first
       store.meta_description = preference_store.get('spree/app_configuration/default_meta_description') {}
       store.meta_keywords    = preference_store.get('spree/app_configuration/default_meta_keywords') {}
       store.seo_title        = preference_store.get('spree/app_configuration/default_seo_title') {}
       store.save!
     else
       # we set defaults for the things we now require
-      Store.new do |s|
+      Spree::Store.new do |s|
         s.name              = preference_store.get 'spree/app_configuration/site_name' do
-          'Sample Store'
+          'Spree Demo Site'
         end
         s.url               = preference_store.get 'spree/app_configuration/site_url' do
-          'example.com'
+          'demo.spreecommerce.com'
         end
         s.mail_from_address = preference_store.get 'spree/app_configuration/mails_from' do
-          'store@example.com'
+          'spree@example.com'
         end
 
         s.meta_description = preference_store.get('spree/app_configuration/default_meta_description') {}

data/spec/dummy/db/migrate/20160708163166_add_many_missing_indexes.spree.rb

@@ -0,0 +1,19 @@
+# This migration comes from spree (originally 20140410141842)
+class AddManyMissingIndexes < ActiveRecord::Migration
+  def change
+    add_index :spree_adjustments, [:adjustable_id, :adjustable_type]
+    add_index :spree_adjustments, :eligible
+    add_index :spree_adjustments, :order_id
+    add_index :spree_promotions, :code
+    add_index :spree_promotions, :expires_at
+    add_index :spree_states, :country_id
+    add_index :spree_stock_items, :deleted_at
+    add_index :spree_option_types, :position
+    add_index :spree_option_values, :position
+    add_index :spree_product_option_types, :option_type_id
+    add_index :spree_product_option_types, :product_id
+    add_index :spree_products_taxons, :position
+    add_index :spree_promotions, :starts_at
+    add_index :spree_stores, :url
+  end
+end

data/spec/dummy/db/migrate/20160708163167_correct_some_polymorphic_index_and_add_more_missing.spree.rb

@@ -0,0 +1,67 @@
+# This migration comes from spree (originally 20140410150358)
+class CorrectSomePolymorphicIndexAndAddMoreMissing < ActiveRecord::Migration
+  def change
+    add_index :spree_addresses, :country_id
+    add_index :spree_addresses, :state_id
+    remove_index :spree_adjustments, [:source_type, :source_id]
+    add_index :spree_adjustments, [:source_id, :source_type]
+    add_index :spree_credit_cards, :address_id
+    add_index :spree_gateways, :active
+    add_index :spree_gateways, :test_mode
+    add_index :spree_inventory_units, :return_authorization_id
+    add_index :spree_line_items, :tax_category_id
+    add_index :spree_log_entries, [:source_id, :source_type]
+    add_index :spree_orders, :approver_id
+    add_index :spree_orders, :bill_address_id
+    add_index :spree_orders, :confirmation_delivered
+    add_index :spree_orders, :considered_risky
+    add_index :spree_orders, :created_by_id
+    add_index :spree_orders, :ship_address_id
+    add_index :spree_orders, :shipping_method_id
+    add_index :spree_orders_promotions, [:order_id, :promotion_id]
+    add_index :spree_payments, [:source_id, :source_type]
+    add_index :spree_prices, :deleted_at
+    add_index :spree_product_option_types, :position
+    add_index :spree_product_properties, :position
+    add_index :spree_product_properties, :property_id
+    add_index :spree_products, :shipping_category_id
+    add_index :spree_products, :tax_category_id
+    add_index :spree_promotion_action_line_items, :promotion_action_id
+    add_index :spree_promotion_action_line_items, :variant_id
+    add_index :spree_promotion_rules, :promotion_id
+    add_index :spree_promotions, :advertise
+    add_index :spree_return_authorizations, :number
+    add_index :spree_return_authorizations, :order_id
+    add_index :spree_return_authorizations, :stock_location_id
+    add_index :spree_shipments, :address_id
+    add_index :spree_shipping_methods, :deleted_at
+    add_index :spree_shipping_methods, :tax_category_id
+    add_index :spree_shipping_rates, :selected
+    add_index :spree_shipping_rates, :tax_rate_id
+    add_index :spree_state_changes, [:stateful_id, :stateful_type]
+    add_index :spree_state_changes, :user_id
+    add_index :spree_stock_items, :backorderable
+    add_index :spree_stock_locations, :active
+    add_index :spree_stock_locations, :backorderable_default
+    add_index :spree_stock_locations, :country_id
+    add_index :spree_stock_locations, :propagate_all_variants
+    add_index :spree_stock_locations, :state_id
+    add_index :spree_tax_categories, :deleted_at
+    add_index :spree_tax_categories, :is_default
+    add_index :spree_tax_rates, :deleted_at
+    add_index :spree_tax_rates, :included_in_price
+    add_index :spree_tax_rates, :show_rate_in_label
+    add_index :spree_tax_rates, :tax_category_id
+    add_index :spree_tax_rates, :zone_id
+    add_index :spree_taxonomies, :position
+    add_index :spree_taxons, :position
+    add_index :spree_trackers, :active
+    add_index :spree_variants, :deleted_at
+    add_index :spree_variants, :is_master
+    add_index :spree_variants, :position
+    add_index :spree_variants, :track_inventory
+    add_index :spree_zone_members, :zone_id
+    add_index :spree_zone_members, [:zoneable_id, :zoneable_type]
+    add_index :spree_zones, :default_tax
+  end
+end

data/spec/dummy/db/migrate/{20160707103500_create_spree_refunds.spree.rb → 20160708163176_create_spree_refunds.spree.rb}

@@ -7,7 +7,7 @@ class CreateSpreeRefunds < ActiveRecord::Migration
       t.decimal :amount, precision: 10, scale: 2, default: 0.0, null: false
       t.string :transaction_id
 
-      t.timestamps null: true
+      t.timestamps
     end
   end
 end

data/spec/dummy/db/migrate/{20160707103501_create_spree_return_authorization_inventory_unit.spree.rb → 20160708163177_create_spree_return_authorization_inventory_unit.spree.rb}

@@ -7,7 +7,7 @@ class CreateSpreeReturnAuthorizationInventoryUnit < ActiveRecord::Migration
       t.integer :exchange_variant_id
       t.datetime :received_at
 
-      t.timestamps null: true
+      t.timestamps
     end
   end
 end

data/spec/dummy/db/migrate/20160708163183_create_spree_return_authorization_reasons.spree.rb

@@ -0,0 +1,29 @@
+# This migration comes from spree (originally 20140713140455)
+class CreateSpreeReturnAuthorizationReasons < ActiveRecord::Migration
+  def change
+    create_table :spree_return_authorization_reasons do |t|
+      t.string :name
+      t.boolean :active, default: true
+      t.boolean :mutable, default: true
+
+      t.timestamps
+    end
+
+    reversible do |direction|
+      direction.up do
+        Spree::ReturnAuthorizationReason.create!(name: 'Better price available')
+        Spree::ReturnAuthorizationReason.create!(name: 'Missed estimated delivery date')
+        Spree::ReturnAuthorizationReason.create!(name: 'Missing parts or accessories')
+        Spree::ReturnAuthorizationReason.create!(name: 'Damaged/Defective')
+        Spree::ReturnAuthorizationReason.create!(name: 'Different from what was ordered')
+        Spree::ReturnAuthorizationReason.create!(name: 'Different from description')
+        Spree::ReturnAuthorizationReason.create!(name: 'No longer needed/wanted')
+        Spree::ReturnAuthorizationReason.create!(name: 'Accidental order')
+        Spree::ReturnAuthorizationReason.create!(name: 'Unauthorized purchase')
+      end
+    end
+
+    add_column :spree_return_authorizations, :return_authorization_reason_id, :integer
+    add_index :spree_return_authorizations, :return_authorization_reason_id, name: 'index_return_authorizations_on_return_authorization_reason_id'
+  end
+end

data/spec/dummy/db/migrate/{20160707103509_create_spree_refund_reasons.spree.rb → 20160708163184_create_spree_refund_reasons.spree.rb}

@@ -6,7 +6,7 @@ class CreateSpreeRefundReasons < ActiveRecord::Migration
       t.boolean :active, default: true
       t.boolean :mutable, default: true
 
-      t.timestamps null: true
+      t.timestamps
     end
 
     add_column :spree_refunds, :refund_reason_id, :integer

data/spec/dummy/db/migrate/{20160707103511_create_spree_promotion_categories.spree.rb → 20160708163186_create_spree_promotion_categories.spree.rb}

@@ -3,7 +3,7 @@ class CreateSpreePromotionCategories < ActiveRecord::Migration
   def change
     create_table :spree_promotion_categories do |t|
       t.string :name
-      t.timestamps null: true
+      t.timestamps
     end
 
     add_column :spree_promotions, :promotion_category_id, :integer

data/spec/dummy/db/migrate/{20160707103516_create_spree_customer_returns.spree.rb → 20160708163191_create_spree_customer_returns.spree.rb}

@@ -4,7 +4,7 @@ class CreateSpreeCustomerReturns < ActiveRecord::Migration
     create_table :spree_customer_returns do |t|
       t.string :number
       t.integer :stock_location_id
-      t.timestamps null: true
+      t.timestamps
     end
   end
 end

data/spec/dummy/db/migrate/{20160707103522_create_spree_reimbursements.spree.rb → 20160708163197_create_spree_reimbursements.spree.rb}

@@ -8,7 +8,7 @@ class CreateSpreeReimbursements < ActiveRecord::Migration
       t.integer :order_id
       t.decimal :total, precision: 10, scale: 2
 
-      t.timestamps null: true
+      t.timestamps
     end
 
     add_index :spree_reimbursements, :customer_return_id

data/spec/dummy/db/migrate/{20160707103526_create_spree_reimbursement_types.spree.rb → 20160708163201_create_spree_reimbursement_types.spree.rb}

@@ -6,7 +6,7 @@ class CreateSpreeReimbursementTypes < ActiveRecord::Migration
       t.boolean :active, default: true
       t.boolean :mutable, default: true
 
-      t.timestamps null: true
+      t.timestamps
     end
 
     reversible do |direction|

data/spec/dummy/db/migrate/20160708163212_add_store_id_to_orders.spree.rb

@@ -0,0 +1,9 @@
+# This migration comes from spree (originally 20141009204607)
+class AddStoreIdToOrders < ActiveRecord::Migration
+  def change
+    add_column :spree_orders, :store_id, :integer
+    if Spree::Store.default.persisted?
+      Spree::Order.where(store_id: nil).update_all(store_id: Spree::Store.default.id)
+    end
+  end
+end

data/spec/dummy/db/migrate/20160708163214_add_state_lock_version_to_order.spree.rb

@@ -0,0 +1,6 @@
+# This migration comes from spree (originally 20141021194502)
+class AddStateLockVersionToOrder < ActiveRecord::Migration
+  def change
+    add_column :spree_orders, :state_lock_version, :integer, default: 0, null: false
+  end
+end

data/spec/dummy/db/migrate/20160708163215_add_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

@@ -0,0 +1,14 @@
+# This migration comes from spree (originally 20141023005240)
+class AddCounterCacheFromSpreeVariantsToSpreeStockItems < ActiveRecord::Migration
+  def up
+    add_column :spree_variants, :stock_items_count, :integer, default: 0, null: false
+
+    Spree::Variant.find_each do |variant|
+      Spree::Variant.reset_counters(variant.id, :stock_items)
+    end
+  end
+
+  def down
+    remove_column :spree_variants, :stock_items_count
+  end
+end

data/spec/dummy/db/migrate/{20160707103540_fix_adjustment_order_presence.spree.rb → 20160708163216_fix_adjustment_order_presence.spree.rb}

@@ -7,7 +7,7 @@ class FixAdjustmentOrderPresence < ActiveRecord::Migration
       if adjustable.is_a? Spree::Order
         adjustment.update_attributes!(order_id: adjustable.id)
       else
-        adjustment.update_attributes!(order_id: adjustable.order.id)
+        adjustment.update_attributes!(adjustable: adjustable.order)
       end
     end
   end

data/spec/dummy/db/migrate/20160708163219_fix_adjustment_order_id.spree.rb

@@ -0,0 +1,71 @@
+# This migration comes from spree (originally 20150515211137)
+class FixAdjustmentOrderId < ActiveRecord::Migration
+  def change
+    say 'Populate order_id from adjustable_id where appropriate'
+    execute(<<-SQL.squish)
+      UPDATE
+        spree_adjustments
+      SET
+        order_id = adjustable_id
+      WHERE
+        adjustable_type = 'Spree::Order'
+      ;
+    SQL
+
+    # Submitter of change does not care about MySQL, as it is not officially supported.
+    # Still spree officials decided to provide a working code path for MySQL users, hence
+    # submitter made a AR code path he could validate on PostgreSQL.
+    #
+    # Whoever runs a big enough MySQL installation where the AR solution hurts:
+    # Will have to write a better MySQL specific equivalent.
+    if Spree::Order.connection.adapter_name.eql?('MySQL')
+      Spree::Adjustment.where(adjustable_type: 'Spree::LineItem').find_each do |adjustment|
+        adjustment.update_columns(order_id: Spree::LineItem.find(adjustment.adjustable_id).order_id)
+      end
+    else
+      execute(<<-SQL.squish)
+        UPDATE
+          spree_adjustments
+        SET
+          order_id =
+            (SELECT order_id FROM spree_line_items WHERE spree_line_items.id = spree_adjustments.adjustable_id)
+        WHERE
+          adjustable_type = 'Spree::LineItem'
+      SQL
+    end
+
+    say 'Fix schema for spree_adjustments order_id column'
+    change_table :spree_adjustments do |t|
+      t.change :order_id, :integer, null: false
+    end
+
+    # Improved schema for postgresql, uncomment if you like it:
+    #
+    # # Negated Logical implication.
+    # #
+    # # When adjustable_type is 'Spree::Order' (p) the adjustable_id must be order_id (q).
+    # #
+    # # When adjustable_type is NOT 'Spree::Order' the adjustable id allowed to be any value (including of order_id in
+    # # case foreign keys match). XOR does not work here.
+    # #
+    # # Postgresql does not have an operator for logical implication. So we need to build the following truth table
+    # # via AND with OR:
+    # #
+    # #  p q | CHECK = !(p -> q)
+    # #  -----------
+    # #  t t | t
+    # #  t f | f
+    # #  f t | t
+    # #  f f | t
+    # #
+    # # According to de-morgans law the logical implication q -> p is equivalent to !p || q
+    # #
+    # execute(<<-SQL.squish)
+    #   ALTER TABLE ONLY spree_adjustments
+    #    ADD CONSTRAINT fk_spree_adjustments FOREIGN KEY (order_id)
+    #      REFERENCES spree_orders(id) ON UPDATE RESTRICT ON DELETE RESTRICT,
+    #    ADD CONSTRAINT check_spree_adjustments_order_id CHECK
+    #      (adjustable_type <> 'Spree::Order' OR order_id = adjustable_id);
+    # SQL
+  end
+end