spree_multi_vendor 2.0.1 → 2.3.0

data/spec/features/spree/admin/orders_spec.rb

@@ -1,25 +1,75 @@
 require 'spec_helper'
 
 RSpec.feature 'Admin Orders', :js do
+  let(:store) { Spree::Store.default }
   let(:vendor) { create(:active_vendor, name: 'Vendor') }
   let(:vendor_2) { create(:active_vendor, name: 'Other vendor') }
-  let(:order) do
-    create(:order,
-           line_items: [
-             create(:line_item, product: product),
-             create(:line_item, product: product_2)
-           ])
-  end
+  let(:order) { create(:order, ship_address: create(:address), bill_address: create(:address), store: store) }
+  let(:order_2) { create(:order, store: store) }
   let!(:user) { create(:user, vendors: [vendor]) }
-  let(:product) { create(:product_in_stock, vendor: vendor) }
-  let(:product_2) { create(:product_in_stock, vendor: vendor_2) }
+  let(:product) { create(:product_in_stock, vendor: vendor, stores:[store]) }
+  let(:product_2) { create(:product_in_stock, vendor: vendor_2,stores:[store]) }
+
+  before do
+    create(:line_item, order: order, product: product)
+    create(:line_item, order: order, product: product_2)
+    order.create_proposed_shipments
+    order.update(state: :complete, completed_at: Time.current)
+    login_as(user, scope: :spree_user)
+  end
+
+  shared_examples 'shows order data' do
+    it { expect(page).to have_text(order.number) }
+    it { expect(page).to have_content(order.display_vendor_total(vendor).to_html) }
+  end
+
+  context 'index' do
+    background do
+      visit spree.admin_orders_path
+    end
+
+    it_behaves_like 'shows order data'
+
+    it 'does not show non-vendor orders' do
+      expect(page).not_to have_text(order_2.number)
+    end
+  end
+
+  context 'cart' do
+    background do
+      visit spree.cart_admin_order_path(id: order.number)
+    end
+
+    it_behaves_like 'shows order data'
+  end
+
+  context 'customer info' do
+    background do
+      visit spree.admin_order_customer_path(order_id: order.number)
+    end
+
+    it_behaves_like 'shows order data'
+
+    it 'shows customer information' do
+      expect(page).to have_text(order.ship_address.full_name)
+      expect(page).to have_text(order.ship_address.address1)
+      expect(page).to have_text(order.ship_address.city)
+
+      expect(page).to have_text(order.bill_address.full_name)
+      expect(page).to have_text(order.bill_address.address1)
+      expect(page).to have_text(order.bill_address.city)
+
+      expect(page).not_to have_selector('input[type=text]')
+    end
+  end
 
   context 'edit' do
     background do
-      login_as(user, scope: :spree_user)
       visit spree.edit_admin_order_path(id: order.number)
     end
 
+    it_behaves_like 'shows order data'
+
     scenario 'vendor can add his product' do
       select2_open label: 'Name or SKU'
       select2_search product.name, from: 'Name or SKU'
@@ -29,8 +79,8 @@ RSpec.feature 'Admin Orders', :js do
 
     scenario 'vendor cannot add other vendors product' do
       select2_open label: 'Name or SKU'
-      select2_search product.name, from: 'Name or SKU'
-      expect(page).not_to have_text(product.name)
+      select2_search product_2.name, from: 'Name or SKU'
+      expect(page).not_to have_text(product_2.name)
     end
   end
 end

data/spec/features/spree/admin/vendor_settings_spec.rb

@@ -42,13 +42,11 @@ RSpec.feature 'Admin Vendor Settings', :js do
       expect(page).not_to have_text 'contact_us can\'t be blank'
     end
 
-    if Spree.version.to_f >= 3.6
-      scenario 'can update an existing vendor image' do
-        create(:vendor, name: 'New vendor')
-        page.attach_file("vendor_image", Spree::Core::Engine.root + 'spec/fixtures' + 'thinking-cat.jpg')
-        click_button 'Update'
-        expect(page).to have_css("img[src*='thinking-cat.jpg']")
-      end
+    scenario 'can update an existing vendor image' do
+      create(:vendor, name: 'New vendor')
+      page.attach_file("vendor_image", Spree::Core::Engine.root + 'spec/fixtures' + 'thinking-cat.jpg')
+      click_button 'Update'
+      expect(page).to have_css("img[src*='thinking-cat.jpg']")
     end
   end
 
@@ -70,7 +68,7 @@ RSpec.feature 'Admin Vendor Settings', :js do
 
     it 'renders forbidden page' do
       visit spree.admin_vendor_settings_path
-      expect(current_path).to eq spree.forbidden_path
+      expect(current_path).to eq spree.admin_forbidden_path
     end
   end
 end

data/spec/models/spree/order_spec.rb

@@ -34,6 +34,20 @@ describe Spree::Order do
         expect(v.commissions.sum(:amount)).to eq(commission_ammount)
       end
     end
+
+    it 'sends mails only once per vendor' do
+      mail_double_1 = double(:mail_double_1)
+      mail_double_2 = double(:mail_double_1)
+
+      expect(Spree::VendorMailer).to receive(:vendor_notification_email)
+        .with(be_an(Integer), vendor.id) { mail_double_1 }
+      expect(mail_double_1).to receive(:deliver_later)
+      expect(Spree::VendorMailer).to receive(:vendor_notification_email)
+        .with(be_an(Integer), vendor_2.id) { mail_double_2 }
+      expect(mail_double_2).to receive(:deliver_later)
+
+      order.next!
+    end
   end
 
   context 'vendor methods' do
@@ -57,11 +71,11 @@ describe Spree::Order do
     end
 
     describe '#vendor_subtotal' do
-      it { expect(order.vendor_subtotal(vendor)).to eq(270) }
+      it { expect(order.vendor_subtotal(vendor)).to eq(320) }
     end
 
     describe '#display_subtotal' do
-      it { expect(order.display_vendor_subtotal(vendor).to_s).to eq('$270.00') }
+      it { expect(order.display_vendor_subtotal(vendor).to_s).to eq('$320.00') }
     end
 
     describe '#vendor_pre_tax_item_amount' do

data/spec/requests/spree/api/v1/products_spec.rb

@@ -0,0 +1,221 @@
+require 'spec_helper'
+
+module Spree
+  describe 'API V1 Products Spec', type: :request do
+    let(:vendor) { create(:vendor, state: :active) }
+    let(:other_vendor) { create(:vendor) }
+    let(:shipping_category) { create(:shipping_category) }
+    let(:selected_product) { product_without_vendor }
+    let(:params) { {} }
+
+    let!(:product_without_vendor) { create(:product) }
+    let!(:product_with_vendor_vendor) { create(:product, vendor: vendor) }
+    let!(:product_with_other_vendor) { create(:product, vendor: other_vendor) }
+
+    before { stub_authentication! }
+
+    describe 'products#index' do
+      before { get '/api/v1/products', params: params }
+
+      context 'as a regular user' do
+        it 'gets a list of all products' do
+          expect(response.status).to eq(200)
+          expect(json_response[:products].size).to eq(3)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'gets a list of all products' do
+          expect(response.status).to eq(200)
+          expect(json_response[:products].size).to eq(3)
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        it 'gets a list of products assigned to that vendor' do
+          expect(response.status).to eq(200)
+          expect(json_response[:products].size).to eq(1)
+          expect(json_response[:products][0][:id]).to eq(vendor.products.first.id)
+        end
+      end
+    end
+
+    describe 'products#show' do
+      before { get "/api/v1/products/#{selected_product.id}" }
+
+      it 'gets a product' do
+        expect(response.status).to eq(200)
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        describe 'cannot view product of another vendor' do
+          let(:selected_product) { product_with_other_vendor }
+
+          it do
+            expect(response.status).to eq(404)
+          end
+        end
+
+        describe 'can view product assigned to that vendor' do
+          let(:selected_product) { product_with_vendor_vendor }
+
+          it do
+            expect(response.status).to eq(200)
+          end
+        end
+      end
+    end
+
+    describe 'products#create' do
+      let(:params) do
+        {
+          product: {
+            name: 'Product',
+            shipping_category_id: shipping_category.id,
+            price: 12.34
+          }
+        }
+      end
+
+      before { post '/api/v1/products', params: params }
+
+      context 'as regular user' do
+        it 'cannot create a new product' do
+          expect(response.status).to eq(401)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'can create a new product' do
+          expect(response.status).to eq(201)
+          expect(json_response['name']).to eq(params[:product][:name])
+          expect(json_response['price']).to eq(params[:product][:price].to_s)
+          expect(json_response['shipping_category_id']).to eq(params[:product][:shipping_category_id])
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        it 'can create a new product assigned to vendor' do
+          expect(response.status).to eq(201)
+          product = Spree::Product.find(json_response[:id])
+          expect(product.vendor).to eq(vendor)
+        end
+      end
+    end
+
+    describe 'products#update' do
+      let(:params) do
+        {
+          product: {
+            name: 'Updated Prodouct',
+            shipping_category_id: shipping_category.id,
+            price: 12.34
+          }
+        }
+      end
+
+      before { put "/api/v1/products/#{selected_product.id}", params: params }
+
+      context 'as regular user' do
+        it 'cannot update product' do
+          expect(response.status).to eq(401)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'can update product' do
+          expect(response.status).to eq(200)
+          expect(json_response['name']).to eq(params[:product][:name])
+          expect(json_response['price']).to eq(params[:product][:price].to_s)
+          expect(json_response['shipping_category_id']).to eq(params[:product][:shipping_category_id])
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        describe 'cannot update product of another vendor' do
+          let(:selected_product) { product_with_other_vendor }
+
+          it do
+            expect(response.status).to eq(404)
+          end
+        end
+
+        describe 'can update product assigned to that vendor' do
+          let(:selected_product) { product_with_vendor_vendor }
+
+          it do
+            expect(response.status).to eq(200)
+          end
+        end
+      end
+    end
+
+    describe 'products#destroy' do
+      before { delete "/api/v1/products/#{selected_product.id}" }
+
+      context 'as regular user' do
+        it 'cannot delete product' do
+          expect(response.status).to eq(401)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'can delete product' do
+          expect(response.status).to eq(204)
+          expect(product_without_vendor.reload.deleted_at).to_not eq(nil)
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        describe 'cannot delete product of another vendor' do
+          let(:selected_product) { product_with_other_vendor }
+
+          it do
+            expect(response.status).to eq(404)
+          end
+        end
+
+        describe 'can delete product assigned to that vendor' do
+          let(:selected_product) { product_with_vendor_vendor }
+
+          it do
+            expect(response.status).to eq(204)
+          end
+        end
+      end
+    end
+  end
+end

data/spec/requests/spree/api/v1/users_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+module Spree
+  describe 'API V1 Users Spec', type: :request do
+    let(:user) { create(:user) }
+    let(:vendor) { create(:vendor, state: :active) }
+
+    before { stub_authentication! }
+
+    describe 'users#update' do
+      let(:params) do
+        {
+          user: {
+            vendor_ids: [vendor.id]
+          }
+        }
+      end
+
+      before { put "/api/v1/users/#{user.id}", params: params }
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'can update user' do
+          expect(response.status).to eq(200)
+          expect(json_response['vendor_ids']).to eq([vendor.id])
+        end
+      end
+    end
+  end
+end

data/spec/requests/spree/api/v1/vendors_spec.rb

@@ -0,0 +1,210 @@
+require 'spec_helper'
+
+module Spree
+  describe 'API V1 Vendors Spec', type: :request do
+    let(:params) { {} }
+    let(:selected_vendor) { vendor }
+
+    let!(:vendor) { create(:vendor, state: :active) }
+    let!(:another_vendor) { create(:vendor, state: :active) }
+
+    before { stub_authentication! }
+
+    describe 'vendors#index' do
+      before { get '/api/v1/vendors', params: params }
+
+      context 'as a regular user' do
+        it 'gets an empty list' do
+          expect(response.status).to eq(200)
+          expect(json_response.size).to eq(0)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'gets a list of all vendors' do
+          expect(response.status).to eq(200)
+          expect(json_response.size).to eq(2)
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        it 'gets a list of assigned vendors' do
+          expect(response.status).to eq(200)
+          expect(json_response.size).to eq(1)
+          expect(json_response[0]['id']).to eq(vendor.id)
+        end
+      end
+    end
+
+    describe 'vendors#show' do
+      before { get "/api/v1/vendors/#{selected_vendor.id}" }
+
+      context 'as a regular user' do
+        it 'cannot view a vendor' do
+          expect(response.status).to eq(404)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+        it 'can view a vendor' do
+          expect(response.status).to eq(200)
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        describe 'can view a assigned vendor' do
+          it do
+            expect(response.status).to eq(200)
+          end
+        end
+
+        describe 'cannot view an another vendor' do
+          let(:selected_vendor) { another_vendor }
+
+          it do
+            expect(response.status).to eq(404)
+          end
+        end
+      end
+    end
+
+    describe 'vendors#create' do
+      let(:params) do
+        {
+          vendor: {
+            name: 'name'
+          }
+        }
+      end
+
+      before { post '/api/v1/vendors', params: params }
+
+      context 'as regular user' do
+        it 'cannot create a new vendor' do
+          expect(response.status).to eq(401)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'can create a new vendor' do
+          expect(response.status).to eq(201)
+          expect(json_response['name']).to eq(params[:vendor][:name])
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor], email: FFaker::Internet.email)
+          user
+        end
+
+        it 'cannot create a new vendor' do
+          expect(response.status).to eq(401)
+        end
+      end
+    end
+
+    describe 'vendors#update' do
+      let(:params) do
+        {
+          vendor: {
+            name: 'updated name'
+          }
+        }
+      end
+
+      before { put "/api/v1/vendors/#{selected_vendor.id}", params: params }
+
+      context 'as regular user' do
+        it 'cannot update vendor' do
+          expect(response.status).to eq(404)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'can update vendor' do
+          expect(response.status).to eq(200)
+          expect(json_response['name']).to eq(params[:vendor][:name])
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        describe 'can update as assigned vendor' do
+          it do
+            expect(response.status).to eq(200)
+          end
+        end
+
+        describe 'cannot update an another vendor' do
+          let(:selected_vendor) { another_vendor }
+
+          it do
+            expect(response.status).to eq(404)
+          end
+        end
+      end
+    end
+
+    describe 'vendors#destroy' do
+      before { delete "/api/v1/vendors/#{selected_vendor.id}" }
+
+      context 'as regular user' do
+        it 'cannot delete vendor' do
+          expect(response.status).to eq(404)
+        end
+      end
+
+      context 'as an admin' do
+        sign_in_as_admin!
+
+        it 'can delete vendor' do
+          expect(response.status).to eq(204)
+          expect(vendor.reload.deleted_at).to_not eq(nil)
+        end
+      end
+
+      context 'as a vendor' do
+        let!(:current_api_user) do
+          user = create(:user, vendors: [vendor])
+          user
+        end
+
+        describe 'can delete an assigned vendor' do
+          it do
+            expect(response.status).to eq(204)
+          end
+        end
+
+        describe 'cannot delete an another vendor' do
+          let(:selected_vendor) { another_vendor }
+
+          it do
+            expect(response.status).to eq(404)
+          end
+        end
+      end
+    end
+  end
+end

data/spec/requests/spree/api/v2/storefront/cart_spec.rb

@@ -26,7 +26,7 @@ describe 'API V2 Storefront Cart Spec', type: :request do
       it_behaves_like 'returns valid cart JSON'
     end
 
-    context 'includes vendor and totals data' do
+    context 'with one vendor' do
       let(:params) { { include: 'vendors,vendor_totals' } }
 
       it_behaves_like 'showing the cart'
@@ -42,6 +42,24 @@ describe 'API V2 Storefront Cart Spec', type: :request do
       end
     end
 
+    context 'with many vendors' do
+      let!(:line_item_2) { create(:line_item, order: order, product: product_2, variant: product_2.default_variant) }
+      let(:params) { { include: 'vendors,vendor_totals' } }
+
+      it_behaves_like 'showing the cart'
+
+      it 'includes many vendors and vendor totals' do
+        get '/api/v2/storefront/cart', headers: headers_bearer, params: params
+
+        [vendor, vendor_2].each do |vendor|
+          expect(json_response['included']).to include(have_type('vendor').and have_id(vendor.id.to_s))
+          expect(json_response['included']).to include(have_type('vendor_totals').and have_id(vendor.id.to_s))
+          expect(json_response['included']).to include(have_type('vendor').and have_attribute(:name).with_value(vendor.name))
+          expect(json_response['included']).to include(have_type('vendor_totals').and have_attribute(:name).with_value(vendor.name))
+        end
+      end
+    end
+
     context 'includes line item vendor data' do
       it_behaves_like 'showing the cart'
 

data/spec/requests/spree/api/v2/storefront/products_spec.rb

@@ -1,7 +1,8 @@
 require 'spec_helper'
 
 describe 'API V2 Storefront Products Spec', type: :request do
-  let!(:products)              { create_list(:product, 5) }
+  let(:store)                  { Spree::Store.default }
+  let!(:products)              { create_list(:product, 5, stores: [store]) }
   let!(:vendor)                { create(:vendor) }
   let!(:vendor_2)              { create(:vendor) }
 
@@ -26,6 +27,8 @@ describe 'API V2 Storefront Products Spec', type: :request do
     end
 
     context 'with specified vendor ids' do
+      before { vendor.products << create(:product) }
+      before { vendor_2.products << create(:product) }
       before { get "/api/v2/storefront/products?filter[vendor_ids]=#{vendor.id}&include=vendor" }
 
       it_behaves_like 'returns 200 HTTP status'