spree_loyalty_points 1.0.1 → 1.0.2

data/README.md

@@ -10,7 +10,7 @@ Installation
 Add spree_loyalty_points to your Gemfile:
 
 ```ruby
-gem 'spree_loyalty_points', '~> 1.0.0'
+gem 'spree_loyalty_points', '~> 1.0.2'
 ```
 
 Bundle your dependencies and run the installation generator:

data/app/models/concerns/spree/payment/loyalty_points.rb

@@ -5,6 +5,10 @@ module Spree
     module LoyaltyPoints
       extend ActiveSupport::Concern
 
+      included do
+        scope :by_loyalty_points, -> { joins(:payment_method).readonly(false).where(:spree_payment_methods => { type: 'Spree::PaymentMethod::LoyaltyPoints'}) }
+      end
+
         module ClassMethods
 
           def any_with_loyalty_points?

data/app/models/spree/app_configuration_decorator.rb

@@ -1,4 +1,3 @@
-#TODO -> Rspecs for this model.
 Spree::AppConfiguration.class_eval do
   preference :min_amount_required_to_get_loyalty_points, :decimal, :default => 20.0
   preference :loyalty_points_awarding_unit, :decimal, :default => 0.0

data/app/models/spree/loyalty_points_transaction.rb

@@ -12,13 +12,10 @@ module Spree
     validate :source_or_comment_present
     validate :transactions_total_range, if: -> { source.present? && source.loyalty_points_transactions.present? }
 
-    #TODO -> rspecs missing for this scope
     scope :for_order, ->(order) { where(source: order) }
 
-    #TODO -> Rspecs missing for this callback.
     before_create :generate_transaction_id
 
-    #TODO -> Rspecs missing for this method.
     def transaction_type
       CLASS_TO_TRANSACTION_TYPE[type]
     end

data/app/models/spree/payment_decorator.rb

@@ -5,7 +5,6 @@ Spree::Payment.class_eval do
 
   validates :amount, numericality: { greater_than: 0 }, :if => :by_loyalty_points?
   scope :state_not, ->(s) { where('state != ?', s) }
-  scope :by_loyalty_points, -> { joins(:payment_method).readonly(false).where(:spree_payment_methods => { type: 'Spree::PaymentMethod::LoyaltyPoints'}) }
 
   fsm = self.state_machines[:state]
   fsm.after_transition :from => fsm.states.map(&:name) - [:completed], :to => [:completed], :do => :notify_paid_order

data/app/models/spree/payment_method_decorator.rb

@@ -1,7 +1,9 @@
 Spree::PaymentMethod.class_eval do
 
+  scope :loyalty_points_type, -> { where(type: 'Spree::PaymentMethod::LoyaltyPoints') }
+
   def self.loyalty_points_id_included?(method_ids)
-    where(type: 'Spree::PaymentMethod::LoyaltyPoints').where(id: method_ids).size != 0
+    loyalty_points_type.where(id: method_ids).size != 0
   end
 
 end

data/lib/tasks/loyalty_points/award.rake

@@ -1,5 +1,3 @@
-#TODO -> Rspecs missing
-#TODO -> Add description of this rake task in README and also tell them to create a cron job for this.
 namespace :spree do
   namespace :loyalty_points do
     desc "Credit loyalty points to pending users accounts"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: spree_loyalty_points
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: 
   segments: 
   - 1
   - 0
-  - 1
-  version: 1.0.1
+  - 2
+  version: 1.0.2
 platform: ruby
 authors: 
 - Jatin Baweja
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2014-02-27 00:00:00 Z
+date: 2014-03-05 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: spree_core