spree_gateway 3.8.0 → 3.9.4

data/spec/features/admin/stripe_elements_payment_spec.rb

@@ -1,53 +1,44 @@
 require 'spec_helper'
 
-describe 'Admin Panel Stripe elements payment', type: :feature, :js => true do
+describe 'Admin Panel Stripe elements payment', type: :feature do
   stub_authorization!
 
-  let!(:country)         { create(:country, :states_required => true) }
-  let!(:state)           { create(:state, :country => country) }
+  let!(:country) { create(:country, states_required: true) }
+  let!(:state) { create(:state, country: country) }
   let!(:shipping_method) { create(:shipping_method) }
-  let!(:stock_location)  { create(:stock_location) }
-  let!(:mug)             { create(:product, :name => 'RoR Mug') }
-  let!(:zone)            { create(:zone) }
+  let!(:stock_location) { create(:stock_location) }
+  let!(:mug) { create(:product, name: 'RoR Mug') }
+  let!(:zone) { create(:zone) }
   let!(:stripe_elements_payment_method) do
     Spree::Gateway::StripeElementsGateway.create!(
-      :name => 'Stripe Element',
-      :preferred_secret_key => 'sk_test_VCZnDv3GLU15TRvn8i2EsaAN',
-      :preferred_publishable_key => 'pk_test_Cuf0PNtiAkkMpTVC2gwYDMIg'
+        name: 'Stripe Element',
+        preferred_secret_key: 'sk_test_VCZnDv3GLU15TRvn8i2EsaAN',
+        preferred_publishable_key: 'pk_test_Cuf0PNtiAkkMpTVC2gwYDMIg',
+        stores: [::Spree::Store.default]
     )
   end
-  
+
   let!(:order) { OrderWalkthrough.up_to(:payment) }
   before { visit spree.new_admin_order_payment_path(order.number) }
 
   it 'can process a valid payment' do
     fill_in_stripe_payment
     wait_for { !page.has_current_path?(spree.admin_order_payments_path(order.number)) }
-    
+
     expect(page.body).to have_content('Payment has been successfully created!')
     expect(page).to have_current_path spree.admin_order_payments_path(order.number)
   end
-  
-  if Spree.version.to_f >= 4.1
-    it 'shows an error with an invalid card name' do
-      fill_in_stripe_payment(true)
 
-      expect(page).to have_content("Credit card Name can't be blank")
-      expect(page).to have_current_path spree.admin_order_payments_path(order.number)
-    end
-  else
-    it 'can proces valid payment with invalid card name' do
-      fill_in_stripe_payment(true)
-      wait_for { !page.has_current_path?(spree.admin_order_payments_path(order.number)) }
+  it 'shows an error with an invalid card name' do
+    fill_in_stripe_payment(true)
 
-      expect(page.body).to have_content('Payment has been successfully created!')
-      expect(page).to have_current_path spree.admin_order_payments_path(order.number)
-    end
+    expect(page).to have_content("Credit card Name can't be blank")
+    expect(page).to have_current_path spree.admin_order_payments_path(order.number)
   end
 
   it 'shows an error with an invalid card number' do
     fill_in_stripe_payment(false, true)
-    
+
     expect(page).to have_content('The card number is not a valid credit card number.')
     expect(page).to have_current_path spree.new_admin_order_payment_path(order.number)
   end
@@ -62,7 +53,7 @@ describe 'Admin Panel Stripe elements payment', type: :feature, :js => true do
   it 'shows an error with an invalid card expiration' do
     fill_in_stripe_payment(false, false, false, true)
 
-    if Spree.version.to_f >= 4.1
+    if Spree.version.to_f >= 4.1 || Spree.version.to_f >= 3.7
       expect(page).to have_content('Credit card Month is not a number')
       expect(page).to have_content('Credit card Year is not a number')
       expect(page).to have_current_path spree.admin_order_payments_path(order.number)
@@ -83,7 +74,7 @@ describe 'Admin Panel Stripe elements payment', type: :feature, :js => true do
 
   def fill_in_card_number(invalid_number)
     number = invalid_number ? '123' : '4242 4242 4242 4242'
-    fill_in_field('Card Number *', '#card_number1', number)
+    fill_in_field('Card Number *', "#card_number#{stripe_elements_payment_method.id}", number)
   end
 
   def fill_in_card_expiration(invalid_expiration)
@@ -91,7 +82,7 @@ describe 'Admin Panel Stripe elements payment', type: :feature, :js => true do
     invalid_expiry = Spree.version.to_f >= 4.2 ? '01/' : '01 / '
 
     card_expiry = invalid_expiration ? invalid_expiry : valid_expiry
-    fill_in_field('Expiration *', '#card_expiry1', card_expiry)
+    fill_in_field('Expiration *', "#card_expiry#{stripe_elements_payment_method.id}", card_expiry)
   end
 
   def fill_in_cvc(invalid_code)

data/spec/features/stripe_checkout_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Stripe checkout", type: :feature do
+describe "Stripe checkout", type: :feature, js: true do
   let!(:country) { create(:country, :states_required => true) }
   let!(:state) { create(:state, :country => country) }
   let!(:shipping_method) { create(:shipping_method) }
@@ -8,15 +8,21 @@ describe "Stripe checkout", type: :feature do
   let!(:mug) { create(:product, :name => "RoR Mug") }
   let!(:stripe_payment_method) do
     Spree::Gateway::StripeGateway.create!(
-      :name => "Stripe",
-      :preferred_secret_key => "sk_test_VCZnDv3GLU15TRvn8i2EsaAN",
-      :preferred_publishable_key => "pk_test_Cuf0PNtiAkkMpTVC2gwYDMIg"
+      name: 'Stripe',
+      preferred_secret_key: 'sk_test_VCZnDv3GLU15TRvn8i2EsaAN',
+      preferred_publishable_key: 'pk_test_Cuf0PNtiAkkMpTVC2gwYDMIg',
+      stores: [::Spree::Store.default]
     )
   end
 
   let!(:zone) { create(:zone) }
 
   before do
+    if Spree.version.to_f >= 4.2
+      payment_method = Spree::PaymentMethod.first
+      payment_method.update!(stores: [Spree::Store.first])
+    end
+
     user = create(:user)
 
     order = OrderWalkthrough.up_to(:delivery)
@@ -42,7 +48,7 @@ describe "Stripe checkout", type: :feature do
   end
 
   # This will pass the CC data to the server and the StripeGateway class handles it
-  it "can process a valid payment (without JS)" do
+  it "can process a valid payment (without JS)", js: false do
     fill_in 'card_number', with: '4242 4242 4242 4242'
     fill_in 'card_code', with: '123'
     fill_in 'card_expiry', with: "01 / #{Time.current.year + 1}"
@@ -56,12 +62,10 @@ describe "Stripe checkout", type: :feature do
 
   # This will fetch a token from Stripe.com and then pass that to the webserver.
   # The server then processes the payment using that token.
-  it "can process a valid payment (with JS)", :js => true do
-    fill_in 'card_number', with: '4242 4242 4242 4242'
-    # Otherwise ccType field does not get updated correctly
-    page.execute_script("$('.cardNumber').trigger('change')")
+  it "can process a valid payment (with JS)" do
+    fill_in_with_force('card_number', with: "4242424242424242")
+    fill_in_with_force('card_expiry', with: "01 / #{Time.current.year + 1}")
     fill_in 'card_code', with: '123'
-    fill_in 'card_expiry', with: "01 / #{Time.current.year + 1}"
     click_button "Save and Continue"
     wait_for_stripe # Wait for Stripe API to return + form to submit
     expect(page).to have_css('#checkout_form_confirm')
@@ -72,18 +76,23 @@ describe "Stripe checkout", type: :feature do
     expect(page).to have_content(order.number)
   end
 
-  it "shows an error with an invalid credit card number", :js => true do
+  it "shows an error with an invalid credit card number" do
     # Card number is NOT valid. Fails Luhn checksum
     fill_in 'card_number', with: '4242 4242 4242 4249'
     click_button "Save and Continue"
     wait_for_stripe
-    expect(page).to have_content("Your card number is incorrect")
-    expect(page).to have_css('.has-error #card_number.error')
+    if Spree.version.to_f >= 3.7 and Spree.version.to_f <= 4.1
+      expect(page).to have_content("The card number is not a valid credit card number")
+    end
+    if Spree.version.to_f >= 4.2
+      expect(page).to have_content("Your card number is incorrect")
+      expect(page).to have_css('.has-error #card_number.error')
+    end
   end
 
-  it "shows an error with invalid security fields", :js => true do
-    fill_in 'card_number', with: '4242 4242 4242 4242'
-    fill_in 'card_expiry', with: "01 / #{Time.current.year + 1}"
+  it "shows an error with invalid security fields" do
+    fill_in_with_force('card_number', with: "4242424242424242")
+    fill_in_with_force('card_expiry', with: "01 / #{Time.current.year + 1}")
     fill_in 'card_code', with: '99'
     click_button "Save and Continue"
     wait_for_stripe
@@ -93,10 +102,10 @@ describe "Stripe checkout", type: :feature do
 
   # this scenario will not occur on Spree 4.2 due to swapping jquery.payment to cleave
   # see https://github.com/spree/spree/pull/10363
-  it "shows an error with invalid expiry month field", :js => true do
-    skip if Spree.version.to_f >= 4.2 
-    fill_in 'card_number', with: '4242 4242 4242 4242'
-    fill_in 'card_expiry', :with => "00 / #{Time.now.year + 1}"
+  it "shows an error with invalid expiry month field" do
+    skip if Spree.version.to_f >= 4.2
+    fill_in_with_force('card_number', with: "4242424242424242")
+    fill_in_with_force('card_expiry', with: "00 / #{Time.current.year + 1}")
     fill_in 'card_code', with: '123'
     click_button "Save and Continue"
     wait_for_stripe
@@ -104,9 +113,9 @@ describe "Stripe checkout", type: :feature do
     expect(page).to have_css('.has-error #card_expiry.error')
   end
 
-  it "shows an error with invalid expiry year field", :js => true do
-    fill_in 'card_number', with: '4242 4242 4242 4242'
-    fill_in 'card_expiry', with: '12 / '
+  it "shows an error with invalid expiry year field" do
+    fill_in_with_force('card_number', with: "4242424242424242")
+    fill_in_with_force('card_expiry', with: "12 / ")
     fill_in 'card_code', with: '123'
     click_button "Save and Continue"
     wait_for_stripe
@@ -114,3 +123,8 @@ describe "Stripe checkout", type: :feature do
     expect(page).to have_css('.has-error #card_expiry.error')
   end
 end
+
+def fill_in_with_force(locator, with:)
+  field_id = find_field(locator)[:id]
+  page.execute_script("document.getElementById('#{field_id}').value = '#{with}';")
+end

data/spec/features/stripe_elements_3ds_checkout_spec.rb

@@ -0,0 +1,225 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Stripe Elements 3ds checkout', type: :feature, js: true do
+  let!(:product) { create(:product, name: 'RoR Mug') }
+  let!(:stripe_payment_method) do
+    Spree::Gateway::StripeElementsGateway.create!(
+        name: 'Stripe',
+        preferred_secret_key: 'sk_test_VCZnDv3GLU15TRvn8i2EsaAN',
+        preferred_publishable_key: 'pk_test_Cuf0PNtiAkkMpTVC2gwYDMIg',
+        preferred_intents: preferred_intents,
+        stores: [::Spree::Store.default]
+    )
+  end
+
+  before do
+    user = create(:user)
+    order = OrderWalkthrough.up_to(:confirm)
+    expect(order).to receive(:confirmation_required?).and_return(true).at_least(:once)
+
+    order.reload
+    order.user = user
+    payment = order.payments.first
+    payment.source = create(:credit_card, number: card_number)
+    payment.save!
+
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(skip_state_validation?: true)
+    allow_any_instance_of(Spree::OrdersController).to receive_messages(try_spree_current_user: user)
+
+    add_to_cart(product)
+
+    if Spree.version.to_f >= 3.7 and Spree.version.to_f < 4.1
+      find("#checkout-link").click
+    else
+      click_link 'checkout'
+      click_button 'Place Order'
+    end
+  end
+
+  describe 'when intents are disabled' do
+    let(:preferred_intents) { false }
+
+    context 'and credit card does not require 3ds authentication' do
+      let(:card_number) { '4242424242424242' }
+
+      if Spree.version.to_f >= 3.7 and Spree.version.to_f < 4.1
+        it 'should place order without 3ds authentication', driver: :selenium_chrome_headless do
+          click_button 'Save and Continue'
+          click_button 'Save and Continue'
+
+          within_frame 0 do
+            fill_in 'cardnumber', with: card_number
+            fill_in 'exp-date', with: "01 / #{Time.current.strftime('%y').to_i + 3}"
+            fill_in 'cvc', with: "222"
+          end
+
+          click_button 'Save and Continue'
+          click_button 'Place Order'
+
+          expect(page).to have_content('Your order has been processed successfully')
+          order = Spree::Order.complete.last
+          expect(page.current_url).to include("/orders/#{order.number}")
+          expect(page).to have_content(order.number)
+        end
+      else
+        it 'should place order without 3ds authentication' do
+          expect(page).to have_content('Order placed successfully')
+          order = Spree::Order.complete.last
+          expect(page.current_url).to include("/orders/#{order.number}")
+          expect(page).to have_content(order.number)
+        end
+      end
+    end
+
+    context 'and credit card does require 3ds authentication' do
+      let(:card_number) { '4000000000003220' }
+
+      if Spree.version.to_f >= 3.7 and Spree.version.to_f < 4.1
+        it 'should not place the order', driver: :selenium_chrome_headless do
+          click_button 'Save and Continue'
+          click_button 'Save and Continue'
+
+          within_frame 0 do
+            fill_in 'cardnumber', with: card_number
+            fill_in 'exp-date', with: "01 / #{Time.current.strftime('%y').to_i + 3}"
+            fill_in 'cvc', with: "222"
+          end
+
+          click_button 'Save and Continue'
+          click_button 'Place Order'
+
+          expect(page).to have_content('Your card was declined. This transaction requires authentication.')
+          expect(Spree::Order.complete.last).to be_nil
+        end
+
+      else
+        it 'should not place the order' do
+          expect(page).to have_content('Your card was declined. This transaction requires authentication.')
+          expect(Spree::Order.complete.last).to be_nil
+        end
+      end
+    end
+  end
+
+  describe 'when intents are enabled' do
+    let(:preferred_intents) { true }
+
+    context 'and credit card does not require 3ds authentication' do
+      let(:card_number) { '4242424242424242' }
+
+      if Spree.version.to_f >= 3.7 and Spree.version.to_f < 4.1
+        it 'should successfully place order without 3ds authentication', driver: :selenium_chrome_headless do
+          click_button 'Save and Continue'
+          click_button 'Save and Continue'
+
+          within_frame 0 do
+            fill_in 'cardnumber', with: card_number
+            fill_in 'exp-date', with: "01 / #{Time.current.strftime('%y').to_i + 3}"
+            fill_in 'cvc', with: "222"
+          end
+
+          click_button 'Save and Continue'
+          click_button 'Place Order'
+
+          expect(page).to have_content('Your order has been processed successfully')
+          order = Spree::Order.complete.last
+          expect(page.current_url).to include("/orders/#{order.number}")
+          expect(page).to have_content(order.number)
+        end
+      else
+        it 'should successfully place order without 3ds authentication' do
+          expect(page).to have_content('Order placed successfully')
+          order = Spree::Order.complete.last
+          expect(page.current_url).to include("/orders/#{order.number}")
+          expect(page).to have_content(order.number)
+        end
+      end
+    end
+
+    context 'when credit card does require 3ds authentication' do
+      let(:card_number) { '4000000000003220' }
+
+      context 'and authentication is successful' do
+        if Spree.version.to_f >= 3.7 and Spree.version.to_f < 4.1
+          it 'should place order after 3ds authentication', driver: :selenium_chrome_headless do
+            click_button 'Save and Continue'
+            click_button 'Save and Continue'
+
+            within_frame 0 do
+              fill_in 'cardnumber', with: card_number
+              fill_in 'exp-date', with: "01 / #{Time.current.strftime('%y').to_i + 3}"
+              fill_in 'cvc', with: "222"
+            end
+
+            click_button 'Save and Continue'
+            click_button 'Place Order'
+
+            within_stripe_3ds_popup do
+              click_button('Complete')
+            end
+
+            expect(page).to have_content('Your order has been processed successfully')
+            order = Spree::Order.complete.last
+            expect(page.current_url).to include("/orders/#{order.number}")
+            expect(page).to have_content(order.number)
+          end
+
+        else
+          it 'should place order after 3ds authentication' do
+            within_stripe_3ds_popup do
+              click_button('Complete')
+            end
+
+            expect(page).to have_content('Order placed successfully')
+            order = Spree::Order.complete.last
+            expect(page.current_url).to include("/orders/#{order.number}")
+            expect(page).to have_content(order.number)
+          end
+        end
+      end
+
+      context 'and authentication is unsuccessful' do
+
+        if Spree.version.to_f >= 3.7 and Spree.version.to_f < 4.1
+          it 'should not place order after 3ds authentication', driver: :selenium_chrome_headless do
+            click_button 'Save and Continue'
+            click_button 'Save and Continue'
+
+            within_frame 0 do
+              fill_in 'cardnumber', with: card_number
+              fill_in 'exp-date', with: "01 / #{Time.current.strftime('%y').to_i + 3}"
+              fill_in 'cvc', with: "222"
+            end
+
+            click_button 'Save and Continue'
+            click_button 'Place Order'
+
+            within_stripe_3ds_popup do
+              click_button('Fail')
+            end
+
+            expect(page).to_not have_content('Order placed successfully')
+            expect(page).to have_content('We are unable to authenticate your payment method.')
+            expect(page).to have_content('Please choose a different payment method and try again.')
+            expect(Spree::Order.complete.last).to be_nil
+          end
+        else
+          it 'should not place order after 3ds authentication' do
+            within_stripe_3ds_popup do
+              click_button('Fail')
+            end
+
+            expect(page).to_not have_content('Order placed successfully')
+            expect(page).to have_content('We are unable to authenticate your payment method.')
+            expect(page).to have_content('Please choose a different payment method and try again.')
+            expect(Spree::Order.complete.last).to be_nil
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/gateway/authorize_net_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Spree::Gateway::AuthorizeNet do
-  let (:gateway) { described_class.create!(name: 'Authorize.net') }
+  let (:gateway) { described_class.create!(name: 'Authorize.net', stores: [::Spree::Store.default]) }
 
   context '.provider_class' do
     it 'is a AuthorizeNet gateway' do