spree_gateway 3.7.5 → 3.8.0

data/lib/views/backend/spree/admin/payments/source_views/_stripe_ach.html.erb

@@ -0,0 +1,21 @@
+<fieldset data-hook="bank_transfer">
+  <legend><%= Spree.t(:bank_transfer) %></legend>
+  <table class="table table-condensed table-bordered">
+    <tr>
+      <th width="20%"><%= Spree.t('stripe.ach.account_holder_name') %>:</th>
+      <td><%= payment.source.account_holder_name %></td>
+    </tr>
+    <tr>
+      <th><%= Spree.t('stripe.ach.account_holder_type') %>:</th>
+      <td><%= payment.source.account_holder_type %></td>
+    </tr>
+    <tr>
+      <th><%= Spree.t('stripe.ach.routing_number') %>:</th>
+      <td><%= payment.source.routing_number %></td>
+    </tr>
+    <tr>
+      <th><%= Spree.t('stripe.ach.account_number') %>:</th>
+      <td><%= payment.source.account_number %></td>
+    </tr>
+  </table>
+</fieldset>

data/lib/views/frontend/spree/checkout/payment/_stripe_ach.html.erb

@@ -0,0 +1,81 @@
+<div class="payment-gateway">
+  <% param_prefix = "payment_source[#{payment_method.id}]" %>
+  <div class="payment-gateway-half-fields">
+    <div class="mb-4 payment-gateway-field checkout-content-inner-field">
+      <%= text_field_tag "#{param_prefix}[account_holder_name]", "#{@order.bill_address_firstname} #{@order.bill_address_lastname}", { id: "account_holder_name", class: 'spree-flat-input', placeholder: Spree.t('stripe.ach.account_holder_name')} %>
+    </div>
+    <div class="mb-4 payment-gateway-field checkout-content-inner-field">
+      <%= select_tag "#{param_prefix}[account_holder_type]", options_for_select(%w(Individual Company)), {id: "account_holder_type", class: 'spree-flat-input', placeholder: Spree.t('stripe.ach.account_holder_type')} %>
+    </div>
+
+    <div class="mb-4 payment-gateway-field checkout-content-inner-field" data-hook="account_number">
+      <%= text_field_tag "#{param_prefix}[routing_number]", '', {id: 'routing_number', class: 'spree-flat-input', autocomplete: "off", placeholder: Spree.t('stripe.ach.routing_number'), maxlength: 9} %>
+    </div>
+    <div class="mb-4 payment-gateway-field checkout-content-inner-field" data-hook="account_number">
+      <%= text_field_tag "#{param_prefix}[account_number]", '', {id: 'account_number', class: 'spree-flat-input', autocomplete: "off", placeholder: Spree.t('stripe.ach.account_number')} %>
+    </div>
+    <div class="mb-4 payment-gateway-field checkout-content-inner-field" data-hook="account_number">
+      <%= text_field_tag "#{param_prefix}[verify_account_number]", '', {id: 'verify_account_number', class: 'spree-flat-input', autocomplete: "off", placeholder: Spree.t('stripe.ach.verify_account_number')} %>
+    </div>
+  </div>
+</div>
+
+<script type="text/javascript" src="https://js.stripe.com/v3/"></script>
+<script type="text/javascript">
+    var stripe = Stripe("<%= payment_method.preferred_publishable_key %>");
+</script>
+
+<script>
+    stripeResponseHandler = function(response) {
+        var paymentMethodId, token, bank_acc_status;
+        if (response.error) {
+            $('#stripeError').html(response.error.message);
+            var param_map = {
+                account_holder_name: '#account_holder_name',
+                account_holder_type: '#account_holder_type',
+                account_number: '#account_number',
+                routing_number: '#routing_number'
+            }
+            if (response.error.param){
+                errorField = Spree.stripePaymentMethod.find(param_map[response.error.param])
+                errorField.addClass('error');
+                errorField.parent().addClass('has-error');
+            }
+            return $('#stripeError').show();
+        } else {
+            token = response.token['id'];
+            bank_acc_status = response.token.bank_account['status'];
+            paymentMethodId = Spree.stripePaymentMethod.prop('id').split("_")[2];
+            Spree.stripePaymentMethod.append("<input type='hidden' class='stripeToken' name='payment_source[" + paymentMethodId + "][gateway_payment_profile_id]' value='" + token + "'/>");
+            Spree.stripePaymentMethod.append("<input type='hidden' class='stripeStatus' name='payment_source[" + paymentMethodId + "][status]' value='" + bank_acc_status + "'/>")
+            return Spree.stripePaymentMethod.parents("form").trigger('submit');
+        }
+    };
+
+    window.addEventListener('DOMContentLoaded', function () {
+        Spree.stripePaymentMethod = $('#payment_method_' + <%= payment_method.id %>);
+        Spree.stripePaymentMethod.prepend("<div id='stripeError' class='errorExplanation alert alert-danger' style='display:none'></div>");
+
+        $('#checkout_form_payment [data-hook=buttons]').click(function (e) {
+            var params;
+            $('#stripeError').hide();
+            Spree.stripePaymentMethod.find('#account_holder_name, #account_holder_type, #account_number, #routing_number').removeClass('error');
+            if (Spree.stripePaymentMethod.is(':visible')) {
+                e.preventDefault();
+
+                params = $.extend({
+                    country: 'US',
+                    currency: 'usd',
+                    account_holder_name: $('#account_holder_name:visible').val(),
+                    account_holder_type: $('#account_holder_type:visible').val(),
+                    routing_number: $('#routing_number:visible').val(),
+                    account_number: $('#account_number:visible').val()
+                }, Spree.stripeAdditionalInfo);
+
+                stripe.createToken('bank_account', params).then(stripeResponseHandler);
+
+                return false;
+            }
+        });
+    });
+</script>

data/lib/views/frontend/spree/checkout/payment/_stripe_ach_verify.html.erb

@@ -0,0 +1,16 @@
+<p class="payment-type checkout-content-header">
+  <%= Spree.t('stripe.ach.verify_bank_account').upcase %>
+</p>
+
+<div class="payment-gateway">
+  <div class="payment-gateway-half-fields">
+    <input type="hidden" name="order[payment_id]" value= <%= payment.id %> />
+    <input type='hidden' name='verifyAch' value=true />
+    <div class="mb-4 payment-gateway-field checkout-content-inner-field">
+      <%= number_field_tag "amounts[]", nil, { id: "deposit1", class: 'spree-flat-input', placeholder: Spree.t('stripe.ach.first_deposit') } %>
+    </div>
+    <div class="mb-4 payment-gateway-field checkout-content-inner-field">
+      <%= number_field_tag "amounts[]", nil, { id: "deposit2", class: 'spree-flat-input', placeholder: Spree.t('stripe.ach.second_deposit') } %>
+    </div>
+  </div>
+</div>

data/spec/factories/check_factory.rb

@@ -0,0 +1,10 @@
+FactoryBot.define do
+  factory :check, class: Spree::Check do
+    account_holder_name { 'John Doe' }
+    account_holder_type { 'Individual' }
+    account_type { 'checking' }
+    routing_number { '110000000' }
+    account_number { '000123456789' }
+    association(:payment_method, factory: :credit_card_payment_method)
+  end
+end

data/spec/features/admin/stripe_elements_payment_spec.rb

@@ -75,10 +75,10 @@ describe 'Admin Panel Stripe elements payment', type: :feature, :js => true do
   def fill_in_stripe_payment(invalid_name = false, invalid_number = false, invalid_code = false, invalid_expiration = false)
     fill_in 'Name *', with: invalid_name ? '' : 'Stripe Elements Gateway Payment'
     fill_in_card_number(invalid_number)
-    fill_in 'Card Code *', with: invalid_code ? '1' : '123'
+    fill_in_cvc(invalid_code)
     fill_in_card_expiration(invalid_expiration)
 
-    click_button "Update"
+    click_button 'Update'
   end
 
   def fill_in_card_number(invalid_number)
@@ -87,10 +87,20 @@ describe 'Admin Panel Stripe elements payment', type: :feature, :js => true do
   end
 
   def fill_in_card_expiration(invalid_expiration)
-    card_expiry = invalid_expiration ? '01 / ' : "01 / #{Time.current.year + 1}"
+    valid_expiry = Spree.version.to_f >= 4.2 ? "01/#{Time.current.year + 1}" : "01 / #{Time.current.year + 1}"
+    invalid_expiry = Spree.version.to_f >= 4.2 ? '01/' : '01 / '
+
+    card_expiry = invalid_expiration ? invalid_expiry : valid_expiry
     fill_in_field('Expiration *', '#card_expiry1', card_expiry)
   end
 
+  def fill_in_cvc(invalid_code)
+    value = invalid_code ? '1' : '123'
+    label = Spree.version.to_f >= 4.2 ? 'Card Varification Code (CVC) *' : 'Card Code *'
+
+    fill_in label, with: value
+  end
+
   def fill_in_field(field_name, field_id, number)
     until page.find(field_id).value == number
       fill_in field_name, with: number

data/spec/features/stripe_checkout_spec.rb

@@ -91,7 +91,10 @@ describe "Stripe checkout", type: :feature do
     expect(page).to have_css('.has-error #card_code.error')
   end
 
+  # this scenario will not occur on Spree 4.2 due to swapping jquery.payment to cleave
+  # see https://github.com/spree/spree/pull/10363
   it "shows an error with invalid expiry month field", :js => true do
+    skip if Spree.version.to_f >= 4.2 
     fill_in 'card_number', with: '4242 4242 4242 4242'
     fill_in 'card_expiry', :with => "00 / #{Time.now.year + 1}"
     fill_in 'card_code', with: '123'

data/spec/models/gateway/stripe_ach_gateway_spec.rb

@@ -0,0 +1,185 @@
+require 'spec_helper'
+
+describe Spree::Gateway::StripeAchGateway do
+  let(:secret_key) { 'key' }
+  let(:email) { 'customer@example.com' }
+  let(:source) { Spree::Check.new }
+  let(:payment) {
+    double('Spree::Payment',
+           source: source,
+           order: double('Spree::Order',
+                         email: email,
+                         bill_address: bill_address,
+                         user: double('Spree::User',
+                                      email: email)
+           )
+    )
+  }
+  let(:provider) do
+    double('provider').tap do |p|
+      p.stub(:purchase)
+      p.stub(:authorize)
+      p.stub(:capture)
+      p.stub(:verify)
+    end
+  end
+
+  before do
+    subject.preferences = { secret_key: secret_key }
+    subject.stub(:options_for_purchase_or_auth).and_return(['money','check','opts'])
+    subject.stub(:provider).and_return provider
+  end
+
+  describe '#create_profile' do
+    before do
+      payment.source.stub(:update!)
+    end
+
+    context 'with an order that has a bill address' do
+      let(:bill_address) {
+        double('Spree::Address',
+               address1: '123 Happy Road',
+               address2: 'Apt 303',
+               city: 'Suzarac',
+               zipcode: '95671',
+               state: double('Spree::State', name: 'Oregon'),
+               country: double('Spree::Country', name: 'United States')
+        )
+      }
+
+      it 'stores the bill address with the provider' do
+        subject.provider.should_receive(:store).with(payment.source, {
+            email: email,
+            login: secret_key,
+
+            address: {
+                address1: '123 Happy Road',
+                address2: 'Apt 303',
+                city: 'Suzarac',
+                zip: '95671',
+                state: 'Oregon',
+                country: 'United States'
+            }
+        }).and_return double.as_null_object
+
+        subject.create_profile payment
+      end
+    end
+
+    context 'with an order that does not have a bill address' do
+      let(:bill_address) { nil }
+
+      it 'does not store a bill address with the provider' do
+        subject.provider.should_receive(:store).with(payment.source, {
+            email: email,
+            login: secret_key
+        }).and_return double.as_null_object
+
+        subject.create_profile payment
+      end
+
+    end
+
+    context 'with a check represents payment_profile' do
+      let(:source) { Spree::Check.new(gateway_payment_profile_id: 'tok_profileid') }
+      let(:bill_address) { nil }
+
+      it 'stores the profile_id as a check' do
+        subject.provider.should_receive(:store).with(source.gateway_payment_profile_id, anything).and_return double.as_null_object
+
+        subject.create_profile payment
+      end
+    end
+  end
+
+  context 'purchasing' do
+    after do
+      subject.purchase(19.99, 'check', {})
+    end
+
+    it 'send the payment to the provider' do
+      provider.should_receive(:purchase).with('money', 'check', 'opts')
+    end
+  end
+
+  context 'authorizing' do
+    after do
+      subject.authorize(19.99, 'check', {})
+    end
+
+    it 'send the authorization to the provider' do
+      provider.should_receive(:authorize).with('money', 'check', 'opts')
+    end
+  end
+
+  context 'verifying' do
+    after do
+      subject.verify(source, {})
+    end
+
+    it 'send the verify to the provider' do
+      provider.should_receive(:verify).with(source, anything)
+    end
+  end
+
+  context 'capturing' do
+
+    after do
+      subject.capture(1234, 'response_code', {})
+    end
+
+    it 'convert the amount to cents' do
+      provider.should_receive(:capture).with(1234, anything, anything)
+    end
+
+    it 'use the response code as the authorization' do
+      provider.should_receive(:capture).with(anything, 'response_code', anything)
+    end
+  end
+
+  context 'capture with payment class' do
+    let(:gateway) do
+      gateway = described_class.new(active: true)
+      gateway.set_preference :secret_key, secret_key
+      gateway.stub(:options_for_purchase_or_auth).and_return(['money', 'check', 'opts'])
+      gateway.stub(:provider).and_return provider
+      gateway.stub source_required: true
+      gateway
+    end
+
+    let(:order) { Spree::Order.create }
+
+    let(:check) do
+      # mock_model(Spree::Check, :gateway_customer_profile_id => 'cus_abcde',
+      # :imported => false)
+      create :check, gateway_customer_profile_id: 'cus_abcde', imported: false
+    end
+
+    let(:payment) do
+      payment = Spree::Payment.new
+      payment.source = check
+      payment.order = order
+      payment.payment_method = gateway
+      payment.amount = 98.55
+      payment.state = 'pending'
+      payment.response_code = '12345'
+      payment
+    end
+
+    after do
+      payment.capture!
+    end
+
+    let!(:success_response) do
+      double('success_response',
+             success?: true,
+             authorization: '123',
+             avs_result: { 'code' => 'avs-code' },
+             cvv_result: { 'code' => 'cvv-code', 'message' => 'CVV Result' })
+    end
+
+    it 'gets correct amount' do
+      provider.should_receive(:capture).with(9855, '12345', anything).and_return(success_response)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,68 +1,10 @@
-require 'simplecov'
-SimpleCov.start 'rails'
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
 
-ENV["RAILS_ENV"] = "test"
+require File.expand_path('../dummy/config/environment.rb', __FILE__)
 
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require 'spree_dev_tools/rspec/spec_helper'
 
-require 'rspec/rails'
-require 'rspec/active_model/mocks'
-require 'capybara/rspec'
-require 'capybara/rails'
-require 'capybara-screenshot/rspec'
-require "selenium-webdriver"
-require 'webdrivers'
-require 'database_cleaner'
-require 'ffaker'
-require 'rspec/active_model/mocks'
-require 'pry'
-
-Dir[File.join(File.dirname(__FILE__), "support", "**", "*.rb")].each { |f| require f }
-
-require 'spree/testing_support/factories'
-require 'spree/testing_support/order_walkthrough'
-require 'spree/testing_support/preferences'
-require 'spree/testing_support/capybara_ext'
-require 'spree/testing_support/authorization_helpers'
-
-FactoryBot.find_definitions
-
-RSpec.configure do |config|
-  config.infer_spec_type_from_file_location!
-  config.mock_with :rspec do |mock|
-    mock.syntax = [:should, :expect]
-  end
-  config.raise_errors_for_deprecations!
-  config.use_transactional_fixtures = false
-  #config.filter_run focus: true
-  #config.filter_run_excluding slow: true
-
-  config.include FactoryBot::Syntax::Methods
-  config.include Spree::TestingSupport::Preferences
-
-  config.before :suite do
-    DatabaseCleaner.strategy = :transaction
-    DatabaseCleaner.clean_with :truncation
-  end
-
-  config.before do
-    DatabaseCleaner.strategy = RSpec.current_example.metadata[:js] ? :truncation : :transaction
-    DatabaseCleaner.start
-    reset_spree_preferences
-    create(:store)
-  end
-
-  config.after do
-    DatabaseCleaner.clean
-  end
-
-  Capybara.register_driver :chrome do |app|
-    Capybara::Selenium::Driver.new app,
-      browser: :chrome,
-      options: Selenium::WebDriver::Chrome::Options.new(
-        args: %w[no-sandbox disable-dev-shm-usage disable-popup-blocking headless disable-gpu window-size=1920,1080 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=VizDisplayCompositor],
-        log_level: :error
-      )
-  end
-  Capybara.javascript_driver = :chrome
-end
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].sort.each { |f| require f }

data/spree_gateway.gemspec

@@ -25,26 +25,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'spree_core', spree_version
   s.add_dependency 'spree_extension'
 
-  s.add_development_dependency 'appraisal'
-  s.add_development_dependency 'bootstrap-sass'
   s.add_development_dependency 'braintree'
-  s.add_development_dependency 'capybara'
-  s.add_development_dependency 'capybara-screenshot'
-  s.add_development_dependency 'coffee-rails'
-  s.add_development_dependency 'database_cleaner'
-  s.add_development_dependency 'factory_bot', '~> 4.7'
-  s.add_development_dependency 'ffaker'
-  s.add_development_dependency 'guard-rspec'
-  s.add_development_dependency 'launchy'
-  s.add_development_dependency 'mysql2'
-  s.add_development_dependency 'pg'
-  s.add_development_dependency 'pry'
-  s.add_development_dependency 'puma'
   s.add_development_dependency 'rspec-activemodel-mocks'
-  s.add_development_dependency 'rspec-rails'
-  s.add_development_dependency 'sass-rails'
-  s.add_development_dependency 'selenium-webdriver'
-  s.add_development_dependency 'webdrivers'
-  s.add_development_dependency 'simplecov'
-  s.add_development_dependency 'sqlite3'
+  s.add_development_dependency 'spree_dev_tools'
 end