spree_gateway 3.7.4 → 3.9.2

data/spec/features/stripe_checkout_spec.rb

@@ -91,7 +91,10 @@ describe "Stripe checkout", type: :feature do
     expect(page).to have_css('.has-error #card_code.error')
   end
 
+  # this scenario will not occur on Spree 4.2 due to swapping jquery.payment to cleave
+  # see https://github.com/spree/spree/pull/10363
   it "shows an error with invalid expiry month field", :js => true do
+    skip if Spree.version.to_f >= 4.2 
     fill_in 'card_number', with: '4242 4242 4242 4242'
     fill_in 'card_expiry', :with => "00 / #{Time.now.year + 1}"
     fill_in 'card_code', with: '123'

data/spec/features/stripe_elements_3ds_checkout_spec.rb

@@ -0,0 +1,106 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Stripe Elements 3ds checkout', type: :feature, js: true do
+  let!(:product) { create(:product, name: 'RoR Mug') }
+  let!(:stripe_payment_method) do
+    Spree::Gateway::StripeElementsGateway.create!(
+      name: 'Stripe',
+      preferred_secret_key: 'sk_test_VCZnDv3GLU15TRvn8i2EsaAN',
+      preferred_publishable_key: 'pk_test_Cuf0PNtiAkkMpTVC2gwYDMIg',
+      preferred_intents: preferred_intents
+    )
+  end
+
+  before do
+    user = create(:user)
+    order = OrderWalkthrough.up_to(:confirm)
+    expect(order).to receive(:confirmation_required?).and_return(true).at_least(:once)
+
+    order.reload
+    order.user = user
+    payment = order.payments.first
+    payment.source = create(:credit_card, number: card_number)
+    payment.save!
+
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(skip_state_validation?: true)
+    allow_any_instance_of(Spree::OrdersController).to receive_messages(try_spree_current_user: user)
+
+    add_to_cart(product)
+    click_link 'checkout'
+    click_button 'Place Order'
+  end
+
+  describe 'when intents are disabled' do
+    let(:preferred_intents) { false }
+
+    context 'and credit card does not require 3ds authentication' do
+      let(:card_number) { '4242424242424242' }
+
+      it 'should place order without 3ds authentication' do
+        expect(page).to have_content('Order placed successfully')
+        order = Spree::Order.complete.last
+        expect(page.current_url).to include("/orders/#{order.number}")
+        expect(page).to have_content(order.number)
+      end
+    end
+
+    context 'and credit card does require 3ds authentication' do
+      let(:card_number) { '4000000000003220' }
+
+      it 'should not place the order' do
+        expect(page).to have_content('Your card was declined. This transaction requires authentication.')
+        expect(Spree::Order.complete.last).to be_nil
+      end
+    end
+  end
+
+  describe 'when intents are enabled' do
+    let(:preferred_intents) { true }
+
+    context 'and credit card does not require 3ds authentication' do
+      let(:card_number) { '4242424242424242' }
+
+      it 'should successfully place order without 3ds authentication' do
+
+        expect(page).to have_content('Order placed successfully')
+        order = Spree::Order.complete.last
+        expect(page.current_url).to include("/orders/#{order.number}")
+        expect(page).to have_content(order.number)
+      end
+    end
+
+    context 'when credit card does require 3ds authentication' do
+      let(:card_number) { '4000000000003220' }
+
+      context 'and authentication is successful' do
+        it 'should place order after 3ds authentication' do
+          within_stripe_3ds_popup do
+            click_button('Complete')
+          end
+
+          expect(page).to have_content('Order placed successfully')
+          order = Spree::Order.complete.last
+          expect(page.current_url).to include("/orders/#{order.number}")
+          expect(page).to have_content(order.number)
+        end
+      end
+
+      context 'and authentication is unsuccessful' do
+        it 'should not place order after 3ds authentication' do
+          within_stripe_3ds_popup do
+            click_button('Fail')
+          end
+
+          expect(page).to_not have_content('Order placed successfully')
+          expect(page).to have_content('We are unable to authenticate your payment method.')
+          expect(page).to have_content('Please choose a different payment method and try again.')
+          expect(Spree::Order.complete.last).to be_nil
+        end
+      end
+    end
+  end
+end

data/spec/models/gateway/stripe_ach_gateway_spec.rb

@@ -0,0 +1,186 @@
+require 'spec_helper'
+
+describe Spree::Gateway::StripeAchGateway do
+  let(:secret_key) { 'key' }
+  let(:email) { 'customer@example.com' }
+  let(:source) { Spree::Check.new }
+  let(:payment) {
+    double('Spree::Payment',
+           source: source,
+           order: double('Spree::Order',
+                         email: email,
+                         bill_address: bill_address,
+                         user: double('Spree::User',
+                                      email: email)
+           )
+    )
+  }
+  let(:provider) do
+    double('provider').tap do |p|
+      p.stub(:purchase)
+      p.stub(:authorize)
+      p.stub(:capture)
+      p.stub(:verify)
+    end
+  end
+
+  before do
+    subject.preferences = { secret_key: secret_key }
+    subject.stub(:options_for_purchase_or_auth).and_return(['money','check','opts'])
+    subject.stub(:provider).and_return provider
+  end
+
+  describe '#create_profile' do
+    before do
+      payment.source.stub(:update!)
+    end
+
+    context 'with an order that has a bill address' do
+      let(:bill_address) {
+        double('Spree::Address',
+               address1: '123 Happy Road',
+               address2: 'Apt 303',
+               city: 'Suzarac',
+               zipcode: '95671',
+               state: double('Spree::State', name: 'Oregon'),
+               country: double('Spree::Country', name: 'United States')
+        )
+      }
+
+      it 'stores the bill address with the provider' do
+        subject.provider.should_receive(:store).with(payment.source, {
+            email: email,
+            login: secret_key,
+
+            address: {
+                address1: '123 Happy Road',
+                address2: 'Apt 303',
+                city: 'Suzarac',
+                zip: '95671',
+                state: 'Oregon',
+                country: 'United States'
+            }
+        }).and_return double.as_null_object
+
+        subject.create_profile payment
+      end
+    end
+
+    context 'with an order that does not have a bill address' do
+      let(:bill_address) { nil }
+
+      it 'does not store a bill address with the provider' do
+        subject.provider.should_receive(:store).with(payment.source, {
+            email: email,
+            login: secret_key
+        }).and_return double.as_null_object
+
+        subject.create_profile payment
+      end
+
+    end
+
+    context 'with a check represents payment_profile' do
+      let(:source) { Spree::Check.new(gateway_payment_profile_id: 'tok_profileid') }
+      let(:bill_address) { nil }
+
+      it 'stores the profile_id as a check' do
+        subject.provider.should_receive(:store).with(source.gateway_payment_profile_id, anything).and_return double.as_null_object
+
+        subject.create_profile payment
+      end
+    end
+  end
+
+  context 'purchasing' do
+    after do
+      subject.purchase(19.99, 'check', {})
+    end
+
+    it 'send the payment to the provider' do
+      provider.should_receive(:purchase).with('money', 'check', 'opts')
+    end
+  end
+
+  context 'authorizing' do
+    after do
+      subject.authorize(19.99, 'check', {})
+    end
+
+    it 'send the authorization to the provider' do
+      provider.should_receive(:authorize).with('money', 'check', 'opts')
+    end
+  end
+
+  context 'verifying' do
+    after do
+      subject.verify(source, {})
+    end
+
+    it 'send the verify to the provider' do
+      provider.should_receive(:verify).with(source, anything)
+    end
+  end
+
+  context 'capturing' do
+
+    after do
+      subject.capture(1234, 'response_code', {})
+    end
+
+    it 'convert the amount to cents' do
+      provider.should_receive(:capture).with(1234, anything, anything)
+    end
+
+    it 'use the response code as the authorization' do
+      provider.should_receive(:capture).with(anything, 'response_code', anything)
+    end
+  end
+
+  context 'capture with payment class' do
+    let(:gateway) do
+      gateway = described_class.new(active: true)
+      gateway.set_preference :secret_key, secret_key
+      gateway.stub(:options_for_purchase_or_auth).and_return(['money', 'check', 'opts'])
+      gateway.stub(:provider).and_return provider
+      gateway.stub source_required: true
+      gateway
+    end
+
+    let(:order) { Spree::Order.create }
+
+    let(:check) do
+      # mock_model(Spree::Check, :gateway_customer_profile_id => 'cus_abcde',
+      # :imported => false)
+      create :check, gateway_customer_profile_id: 'cus_abcde', imported: false
+    end
+
+    let(:payment) do
+      payment = Spree::Payment.new
+      payment.source = check
+      payment.order = order
+      payment.payment_method = gateway
+      payment.amount = 98.55
+      payment.state = 'pending'
+      payment.response_code = '12345'
+      payment
+    end
+
+    after do
+      payment.capture!
+    end
+
+    let!(:success_response) do
+      double('success_response',
+             success?: true,
+             authorization: '123',
+             avs_result: { 'code' => 'avs-code' },
+             cvv_result: { 'code' => 'cvv-code', 'message' => 'CVV Result' },
+             params: {})
+    end
+
+    it 'gets correct amount' do
+      provider.should_receive(:capture).with(9855, '12345', anything).and_return(success_response)
+    end
+  end
+end

data/spec/models/gateway/stripe_gateway_spec.rb

@@ -182,6 +182,7 @@ describe Spree::Gateway::StripeGateway do
 
     let!(:success_response) do
       double('success_response', :success? => true,
+                               :params => {},
                                :authorization => '123',
                                :avs_result => { 'code' => 'avs-code' },
                                :cvv_result => { 'code' => 'cvv-code', 'message' => "CVV Result"})

data/spec/spec_helper.rb

@@ -1,68 +1,10 @@
-require 'simplecov'
-SimpleCov.start 'rails'
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
 
-ENV["RAILS_ENV"] = "test"
+require File.expand_path('../dummy/config/environment.rb', __FILE__)
 
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require 'spree_dev_tools/rspec/spec_helper'
 
-require 'rspec/rails'
-require 'rspec/active_model/mocks'
-require 'capybara/rspec'
-require 'capybara/rails'
-require 'capybara-screenshot/rspec'
-require "selenium-webdriver"
-require 'webdrivers'
-require 'database_cleaner'
-require 'ffaker'
-require 'rspec/active_model/mocks'
-require 'pry'
-
-Dir[File.join(File.dirname(__FILE__), "support", "**", "*.rb")].each { |f| require f }
-
-require 'spree/testing_support/factories'
-require 'spree/testing_support/order_walkthrough'
-require 'spree/testing_support/preferences'
-require 'spree/testing_support/capybara_ext'
-require 'spree/testing_support/authorization_helpers'
-
-FactoryBot.find_definitions
-
-RSpec.configure do |config|
-  config.infer_spec_type_from_file_location!
-  config.mock_with :rspec do |mock|
-    mock.syntax = [:should, :expect]
-  end
-  config.raise_errors_for_deprecations!
-  config.use_transactional_fixtures = false
-  #config.filter_run focus: true
-  #config.filter_run_excluding slow: true
-
-  config.include FactoryBot::Syntax::Methods
-  config.include Spree::TestingSupport::Preferences
-
-  config.before :suite do
-    DatabaseCleaner.strategy = :transaction
-    DatabaseCleaner.clean_with :truncation
-  end
-
-  config.before do
-    DatabaseCleaner.strategy = RSpec.current_example.metadata[:js] ? :truncation : :transaction
-    DatabaseCleaner.start
-    reset_spree_preferences
-    create(:store)
-  end
-
-  config.after do
-    DatabaseCleaner.clean
-  end
-
-  Capybara.register_driver :chrome do |app|
-    Capybara::Selenium::Driver.new app,
-      browser: :chrome,
-      options: Selenium::WebDriver::Chrome::Options.new(
-        args: %w[no-sandbox disable-dev-shm-usage disable-popup-blocking headless disable-gpu window-size=1920,1080 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=VizDisplayCompositor],
-        log_level: :error
-      )
-  end
-  Capybara.javascript_driver = :chrome
-end
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].sort.each { |f| require f }

data/spec/support/within_stripe_3ds_popup.rb

@@ -0,0 +1,10 @@
+def within_stripe_3ds_popup
+  using_wait_time(10) do
+    within_frame 0 do
+      within_frame 0 do
+        expect(page).to have_text('3D Secure 2 Test Page', normalize_ws: true)
+        yield
+      end
+    end
+  end
+end

data/spree_gateway.gemspec

@@ -16,35 +16,24 @@ Gem::Specification.new do |s|
   s.homepage     = 'https://spreecommerce.org'
   s.license      = 'BSD-3-Clause'
 
+  s.metadata = {
+    "bug_tracker_uri"   => "https://github.com/spree/spree_gateway/issues",
+    "changelog_uri"     => "https://github.com/spree/spree_gateway/releases/tag/v#{s.version}",
+    "documentation_uri" => "https://guides.spreecommerce.org/",
+    "source_code_uri"   => "https://github.com/spree/spree_gateway/tree/v#{s.version}",
+  }
+
   s.files        = `git ls-files`.split("\n")
   s.test_files   = `git ls-files -- spec/*`.split("\n")
   s.require_path = 'lib'
   s.requirements << 'none'
 
-  spree_version = '>= 3.1.0', '< 5.0'
+  spree_version = '>= 3.7.0', '< 5.0'
   s.add_dependency 'spree_core', spree_version
   s.add_dependency 'spree_extension'
+  s.add_dependency 'deface'
 
-  s.add_development_dependency 'appraisal'
-  s.add_development_dependency 'bootstrap-sass'
-  s.add_development_dependency 'braintree'
-  s.add_development_dependency 'capybara'
-  s.add_development_dependency 'capybara-screenshot'
-  s.add_development_dependency 'coffee-rails'
-  s.add_development_dependency 'database_cleaner'
-  s.add_development_dependency 'factory_bot', '~> 4.7'
-  s.add_development_dependency 'ffaker'
-  s.add_development_dependency 'guard-rspec'
-  s.add_development_dependency 'launchy'
-  s.add_development_dependency 'mysql2'
-  s.add_development_dependency 'pg'
-  s.add_development_dependency 'pry'
-  s.add_development_dependency 'puma'
+  s.add_development_dependency 'braintree', '~>2.78'
   s.add_development_dependency 'rspec-activemodel-mocks'
-  s.add_development_dependency 'rspec-rails'
-  s.add_development_dependency 'sass-rails'
-  s.add_development_dependency 'selenium-webdriver'
-  s.add_development_dependency 'webdrivers'
-  s.add_development_dependency 'simplecov'
-  s.add_development_dependency 'sqlite3'
+  s.add_development_dependency 'spree_dev_tools'
 end