spree_gateway 2.2.1 → 3.0.0

data/spec/models/gateway/authorize_net_cim_spec.rb

@@ -11,18 +11,18 @@ describe Spree::Gateway::AuthorizeNetCim do
 
   context '.payment_profiles_supported?' do
     it 'return true' do
-      expect(subject.payment_profiles_supported?).to be_true
+      expect(subject.payment_profiles_supported?).to be true
     end
   end
 
   describe 'options' do
-    it 'include :test => true when :test_mode is true' do
-      gateway.preferred_test_mode = true
-      expect(gateway.options[:test]).to be_true
+    it 'include :test => true when test server is "test"' do
+      gateway.preferred_server = "test"
+      expect(gateway.options[:test]).to be true
     end
 
-    it 'does not include :test when :test_mode is false' do
-      gateway.preferred_test_mode = false
+    it 'does not include :test when test server is "live"' do
+      gateway.preferred_server = "live"
       expect(gateway.options[:test]).to be_nil
     end
   end

data/spec/models/gateway/authorize_net_spec.rb

@@ -10,14 +10,14 @@ describe Spree::Gateway::AuthorizeNet do
   end
 
   describe 'options' do
-    it 'include :test => true when :test_mode is true' do
-      gateway.preferred_test_mode = true
-      expect(gateway.options[:test]).to be_true
+    it 'include :test => true when server is "test"' do
+      gateway.preferred_server = "test"
+      expect(gateway.options[:test]).to be true
     end
 
-    it 'does not include :test when test_mode is false' do
-      gateway.preferred_test_mode = false
-      expect(gateway.options[:test]).to be_false
+    it 'does not include :test when server is "live"' do
+      gateway.preferred_server = "live"
+      expect(gateway.options[:test]).to be false
     end
   end
 end

data/spec/models/gateway/balanced_gateway_spec.rb

@@ -11,7 +11,7 @@ describe Spree::Gateway::BalancedGateway do
 
   context '.payment_profiles_supported?' do
     it 'return true' do
-      expect(gateway.payment_profiles_supported?).to be_true
+      expect(gateway.payment_profiles_supported?).to be true
     end
   end
 end

data/spec/models/gateway/beanstream_spec.rb

@@ -11,7 +11,7 @@ describe Spree::Gateway::Beanstream do
 
   context '.payment_profiles_supported?' do
     it 'return true' do
-      expect(gateway.payment_profiles_supported?).to be_true
+      expect(gateway.payment_profiles_supported?).to be true
     end
   end
 end

data/spec/models/gateway/braintree_gateway_spec.rb

@@ -1,14 +1,17 @@
 require 'spec_helper'
+require 'pry'
 
 describe Spree::Gateway::BraintreeGateway do
 
   before do
     Spree::Gateway.update_all(active: false)
-    @gateway = Spree::Gateway::BraintreeGateway.create!(name: 'Braintree Gateway', environment: 'sandbox', active: true)
-    @gateway.set_preference(:environment, 'sandbox')
-    @gateway.set_preference(:merchant_id, 'zbn5yzq9t7wmwx42')
-    @gateway.set_preference(:public_key,  'ym9djwqpkxbv3xzt')
-    @gateway.set_preference(:private_key, '4ghghkyp2yy6yqc8')
+    @gateway = Spree::Gateway::BraintreeGateway.create!(name: 'Braintree Gateway', active: true)
+    @gateway.preferences = {
+      environment: 'sandbox',
+      merchant_id: 'zbn5yzq9t7wmwx42',
+      public_key: 'ym9djwqpkxbv3xzt',
+      private_key: '4ghghkyp2yy6yqc8'
+    }
     @gateway.save!
 
     with_payment_profiles_off do
@@ -29,30 +32,112 @@ describe Spree::Gateway::BraintreeGateway do
       order = create(:order_with_totals, bill_address: address, ship_address: address)
       order.update!
 
+      # Use a valid CC from braintree sandbox: https://www.braintreepayments.com/docs/ruby/reference/sandbox
+
       @credit_card = create(:credit_card,
         verification_value: '123',
-        number:             '5105105105105100',
+        number:             '5555555555554444',
         month:              9,
         year:               Time.now.year + 1,
-        first_name:         'John',
-        last_name:          'Doe',
+        name:               'John Doe',
         cc_type:            'mastercard')
 
       @payment = create(:payment, source: @credit_card, order: order, payment_method: @gateway, amount: 10.00)
-      @payment.payment_method.environment = 'test'
     end
   end
 
+  describe 'payment profile creation' do
+    before do
+      country = create(:country, name: 'United States', iso_name: 'UNITED STATES', iso3: 'USA', iso: 'US', numcode: 840)
+      state   = create(:state, name: 'Maryland', abbr: 'MD', country: country)
+      address = create(:address,
+        firstname: 'John',
+        lastname:  'Doe',
+        address1:  '1234 My Street',
+        address2:  'Apt 1',
+        city:      'Washington DC',
+        zipcode:   '20123',
+        phone:     '(555)555-5555',
+        state:     state,
+        country:   country
+      )
+      @address = address
+
+      order = create(:order_with_totals, bill_address: address, ship_address: address)
+      order.update!
+
+      @credit_card = create(:credit_card,
+        verification_value: '123',
+        number:             '5555555555554444',
+        month:              9,
+        year:               Time.now.year + 1,
+        name:               'John Doe',
+        cc_type:            'mastercard')
+
+      @payment = create(:payment, source: @credit_card, order: order, payment_method: @gateway, amount: 10.00)
+    end
+
+    context 'when a credit card is created' do
+      it 'it has the address associated on the remote payment profile' do
+        remote_customer = @gateway.provider.instance_variable_get(:@braintree_gateway).customer.find(@credit_card.gateway_customer_profile_id)
+        remote_address = remote_customer.addresses.first rescue nil
+        expect(remote_address).not_to be_nil
+        expect(remote_address.street_address).to eq(@address.address1)
+        expect(remote_address.extended_address).to eq(@address.address2)
+        expect(remote_address.locality).to eq(@address.city)
+        expect(remote_address.region).to eq(@address.state.name)
+        expect(remote_address.country_code_alpha2).to eq(@address.country.iso)
+        expect(remote_address.postal_code).to eq(@address.zipcode)
+      end
+    end
+
+  end
+
+  describe 'payment profile failure' do
+    before do
+      country = create(:country, name: 'United States', iso_name: 'UNITED STATES', iso3: 'USA', iso: 'US', numcode: 840)
+      state   = create(:state, name: 'Maryland', abbr: 'MD', country: country)
+      address = create(:address,
+        firstname: 'John',
+        lastname:  'Doe',
+        address1:  '1234 My Street',
+        address2:  'Apt 1',
+        city:      'Washington DC',
+        zipcode:   '20123',
+        phone:     '(555)555-5555',
+        state:     state,
+        country:   country
+      )
+      @address = address
+
+      order = create(:order_with_totals, bill_address: address, ship_address: address)
+      order.update!
+
+      @credit_card = create(:credit_card,
+        verification_value: '123',
+        number:             '5105105105105100',
+        month:              9,
+        year:               Time.now.year + 1,
+        name:               'John Doe',
+        cc_type:            'mastercard')
+    end
+
+    it 'should fail creation' do
+      expect{ create(:payment, source: @credit_card, order: order, payment_method: @gateway, amount: 10.00) }.to raise_error
+    end
+
+  end
+
   describe 'merchant_account_id' do
     before do
-      @gateway.set_preference(:merchant_account_id, merchant_account_id)
+      @gateway.preferences[:merchant_account_id] = merchant_account_id
     end
 
     context 'with merchant_account_id empty' do
       let(:merchant_account_id) { '' }
 
       it 'does not be present in options' do
-        expect(@gateway.options.keys.include?(:merchant_account_id)).to be_false
+        expect(@gateway.options.keys.include?(:merchant_account_id)).to be false
       end
     end
 
@@ -64,11 +149,11 @@ describe Spree::Gateway::BraintreeGateway do
       end
 
       it 'have a preferences[:merchant_account_id]' do
-        expect(@gateway.preferences.keys.include?(:merchant_account_id)).to be_true
+        expect(@gateway.preferences.keys.include?(:merchant_account_id)).to be true
       end
 
       it 'is present in options' do
-        expect(@gateway.options.keys.include?(:merchant_account_id)).to be_true
+        expect(@gateway.options.keys.include?(:merchant_account_id)).to be true
       end
     end
   end
@@ -81,7 +166,7 @@ describe Spree::Gateway::BraintreeGateway do
 
   context '.payment_profiles_supported?' do
     it 'return true' do
-      expect(@gateway.payment_profiles_supported?).to be_true
+      expect(@gateway.payment_profiles_supported?).to be true
     end
   end
 
@@ -92,10 +177,41 @@ describe Spree::Gateway::BraintreeGateway do
   end
 
   describe 'authorize' do
+    context "the credit card has a token" do
+      before(:each) do
+        @credit_card.update_attributes(gateway_payment_profile_id: 'test')
+      end
+
+      it 'calls provider#authorize using the gateway_payment_profile_id' do
+        expect(@gateway.provider).to receive(:authorize).with(500, 'test', { payment_method_token: true } )
+        @gateway.authorize(500, @credit_card)
+      end
+    end
+
+    context "the given credit card does not have a token" do
+      context "the credit card has a customer profile id" do
+        before(:each) do
+          @credit_card.update_attributes(gateway_customer_profile_id: '12345')
+        end
+
+        it 'calls provider#authorize using the gateway_customer_profile_id' do
+          expect(@gateway.provider).to receive(:authorize).with(500, '12345', {})
+          @gateway.authorize(500, @credit_card)
+        end
+      end
+
+      context "no customer profile id" do
+        it 'calls provider#authorize with the credit card object' do
+          expect(@gateway.provider).to receive(:authorize).with(500, @credit_card, {})
+          @gateway.authorize(500, @credit_card)
+        end
+      end
+    end
+
     it 'return a success response with an authorization code' do
       result = @gateway.authorize(500, @credit_card)
 
-      expect(result.success?).to be_true
+      expect(result.success?).to be true
       expect(result.authorization).to match /\A\w{6}\z/
       expect(Braintree::Transaction::Status::Authorized).to eq Braintree::Transaction.find(result.authorization).status
     end
@@ -123,7 +239,7 @@ describe Spree::Gateway::BraintreeGateway do
 
     context 'when the card is a mastercard' do
       before do
-        @credit_card.number = '5105105105105100'
+        @credit_card.number = '5555555555554444'
         @credit_card.cc_type = 'mastercard'
         @credit_card.save
       end
@@ -182,8 +298,8 @@ describe Spree::Gateway::BraintreeGateway do
       transaction = ::Braintree::Transaction.find(@payment.response_code)
       expect(transaction.status).to eq Braintree::Transaction::Status::Authorized
 
-      capture_result = @gateway.capture(@payment,:ignored_arg_credit_card, :ignored_arg_options)
-      expect(capture_result.success?).to be_true
+      capture_result = @gateway.capture(@payment.amount, @payment.response_code)
+      expect(capture_result.success?).to be true
 
       transaction = ::Braintree::Transaction.find(@payment.response_code)
       expect(transaction.status).to eq Braintree::Transaction::Status::SubmittedForSettlement
@@ -199,20 +315,17 @@ describe Spree::Gateway::BraintreeGateway do
       transaction = ::Braintree::Transaction.find(@payment.response_code)
       expect(transaction.status).to eq Braintree::Transaction::Status::Authorized
 
-      pending 'undefined method reopen for nil:NilClass'
-      @payment.payment_source.capture(@payment) # as done in PaymentsController#fire
+      @payment.capture! # as done in PaymentsController#fire
       transaction = ::Braintree::Transaction.find(@payment.response_code)
       expect(transaction.status).to eq Braintree::Transaction::Status::SubmittedForSettlement
-      expect {
-        @payment.payment_source.capture(@payment)
-      }.to raise_error(Spree::Core::GatewayError, 'Cannot submit for settlement unless status is authorized. (91507)')
+      expect(@payment.completed?).to be true
     end
   end
 
   context 'purchase' do
     it 'return a success response with an authorization code' do
       result =  @gateway.purchase(500, @credit_card)
-      expect(result.success?).to be_true
+      expect(result.success?).to be true
       expect(result.authorization).to match /\A\w{6}\z/
       expect(Braintree::Transaction::Status::SubmittedForSettlement).to eq Braintree::Transaction.find(result.authorization).status
     end
@@ -234,14 +347,18 @@ describe Spree::Gateway::BraintreeGateway do
 
   context 'credit' do
     it 'work through the spree interface' do
-      pending 'undefined method credit for #<TestCard:0x007fdba1809ad8>'
       @payment.amount += 100.00
       purchase_using_spree_interface
+      skip "Braintree does not provide a way to settle a transaction manually: https://twitter.com/braintree/status/446099537224933376"
       credit_using_spree_interface
     end
   end
 
   context 'void' do
+    before do
+      Spree::Config.set(auto_capture: true)
+    end
+
     it 'work through the spree credit_card / payment interface' do
       expect(@payment.log_entries.size).to eq(0)
       @payment.process!
@@ -249,11 +366,10 @@ describe Spree::Gateway::BraintreeGateway do
       expect(@payment.log_entries.size).to eq(1)
       expect(@payment.response_code).to match /\A\w{6}\z/
 
-      pending 'expected: submitted_for_settlement got: authorized'
       transaction = Braintree::Transaction.find(@payment.response_code)
       expect(transaction.status).to eq Braintree::Transaction::Status::SubmittedForSettlement
 
-      @credit_card.void(@payment)
+      @payment.void_transaction!
       transaction = Braintree::Transaction.find(transaction.id)
       expect(transaction.status).to eq Braintree::Transaction::Status::Voided
     end
@@ -261,7 +377,7 @@ describe Spree::Gateway::BraintreeGateway do
 
   context 'update_card_number' do
     it 'passes through gateway_payment_profile_id' do
-      credit_card = { 'token' => 'testing', 'last_4' => '1234', 'masked_number' => '5555**5555' }
+      credit_card = { 'token' => 'testing', 'last_4' => '1234', 'masked_number' => '555555******4444' }
       @gateway.update_card_number(@payment.source, credit_card)
       expect(@payment.source.gateway_payment_profile_id).to eq 'testing'
     end
@@ -269,7 +385,7 @@ describe Spree::Gateway::BraintreeGateway do
 
   def credit_using_spree_interface
     expect(@payment.log_entries.size).to eq(1)
-    @payment.source.credit(@payment) # as done in PaymentsController#fire
+    @payment.credit!
     expect(@payment.log_entries.size).to eq(2)
 
     # Let's get the payment record associated with the credit
@@ -279,7 +395,7 @@ describe Spree::Gateway::BraintreeGateway do
     transaction = ::Braintree::Transaction.find(@payment.response_code)
     expect(transaction.type).to eq Braintree::Transaction::Type::Credit
     expect(transaction.status).to eq Braintree::Transaction::Status::SubmittedForSettlement
-    expect(transaction.credit_card_details.masked_number).to eq '510510******5100'
+    expect(transaction.credit_card_details.masked_number).to eq '555555******4444'
     expect(transaction.credit_card_details.expiration_date).to eq "09/#{Time.now.year + 1}"
     expect(transaction.customer_details.first_name).to eq 'John'
     expect(transaction.customer_details.last_name).to eq 'Doe'
@@ -296,7 +412,7 @@ describe Spree::Gateway::BraintreeGateway do
 
     transaction = ::Braintree::Transaction.find(@payment.response_code)
     expect(Braintree::Transaction::Status::SubmittedForSettlement).to eq transaction.status
-    expect(transaction.credit_card_details.masked_number).to eq '510510******5100'
+    expect(transaction.credit_card_details.masked_number).to eq '555555******4444'
     expect(transaction.credit_card_details.expiration_date).to eq "09/#{Time.now.year + 1}"
     expect(transaction.customer_details.first_name).to eq 'John'
     expect(transaction.customer_details.last_name).to eq 'Doe'

data/spec/models/gateway/cyber_source_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Spree::Gateway::CyberSource do
+  let(:gateway) { described_class.create!(name: 'CyberSource') }
+
+  context '.provider_class' do
+    it 'is a CyberSource gateway' do
+      expect(subject.provider_class).to eq ::ActiveMerchant::Billing::CyberSourceGateway
+    end
+  end
+end

data/spec/models/gateway/eway_spec.rb

@@ -11,19 +11,19 @@ describe Spree::Gateway::Eway do
 
   context '.auto_capture?' do
     it 'supports purchase method only' do
-      expect(gateway.auto_capture?).to be_true
+      expect(gateway.auto_capture?).to be true
     end
   end
 
   describe 'options' do
     it 'include :test => true in  when :test_mode is true' do
       gateway.preferred_test_mode = true
-      expect(gateway.options[:test]).to be_true
+      expect(gateway.options[:test]).to be true
     end
 
     it 'does not include :test when test_mode is false' do
       gateway.preferred_test_mode = false
-      expect(gateway.options[:test]).to be_false
+      expect(gateway.options[:test]).to be false
     end
   end
 end

data/spec/models/gateway/maxipago_spec.rb

@@ -11,7 +11,7 @@ describe Spree::Gateway::Maxipago do
 
   context '.auto_capture?' do
     it 'return true' do
-      expect(subject.auto_capture?).to be_true
+      expect(subject.auto_capture?).to be true
     end
   end
 end

data/spec/models/gateway/pay_junction_spec.rb

@@ -12,12 +12,12 @@ describe Spree::Gateway::PayJunction do
   describe 'options' do
     it 'include :test => true in  when :test_mode is true' do
       gateway.preferred_test_mode = true
-      expect(gateway.options[:test]).to be_true
+      expect(gateway.options[:test]).to be true
     end
 
     it 'does not include :test when test_mode is false' do
       gateway.preferred_test_mode = false
-      expect(gateway.options[:test]).to be_false
+      expect(gateway.options[:test]).to be false
     end
   end
 end

data/spec/models/gateway/payflow_pro_spec.rb

@@ -12,12 +12,12 @@ describe Spree::Gateway::PayflowPro do
   describe 'options' do
     it 'include :test => true when :test_mode is true' do
       gateway.preferred_test_mode = true
-      expect(gateway.options[:test]).to be_true
+      expect(gateway.options[:test]).to be true
     end
 
     it 'does not include :test when test_mode is false' do
       gateway.preferred_test_mode = false
-      expect(gateway.options[:test]).to be_false
+      expect(gateway.options[:test]).to be false
     end
   end
 end