spree_frontend 3.3.0.rc1 → 3.3.0.rc2

data/spec/controllers/spree/checkout_controller_with_views_spec.rb

@@ -1,36 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-# This spec is useful for when we just want to make sure a view is rendering correctly
-# Walking through the entire checkout process is rather tedious, don't you think?
-describe Spree::CheckoutController, type: :controller do
-  render_views
-  let(:token) { 'some_token' }
-  let(:user) { stub_model(Spree::LegacyUser) }
-
-  before do
-    allow(controller).to receive_messages try_spree_current_user: user
-  end
-
-  # Regression test for #3246
-  context "when using GBP" do
-    before do
-      Spree::Config[:currency] = "GBP"
-    end
-
-    context "when order is in delivery" do
-      before do
-        # Using a let block won't acknowledge the currency setting
-        # Therefore we just do it like this...
-        order = OrderWalkthrough.up_to(:delivery)
-        allow(controller).to receive_messages current_order: order
-      end
-
-      it "displays rate cost in correct currency" do
-        spree_get :edit
-        html = Nokogiri::HTML(response.body)
-        expect(html.css('.rate-cost').text).to eq "£10.00"
-      end
-    end
-  end
-end

data/spec/controllers/spree/content_controller_spec.rb

@@ -1,12 +0,0 @@
-require 'spec_helper'
-describe Spree::ContentController, type: :controller do
-  it "should not display a local file" do
-    spree_get :show, path: "../../Gemfile"
-    expect(response.response_code).to eq(404)
-  end
-
-  it "should display CVV page" do
-    spree_get :cvv
-    expect(response.response_code).to eq(200)
-  end
-end

data/spec/controllers/spree/current_order_tracking_spec.rb

@@ -1,44 +0,0 @@
-require 'spec_helper'
-
-describe 'current order tracking', type: :controller do
-  let(:user) { create(:user) }
-
-  controller(Spree::StoreController) do
-    def index
-      head :ok
-    end
-  end
-
-  let(:order) { FactoryGirl.create(:order) }
-
-  it 'automatically tracks who the order was created by & IP address' do
-    allow(controller).to receive_messages(try_spree_current_user: user)
-    get :index
-    expect(controller.current_order(create_order_if_necessary: true).created_by).to eq controller.try_spree_current_user
-    expect(controller.current_order.last_ip_address).to eq "0.0.0.0"
-  end
-
-  context "current order creation" do
-    before { allow(controller).to receive_messages(try_spree_current_user: user) }
-
-    it "doesn't create a new order out of the blue" do
-      expect {
-        spree_get :index
-      }.not_to change { Spree::Order.count }
-    end
-  end
-end
-
-describe Spree::OrdersController, type: :controller do
-  let(:user) { create(:user) }
-
-  before { allow(controller).to receive_messages(try_spree_current_user: user) }
-
-  describe Spree::OrdersController do
-    it "doesn't create a new order out of the blue" do
-      expect {
-        spree_get :edit
-      }.not_to change { Spree::Order.count }
-    end
-  end
-end

data/spec/controllers/spree/home_controller_spec.rb

@@ -1,47 +0,0 @@
-require 'spec_helper'
-
-describe Spree::HomeController, type: :controller do
-  it "provides current user to the searcher class" do
-    user = mock_model(Spree.user_class, last_incomplete_spree_order: nil, spree_api_key: 'fake')
-    allow(controller).to receive_messages try_spree_current_user: user
-    expect_any_instance_of(Spree::Config.searcher_class).to receive(:current_user=).with(user)
-    spree_get :index
-    expect(response.status).to eq(200)
-  end
-
-  context "layout" do
-    it "renders default layout" do
-      spree_get :index
-      expect(response).to render_template(layout: 'spree/layouts/spree_application')
-    end
-
-    context "different layout specified in config" do
-      before { Spree::Config.layout = 'layouts/application' }
-
-      it "renders specified layout" do
-        spree_get :index
-        expect(response).to render_template(layout: 'layouts/application')
-      end
-    end
-  end
-
-  context "index products" do
-    it "calls includes when the retrieved_products object responds to it" do
-      searcher = double("Searcher")
-      allow(controller).to receive_messages build_searcher: searcher
-      expect(searcher).to receive_message_chain("retrieve_products.includes")
-
-      spree_get :index
-    end
-
-    it "does not call includes when it's not available" do
-      searcher = double("Searcher")
-      allow(controller).to receive_messages build_searcher: searcher
-      allow(searcher).to receive(:retrieve_products).and_return([])
-
-      spree_get :index
-
-      expect(assigns(:products)).to eq([])
-    end
-  end
-end

data/spec/controllers/spree/orders_controller_ability_spec.rb

@@ -1,96 +0,0 @@
-require 'spec_helper'
-
-module Spree
-  describe OrdersController, type: :controller do
-    let(:user) { create(:user) }
-    let(:guest_user) { create(:user) }
-    let(:order) { Spree::Order.create }
-
-    context 'when an order exists in the cookies.signed' do
-      let(:token) { 'some_token' }
-      let(:specified_order) { create(:order) }
-
-      before do
-        cookies.signed[:guest_token] = token
-        allow(controller).to receive_messages current_order: order
-        allow(controller).to receive_messages spree_current_user: user
-      end
-
-      context '#populate' do
-        it 'should check if user is authorized for :edit' do
-          expect(controller).to receive(:authorize!).with(:edit, order, token)
-          spree_post :populate
-        end
-        it "should check against the specified order" do
-          expect(controller).to receive(:authorize!).with(:edit, specified_order, token)
-          spree_post :populate, id: specified_order.number
-        end
-      end
-
-      context '#edit' do
-        it 'should check if user is authorized for :edit' do
-          expect(controller).to receive(:authorize!).with(:edit, order, token)
-          spree_get :edit
-        end
-        it "should check against the specified order" do
-          expect(controller).to receive(:authorize!).with(:edit, specified_order, token)
-          spree_get :edit, id: specified_order.number
-        end
-      end
-
-      context '#update' do
-        it 'should check if user is authorized for :edit' do
-          allow(order).to receive :update_attributes
-          expect(controller).to receive(:authorize!).with(:edit, order, token)
-          spree_post :update, order: { email: "foo@bar.com" }
-        end
-        it "should check against the specified order" do
-          allow(order).to receive :update_attributes
-          expect(controller).to receive(:authorize!).with(:edit, specified_order, token)
-          spree_post :update, order: { email: "foo@bar.com" }, id: specified_order.number
-        end
-      end
-
-      context '#empty' do
-        it 'should check if user is authorized for :edit' do
-          expect(controller).to receive(:authorize!).with(:edit, order, token)
-          spree_post :empty
-        end
-        it "should check against the specified order" do
-          expect(controller).to receive(:authorize!).with(:edit, specified_order, token)
-          spree_post :empty, id: specified_order.number
-        end
-      end
-
-      context "#show" do
-        it "should check against the specified order" do
-          expect(controller).to receive(:authorize!).with(:edit, specified_order, token)
-          spree_get :show, id: specified_order.number
-        end
-      end
-    end
-
-    context 'when no authenticated user' do
-      let(:order) { create(:order, number: 'R123') }
-
-      context '#show' do
-        context 'when guest_token correct' do
-          before { cookies.signed[:guest_token] = order.guest_token }
-
-          it 'displays the page' do
-            expect(controller).to receive(:authorize!).with(:edit, order, order.guest_token)
-            spree_get :show, { id: 'R123' }
-            expect(response.code).to eq('200')
-          end
-        end
-
-        context 'when guest_token not present' do
-          it 'should respond with 404' do
-            spree_get :show, { id: 'R123'}
-            expect(response.code).to eq('404')
-          end
-        end
-      end
-    end
-  end
-end

data/spec/controllers/spree/orders_controller_spec.rb

@@ -1,134 +0,0 @@
-require 'spec_helper'
-
-describe Spree::OrdersController, type: :controller do
-  let(:user) { create(:user) }
-
-  context "Order model mock" do
-    let(:order) do
-      Spree::Order.create!
-    end
-    let(:variant) { create(:variant) }
-
-    before do
-      allow(controller).to receive_messages(try_spree_current_user: user)
-    end
-
-    context "#populate" do
-      it "should create a new order when none specified" do
-        spree_post :populate, {}, {}
-        expect(cookies.signed[:guest_token]).not_to be_blank
-        expect(Spree::Order.find_by_guest_token(cookies.signed[:guest_token])).to be_persisted
-      end
-
-      context "with Variant" do
-        it "should handle population" do
-          expect do
-            spree_post :populate, variant_id: variant.id, quantity: 5
-          end.to change { user.orders.count }.by(1)
-          order = user.orders.last
-          expect(response).to redirect_to spree.cart_path
-          expect(order.line_items.size).to eq(1)
-          line_item = order.line_items.first
-          expect(line_item.variant_id).to eq(variant.id)
-          expect(line_item.quantity).to eq(5)
-        end
-
-        it "shows an error when population fails" do
-          request.env["HTTP_REFERER"] = '/dummy_redirect'
-          allow_any_instance_of(Spree::LineItem).to(
-            receive(:valid?).and_return(false)
-          )
-          allow_any_instance_of(Spree::LineItem).to(
-            receive_message_chain(:errors, :full_messages).
-              and_return(["Order population failed"])
-          )
-
-          spree_post :populate, variant_id: variant.id, quantity: 5
-
-          expect(response).to redirect_to('/dummy_redirect')
-          expect(flash[:error]).to eq("Order population failed")
-        end
-
-        it "shows an error when quantity is invalid" do
-          request.env["HTTP_REFERER"] = '/dummy_redirect'
-
-          spree_post(
-            :populate,
-            variant_id: variant.id, quantity: -1
-          )
-
-          expect(response).to redirect_to('/dummy_redirect')
-          expect(flash[:error]).to eq(
-            Spree.t(:please_enter_reasonable_quantity)
-          )
-        end
-      end
-    end
-
-    context "#update" do
-      context "with authorization" do
-        before do
-          allow(controller).to receive :check_authorization
-          allow(controller).to receive_messages current_order: order
-        end
-
-        it "should render the edit view (on failure)" do
-          # email validation is only after address state
-          order.update_column(:state, "delivery")
-          spree_put :update, { order: { email: "" } }, { order_id: order.id }
-          expect(response).to render_template :edit
-        end
-
-        it "should redirect to cart path (on success)" do
-          allow(order).to receive(:update_attributes).and_return true
-          spree_put :update, {}, {order_id: 1}
-          expect(response).to redirect_to(spree.cart_path)
-        end
-      end
-    end
-
-    context "#empty" do
-      before do
-        allow(controller).to receive :check_authorization
-      end
-
-      it "should destroy line items in the current order" do
-        allow(controller).to receive(:current_order).and_return(order)
-        expect(order).to receive(:empty!)
-        spree_put :empty
-        expect(response).to redirect_to(spree.cart_path)
-      end
-    end
-
-    # Regression test for #2750
-    context "#update" do
-      before do
-        allow(user).to receive :last_incomplete_spree_order
-        allow(controller).to receive :set_current_order
-      end
-
-      it "cannot update a blank order" do
-        spree_put :update, order: { email: "foo" }
-        expect(flash[:error]).to eq(Spree.t(:order_not_found))
-        expect(response).to redirect_to(spree.root_path)
-      end
-    end
-  end
-
-  context "line items quantity is 0" do
-    let(:order) { Spree::Order.create }
-    let(:variant) { create(:variant) }
-    let!(:line_item) { order.contents.add(variant, 1) }
-
-    before do
-      allow(controller).to receive(:check_authorization)
-      allow(controller).to receive_messages(current_order: order)
-    end
-
-    it "removes line items on update" do
-      expect(order.line_items.count).to eq 1
-      spree_put :update, order: { line_items_attributes: { "0" => { id: line_item.id, quantity: 0 } } }
-      expect(order.reload.line_items.count).to eq 0
-    end
-  end
-end

data/spec/controllers/spree/orders_controller_transitions_spec.rb

@@ -1,31 +0,0 @@
-require 'spec_helper'
-
-Spree::Order.class_eval do
-  attr_accessor :did_transition
-end
-
-module Spree
-  describe OrdersController, type: :controller do
-    # Regression test for #2004
-    context "with a transition callback on first state" do
-      let(:order) { Spree::Order.new }
-
-      before do
-        allow(controller).to receive_messages current_order: order
-        expect(controller).to receive(:authorize!).at_least(:once).and_return(true)
-
-        first_state, _ = Spree::Order.checkout_steps.first
-        Spree::Order.state_machine.after_transition to: first_state do |order|
-          order.did_transition = true
-        end
-      end
-
-      it "correctly calls the transition callback" do
-        expect(order.did_transition).to be_nil
-        order.line_items << FactoryGirl.create(:line_item)
-        spree_put :update, { checkout: "checkout" }, { order_id: 1}
-        expect(order.did_transition).to be true
-      end
-    end
-  end
-end

data/spec/controllers/spree/products_controller_spec.rb

@@ -1,87 +0,0 @@
-require 'spec_helper'
-
-describe Spree::ProductsController, type: :controller do
-  let!(:product) { create(:product, available_on: 1.year.from_now) }
-  let(:taxon) { create(:taxon) }
-
-  # Regression test for #1390
-  it "allows admins to view non-active products" do
-    allow(controller).to receive_messages spree_current_user: mock_model(Spree.user_class, has_spree_role?: true, last_incomplete_spree_order: nil, spree_api_key: 'fake')
-    spree_get :show, id: product.to_param
-    expect(response.status).to eq(200)
-  end
-
-  it "cannot view non-active products" do
-    spree_get :show, id: product.to_param
-    expect(response.status).to eq(404)
-  end
-
-  it "should provide the current user to the searcher class" do
-    user = mock_model(Spree.user_class, last_incomplete_spree_order: nil, spree_api_key: 'fake')
-    allow(controller).to receive_messages spree_current_user: user
-    expect_any_instance_of(Spree::Config.searcher_class).to receive(:current_user=).with(user)
-    spree_get :index
-    expect(response.status).to eq(200)
-  end
-
-  # Regression test for #2249
-  it "doesn't error when given an invalid referer" do
-    current_user = mock_model(Spree.user_class, has_spree_role?: true, last_incomplete_spree_order: nil, generate_spree_api_key!: nil)
-    allow(controller).to receive_messages spree_current_user: current_user
-    request.env['HTTP_REFERER'] = "not|a$url"
-
-    # Previously a URI::InvalidURIError exception was being thrown
-    expect { spree_get :show, id: product.to_param }.not_to raise_error
-  end
-
-  context 'with history slugs present' do
-    let!(:product) { create(:product, available_on: 1.day.ago) }
-
-    it 'will redirect with a 301 with legacy url used' do
-      legacy_params = product.to_param
-      product.name = product.name + " Brand New"
-      product.slug = nil
-      product.save!
-      spree_get :show, id: legacy_params
-      expect(response.status).to eq(301)
-    end
-
-    it 'will redirect with a 301 with id used' do
-      product.name = product.name + " Brand New"
-      product.slug = nil
-      product.save!
-      spree_get :show, id: product.id
-      expect(response.status).to eq(301)
-    end
-
-    it "will keep url params on legacy url redirect" do
-      legacy_params = product.to_param
-      product.name = product.name + " Brand New"
-      product.slug = nil
-      product.save!
-      spree_get :show, id: legacy_params, taxon_id: taxon.id
-      expect(response.status).to eq(301)
-      expect(response.header["Location"]).to include("taxon_id=#{taxon.id}")
-    end
-  end
-
-  context "index products" do
-    it "calls includes when the retrieved_products object responds to it" do
-      searcher = double("Searcher")
-      allow(controller).to receive_messages build_searcher: searcher
-      expect(searcher).to receive_message_chain("retrieve_products.includes")
-
-      spree_get :index
-    end
-
-    it "does not call includes when it's not available" do
-      searcher = double("Searcher")
-      allow(controller).to receive_messages build_searcher: searcher
-      allow(searcher).to receive(:retrieve_products).and_return([])
-
-      spree_get :index
-
-      expect(assigns(:products)).to eq([])
-    end
-  end
-end