spree_frontend 3.2.9 → 3.3.0.rc1

data/spec/features/products_spec.rb

@@ -0,0 +1,345 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe "Visiting Products", type: :feature, inaccessible: true do
+  include_context "custom products"
+
+  let(:store_name) do
+    ((first_store = Spree::Store.first) && first_store.name).to_s
+  end
+
+  before(:each) do
+    visit spree.root_path
+  end
+
+  it "should be able to show the shopping cart after adding a product to it" do
+    click_link "Ruby on Rails Ringer T-Shirt"
+    expect(page).to have_content("$19.99")
+
+    click_button 'add-to-cart-button'
+    expect(page).to have_content("Shopping Cart")
+  end
+
+  describe "correct displaying of microdata" do
+    let(:product) { Spree::Product.find_by(name: 'Ruby on Rails Ringer T-Shirt') }
+
+    it "on products page" do
+      within("#product_#{product.id}") do
+        within('[itemprop=name]') do
+          expect(page).to have_content('Ruby on Rails Ringer T-Shirt')
+        end
+        expect(page).to have_css("[itemprop='price'][content='19.99']")
+        expect(page).to have_css("[itemprop='priceCurrency'][content='USD']")
+        expect(page).to have_css("[itemprop='url'][href='/products/ruby-on-rails-ringer-t-shirt']")
+        expect(page).to have_css("[itemprop='image'][src*='/assets/noimage/small']")
+      end
+    end
+
+    it "on product page" do
+      click_link product.name
+      within('[data-hook=product_show]') do
+        within('[itemprop=name]') do
+          expect(page).to have_content('Ruby on Rails Ringer T-Shirt')
+        end
+        expect(page).to have_css("[itemprop='price'][content='19.99']")
+        expect(page).to have_css("[itemprop='priceCurrency'][content='USD']")
+        expect(page).to have_css("[itemprop='image'][src*='/assets/noimage/product']")
+      end
+    end
+  end
+
+  describe 'meta tags and title' do
+    let(:jersey) { Spree::Product.find_by_name('Ruby on Rails Baseball Jersey') }
+    let(:metas) { { meta_description: 'Brand new Ruby on Rails Jersey', meta_title: 'Ruby on Rails Baseball Jersey Buy High Quality Geek Apparel', meta_keywords: 'ror, jersey, ruby' } }
+
+    it 'should return the correct title when displaying a single product' do
+      click_link jersey.name
+      expect(page).to have_title('Ruby on Rails Baseball Jersey - ' + store_name)
+      within('div#product-description') do
+        within('h1.product-title') do
+          expect(page).to have_content('Ruby on Rails Baseball Jersey')
+        end
+      end
+    end
+
+    it 'displays metas' do
+      jersey.update_attributes metas
+      click_link jersey.name
+      expect(page).to have_meta(:description, 'Brand new Ruby on Rails Jersey')
+      expect(page).to have_meta(:keywords, 'ror, jersey, ruby')
+    end
+
+    it 'displays title if set' do
+      jersey.update_attributes metas
+      click_link jersey.name
+      expect(page).to have_title('Ruby on Rails Baseball Jersey Buy High Quality Geek Apparel')
+    end
+
+    it "doesn't use meta_title as heading on page" do
+      jersey.update_attributes metas
+      click_link jersey.name
+      within("h1") do
+        expect(page).to have_content(jersey.name)
+        expect(page).not_to have_content(jersey.meta_title)
+      end
+    end
+
+    it 'uses product name in title when meta_title set to empty string' do
+      jersey.update_attributes meta_title: ''
+      click_link jersey.name
+      expect(page).to have_title('Ruby on Rails Baseball Jersey - ' + store_name)
+    end
+  end
+
+  context "using Russian Rubles as a currency" do
+    before do
+      Spree::Config[:currency] = "RUB"
+    end
+
+    let!(:product) do
+      product = Spree::Product.find_by_name("Ruby on Rails Ringer T-Shirt")
+      product.price = 19.99
+      product.tap(&:save)
+    end
+
+    # Regression tests for #2737
+    context "uses руб as the currency symbol" do
+      it "on products page" do
+        visit spree.root_path
+        within("#product_#{product.id}") do
+          within(".price") do
+            expect(page).to have_content("19.99 ₽")
+          end
+        end
+      end
+
+      it "on product page" do
+        visit spree.product_path(product)
+        within(".price") do
+          expect(page).to have_content("19.99 ₽")
+        end
+      end
+
+      it "when adding a product to the cart", js: true do
+        visit spree.product_path(product)
+        click_button "Add To Cart"
+        click_link "Home"
+        within(".cart-info") do
+          expect(page).to have_content("19.99 ₽")
+        end
+      end
+
+      it "when on the 'address' state of the cart", js: true do
+        visit spree.product_path(product)
+        click_button "Add To Cart"
+        click_button "Checkout"
+        fill_in "order_email", with: "test@example.com"
+        click_button 'Continue'
+        within("tr[data-hook=item_total]") do
+          expect(page).to have_content("19.99 ₽")
+        end
+      end
+    end
+  end
+
+  it "should be able to search for a product" do
+    fill_in "keywords", with: "shirt"
+    click_button "Search"
+
+    expect(page.all('#products .product-list-item').size).to eq(1)
+  end
+
+  context "a product with variants" do
+    let(:product) { Spree::Product.find_by_name("Ruby on Rails Baseball Jersey") }
+    let(:option_value) { create(:option_value) }
+    let!(:variant) { build(:variant, price: 5.59, product: product, option_values: []) }
+
+    before do
+      # Need to have two images to trigger the error
+      image = File.open(File.expand_path('../../fixtures/thinking-cat.jpg', __FILE__))
+      product.images.create!(attachment: image)
+      product.images.create!(attachment: image)
+
+      product.option_types << option_value.option_type
+      variant.option_values << option_value
+      variant.save!
+    end
+
+    it "should be displayed" do
+      expect { click_link product.name }.to_not raise_error
+    end
+
+    it "displays price of first variant listed", js: true do
+      click_link product.name
+      within("#product-price") do
+        expect(page).to have_content variant.price
+        expect(page).not_to have_content Spree.t(:out_of_stock)
+      end
+    end
+
+    it "doesn't display out of stock for master product" do
+      product.master.stock_items.update_all count_on_hand: 0, backorderable: false
+
+      click_link product.name
+      within("#product-price") do
+        expect(page).not_to have_content Spree.t(:out_of_stock)
+      end
+    end
+
+    it "doesn't display cart form if all variants (including master) are out of stock" do
+      product.variants_including_master.each { |v| v.stock_items.update_all count_on_hand: 0, backorderable: false }
+
+      click_link product.name
+      within("[data-hook=product_price]") do
+        expect(page).not_to have_content Spree.t(:add_to_cart)
+      end
+    end
+  end
+
+  context "a product with variants, images only for the variants" do
+    let(:product) { Spree::Product.find_by_name("Ruby on Rails Baseball Jersey") }
+    let(:variant1) { create(:variant, product: product, price: 9.99) }
+    let(:variant2) { create(:variant, product: product, price: 10.99) }
+
+    before do
+      image = File.open(File.expand_path('../../fixtures/thinking-cat.jpg', __FILE__))
+      variant1.images.create!(attachment: image)
+      variant2.images.create!(attachment: image)
+    end
+
+    it "should not display no image available" do
+      visit spree.root_path
+      expect(page).to have_xpath("//img[contains(@src,'thinking-cat')]")
+    end
+  end
+
+  context "an out of stock product without variants" do
+    let(:product) { Spree::Product.find_by_name("Ruby on Rails Tote") }
+
+    before do
+      product.master.stock_items.update_all count_on_hand: 0, backorderable: false
+    end
+
+    it "does display out of stock for master product" do
+      click_link product.name
+      within("#product-price") do
+        expect(page).to have_content Spree.t(:out_of_stock)
+      end
+    end
+
+    it "doesn't display cart form if master is out of stock" do
+      click_link product.name
+      within("[data-hook=product_price]") do
+        expect(page).not_to have_content Spree.t(:add_to_cart)
+      end
+    end
+  end
+
+  context 'product with taxons' do
+    let(:product) { Spree::Product.find_by_name("Ruby on Rails Tote") }
+    let(:taxon) { product.taxons.first }
+
+    it 'displays breadcrumbs for the default taxon when none selected' do
+      click_link product.name
+      within("#breadcrumbs") do
+        expect(page).to have_content taxon.name
+      end
+    end
+
+    it 'displays selected taxon in breadcrumbs' do
+      taxon = Spree::Taxon.last
+      product.taxons << taxon
+      product.save!
+      visit '/t/' + taxon.to_param
+      click_link product.name
+      within("#breadcrumbs") do
+        expect(page).to have_content taxon.name
+      end
+    end
+  end
+
+  it "should be able to hide products without price" do
+    expect(page.all('#products .product-list-item').size).to eq(9)
+    Spree::Config.show_products_without_price = false
+    Spree::Config.currency = "CAN"
+    visit spree.root_path
+    expect(page.all('#products .product-list-item').size).to eq(0)
+  end
+
+
+  it "should be able to display products priced under 10 dollars" do
+    within(:css, '#taxonomies') { click_link "Ruby on Rails" }
+    check "Price_Range_Under_$10.00"
+    within(:css, '#sidebar_products_search') { click_button "Search" }
+    expect(page).to have_content("No products found")
+  end
+
+  it "should be able to display products priced between 15 and 18 dollars" do
+    within(:css, '#taxonomies') { click_link "Ruby on Rails" }
+    check "Price_Range_$15.00_-_$18.00"
+    within(:css, '#sidebar_products_search') { click_button "Search" }
+
+    expect(page.all('#products .product-list-item').size).to eq(3)
+    tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+    tmp.delete("")
+    expect(tmp.sort!).to eq(["Ruby on Rails Mug", "Ruby on Rails Stein", "Ruby on Rails Tote"])
+  end
+
+  it "should be able to display products priced between 15 and 18 dollars across multiple pages" do
+    Spree::Config.products_per_page = 2
+    within(:css, '#taxonomies') { click_link "Ruby on Rails" }
+    check "Price_Range_$15.00_-_$18.00"
+    within(:css, '#sidebar_products_search') { click_button "Search" }
+
+    expect(page.all('#products .product-list-item').size).to eq(2)
+    products = page.all('#products .product-list-item span[itemprop=name]')
+    expect(products.count).to eq(2)
+
+    find('.pagination .next a').click
+    products = page.all('#products .product-list-item span[itemprop=name]')
+    expect(products.count).to eq(1)
+  end
+
+  it "should be able to display products priced 18 dollars and above" do
+    within(:css, '#taxonomies') { click_link "Ruby on Rails" }
+    check "Price_Range_$18.00_-_$20.00"
+    check "Price_Range_$20.00_or_over"
+    within(:css, '#sidebar_products_search') { click_button "Search" }
+
+    expect(page.all('#products .product-list-item').size).to eq(4)
+    tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+    tmp.delete("")
+    expect(tmp.sort!).to eq(["Ruby on Rails Bag",
+                         "Ruby on Rails Baseball Jersey",
+                         "Ruby on Rails Jr. Spaghetti",
+                         "Ruby on Rails Ringer T-Shirt"])
+  end
+
+  it "should be able to put a product without a description in the cart" do
+    product = FactoryGirl.create(:base_product, description: nil, name: 'Sample', price: '19.99')
+    visit spree.product_path(product)
+    expect(page).to have_content "This product has no description"
+    click_button 'add-to-cart-button'
+    expect(page).to have_content "This product has no description"
+  end
+
+  it "shouldn't be able to put a product without a current price in the cart" do
+    product = FactoryGirl.create(:base_product, description: nil, name: 'Sample', price: '19.99')
+    Spree::Config.currency = "CAN"
+    Spree::Config.show_products_without_price = true
+    visit spree.product_path(product)
+    expect(page).to have_content "This product is not available in the selected currency."
+    expect(page).not_to have_content "add-to-cart-button"
+  end
+
+  it "should return the correct title when displaying a single product" do
+    product = Spree::Product.find_by_name("Ruby on Rails Baseball Jersey")
+    click_link product.name
+
+    within("div#product-description") do
+      within("h1.product-title") do
+        expect(page).to have_content("Ruby on Rails Baseball Jersey")
+      end
+    end
+  end
+end

data/spec/features/taxons_spec.rb

@@ -0,0 +1,147 @@
+require 'spec_helper'
+
+describe "viewing products", type: :feature, inaccessible: true do
+  let!(:taxonomy) { create(:taxonomy, name: "Category") }
+  let!(:super_clothing) { taxonomy.root.children.create(name: "Super Clothing") }
+  let!(:t_shirts) { super_clothing.children.create(name: "T-Shirts") }
+  let!(:xxl) { t_shirts.children.create(name: "XXL") }
+  let!(:product) do
+    product = create(:product, name: "Superman T-Shirt")
+    product.taxons << t_shirts
+  end
+  let(:metas) { { meta_description: 'Brand new Ruby on Rails TShirts', meta_title: "Ruby On Rails TShirt", meta_keywords: 'ror, tshirt, ruby' } }
+  let(:store_name) do
+    ((first_store = Spree::Store.first) && first_store.name).to_s
+  end
+
+  # Regression test for #1796
+  it "can see a taxon's products, even if that taxon has child taxons" do
+    visit '/t/category/super-clothing/t-shirts'
+    expect(page).to have_content("Superman T-Shirt")
+  end
+
+  it "shouldn't show nested taxons with a search" do
+    visit '/t/category/super-clothing?keywords=shirt'
+    expect(page).to have_content("Superman T-Shirt")
+    expect(page).not_to have_selector("div[data-hook='taxon_children']")
+  end
+
+  describe 'breadcrumbs' do
+    before do
+      visit '/t/category/super-clothing/t-shirts'
+    end
+    it "should render breadcrumbs" do
+      expect(page.find("#breadcrumbs")).to have_link("T-Shirts")
+    end
+    it "should mark last breadcrumb as active" do
+      expect(page.find('#breadcrumbs .active')).to have_link("T-Shirts")
+    end
+  end
+
+  describe 'meta tags and title' do
+    it 'displays metas' do
+      t_shirts.update_attributes metas
+      visit '/t/category/super-clothing/t-shirts'
+      expect(page).to have_meta(:description, 'Brand new Ruby on Rails TShirts')
+      expect(page).to have_meta(:keywords, 'ror, tshirt, ruby')
+    end
+
+    it 'display title if set' do
+      t_shirts.update_attributes metas
+      visit '/t/category/super-clothing/t-shirts'
+      expect(page).to have_title("Ruby On Rails TShirt")
+    end
+
+    it 'displays title from taxon root and taxon name' do
+      visit '/t/category/super-clothing/t-shirts'
+      expect(page).to have_title('Category - T-Shirts - ' + store_name)
+    end
+
+    # Regression test for #2814
+    it "doesn't use meta_title as heading on page" do
+      t_shirts.update_attributes metas
+      visit '/t/category/super-clothing/t-shirts'
+      within("h1.taxon-title") do
+        expect(page).to have_content(t_shirts.name)
+      end
+    end
+
+    it 'uses taxon name in title when meta_title set to empty string' do
+      t_shirts.update_attributes meta_title: ''
+      visit '/t/category/super-clothing/t-shirts'
+      expect(page).to have_title('Category - T-Shirts - ' + store_name)
+    end
+  end
+
+  context "taxon pages" do
+    include_context "custom products"
+    before do
+      visit spree.root_path
+    end
+
+    it "should be able to visit brand Ruby on Rails" do
+      within(:css, '#taxonomies') { click_link "Ruby on Rails" }
+
+      expect(page.all('#products .product-list-item').size).to eq(7)
+      tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+      tmp.delete("")
+      array = ["Ruby on Rails Bag",
+       "Ruby on Rails Baseball Jersey",
+       "Ruby on Rails Jr. Spaghetti",
+       "Ruby on Rails Mug",
+       "Ruby on Rails Ringer T-Shirt",
+       "Ruby on Rails Stein",
+       "Ruby on Rails Tote"]
+      expect(tmp.sort!).to eq(array)
+    end
+
+    it "should be able to visit brand Ruby" do
+      within(:css, '#taxonomies') { click_link "Ruby" }
+
+      expect(page.all('#products .product-list-item').size).to eq(1)
+      tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+      tmp.delete("")
+      expect(tmp.sort!).to eq(["Ruby Baseball Jersey"])
+    end
+
+    it "should be able to visit brand Apache" do
+      within(:css, '#taxonomies') { click_link "Apache" }
+
+      expect(page.all('#products .product-list-item').size).to eq(1)
+      tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+      tmp.delete("")
+      expect(tmp.sort!).to eq(["Apache Baseball Jersey"])
+    end
+
+    it "should be able to visit category Clothing" do
+      click_link "Clothing"
+
+      expect(page.all('#products .product-list-item').size).to eq(5)
+      tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+      tmp.delete("")
+      expect(tmp.sort!).to eq(["Apache Baseball Jersey",
+     "Ruby Baseball Jersey",
+     "Ruby on Rails Baseball Jersey",
+     "Ruby on Rails Jr. Spaghetti",
+     "Ruby on Rails Ringer T-Shirt"])
+    end
+
+    it "should be able to visit category Mugs" do
+      click_link "Mugs"
+
+      expect(page.all('#products .product-list-item').size).to eq(2)
+      tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+      tmp.delete("")
+      expect(tmp.sort!).to eq(["Ruby on Rails Mug", "Ruby on Rails Stein"])
+    end
+
+    it "should be able to visit category Bags" do
+      click_link "Bags"
+
+      expect(page.all('#products .product-list-item').size).to eq(2)
+      tmp = page.all('#products .product-list-item a').map(&:text).flatten.compact
+      tmp.delete("")
+      expect(tmp.sort!).to eq(["Ruby on Rails Bag", "Ruby on Rails Tote"])
+    end
+  end
+end

data/spec/features/template_rendering_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe "Template rendering", type: :feature do
+
+  after do
+    Capybara.ignore_hidden_elements = true
+  end
+
+  before do
+    Capybara.ignore_hidden_elements = false
+  end
+
+  it 'layout should have canonical tag referencing site url' do
+    Spree::Store.create!(code: 'spree', name: 'My Spree Store', url: 'spreestore.example.com', mail_from_address: 'test@example.com')
+
+    visit spree.root_path
+    expect(find('link[rel=canonical]')[:href]).to eql('http://spreestore.example.com/')
+  end
+end

data/spec/helpers/frontend_helper_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+module Spree
+  describe FrontendHelper, type: :helper do
+    # Regression test for #2034
+    context "flash_message" do
+      let(:flash) { { "notice" => "ok", "foo" => "foo", "bar" => "bar" } }
+
+      it "should output all flash content" do
+        flash_messages
+        html = Nokogiri::HTML(helper.output_buffer)
+        expect(html.css(".alert-notice").text).to eq("ok")
+        expect(html.css(".alert-foo").text).to eq("foo")
+        expect(html.css(".alert-bar").text).to eq("bar")
+      end
+
+      it "should output flash content except one key" do
+        flash_messages(ignore_types: :bar)
+        html = Nokogiri::HTML(helper.output_buffer)
+        expect(html.css(".alert-notice").text).to eq("ok")
+        expect(html.css(".alert-foo").text).to eq("foo")
+        expect(html.css(".alert-bar").text).to be_empty
+      end
+
+      it "should output flash content except some keys" do
+        flash_messages(ignore_types: [:foo, :bar])
+        html = Nokogiri::HTML(helper.output_buffer)
+        expect(html.css(".alert-notice").text).to eq("ok")
+        expect(html.css(".alert-foo").text).to be_empty
+        expect(html.css(".alert-bar").text).to be_empty
+        expect(helper.output_buffer).to eq("<div class=\"alert alert-notice\">ok</div>")
+      end
+    end
+
+    # Regression test for #2759
+    it "nested_taxons_path works with a Taxon object" do
+      taxon = create(:taxon, name: "iphone")
+      expect(spree.nested_taxons_path(taxon)).to eq("/t/iphone")
+    end
+
+    context '#checkout_progress' do
+      before do
+        @order = create(:order, state: 'address')
+      end
+
+      it 'does not include numbers by default' do
+        output = checkout_progress
+        expect(output).to_not include('1.')
+      end
+
+      it 'has option to include numbers' do
+        output = checkout_progress(numbers: true)
+        expect(output).to include('1.')
+      end
+    end
+  end
+end

data/spec/helpers/taxons_helper_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe Spree::TaxonsHelper, type: :helper do
+  # Regression test for #4382
+  it "#taxon_preview" do
+    taxon = create(:taxon)
+    child_taxon = create(:taxon, parent: taxon)
+    product_1 = create(:product)
+    product_2 = create(:product)
+    product_3 = create(:product)
+    taxon.products << product_1
+    taxon.products << product_2
+    child_taxon.products << product_3
+
+    expect(taxon_preview(taxon.reload)).to eql([product_1, product_2, product_3])
+  end
+end