spree_frontend 3.1.14 → 3.2.0.rc1

data/spec/controllers/spree/taxons_controller_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Spree::TaxonsController, type: :controller do
+  it "should provide the current user to the searcher class" do
+    taxon = create(:taxon, permalink: "test")
+    user = mock_model(Spree.user_class, last_incomplete_spree_order: nil, spree_api_key: 'fake')
+    allow(controller).to receive_messages spree_current_user: user
+    expect_any_instance_of(Spree::Config.searcher_class).to receive(:current_user=).with(user)
+    spree_get :show, id: taxon.permalink
+    expect(response.status).to eq(200)
+  end
+end

data/spec/features/address_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+describe "Address", type: :feature, inaccessible: true do
+  let!(:product) { create(:product, name: "RoR Mug") }
+  let!(:order) { create(:order_with_totals, state: 'cart') }
+
+  stub_authorization!
+
+  after do
+    Capybara.ignore_hidden_elements = true
+  end
+
+  before do
+    Capybara.ignore_hidden_elements = false
+
+    visit spree.root_path
+
+    click_link "RoR Mug"
+    click_button "add-to-cart-button"
+
+    address = "order_bill_address_attributes"
+    @country_css = "#{address}_country_id"
+    @state_select_css = "##{address}_state_id"
+    @state_name_css = "##{address}_state_name"
+  end
+
+  context "country requires state", js: true, focus: true do
+    let!(:canada) { create(:country, name: "Canada", states_required: true, iso: "CA") }
+    let!(:uk) { create(:country, name: "United Kingdom", states_required: true, iso: "UK") }
+
+    before { Spree::Config[:default_country_id] = uk.id }
+
+    context "but has no state" do
+      it "shows the state input field" do
+        click_button "Checkout"
+
+        select canada.name, from: @country_css
+        expect(page).to have_selector(@state_select_css, visible: false)
+        expect(page).to have_selector(@state_name_css, visible: true)
+        expect(find(@state_name_css)['class']).not_to match(/hidden/)
+        expect(find(@state_name_css)['class']).to match(/required/)
+        expect(find(@state_select_css)['class']).not_to match(/required/)
+        expect(page).not_to have_selector("input#{@state_name_css}[disabled]")
+      end
+    end
+
+    context "and has state" do
+      before { create(:state, name: "Ontario", country: canada) }
+
+      it "shows the state collection selection" do
+        click_button "Checkout"
+
+        select canada.name, from: @country_css
+        expect(page).to have_selector(@state_select_css, visible: true)
+        expect(page).to have_selector(@state_name_css, visible: false)
+        expect(find(@state_select_css)['class']).to match(/required/)
+        expect(find(@state_select_css)['class']).not_to match(/hidden/)
+        expect(find(@state_name_css)['class']).not_to match(/required/)
+      end
+    end
+
+    context "user changes to country without states required" do
+      let!(:france) { create(:country, name: "France", states_required: false, iso: "FRA") }
+
+      it "clears the state name" do
+        skip "This is failing on the CI server, but not when you run the tests manually... It also does not fail locally on a machine."
+        click_button "Checkout"
+        select canada.name, from: @country_css
+        page.find(@state_name_css).set("Toscana")
+
+        select france.name, from: @country_css
+        expect(page.find(@state_name_css)).to have_content('')
+        until page.evaluate_script("$.active").to_i == 0
+          expect(find(@state_name_css)['class']).not_to match(/hidden/)
+          expect(find(@state_name_css)['class']).not_to match(/required/)
+          expect(find(@state_select_css)['class']).not_to match(/required/)
+        end
+      end
+    end
+  end
+
+  context "country does not require state", js: true do
+    let!(:france) { create(:country, name: "France", states_required: false, iso: "FRA") }
+
+    it "shows a disabled state input field" do
+       click_button "Checkout"
+
+       select france.name, from: @country_css
+       expect(page).to have_selector(@state_select_css, visible: false)
+       expect(page).to have_selector(@state_name_css, visible: false)
+    end
+  end
+end

data/spec/features/automatic_promotion_adjustments_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe "Automatic promotions", type: :feature, js: true do
+  let!(:country) { create(:country, name: "United States of America", states_required: true) }
+  let!(:state) { create(:state, name: "Alabama", country: country) }
+  let!(:zone) { create(:zone) }
+  let!(:shipping_method) { create(:shipping_method) }
+  let!(:payment_method) { create(:check_payment_method) }
+  let!(:product) { create(:product, name: "RoR Mug", price: 20) }
+
+  let!(:promotion) do
+    promotion = Spree::Promotion.create!(name: "$10 off when you spend more than $100")
+
+   calculator = Spree::Calculator::FlatRate.new
+   calculator.preferred_amount = 10
+
+   rule = Spree::Promotion::Rules::ItemTotal.create
+   rule.preferred_amount_min = 100
+   rule.save
+
+   promotion.rules << rule
+
+   action = Spree::Promotion::Actions::CreateAdjustment.create
+   action.calculator = calculator
+   action.save
+
+   promotion.actions << action
+  end
+
+  context "on the cart page" do
+
+    before do
+      visit spree.root_path
+      click_link product.name
+      click_button "add-to-cart-button"
+    end
+
+    it "automatically applies the promotion once the order crosses the threshold" do
+      fill_in "order_line_items_attributes_0_quantity", with: 10
+      click_button "Update"
+      expect(page).to have_content("Promotion ($10 off when you spend more than $100) -$10.00")
+      fill_in "order_line_items_attributes_0_quantity", with: 1
+      click_button "Update"
+      expect(page).not_to have_content("Promotion ($10 off when you spend more than $100) -$10.00")
+    end
+  end
+end

data/spec/features/caching/products_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe 'products', type: :feature, caching: true do
+  let!(:product) { create(:product) }
+  let!(:product2) { create(:product) }
+  let!(:taxonomy) { create(:taxonomy) }
+  let!(:taxon) { create(:taxon, taxonomy: taxonomy) }
+
+  before { Timecop.scale(1000) }
+
+  after { Timecop.return }
+
+  before do
+    product2.update_column(:updated_at, 1.day.ago)
+    # warm up the cache
+    visit spree.root_path
+    assert_written_to_cache("views/en/USD/spree/products/all--#{product.updated_at.utc.to_s(:number)}")
+    assert_written_to_cache("views/en/USD/spree/products/#{product.id}-#{product.updated_at.utc.to_s(:number)}")
+    assert_written_to_cache("views/en/spree/taxonomies/#{taxonomy.id}")
+    assert_written_to_cache("views/en/taxons/#{taxon.updated_at.utc.to_i}")
+
+    clear_cache_events
+  end
+
+  it "reads from cache upon a second viewing" do
+    visit spree.root_path
+    expect(cache_writes.count).to eq(0)
+  end
+
+  it "busts the cache when a product is updated" do
+    product.update_column(:updated_at, 1.day.from_now)
+    visit spree.root_path
+    assert_written_to_cache("views/en/USD/spree/products/all--#{product.updated_at.utc.to_s(:number)}")
+    assert_written_to_cache("views/en/USD/spree/products/#{product.id}-#{product.updated_at.utc.to_s(:number)}")
+    expect(cache_writes.count).to eq(2)
+  end
+
+  it "busts the cache when all products are deleted" do
+    product.destroy
+    product2.destroy
+    visit spree.root_path
+    assert_written_to_cache("views/en/USD/spree/products/all--#{Date.today.to_s(:number)}-0")
+    expect(cache_writes.count).to eq(1)
+  end
+
+  it "busts the cache when the newest product is deleted" do
+    product.destroy
+    visit spree.root_path
+    assert_written_to_cache("views/en/USD/spree/products/all--#{product2.updated_at.utc.to_s(:number)}")
+    expect(cache_writes.count).to eq(1)
+  end
+
+  it "busts the cache when an older product is deleted" do
+    product2.destroy
+    visit spree.root_path
+    assert_written_to_cache("views/en/USD/spree/products/all--#{product.updated_at.utc.to_s(:number)}")
+    expect(cache_writes.count).to eq(1)
+  end
+end

data/spec/features/caching/taxons_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe 'taxons', type: :feature, caching: true do
+  let!(:taxonomy) { create(:taxonomy) }
+  let!(:taxon) { create(:taxon, taxonomy: taxonomy) }
+
+  before do
+    # warm up the cache
+    visit spree.root_path
+    assert_written_to_cache("views/en/spree/taxonomies/#{taxonomy.id}")
+    assert_written_to_cache("views/en/taxons/#{taxon.updated_at.utc.to_i}")
+
+    clear_cache_events
+  end
+
+  it "busts the cache when max_level_in_taxons_menu conf changes" do
+    Spree::Config[:max_level_in_taxons_menu] = 5
+    visit spree.root_path
+    assert_written_to_cache("views/en/spree/taxonomies/#{taxonomy.id}")
+    expect(cache_writes.count).to eq(1)
+  end
+end

data/spec/features/cart_spec.rb

@@ -0,0 +1,132 @@
+require 'spec_helper'
+
+describe "Cart", type: :feature, inaccessible: true do
+  before { Timecop.scale(100) }
+
+  after { Timecop.return }
+
+  let!(:variant) { create(:variant) }
+  let!(:product) { variant.product }
+
+  def add_mug_to_cart
+    visit spree.root_path
+    click_link product.name
+    click_button "add-to-cart-button"
+  end
+
+  it "shows cart icon on non-cart pages" do
+    visit spree.root_path
+    expect(page).to have_selector("li#link-to-cart a", visible: true)
+  end
+
+  it "prevents double clicking the remove button on cart", js: true do
+    add_mug_to_cart
+    # prevent form submit to verify button is disabled
+    page.execute_script("$('#update-cart').submit(function(){return false;})")
+
+    expect(page).not_to have_selector('button#update-button[disabled]')
+    page.find(:css, '.delete span').click
+    expect(page).to have_selector('button#update-button[disabled]')
+  end
+
+  # Regression test for #2006
+  it "does not error out with a 404 when GET'ing to /orders/populate" do
+    visit '/orders/populate'
+    within(".alert-error") do
+      expect(page).to have_content(Spree.t(:populate_get_error))
+    end
+  end
+
+  it 'allows you to remove an item from the cart', js: true do
+    add_mug_to_cart
+    line_item = Spree::LineItem.first!
+    within("#line_items") do
+      click_link "delete_line_item_#{line_item.id}"
+    end
+
+    expect(page).to_not have_content("Line items quantity must be an integer")
+    expect(page).to_not have_content(product.name)
+    expect(page).to have_content("Your cart is empty")
+
+    within "#link-to-cart" do
+      expect(page).to have_content("Empty")
+    end
+  end
+
+  it 'allows you to empty the cart', js: true do
+    add_mug_to_cart
+    expect(page).to have_content(product.name)
+    click_on "Empty Cart"
+    expect(page).to have_content("Your cart is empty")
+
+    within "#link-to-cart" do
+      expect(page).to have_content("Empty")
+    end
+  end
+
+  # regression for #2276
+  context "product contains variants but no option values" do
+    before { variant.option_values.destroy_all }
+
+    it "still adds product to cart", inaccessible: true do
+      add_mug_to_cart
+      visit spree.cart_path
+      expect(page).to have_content(product.name)
+    end
+  end
+
+  it "should have a surrounding element with data-hook='cart_container'" do
+    visit spree.cart_path
+    expect(page).to have_selector("div[data-hook='cart_container']")
+  end
+
+  describe 'add promotion coupon on cart page', js: true do
+    let!(:promotion) { Spree::Promotion.create(name: 'Huhuhu', code: 'huhu') }
+    let!(:calculator) { Spree::Calculator::FlatPercentItemTotal.create(preferred_flat_percent: '10') }
+    let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(calculator: calculator) }
+
+    before do
+      promotion.actions << action
+      add_mug_to_cart
+      expect(current_path).to eql(spree.cart_path)
+    end
+
+    def apply_coupon(code)
+      fill_in 'Coupon Code', with: code
+      click_on 'Update'
+    end
+
+    context 'valid coupon' do
+      before { apply_coupon(promotion.code) }
+
+      context 'for the first time' do
+        it 'makes sure payment reflects order total with discounts' do
+          expect(page).to have_content(promotion.name)
+        end
+      end
+
+      context 'same coupon for the second time' do
+        before { apply_coupon(promotion.code) }
+        it 'should reflect an error that coupon already applied' do
+          apply_coupon(promotion.code)
+          expect(page).to have_content(Spree.t(:coupon_code_already_applied))
+          expect(page).to have_content(promotion.name)
+        end
+      end
+    end
+
+    context 'invalid coupon' do
+      it 'doesnt create a payment record' do
+        apply_coupon('invalid')
+        expect(page).to have_content(Spree.t(:coupon_code_not_found))
+      end
+    end
+
+    context "doesn't fill in coupon code input" do
+      it 'advances just fine' do
+        click_on 'Update'
+        expect(current_path).to match(spree.cart_path)
+      end
+    end
+  end
+end

data/spec/features/checkout_spec.rb

@@ -0,0 +1,572 @@
+require 'spec_helper'
+
+describe 'Checkout', type: :feature, inaccessible: true, js: true do
+  include_context 'checkout setup'
+
+  let(:country) { create(:country, name: 'United States of America', iso_name: 'UNITED STATES') }
+  let(:state) { create(:state, name: 'Alabama', abbr: 'AL', country: country) }
+
+  context "visitor makes checkout as guest without registration" do
+    before(:each) do
+      stock_location.stock_items.update_all(count_on_hand: 1)
+    end
+
+    context 'defaults to use billing address' do
+      before do
+        add_mug_to_cart
+        Spree::Order.last.update_column(:email, 'test@example.com')
+        click_button 'Checkout'
+      end
+
+      it 'should default checkbox to checked' do
+        expect(find('input#order_use_billing')).to be_checked
+      end
+
+      it 'should remain checked when used and visitor steps back to address step' do
+        fill_in_address
+        expect(find('input#order_use_billing')).to be_checked
+      end
+    end
+
+    # Regression test for #4079
+    context 'persists state when on address page' do
+      before do
+        add_mug_to_cart
+        click_button 'Checkout'
+      end
+
+      specify do
+        expect(Spree::Order.count).to eq 1
+        expect(Spree::Order.last.state).to eq 'address'
+      end
+    end
+
+    # Regression test for #1596
+    context 'full checkout' do
+      before do
+        shipping_method.calculator.update!(preferred_amount: 10)
+        mug.shipping_category = shipping_method.shipping_categories.first
+        mug.save!
+      end
+
+      it 'does not break the per-item shipping method calculator', js: true do
+        add_mug_to_cart
+        click_button 'Checkout'
+
+        fill_in 'order_email', with: 'test@example.com'
+        click_on 'Continue'
+        fill_in_address
+
+        click_button 'Save and Continue'
+        expect(page).to_not have_content("undefined method `promotion'")
+        click_button 'Save and Continue'
+        expect(page).to have_content('Shipping total: $10.00')
+      end
+    end
+
+    # Regression test for #4306
+    context 'free shipping' do
+      before do
+        add_mug_to_cart
+        click_button 'Checkout'
+        fill_in 'order_email', with: 'test@example.com'
+        click_on 'Continue'
+      end
+
+      it "should not show 'Free Shipping' when there are no shipments" do
+        within('#checkout-summary') do
+          expect(page).to_not have_content('Free Shipping')
+        end
+      end
+    end
+
+    # Regression test for #4190
+    it 'updates state_lock_version on form submission', js: true do
+      add_mug_to_cart
+      click_button "Checkout"
+
+      expect(find('input#order_state_lock_version', visible: false).value).to eq '0'
+
+      fill_in 'order_email', with: 'test@example.com'
+      fill_in_address
+      click_button 'Save and Continue'
+
+      expect(find('input#order_state_lock_version', visible: false).value).to eq '1'
+    end
+  end
+
+  # Regression test for #2694 and #4117
+  context "doesn't allow bad credit card numbers" do
+    before(:each) do
+      order = OrderWalkthrough.up_to(:payment)
+      allow(order).to receive_messages confirmation_required?: true
+      allow(order).to receive_messages(available_payment_methods: [create(:credit_card_payment_method)])
+
+      user = create(:user)
+      order.user = user
+      order.update_with_updater!
+
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+    end
+
+    it 'redirects to payment page', inaccessible: true, js: true do
+      visit spree.checkout_state_path(:payment)
+      click_button 'Save and Continue'
+      choose 'Credit Card'
+      fill_in 'Card Number', with: '123'
+      fill_in 'card_expiry', with: '04 / 20'
+      fill_in 'Card Code', with: '123'
+      click_button 'Save and Continue'
+      click_button 'Place Order'
+      expect(page).to have_content('Bogus Gateway: Forced failure')
+      expect(page.current_url).to include('/checkout/payment')
+    end
+  end
+
+  # regression test for #3945
+  context 'when Spree::Config[:always_include_confirm_step] is true' do
+    before do
+      Spree::Config[:always_include_confirm_step] = true
+    end
+
+    it 'displays confirmation step', js: true do
+      add_mug_to_cart
+      click_button 'Checkout'
+
+      fill_in 'order_email', with: 'test@example.com'
+      click_on 'Continue'
+      fill_in_address
+
+      click_button 'Save and Continue'
+      click_button 'Save and Continue'
+      click_button 'Save and Continue'
+
+      continue_button = find('#checkout .btn-success')
+      expect(continue_button.value).to eq 'Place Order'
+    end
+  end
+
+  context 'and likes to double click buttons' do
+    let!(:user) { create(:user) }
+
+    let!(:order) do
+      order = OrderWalkthrough.up_to(:payment)
+      allow(order).to receive_messages confirmation_required?: true
+
+      order.reload
+      order.user = user
+      order.update_with_updater!
+      order
+    end
+
+    before(:each) do
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(skip_state_validation?: true)
+    end
+
+    it 'prevents double clicking the payment button on checkout', js: true do
+      visit spree.checkout_state_path(:payment)
+
+      # prevent form submit to verify button is disabled
+      page.execute_script("$('#checkout_form_payment').submit(function(){return false;})")
+
+      expect(page).to_not have_selector('input.btn.disabled')
+      click_button 'Save and Continue'
+      expect(page).to have_selector('input.btn.disabled')
+    end
+
+    it 'prevents double clicking the confirm button on checkout', js: true do
+      order.payments << create(:payment, amount: order.amount)
+      visit spree.checkout_state_path(:confirm)
+
+      # prevent form submit to verify button is disabled
+      page.execute_script("$('#checkout_form_confirm').submit(function(){return false;})")
+
+      expect(page).to_not have_selector('input.btn.disabled')
+      click_button 'Place Order'
+      expect(page).to have_selector('input.btn.disabled')
+    end
+  end
+
+  context 'when several payment methods are available', js: true do
+    let(:credit_cart_payment) { create(:credit_card_payment_method) }
+    let(:check_payment) { create(:check_payment_method) }
+
+    after do
+      Capybara.ignore_hidden_elements = true
+    end
+
+    before do
+      Capybara.ignore_hidden_elements = false
+      order = OrderWalkthrough.up_to(:payment)
+      allow(order).to receive_messages(available_payment_methods: [check_payment, credit_cart_payment])
+      order.user = create(:user)
+      order.update_with_updater!
+
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: order.user)
+
+      visit spree.checkout_state_path(:payment)
+    end
+
+    it 'the first payment method should be selected' do
+      payment_method_css = '#order_payments_attributes__payment_method_id_'
+      expect(find("#{payment_method_css}#{check_payment.id}")).to be_checked
+      expect(find("#{payment_method_css}#{credit_cart_payment.id}")).not_to be_checked
+    end
+
+    it 'the fields for the other payment methods should be hidden' do
+      payment_method_css = '#payment_method_'
+      expect(find("#{payment_method_css}#{check_payment.id}")).to be_visible
+      expect(find("#{payment_method_css}#{credit_cart_payment.id}")).not_to be_visible
+    end
+  end
+
+  context 'user has payment sources', js: true do
+    let(:bogus) { create(:credit_card_payment_method) }
+    let(:user) { create(:user) }
+
+    let!(:credit_card) do
+      create(:credit_card, user_id: user.id, payment_method: bogus, gateway_customer_profile_id: 'BGS-WEFWF')
+    end
+
+    before do
+      order = OrderWalkthrough.up_to(:payment)
+      allow(order).to receive_messages(available_payment_methods: [bogus])
+
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+      allow_any_instance_of(Spree::OrdersController).to receive_messages(try_spree_current_user: user)
+
+      visit spree.checkout_state_path(:payment)
+    end
+
+    it 'selects first source available and customer moves on' do
+      expect(find('#use_existing_card_yes')).to be_checked
+
+      expect { click_on 'Save and Continue' }.not_to change { Spree::CreditCard.count }
+
+      click_on 'Place Order'
+      expect(current_path).to match(spree.order_path(Spree::Order.last))
+    end
+
+    it 'allows user to enter a new source' do
+      choose 'use_existing_card_no'
+
+      fill_in 'Name on card', with: 'Spree Commerce'
+      fill_in 'Card Number', with: '4111111111111111'
+      fill_in 'card_expiry', with: '04 / 20'
+      fill_in 'Card Code', with: '123'
+
+      expect { click_on 'Save and Continue' }.to change { Spree::CreditCard.count }.by 1
+
+      click_on 'Place Order'
+      expect(current_path).to match(spree.order_path(Spree::Order.last))
+    end
+  end
+
+  # regression for #2921
+  context 'goes back from payment to add another item', js: true do
+    let!(:bag) { create(:product, name: 'RoR Bag') }
+
+    it 'transit nicely through checkout steps again' do
+      add_mug_to_cart
+      click_on 'Checkout'
+      fill_in 'order_email', with: 'test@example.com'
+      click_on 'Continue'
+      fill_in_address
+      click_on 'Save and Continue'
+      click_on 'Save and Continue'
+      expect(current_path).to eql(spree.checkout_state_path('payment'))
+
+      visit spree.root_path
+      click_link bag.name
+      click_button 'add-to-cart-button'
+
+      click_on 'Checkout'
+      click_on 'Save and Continue'
+      click_on 'Save and Continue'
+      click_on 'Save and Continue'
+
+      expect(current_path).to match(spree.order_path(Spree::Order.last))
+    end
+  end
+
+  context 'from payment step customer goes back to cart', js: true do
+    before do
+      add_mug_to_cart
+      click_on 'Checkout'
+      fill_in 'order_email', with: 'test@example.com'
+      click_on 'Continue'
+      fill_in_address
+      click_on 'Save and Continue'
+      click_on 'Save and Continue'
+      expect(current_path).to eql(spree.checkout_state_path('payment'))
+    end
+
+    context 'and updates line item quantity and try to reach payment page' do
+      before do
+        visit spree.cart_path
+        within '.cart-item-quantity' do
+          fill_in first('input')['name'], with: 3
+        end
+
+        click_on 'Update'
+      end
+
+      it 'redirects user back to address step' do
+        visit spree.checkout_state_path('payment')
+        expect(current_path).to eql(spree.checkout_state_path('address'))
+      end
+
+      it 'updates shipments properly through step address -> delivery transitions' do
+        visit spree.checkout_state_path('payment')
+        click_on 'Save and Continue'
+        click_on 'Save and Continue'
+
+        expect(Spree::InventoryUnit.count).to eq 3
+      end
+    end
+
+    context 'and adds new product to cart and try to reach payment page' do
+      let!(:bag) { create(:product, name: 'RoR Bag') }
+
+      before do
+        visit spree.root_path
+        click_link bag.name
+        click_button 'add-to-cart-button'
+      end
+
+      it 'redirects user back to address step' do
+        visit spree.checkout_state_path('payment')
+        expect(current_path).to eql(spree.checkout_state_path('address'))
+      end
+
+      it 'updates shipments properly through step address -> delivery transitions' do
+        visit spree.checkout_state_path("payment")
+        click_on 'Save and Continue'
+        click_on 'Save and Continue'
+
+        expect(Spree::InventoryUnit.count).to eq 2
+      end
+    end
+  end
+
+  context 'if coupon promotion, submits coupon along with payment', js: true do
+    let!(:promotion) { Spree::Promotion.create(name: 'Huhuhu', code: 'huhu') }
+    let!(:calculator) { Spree::Calculator::FlatPercentItemTotal.create(preferred_flat_percent: '10') }
+    let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(calculator: calculator) }
+
+    before do
+      promotion.actions << action
+
+      add_mug_to_cart
+      click_on 'Checkout'
+
+      fill_in 'order_email', with: 'test@example.com'
+      click_on 'Continue'
+      fill_in_address
+      click_on 'Save and Continue'
+
+      click_on 'Save and Continue'
+      expect(current_path).to eql(spree.checkout_state_path('payment'))
+    end
+
+    it 'makes sure payment reflects order total with discounts' do
+      fill_in 'Coupon Code', with: promotion.code
+      click_on 'Save and Continue'
+
+      expect(page).to have_content(promotion.name)
+      expect(Spree::Payment.first.amount.to_f).to eq Spree::Order.last.total.to_f
+    end
+
+    context 'invalid coupon' do
+      it 'doesnt create a payment record' do
+        fill_in 'Coupon Code', with: 'invalid'
+        click_on 'Save and Continue'
+
+        expect(Spree::Payment.count).to eq 0
+        expect(page).to have_content(Spree.t(:coupon_code_not_found))
+      end
+    end
+
+    context "doesn't fill in coupon code input" do
+      it 'advances just fine' do
+        click_on 'Save and Continue'
+        expect(current_path).to match(spree.order_path(Spree::Order.last))
+      end
+    end
+  end
+
+  context 'order has only payment step' do
+    before do
+      create(:credit_card_payment_method)
+      @old_checkout_flow = Spree::Order.checkout_flow
+      Spree::Order.class_eval do
+        checkout_flow do
+          go_to_state :payment
+          go_to_state :confirm
+        end
+      end
+
+      allow_any_instance_of(Spree::Order).to receive_messages email: 'spree@commerce.com'
+
+      add_mug_to_cart
+      click_on 'Checkout'
+    end
+
+    after do
+      Spree::Order.checkout_flow(&@old_checkout_flow)
+    end
+
+    it 'goes right payment step and place order just fine' do
+      expect(current_path).to eq spree.checkout_state_path('payment')
+
+      choose 'Credit Card'
+      fill_in 'Name on card', with: 'Spree Commerce'
+      fill_in 'Card Number', with: '4111111111111111'
+      fill_in 'card_expiry', with: '04 / 20'
+      fill_in 'Card Code', with: '123'
+      click_button 'Save and Continue'
+
+      expect(current_path).to eq spree.checkout_state_path('confirm')
+      click_button 'Place Order'
+    end
+  end
+
+  context 'save my address' do
+    before do
+      stock_location.stock_items.update_all(count_on_hand: 1)
+      add_mug_to_cart
+    end
+
+    context 'as a guest' do
+      before do
+        Spree::Order.last.update_column(:email, 'test@example.com')
+        click_button 'Checkout'
+      end
+
+      it 'should not be displayed' do
+        expect(page).to_not have_css('[data-hook=save_user_address]')
+      end
+    end
+
+    context 'as a User' do
+      before do
+        user = create(:user)
+        Spree::Order.last.update_column :user_id, user.id
+        allow_any_instance_of(Spree::OrdersController).to receive_messages(try_spree_current_user: user)
+        allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+        click_button 'Checkout'
+      end
+
+      it 'should be displayed' do
+        expect(page).to have_css('[data-hook=save_user_address]')
+      end
+    end
+  end
+
+  context 'when order is completed' do
+    let!(:user) { create(:user) }
+    let!(:order) { OrderWalkthrough.up_to(:payment) }
+
+    before(:each) do
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+      allow_any_instance_of(Spree::OrdersController).to receive_messages(try_spree_current_user: user)
+
+      visit spree.checkout_state_path(:payment)
+      click_button 'Save and Continue'
+    end
+
+    it 'displays a thank you message' do
+      expect(page).to have_content(Spree.t(:thank_you_for_your_order))
+    end
+
+    it 'does not display a thank you message on that order future visits' do
+      visit spree.order_path(order)
+      expect(page).to_not have_content(Spree.t(:thank_you_for_your_order))
+    end
+  end
+
+  context 'user has store credits', js: true do
+    let(:bogus) { create(:credit_card_payment_method) }
+    let(:store_credit_payment_method) { create(:store_credit_payment_method) }
+    let(:user) { create(:user) }
+    let(:order) { OrderWalkthrough.up_to(:payment) }
+
+    let(:prepare_checkout!) do
+      order.update(user: user)
+      allow(order).to receive_messages(available_payment_methods: [bogus, store_credit_payment_method])
+
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+      allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: user)
+      allow_any_instance_of(Spree::OrdersController).to receive_messages(try_spree_current_user: user)
+      visit spree.checkout_state_path(:payment)
+    end
+
+    context 'when not all Store Credits are used' do
+      let!(:store_credit) { create(:store_credit, user: user) }
+      let!(:additional_store_credit) { create(:store_credit, user: user, amount: 13) }
+
+      before { prepare_checkout! }
+
+      it 'page has data for (multiple) Store Credits' do
+        expect(page).to have_selector('[data-hook="checkout_payment_store_credit_available"]')
+        expect(page).to have_selector('button[name="apply_store_credit"]')
+
+        amount = Spree::Money.new(store_credit.amount_remaining + additional_store_credit.amount_remaining)
+        expect(page).to have_content(Spree.t('store_credit.available_amount', amount: amount))
+      end
+
+      it 'apply store credits button should move checkout to next step if amount is sufficient' do
+        click_button 'Apply Store Credit'
+        expect(current_path).to eq spree.order_path(order)
+        expect(page).to have_content(Spree.t('order_processed_successfully'))
+      end
+
+      it 'apply store credits button should wait on payment step for other payment' do
+        store_credit.update(amount_used: 145)
+        additional_store_credit.update(amount_used: 12)
+        click_button 'Apply Store Credit'
+
+        expect(current_path).to eq spree.checkout_state_path(:payment)
+        amount = Spree::Money.new(store_credit.amount_remaining + additional_store_credit.amount_remaining)
+        remaining_amount = Spree::Money.new(order.total - amount.money.to_f)
+        expect(page).to have_content(Spree.t('store_credit.applicable_amount', amount: amount))
+        expect(page).to have_content(Spree.t('store_credit.additional_payment_needed', amount: remaining_amount))
+      end
+    end
+
+    context 'when all Store Credits are used' do
+      let!(:store_credit) { create(:store_credit, user: user, amount_used: 150) }
+
+      before { prepare_checkout! }
+
+      it 'page has no data for Store Credits when all Store Credits are used' do
+        expect(page).to_not have_selector('[data-hook="checkout_payment_store_credit_available"]')
+        expect(page).to_not have_selector('button[name="apply_store_credit"]')
+      end
+    end
+  end
+
+  def fill_in_address
+    address = "order_bill_address_attributes"
+    fill_in "#{address}_firstname", with: "Ryan"
+    fill_in "#{address}_lastname", with: "Bigg"
+    fill_in "#{address}_address1", with: "143 Swan Street"
+    fill_in "#{address}_city", with: "Richmond"
+    select country.name, from: "#{address}_country_id"
+    select state.name, from: "#{address}_state_id"
+    fill_in "#{address}_zipcode", with: "12345"
+    fill_in "#{address}_phone", with: "(555) 555-5555"
+  end
+
+  def add_mug_to_cart
+    visit spree.root_path
+    click_link mug.name
+    click_button "add-to-cart-button"
+  end
+end