spree_doordash 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11ea8c9082c5f3a17fb5e7ad172eab82c717d17af077bee7d0df14c92a75fba6
-  data.tar.gz: 5e435d16a2bef4e610760fb993533cf54f31a81343b1f5ade02f7889f8eb622c
+  metadata.gz: 4386dd5c8b44b1fa483213fcfae97c5c21ad8143f92650714fb7cc0f1966e059
+  data.tar.gz: 75d2fbda1b0870f14397a77a042b518c6b5972f1e7d8c3fb7f4c38ca182395ea
 SHA512:
-  metadata.gz: bcee352d7bc9b0a6eeb877d5cd112cf40de922de796739f607058ad92735c787f665641d981d501e3d21af5b82b7e8f4e289b4a96cc6351d659d9f78eed95174
-  data.tar.gz: 99e77a1d48d37fe6f1573341a0e93d90f4d7a68690ede1f1ecdfc43c508340ef9b60aec101f9c4b7aea32fca25109dc94e8f13f8712124802f8b4e64e7866295
+  metadata.gz: b9c8465fcded4299713522d77ddf130c6ad9c8479233644fe9efe41817b90b08f7d6e8dd4edd99d88ee9c2b5b408668315d8f3bb58f2d8be47be708eeb7e34ef
+  data.tar.gz: 2ad0971dfd7551ebcb0e6ebac5c0fbe94a4ef7d5c8f6022469ee8c937cd31ded0d17c7c0ea2ed6e6fb94c1426d906a0ccd72b1f3de5b7d38513207a0780f6d64

data/CHANGELOG.md

@@ -2,6 +2,28 @@
 
 All notable changes to this project are documented here.
 
+## 0.1.2
+
+A real bug found live during checkout-validation work: a blank phone on the dropoff address used
+to fall back to a fake placeholder number (`+10000000000`) that DoorDash's API rejected anyway —
+the request was doomed before it was even built, and (same as the E.164 issue fixed in 0.1.1) the
+DoorDash Delivery rate just silently vanished with no error anywhere in the UI.
+
+- `SpreeDoordash::Quote#call` now returns early (no API call at all) when the ship address has no
+  phone, instead of building a request known to fail. `format_phone`'s placeholder fallback is
+  removed entirely.
+- `Spree::Calculator::Shipping::DoordashQuote#compute_package` now pushes a
+  `doordash_quote_unavailable` warning onto `Spree::Order#warnings` whenever `SpreeDoordash::Quote`
+  returns `nil` — generic to *why* the quote failed (bad/missing phone, an address DoorDash
+  genuinely can't serve, DoorDash API down), confirmed live for two different real causes.
+  `Spree::Order#warnings` is the same transient mechanism core's own
+  `ensure_available_shipping_rates` already uses for the identical class of problem, and flows
+  through to the Store API's `cart.warnings` with no new API surface. A storefront reference
+  implementation now renders this as a real, non-blocking banner instead of silence — see
+  `spree_storefront_web`'s `DeliveryMethodSection.tsx`.
+
+Full suite: 90 examples, 0 failures (2 new). Coverage: 94.14% (241/256 lines). Brakeman clean.
+
 ## 0.1.1
 
 Two real production bugs, both invisible to the full spec suite and to every prior "live

data/app/models/spree/calculator/shipping/doordash_quote.rb

@@ -20,7 +20,26 @@ module Spree
 
       def compute_package(package)
         result = SpreeDoordash::Quote.call(package.order)
-        return nil unless result
+        if result.nil?
+          # A real bug found live: a nil Result here (bad/missing phone, an
+          # address DoorDash genuinely can't serve, DoorDash API down —
+          # SpreeDoordash::Quote#call collapses all of these to the same
+          # "unavailable" nil, deliberately, so this stays generic to *why*)
+          # used to just make the rate silently vanish with zero signal
+          # anywhere in the UI. Spree::Order#warnings is the same
+          # transient, request-scoped mechanism core's own
+          # `ensure_available_shipping_rates` already uses for the
+          # identical class of problem (a line item that can't ship at
+          # all) — it flows through to the Store API's `cart.warnings`
+          # with no new API surface needed. The storefront renders its own
+          # localized copy for this code; `message` here is English-only,
+          # a fallback for any other API consumer, not the UI text itself.
+          package.order.warnings |= [{
+            code: 'doordash_quote_unavailable',
+            message: 'We could not get a DoorDash delivery quote for this address.'
+          }]
+          return nil
+        end
 
         result.fee_cents / 100.0
       end

data/app/services/spree_doordash/quote.rb

@@ -17,6 +17,16 @@ module SpreeDoordash
     def call(order)
       location_mapping = location_mapping_for(order)
       return nil unless location_mapping && order.ship_address
+      # A real bug found live: with no phone on the ship address,
+      # `format_phone` used to fall back to a fake placeholder number that
+      # DoorDash's API correctly rejects with a 400 — the request was
+      # doomed before it was even built. `Spree::Config[:address_requires_phone]`
+      # (spree_host) should make this unreachable in the normal storefront
+      # checkout flow, but this guard stays as defense in depth for any
+      # other path that can create an order (admin, API, migrated data)
+      # — same "unavailable, not exceptional" nil-return shape as every
+      # other unserviceable case below.
+      return nil if order.ship_address.phone.blank?
 
       client = SpreeDoordash::Client.for_store(order.store || Spree::Store.default)
       # A random suffix per attempt, not just order.number — confirmed live
@@ -93,11 +103,17 @@ module SpreeDoordash
     # US-only, matching the rest of this demo (every address here is a US
     # address) — strips everything but digits, assumes a bare 10-digit
     # number is domestic and prepends the country code.
+    #
+    # No blank-phone fallback here (a prior version faked one as
+    # "+10000000000" — DoorDash rejected it too, just as uninformatively as
+    # a missing one; better to let a genuinely blank pickup phone fail
+    # DoorDash's own validation loudly than paper over it with fake data).
+    # `call` above already guards the dropoff phone specifically; this
+    # method is also reused for the pickup (StockLocation) phone, which is
+    # real business data expected to always be set.
     def format_phone(raw)
       digits = raw.to_s.gsub(/\D/, '')
       digits = "1#{digits}" if digits.length == 10
-      return '+10000000000' if digits.blank?
-
       "+#{digits}"
     end
 

data/lib/spree_doordash/version.rb

@@ -1,5 +1,5 @@
 module SpreeDoordash
-  VERSION = '0.1.1'.freeze
+  VERSION = '0.1.2'.freeze
 
   def gem_version
     Gem::Version.new(VERSION)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_doordash
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Amit Solanki