spree_doordash 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba867fc23a044f6166e7fcb61f1641a9f3bd79ddc7c08cf1808abf20664defee
-  data.tar.gz: c3dba97527799999bcbd5cc9881b936c368a1ff819f89e4bc8cf568e7513f568
+  metadata.gz: 4386dd5c8b44b1fa483213fcfae97c5c21ad8143f92650714fb7cc0f1966e059
+  data.tar.gz: 75d2fbda1b0870f14397a77a042b518c6b5972f1e7d8c3fb7f4c38ca182395ea
 SHA512:
-  metadata.gz: 9eccedd59afafb3bc174d769deb3cd47aa6511ca0ec4f6aec3989adab82c148928c74ba0c4416096996d1fa032f49534f1a22736292e670bcacf7ee33a1c090a
-  data.tar.gz: f5bb35207b1cfba4544b47c459c56936eb69b163c3deb3f9fd4f5322ad043b6f36b5b7a220d306037dcffa5d68967b39fac1b2bd0bc558715a41ed78aa1da034
+  metadata.gz: b9c8465fcded4299713522d77ddf130c6ad9c8479233644fe9efe41817b90b08f7d6e8dd4edd99d88ee9c2b5b408668315d8f3bb58f2d8be47be708eeb7e34ef
+  data.tar.gz: 2ad0971dfd7551ebcb0e6ebac5c0fbe94a4ef7d5c8f6022469ee8c937cd31ded0d17c7c0ea2ed6e6fb94c1426d906a0ccd72b1f3de5b7d38513207a0780f6d64

data/CHANGELOG.md

@@ -2,7 +2,55 @@
 
 All notable changes to this project are documented here.
 
-## 0.1.0 (unreleased)
+## 0.1.2
+
+A real bug found live during checkout-validation work: a blank phone on the dropoff address used
+to fall back to a fake placeholder number (`+10000000000`) that DoorDash's API rejected anyway —
+the request was doomed before it was even built, and (same as the E.164 issue fixed in 0.1.1) the
+DoorDash Delivery rate just silently vanished with no error anywhere in the UI.
+
+- `SpreeDoordash::Quote#call` now returns early (no API call at all) when the ship address has no
+  phone, instead of building a request known to fail. `format_phone`'s placeholder fallback is
+  removed entirely.
+- `Spree::Calculator::Shipping::DoordashQuote#compute_package` now pushes a
+  `doordash_quote_unavailable` warning onto `Spree::Order#warnings` whenever `SpreeDoordash::Quote`
+  returns `nil` — generic to *why* the quote failed (bad/missing phone, an address DoorDash
+  genuinely can't serve, DoorDash API down), confirmed live for two different real causes.
+  `Spree::Order#warnings` is the same transient mechanism core's own
+  `ensure_available_shipping_rates` already uses for the identical class of problem, and flows
+  through to the Store API's `cart.warnings` with no new API surface. A storefront reference
+  implementation now renders this as a real, non-blocking banner instead of silence — see
+  `spree_storefront_web`'s `DeliveryMethodSection.tsx`.
+
+Full suite: 90 examples, 0 failures (2 new). Coverage: 94.14% (241/256 lines). Brakeman clean.
+
+## 0.1.1
+
+Two real production bugs, both invisible to the full spec suite and to every prior "live
+verification" in this project, both found only by driving a genuine storefront checkout end to
+end instead of calling the services directly:
+
+- **DoorDash rejects any phone number that isn't strict E.164.** Every earlier live test in this
+  project — including the M1–M5 verifications documented below — happened to type phone numbers
+  directly in `+1XXXXXXXXXX` form. The first real checkout, with a number typed the way an address
+  form actually produces one (`(202) 555-0199`), got a real `400 Unknown phone number format` from
+  DoorDash's `/drive/v2/quotes` endpoint — which silently dropped the DoorDash Delivery shipping
+  rate with no error surfaced anywhere in checkout. Fixed by normalizing both `pickup_phone_number`
+  and `dropoff_phone_number` to E.164 before every quote request.
+
+- **The order-completed subscriber was never actually registered with Spree's event system.**
+  `Spree::Subscriber`'s own docstring claims subscribers are "automatically registered during Rails
+  initialization" — that's not what `spree_core` 5.6.1 actually does. `Spree::Events.register_subscribers!`
+  only iterates an explicit `Spree.subscribers` array, populated via `Spree.subscribers << YourClass`
+  in an initializer; there's no automatic scan. This gem never had that initializer line. Every spec
+  for `OrderCompletedSubscriber` called `.call` on it directly, which bypasses the registry entirely
+  and kept passing regardless — so a real storefront order, placed with DoorDash Delivery selected,
+  completed successfully and was never dispatched, with nothing anywhere indicating a problem. Fixed
+  by adding the missing `config/initializers/spree.rb`, plus a new spec that asserts
+  `Spree.subscribers` actually includes the class — the one test that would have caught this from
+  the start.
+
+## 0.1.0
 
 Initial development. M1 (foundation) — complete and verified against a real DoorDash Sandbox
 endpoint (`bin/rails spree_doordash:verify_connection`, a real accepted quote):

data/app/models/spree/calculator/shipping/doordash_quote.rb

@@ -20,7 +20,26 @@ module Spree
 
       def compute_package(package)
         result = SpreeDoordash::Quote.call(package.order)
-        return nil unless result
+        if result.nil?
+          # A real bug found live: a nil Result here (bad/missing phone, an
+          # address DoorDash genuinely can't serve, DoorDash API down —
+          # SpreeDoordash::Quote#call collapses all of these to the same
+          # "unavailable" nil, deliberately, so this stays generic to *why*)
+          # used to just make the rate silently vanish with zero signal
+          # anywhere in the UI. Spree::Order#warnings is the same
+          # transient, request-scoped mechanism core's own
+          # `ensure_available_shipping_rates` already uses for the
+          # identical class of problem (a line item that can't ship at
+          # all) — it flows through to the Store API's `cart.warnings`
+          # with no new API surface needed. The storefront renders its own
+          # localized copy for this code; `message` here is English-only,
+          # a fallback for any other API consumer, not the UI text itself.
+          package.order.warnings |= [{
+            code: 'doordash_quote_unavailable',
+            message: 'We could not get a DoorDash delivery quote for this address.'
+          }]
+          return nil
+        end
 
         result.fee_cents / 100.0
       end

data/app/services/spree_doordash/quote.rb

@@ -17,6 +17,16 @@ module SpreeDoordash
     def call(order)
       location_mapping = location_mapping_for(order)
       return nil unless location_mapping && order.ship_address
+      # A real bug found live: with no phone on the ship address,
+      # `format_phone` used to fall back to a fake placeholder number that
+      # DoorDash's API correctly rejects with a 400 — the request was
+      # doomed before it was even built. `Spree::Config[:address_requires_phone]`
+      # (spree_host) should make this unreachable in the normal storefront
+      # checkout flow, but this guard stays as defense in depth for any
+      # other path that can create an order (admin, API, migrated data)
+      # — same "unavailable, not exceptional" nil-return shape as every
+      # other unserviceable case below.
+      return nil if order.ship_address.phone.blank?
 
       client = SpreeDoordash::Client.for_store(order.store || Spree::Store.default)
       # A random suffix per attempt, not just order.number — confirmed live
@@ -73,14 +83,40 @@ module SpreeDoordash
         external_delivery_id: external_delivery_id,
         pickup_address: format_address(location_mapping.stock_location),
         pickup_business_name: location_mapping.stock_location.name,
-        pickup_phone_number: location_mapping.stock_location.phone.presence || '+10000000000',
+        pickup_phone_number: format_phone(location_mapping.stock_location.phone),
         pickup_instructions: location_mapping.stock_location.pickup_instructions,
         dropoff_address: format_address(order.ship_address),
-        dropoff_phone_number: order.ship_address.phone.presence || '+10000000000',
+        dropoff_phone_number: format_phone(order.ship_address.phone),
         order_value: (order.total * 100).to_i
       }
     end
 
+    # DoorDash wants E.164 (+1XXXXXXXXXX) and rejects anything else outright
+    # — confirmed live: a real checkout with a normally-typed US phone number
+    # ("(202) 555-0199", exactly what an address form produces) got a real
+    # 400 "Unknown phone number format" from DoorDash, silently dropping the
+    # DoorDash Delivery rate with no visible error anywhere in the UI. Every
+    # earlier live verification in this project used numbers already typed
+    # in +1XXXXXXXXXX form by hand, which is why this never surfaced until
+    # an actual storefront checkout was driven through normally.
+    #
+    # US-only, matching the rest of this demo (every address here is a US
+    # address) — strips everything but digits, assumes a bare 10-digit
+    # number is domestic and prepends the country code.
+    #
+    # No blank-phone fallback here (a prior version faked one as
+    # "+10000000000" — DoorDash rejected it too, just as uninformatively as
+    # a missing one; better to let a genuinely blank pickup phone fail
+    # DoorDash's own validation loudly than paper over it with fake data).
+    # `call` above already guards the dropoff phone specifically; this
+    # method is also reused for the pickup (StockLocation) phone, which is
+    # real business data expected to always be set.
+    def format_phone(raw)
+      digits = raw.to_s.gsub(/\D/, '')
+      digits = "1#{digits}" if digits.length == 10
+      "+#{digits}"
+    end
+
     # Spree::StockLocation and Spree::Address share the same field shape
     # (address1/address2/city/state/zipcode/country) even though they're
     # unrelated classes — DoorDash wants one flat string, not structured

data/config/initializers/spree.rb

@@ -0,0 +1,17 @@
+# Registers this extension's event subscriber with Spree's event system.
+#
+# Spree::Subscriber's own docstring says subscribers are "automatically
+# registered during Rails initialization" — that's not what actually
+# happens in spree_core 5.6.1: Spree::Events.register_subscribers! only
+# ever iterates the explicit Spree.subscribers array (see
+# spree_core/lib/spree/events.rb) — there is no Zeitwerk-descendant scan.
+# Without this file, SpreeDoordash::OrderCompletedSubscriber is a real,
+# loadable class (so specs calling it directly always passed) but is never
+# actually wired to the 'order.completed' event in the running app — found
+# live: a real storefront order completed with DoorDash Delivery selected
+# and never got dispatched, because nothing ever appended this subscriber
+# to Spree.subscribers. Mirrors spree_square's own identical registration
+# in its own config/initializers/spree.rb.
+Rails.application.config.after_initialize do
+  Spree.subscribers << SpreeDoordash::OrderCompletedSubscriber
+end

data/lib/spree_doordash/version.rb

@@ -1,5 +1,5 @@
 module SpreeDoordash
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.2'.freeze
 
   def gem_version
     Gem::Version.new(VERSION)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_doordash
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Amit Solanki
@@ -136,6 +136,7 @@ files:
 - app/views/spree/admin/doordash_delivery_mappings/index.html.erb
 - app/views/spree/admin/doordash_webhook_events/index.html.erb
 - config/brakeman.ignore
+- config/initializers/spree.rb
 - config/initializers/spree_admin_doordash_navigation.rb
 - config/initializers/spree_admin_doordash_tables.rb
 - config/initializers/spree_doordash_calculators.rb