spree_core 5.4.4 → 5.5.0.rc1

data/app/models/concerns/spree/webhook_payload_redaction.rb

@@ -1,88 +0,0 @@
-# frozen_string_literal: true
-
-module Spree
-  # Keeps single-use credentials out of the persisted webhook delivery log.
-  #
-  # Some events must carry a live credential to their subscriber — a storefront
-  # that owns its transactional emails needs the real password reset token to
-  # build the email. Delivering it over TLS to a merchant-configured endpoint is
-  # intended; keeping a readable copy in `spree_webhook_deliveries.payload` is
-  # not, because that column is queryable and is served back through the Admin
-  # API delivery log.
-  #
-  # Sensitive values are therefore replaced with {REDACTION_PLACEHOLDER} before
-  # the record is written, and re-attached in memory at send time so the
-  # outgoing request body is unchanged.
-  module WebhookPayloadRedaction
-    extend ActiveSupport::Concern
-
-    # Payload keys under `data` whose values are live credentials.
-    SENSITIVE_PAYLOAD_KEYS = %w[reset_token unsubscribe_token].freeze
-
-    REDACTION_PLACEHOLDER = '[REDACTED]'
-
-    # Splits a payload into the version safe to persist and the secrets held
-    # back from it.
-    #
-    # @param payload [Hash] the full event payload
-    # @return [Array(Hash, Hash)] redacted payload, and the extracted secrets
-    #   keyed as they appeared under `data`
-    def self.split(payload)
-      secrets = {}
-
-      redacted = transform_data_hashes(payload) do |data|
-        data.to_h do |key, value|
-          if SENSITIVE_PAYLOAD_KEYS.include?(key.to_s) && value.present?
-            secrets[secret_key_for(key)] = value
-            [key, REDACTION_PLACEHOLDER]
-          else
-            [key, value]
-          end
-        end
-      end
-
-      secrets.empty? ? [payload, {}] : [redacted, secrets]
-    end
-
-    # Re-attaches previously extracted secrets to a redacted payload.
-    #
-    # @param payload [Hash] the redacted payload
-    # @param secrets [Hash] secrets returned by {split}
-    # @return [Hash] the payload as it should go over the wire
-    def self.merge(payload, secrets)
-      return payload if secrets.blank?
-
-      transform_data_hashes(payload) do |data|
-        data.to_h do |key, value|
-          secret = secrets[secret_key_for(key)]
-          [key, secret.presence || value]
-        end
-      end
-    end
-
-    # Applies +block+ to every `data` hash on the payload.
-    #
-    # Both key forms are visited rather than only the first match: a payload
-    # carrying `:data` *and* `'data'` would otherwise leave one of them
-    # unredacted.
-    def self.transform_data_hashes(payload)
-      return payload unless payload.is_a?(Hash)
-
-      [:data, 'data'].reduce(payload) do |result, data_key|
-        data = result[data_key]
-        next result unless data.is_a?(Hash)
-
-        result.merge(data_key => yield(data))
-      end
-    end
-    private_class_method :transform_data_hashes
-
-    # Secrets are keyed by name alone. They cross an ActiveJob serialization
-    # boundary, which coerces symbol keys to strings, so the key form at split
-    # time cannot be relied on to still match at merge time.
-    def self.secret_key_for(key)
-      key.to_s
-    end
-    private_class_method :secret_key_for
-  end
-end

data/app/paginators/spree/shared/paginate.rb

@@ -1,30 +0,0 @@
-module Spree
-  module Shared
-    class Paginate
-      def initialize(collection, params)
-        Spree::Deprecation.warn('Spree::Shared::Paginate is deprecated and will be removed in Spree 5.5. Please use Kaminari instead.')
-
-        raise 'Kaminari is not installed. Please add it to your Gemfile.' unless defined?(Kaminari)
-
-        @collection = collection
-        @page       = params[:page]
-
-        per_page_limit = Spree::Api::Config[:api_v2_per_page_limit]
-
-        @per_page = if params[:per_page].to_i.between?(1, per_page_limit)
-                      params[:per_page]
-                    else
-                      Kaminari.config.default_per_page
-                    end
-      end
-
-      def call
-        collection.page(page).per(per_page)
-      end
-
-      private
-
-      attr_reader :collection, :page, :per_page
-    end
-  end
-end

data/app/presenters/spree/filters/price_presenter.rb

@@ -1,23 +0,0 @@
-module Spree
-  module Filters
-    class PricePresenter
-      def initialize(amount:, currency:)
-        Spree::Deprecation.warn('Spree::Filters::PricePresenter is deprecated and will be removed in Spree 5.5.')
-        @amount = amount.to_i
-        @currency = currency
-      end
-
-      def to_i
-        amount
-      end
-
-      def to_s
-        Spree::Money.new(amount, currency: currency, no_cents_if_whole: true).to_s
-      end
-
-      private
-
-      attr_reader :amount, :currency
-    end
-  end
-end

data/app/presenters/spree/filters/price_range_presenter.rb

@@ -1,30 +0,0 @@
-module Spree
-  module Filters
-    class PriceRangePresenter
-      def self.from_param(param, currency:)
-        prices = param.split('-')
-
-        new(
-          min_price: PricePresenter.new(amount: prices.first, currency: currency),
-          max_price: PricePresenter.new(amount: prices.last, currency: currency)
-        )
-      end
-
-      def initialize(min_price:, max_price:)
-        Spree::Deprecation.warn('Spree::Filters::PriceRangePresenter is deprecated and will be removed in Spree 5.5.')
-        @min_price = min_price
-        @max_price = max_price
-      end
-
-      attr_reader :min_price, :max_price
-
-      def to_param
-        "#{min_price.to_i}-#{max_price.to_i}"
-      end
-
-      def to_s
-        "#{min_price} - #{max_price}"
-      end
-    end
-  end
-end

data/app/presenters/spree/filters/quantified_price_range_presenter.rb

@@ -1,45 +0,0 @@
-module Spree
-  module Filters
-    class QuantifiedPriceRangePresenter
-      ALLOWED_QUANTIFIERS = [
-        :less_than,
-        :more_than
-      ].freeze
-
-      def initialize(price:, quantifier:)
-        Spree::Deprecation.warn('Spree::Filters::QuantifiedPriceRangePresenter is deprecated and will be removed in Spree 5.5.')
-        if ALLOWED_QUANTIFIERS.exclude?(quantifier.to_sym)
-          raise ArgumentError, "quantifier must be one of: #{ALLOWED_QUANTIFIERS.join(', ')}"
-        end
-
-        @price = price
-        @quantifier = quantifier.to_sym
-      end
-
-      def to_param
-        case quantifier
-        when :less_than
-          less_than_param
-        when :more_than
-          more_than_param
-        end
-      end
-
-      def to_s
-        "#{I18n.t("activerecord.attributes.spree/product.#{quantifier}")} #{price}"
-      end
-
-      private
-
-      attr_reader :price, :quantifier
-
-      def less_than_param
-        "0-#{price.to_i}"
-      end
-
-      def more_than_param
-        "#{price.to_i}-Infinity"
-      end
-    end
-  end
-end

data/app/presenters/spree/product_summary_presenter.rb

@@ -1,27 +0,0 @@
-module Spree
-  class ProductSummaryPresenter
-    include Rails.application.routes.url_helpers
-
-    def initialize(product)
-      Spree::Deprecation.warn('Spree::ProductSummaryPresenter is deprecated and will be removed in Spree 5.5.')
-      @product = product
-    end
-
-    def call
-      {
-        name: @product.name,
-        images: images
-      }
-    end
-
-    private
-
-    def images
-      @product.images.map do |image|
-        {
-          url_product: rails_representation_url(image.url(:product), only_path: true)
-        }
-      end
-    end
-  end
-end

data/app/presenters/spree/variants/options_presenter.rb

@@ -1,82 +0,0 @@
-module Spree
-  module Variants
-    class OptionsPresenter
-      WORDS_CONNECTOR = ', '.freeze
-
-      attr_reader :variant
-
-      delegate :option_values, to: :variant
-
-      def initialize(variant)
-        Spree::Deprecation.warn('Spree::Variants::OptionsPresenter is deprecated and will be removed in Spree 5.5. Please use Spree::Variant#options_text instead.')
-        @variant = variant
-      end
-
-      def to_sentence
-        options = option_values
-        options = sort_options(options)
-        options = present_options(options)
-
-        join_options(options)
-      end
-
-      def to_hash
-        options = option_values
-        options = sort_options(options)
-        options = present_options_as_hash(options)
-
-        join_hash_options(options)
-      end
-
-      private
-
-      def sort_options(options)
-        if options.first&.association(:option_type)&.loaded?
-          options.sort_by { |o| o.option_type.position }
-        else
-          options.includes(:option_type).sort_by { |o| o.option_type.position }
-        end
-      end
-
-      def present_options(options)
-        options.map do |ov|
-          method = "present_#{ov.option_type.name}_option"
-
-          respond_to?(method, true) ? send(method, ov) : present_option(ov)
-        end
-      end
-
-      def present_color_option(option)
-        "#{option.option_type.presentation}: #{option.presentation}"
-      end
-
-      def present_option(option)
-        "#{option.option_type.presentation}: #{option.presentation}"
-      end
-
-      def join_options(options)
-        options.to_sentence(words_connector: WORDS_CONNECTOR, two_words_connector: WORDS_CONNECTOR)
-      end
-
-      def present_options_as_hash(options)
-        options.map do |ov|
-          method = "present_#{ov.option_type.name}_option_as_hash"
-
-          respond_to?(method, true) ? send(method, ov) : present_option_as_hash(ov)
-        end
-      end
-
-      def present_option_as_hash(option)
-        {}.tap do |hash|
-          hash.store(option.option_type.presentation.downcase, option.presentation)
-        end
-      end
-
-      def join_hash_options(options)
-        return {} if options.empty?
-
-        options.inject(:merge).symbolize_keys
-      end
-    end
-  end
-end

data/app/services/spree/classifications/reposition.rb

@@ -1,23 +0,0 @@
-module Spree
-  module Classifications
-    # @deprecated This service is deprecated and will be removed in Spree 5.5.
-    class Reposition
-      prepend Spree::ServiceModule::Base
-
-      def call(classification:, position:)
-        Spree::Deprecation.warn(
-          "#{self.class.name} is deprecated and will be removed in Spree 5.5.",
-          caller_locations(2)
-        )
-        if position.is_a?(String) && !position.match(/^\d+$/)
-          return failure(nil, I18n.t('errors.messages.not_a_number'))
-        end
-
-        # Because position we get back is 0-indexed.
-        # acts_as_list is 1-indexed.
-        classification.insert_at(position.to_i + 1)
-        success(classification)
-      end
-    end
-  end
-end

data/app/sorters/spree/orders/sort.rb

@@ -1,10 +0,0 @@
-module Spree
-  module Orders
-    class Sort < ::Spree::BaseSorter
-      def initialize(*args)
-        Spree::Deprecation.warn('Spree::Orders::Sort is deprecated and will be removed in Spree 5.5.')
-        super
-      end
-    end
-  end
-end

data/lib/spree/core/controller_helpers/common.rb

@@ -1,14 +0,0 @@
-module Spree
-  module Core
-    module ControllerHelpers
-      # @deprecated This module is deprecated and will be removed in Spree 5.5.
-      module Common
-        def self.included(base)
-          Spree::Deprecation.warn(
-            'Spree::Core::ControllerHelpers::Common is deprecated and will be removed in Spree 5.5.'
-          )
-        end
-      end
-    end
-  end
-end

data/lib/spree/core/token_generator.rb

@@ -1,23 +0,0 @@
-module Spree
-  module Core
-    module TokenGenerator
-      def generate_token(model_class = Spree::Order)
-        Spree::Deprecation.warn('generate_token is deprecated and will be removed in Spree 5.5. Please use Rails secure token generator: https://api.rubyonrails.org/classes/ActiveRecord/SecureToken/ClassMethods.html')
-        loop do
-          token = "#{random_token}#{unique_ending}"
-          break token unless model_class.exists?(token: token)
-        end
-      end
-
-      private
-
-      def random_token
-        SecureRandom.urlsafe_base64(nil, false)
-      end
-
-      def unique_ending
-        (Time.now.to_f * 1000).to_i
-      end
-    end
-  end
-end

data/lib/spree/database_type_utilities.rb

@@ -1,22 +0,0 @@
-module Spree
-  # @deprecated Use the integer constant directly instead, eg. `2_147_483_647` for 4-byte signed integer max.
-  #   This module will be removed in Spree 5.5.
-  module DatabaseTypeUtilities
-    # Maximum value for a 4-byte signed integer (default database integer type)
-    INTEGER_MAX = (2**31) - 1
-
-    def self.maximum_value_for(data_type)
-      Spree::Deprecation.warn(
-        'Spree::DatabaseTypeUtilities.maximum_value_for is deprecated and will be removed in Spree 5.5. ' \
-        'Use the integer constant directly instead, eg. 2_147_483_647 for 4-byte signed integer max.'
-      )
-
-      case data_type
-      when :integer
-        INTEGER_MAX
-      else
-        raise ArgumentError, 'Currently only :integer argument is acceptable'
-      end
-    end
-  end
-end

data/lib/spree/testing_support/bar_ability.rb

@@ -1,14 +0,0 @@
-# Fake ability for testing administration
-class BarAbility
-  include CanCan::Ability
-
-  def initialize(user)
-    user ||= Spree::User.new
-    if user.has_spree_role? 'bar'
-      # allow dispatch to :admin, :index, and :show on Spree::Order
-      can [:admin, :index, :show], Spree::Order
-      # allow dispatch to :index, :show, :create and :update shipments on the admin
-      can [:admin, :manage], Spree::Shipment
-    end
-  end
-end

data/lib/spree/testing_support/factories/store_product_factory.rb

@@ -1,6 +0,0 @@
-FactoryBot.define do
-  factory :store_product, class: Spree::StoreProduct do
-    store
-    product
-  end
-end