spree_core 5.3.0.rc2 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4241192c0b403bb14c71969625a754c8697e3f2cdc643e2095ad87a013b11b8b
-  data.tar.gz: 2c747e6ad0a508d22442d959c8617b7bed0fd215b2606c4f889c6bba04c87507
+  metadata.gz: 955b622bdd29054fb4bdb3e336a4a72e36c03f20e54cec6704aed0ed00407f17
+  data.tar.gz: 2b0d4168fa45ce1814d16b42c54241b1b63034a586281bccd5fb6297f1634aac
 SHA512:
-  metadata.gz: 805d79f3e0e69417cd88b7304aabf4ac9b9a3df5ff04a3738c500ed6711b0ce8f3f5b1007e0ac7a90a865ec218e9ffc52d238c0ad79884316f04eba4f967cdeb
-  data.tar.gz: 250588209094b5acf8215c85c4616880794d38d01644c011c4bee3349df39f0a3b48826918f710715dc464dff06b03c827bd28efd687303038cee2bc4ec28e21
+  metadata.gz: 68f6b6296a2d489c54009a8d52586e268d01c7894785c6cf1d5d0d428a6e8fa2365b8b29296bbc4a4452004efedea81c397d73ceb3047f6e9d9e9370af41fc7e
+  data.tar.gz: 6ec77c2ecee5028ee57e03664dfb2fec39794867e04659fb0fcb1d7042287a8b912705f1c20674a9be68c00c0050a54d6cc3e05bc73b36f9112b1c2bfb931619

data/README.md

@@ -0,0 +1,116 @@
+# Spree Core
+
+[![Gem Version](https://badge.fury.io/rb/spree_core.svg)](https://badge.fury.io/rb/spree_core)
+
+Spree Core is the foundation of Spree Commerce, containing all the essential models, services, and business logic that power an e-commerce application.
+
+## Overview
+
+This gem provides:
+
+- **Domain Models** - Products, Variants, Orders, Payments, Shipments, Taxons, Stores, and more
+- **Services** - Cart operations, checkout flows, order management, inventory handling
+- **State Machines** - Order and payment state management
+- **Events System** - Publish/subscribe architecture for loose coupling
+- **Dependencies Injection** - Swappable service implementations via `Spree::Dependencies`
+- **Permissions** - CanCanCan-based authorization with Permission Sets
+
+## Installation
+
+This gem is included in every Spree installation. No additional steps are required.
+
+## Key Components
+
+### Models
+
+All models are namespaced under `Spree::` and include:
+
+- `Spree::Product` / `Spree::Variant` - Product catalog
+- `Spree::Order` / `Spree::LineItem` - Order management
+- `Spree::Payment` / `Spree::PaymentMethod` - Payment processing
+- `Spree::Shipment` / `Spree::ShippingMethod` - Shipping and fulfillment
+- `Spree::Taxon` / `Spree::Taxonomy` - Product categorization
+- `Spree::Store` - Multi-store support
+- `Spree::Promotion` - Promotions and discounts
+- `Spree::GiftCard` - Gift card functionality
+
+### Services
+
+Services follow a consistent interface pattern and are located in `app/services/spree/`:
+
+```ruby
+# Add item to cart
+Spree.cart_add_item_service.call(
+  order: order,
+  variant: variant,
+  quantity: 1
+)
+```
+
+### Events System
+
+Spree uses an event-driven architecture for decoupling components:
+
+```ruby
+# Publishing events
+order.publish_event('order.completed')
+
+# Subscribing to events
+module Spree
+  module MySubscriber
+    include Spree::Event::Subscriber
+
+    event_action :order_completed
+
+    def order_completed(event)
+      order = event.payload[:order]
+      # Handle the event
+    end
+  end
+end
+```
+
+### Dependencies
+
+Swap out default implementations with custom services:
+
+```ruby
+# config/initializers/spree.rb
+Spree::Dependencies.cart_add_item_service = 'MyCustom::CartAddItem'
+```
+
+## Configuration
+
+Configure Spree in an initializer:
+
+```ruby
+# config/initializers/spree.rb
+Spree.config do |config|
+  config.currency = 'USD'
+  config.default_country_iso = 'US'
+end
+```
+
+## Testing
+
+Spree Core includes testing support utilities:
+
+```ruby
+# spec/rails_helper.rb
+require 'spree/testing_support/factories'
+require 'spree/testing_support/authorization_helpers'
+```
+
+To run the test suite:
+
+```bash
+cd core
+bundle exec rake test_app  # First time only
+bundle exec rspec
+```
+
+## Documentation
+
+- [Official Documentation](https://docs.spreecommerce.org)
+- [API Reference](https://api.spreecommerce.org)
+- [Guides](https://docs.spreecommerce.org/developer)

data/app/models/spree/product.rb

@@ -367,6 +367,14 @@ module Spree
       variant_for_images&.primary_image
     end
 
+    # Backward compatibility for Spree 5.2 and earlier.
+    # @deprecated Use Spree::Product#default_image instead.
+    def featured_image
+      Spree::Deprecation.warn('Spree::Product#featured_image is deprecated and will be removed in Spree 5.5. Please use Spree::Product#default_image instead.')
+
+      default_image
+    end
+
     # Returns secondary Image for Product (for hover effects).
     # @return [Spree::Image, nil]
     def secondary_image

data/app/services/spree/data_feeds/google/required_attributes.rb

@@ -10,6 +10,7 @@ module Spree
           return failure(nil, error: 'No image link') if get_image_link(input[:variant], input[:product]).nil?
 
           information['id'] = input[:variant].id
+          information['item_group_id'] = input[:product].id
           information['title'] = format_title(input[:product], input[:variant])
           information['description'] = get_description(input[:product], input[:variant])
           information['link'] = "#{input[:store].url}/products/#{input[:product].slug}"
@@ -56,7 +57,7 @@ module Spree
         end
 
         def get_availability(product)
-          return 'in stock' if product.available? && product.available_on&.past?
+          return 'in stock' if product.available? && (product.available_on.nil? || product.available_on.past?)
           return 'backorder' if product.backorderable? && product.backordered? && product.available_on&.future?
 
           'out of stock'

data/app/services/spree/gift_cards/apply.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Applies a gift card to an order
 # under the hood it creates a store credit payment record and updates the gift card amount used
 # @param gift_card [Spree::GiftCard] the gift card to apply
@@ -16,6 +17,14 @@ module Spree
         # we shouldn't allow a gift card to be applied to an order with a different currency
         return failure(:gift_card_mismatched_currency) if gift_card.currency != order.currency
 
+        # gift card requires logged user
+        if gift_card.user.present?
+          # user must be logged in
+          return failure(:gift_card_customer_not_logged_in) if order.user.blank?
+          # user must be the same as the gift card user
+          return failure(:gift_card_mismatched_customer) if gift_card.user != order.user
+        end
+
         amount = [gift_card.amount_remaining, order.total].min
         store = order.store
 

data/config/locales/en.yml

@@ -1190,7 +1190,10 @@ en:
     gift_card_already_redeemed: The Gift Card has already been redeemed.
     gift_card_applied: The Gift Card was successfully applied to your order!
     gift_card_batch: Gift Card Batch
+    gift_card_customer_not_logged_in: Gift Card cannot be applied with guest user.
     gift_card_expired: The Gift Card has expired.
+    gift_card_mismatched_currency: Gift Card cannot be applied with current currency.
+    gift_card_mismatched_customer: This gift card is associated with another user.
     gift_card_removed: The Gift Card was successfully removed from your order
     gift_card_using_store_credit_error: You can't apply the Gift Card after you applied the store credit.
     gift_cards: Gift Cards

data/lib/spree/core/version.rb

@@ -1,5 +1,5 @@
 module Spree
-  VERSION = '5.3.0.rc2'.freeze
+  VERSION = '5.3.1'.freeze
 
   def self.version
     VERSION

data/lib/spree/testing_support/common_rake.rb

@@ -20,8 +20,7 @@ namespace :common do
     javascript_enabled = args[:javascript].to_b
     css_enabled = args[:css].to_b
 
-    # Admin and Storefront require JavaScript and CSS (Tailwind) to function properly
-    javascript_enabled ||= install_admin || install_storefront
+    # Admin and Storefront require CSS (Tailwind) to function properly
     css_enabled ||= install_admin || install_storefront
 
     puts args
@@ -32,9 +31,6 @@ namespace :common do
     dummy_app_args = [
       "--lib_name=#{ENV['LIB_NAME']}"
     ]
-    # Use API mode only if no frontend components are needed
-    use_api_mode = !install_storefront && !install_admin && !javascript_enabled && !css_enabled
-    dummy_app_args << '--api' if use_api_mode
     dummy_app_args << '--javascript' if javascript_enabled
     dummy_app_args << '--css=tailwind' if css_enabled
 
@@ -58,8 +54,17 @@ namespace :common do
     end
 
     # Run core Spree install generator
+    # The spree:install generator lives in the root spree gem. Core gems (spree_core, spree_api)
+    # don't have spree as a dependency, so we need to use the root Gemfile to access the generator.
+    # Other gems (admin, storefront, etc.) already have spree in their Gemfile.
+    core_gems = %w[spree/core spree/api]
+    root_gemfile = File.expand_path('../../../../Gemfile', __dir__)
+    use_root_gemfile = core_gems.include?(ENV['LIB_NAME']) &&
+                       File.exist?(root_gemfile) &&
+                       File.exist?(File.expand_path('../../../../spree.gemspec', __dir__))
+    bundle_exec = use_root_gemfile ? "bundle exec --gemfile=#{root_gemfile}" : 'bundle exec'
     puts 'Running Spree install generator...'
-    system("bundle exec rails g spree:install --force --auto-accept --migrate=false --seed=false --sample=false --user_class=#{args[:user_class]} --admin_user_class=#{args[:admin_user_class]} --authentication=#{args[:authentication]}")
+    system("#{bundle_exec} rails g spree:install --force --auto-accept --migrate=false --seed=false --sample=false --user_class=#{args[:user_class]} --admin_user_class=#{args[:admin_user_class]} --authentication=#{args[:authentication]}")
 
     # Determine if we need to install admin/storefront
     # Either via explicit flag or because we're testing that gem itself

data/lib/spree/testing_support/extension_rake.rb

@@ -4,6 +4,6 @@ desc 'Generates a dummy app for testing an extension'
 namespace :extension do
   task :test_app, [:authentication, :user_class] do |_t, args|
     Spree::DummyGeneratorHelper.inject_extension_requirements = true
-    Rake::Task['common:test_app'].execute(args.with_defaults(install_admin: true, install_storefront: true))
+    Rake::Task['common:test_app'].execute(args)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_core
 version: !ruby/object:Gem::Version
-  version: 5.3.0.rc2
+  version: 5.3.1
 platform: ruby
 authors:
 - Sean Schofield
@@ -107,6 +107,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.3.1
+- !ruby/object:Gem::Dependency
+  name: benchmark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: carmen
   requirement: !ruby/object:Gem::Requirement
@@ -566,6 +580,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - LICENSE.md
+- README.md
 - Rakefile
 - app/assets/config/spree_core_manifest.js
 - app/assets/images/google_on_white_hdpi.png
@@ -1702,9 +1717,9 @@ licenses:
 - BSD-3-Clause
 metadata:
   bug_tracker_uri: https://github.com/spree/spree/issues
-  changelog_uri: https://github.com/spree/spree/releases/tag/v5.3.0.rc2
+  changelog_uri: https://github.com/spree/spree/releases/tag/v5.3.1
   documentation_uri: https://docs.spreecommerce.org/
-  source_code_uri: https://github.com/spree/spree/tree/v5.3.0.rc2
+  source_code_uri: https://github.com/spree/spree/tree/v5.3.1
 rdoc_options: []
 require_paths:
 - lib
@@ -1719,7 +1734,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.8.23
 requirements: []
-rubygems_version: 4.0.2
+rubygems_version: 4.0.3
 specification_version: 4
 summary: The bare bones necessary for Spree
 test_files: []