spree_core 5.1.2 → 5.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a078eb338ddec6ce51734169a4a549a0beb103e9e771826813e9fba21cfd26a
-  data.tar.gz: be388de6fdef55db241a7f5eb5655bfeefe835eb68b3dbca2c4e5b0f46e4ddd2
+  metadata.gz: 90be1a32290303d4feb6a777d2a5ed2d88232edfa9998e748299df632346543f
+  data.tar.gz: 63b6aebfc73bdb8e56e945471245cb2ac4bff7afb09db4d4377b753ba6bcfe06
 SHA512:
-  metadata.gz: 411fc129ceb5be8c3c7486c14869906b4005ee3ea8caab930c0107d06c591ae865f22cf594c16896bedc3ff6d4a414b3acbe9f6fad9d981cc675d5dfe99f7188
-  data.tar.gz: 5b0e582898ce11cd04e842faef59eebda6fca7bdf991bae9a976bcb8ef97681c11dc8094989c9ec95b9c1d8d7987b691acceab8c64b94f366ce4af5c1725aa46
+  metadata.gz: 6f4cd428b66cee1b390d3710ff2d33d71a4d4ffcfa8648672937eb748a6c91993e1ec8d23495b099e25efc8790a8d0a093d849339f5659be6097ffb878bde293
+  data.tar.gz: 5c7186492fe423d5b8862771dd3767ad9f9d9fb5c00bd71a434c19a5b3d938c9a071579aa54594f235ad16e0c9bac64bfbab8d286a0f40ae5522cffe8c453b82

data/app/mailers/spree/base_mailer.rb

@@ -39,8 +39,12 @@ module Spree
     # this is only a fail-safe solution if developer didn't set this in environment files
     # http://guides.rubyonrails.org/action_mailer_basics.html#generating-urls-in-action-mailer-views
     def ensure_default_action_mailer_url_host(store_url = nil)
+      host_url = store_url.presence || current_store.try(:url_or_custom_domain)
+
+      return if host_url.blank?
+
       ActionMailer::Base.default_url_options ||= {}
-      ActionMailer::Base.default_url_options[:host] ||= store_url.presence || current_store.url
+      ActionMailer::Base.default_url_options[:host] = host_url
     end
 
     def set_email_locale

data/app/models/concerns/spree/user_payment_source.rb

@@ -9,7 +9,7 @@ module Spree
       end
 
       def payment_sources
-        credit_cards.with_payment_profile.not_expired.where(payment_method: Spree::PaymentMethod.active).not_removed
+        credit_cards.capturable.not_expired.where(payment_method: Spree::PaymentMethod.active).not_removed
       end
 
       def drop_payment_source(source)

data/app/models/spree/credit_card.rb

@@ -39,6 +39,7 @@ module Spree
     end
 
     scope :with_payment_profile, -> { where.not(gateway_customer_profile_id: nil) }
+    scope :capturable, -> { where.not(gateway_customer_profile_id: nil).or(where.not(gateway_payment_profile_id: nil)) }
     scope :default, -> { where(default: true) }
     scope :not_expired, lambda {
       where('CAST(spree_credit_cards.year AS DECIMAL) > ?', Time.current.year).

data/app/models/spree/custom_domain.rb

@@ -29,7 +29,7 @@ module Spree
       return if url.blank?
       parts = url.split('.')
 
-      errors.add(:url, 'use domain or subdomain') if (parts[0] != 'www' && parts.size > 3) || (parts[0] == 'www' && parts.size > 4) || parts.size < 2
+      errors.add(:url, 'use domain or subdomain') if parts.size > 4 || parts.size < 2
     end
 
     def ensure_default

data/app/models/spree/gateway.rb

@@ -67,7 +67,7 @@ module Spree
 
     def sources_by_order(order)
       source_ids = order.payments.where(source_type: payment_source_class.to_s, payment_method_id: id).pluck(:source_id).uniq
-      payment_source_class.where(id: source_ids).with_payment_profile
+      payment_source_class.where(id: source_ids).capturable
     end
 
     def reusable_sources(order)
@@ -75,7 +75,7 @@ module Spree
         sources_by_order order
       else
         if order.user_id
-          credit_cards.where(user_id: order.user_id).with_payment_profile
+          credit_cards.where(user_id: order.user_id).capturable
         else
           []
         end

data/app/models/spree/payment.rb

@@ -32,7 +32,7 @@ module Spree
     has_many :refunds, inverse_of: :payment
 
     validates :payment_method, presence: true
-    validates :source, presence: true, if: -> { payment_method&.source_required? }
+    validates :source, presence: true, if: :source_required?
     validate :payment_method_available_for_order, on: :create
 
     before_validation :validate_source
@@ -50,6 +50,7 @@ module Spree
     after_destroy :update_order
 
     attr_accessor :source_attributes, :request_env, :capture_on_dispatch
+    attribute :skip_source_requirement, :boolean, default: false
 
     after_initialize :build_source
 
@@ -247,6 +248,12 @@ module Spree
       source_class.respond_to?(:display_name) ? source_class.display_name : source_class.name.demodulize.split(/(?=[A-Z])/).join(' ')
     end
 
+    def source_required?
+      return false if skip_source_requirement
+
+      payment_method&.source_required?
+    end
+
     private
 
     def set_amount

data/app/models/spree/product/slugs.rb

@@ -11,11 +11,15 @@ module Spree
         friendly_id :slug_candidates, use: [:history, :slugged, :scoped, :mobility], scope: spree_base_uniqueness_scope, slug_limit: 255
 
         Product::Translation.class_eval do
-          before_save :set_slug
           acts_as_paranoid
           # deleted translation values also need to be accessible for index views listing deleted resources
           default_scope { unscope(where: :deleted_at) }
 
+          before_validation :set_slug
+          before_validation :ensure_slug_is_unique
+
+          validates :slug, presence: true, uniqueness: { allow_blank: true, case_sensitive: true, scope: [*::Spree.base_class.spree_base_uniqueness_scope, :locale] }
+
           private
 
           def set_slug
@@ -31,6 +35,11 @@ module Spree
               slug.to_url
             end
           end
+
+          def ensure_slug_is_unique
+            slug_exists = self.class.where(slug: slug, locale: locale).where.not(id: id).exists?
+            self.slug = [slug, SecureRandom.uuid].join('-') if slug_exists
+          end
         end
 
         before_validation :downcase_slug
@@ -57,8 +66,6 @@ module Spree
       def slug_candidates
         if defined?(:deleted_at) && deleted_at.present?
           [
-            ['deleted', :name],
-            ['deleted', :name, :sku],
             ['deleted', :name, :uuid_for_friendly_id]
           ]
         else
@@ -91,7 +98,7 @@ module Spree
         set_slug
         update_column(:slug, slug)
 
-        new_slug = ->(rec) { "deleted-#{rec.id}_#{rec.slug}"[..254] }
+        new_slug = ->(rec) { "deleted-#{rec.slug}-#{uuid_for_friendly_id}"[..254] }
 
         translations.with_deleted.each { |rec| rec.update_columns(slug: new_slug.call(rec)) }
         slugs.with_deleted.each { |rec| rec.update_column(:slug, new_slug.call(rec)) }

data/app/models/spree/shipment.rb

@@ -221,6 +221,11 @@ module Spree
       inventory_units.where(line_item_id: line_item.id, variant_id: line_item.variant_id || variant.id)
     end
 
+    # Returns the total quantity of all line items in the shipment
+    def item_quantity
+      manifest.sum(&:quantity)
+    end
+
     # Returns the cost of the shipment
     #
     # @return [BigDecimal]

data/app/services/spree/products/prepare_nested_attributes.rb

@@ -140,8 +140,8 @@ module Spree
           option_value_identificator = if opt[:option_value_name].present?
                                          opt[:option_value_name]
                                        else
-                                         opt[:option_value_presentation].parameterize
-                                       end.strip
+                                         opt[:option_value_presentation]
+                                       end.parameterize.strip
 
           option_value = option_type.option_values.where(name: option_value_identificator).first_or_initialize do |o|
             o.presentation = opt[:option_value_presentation]

data/lib/generators/spree/dummy/dummy_generator.rb

@@ -38,6 +38,7 @@ module Spree
       opts[:skip_spring] = true
       opts[:skip_test] = true
       opts[:skip_bootsnap] = true
+      opts[:skip_asset_pipeline] = true # skip installing propshaft, we're still using sprockets as a dependency
 
       puts 'Generating dummy Rails application...'
       invoke Rails::Generators::AppGenerator,

data/lib/spree/core/version.rb

@@ -1,5 +1,5 @@
 module Spree
-  VERSION = '5.1.2'.freeze
+  VERSION = '5.1.4'.freeze
 
   def self.version
     VERSION

data/lib/spree/testing_support/extension_rake.rb

@@ -2,7 +2,7 @@ require 'spree/testing_support/common_rake'
 
 desc 'Generates a dummy app for testing an extension'
 namespace :extension do
-  task :test_app, [:user_class] do |_t, args|
+  task :test_app, [:authentication, :user_class] do |_t, args|
     Spree::DummyGeneratorHelper.inject_extension_requirements = true
     Rake::Task['common:test_app'].execute(args.with_defaults(install_admin: true, install_storefront: true))
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_core
 version: !ruby/object:Gem::Version
-  version: 5.1.2
+  version: 5.1.4
 platform: ruby
 authors:
 - Sean Schofield
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-14 00:00:00.000000000 Z
+date: 2025-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n-tasks
@@ -1382,9 +1382,9 @@ licenses:
 - BSD-3-Clause
 metadata:
   bug_tracker_uri: https://github.com/spree/spree/issues
-  changelog_uri: https://github.com/spree/spree/releases/tag/v5.1.2
+  changelog_uri: https://github.com/spree/spree/releases/tag/v5.1.4
   documentation_uri: https://docs.spreecommerce.org/
-  source_code_uri: https://github.com/spree/spree/tree/v5.1.2
+  source_code_uri: https://github.com/spree/spree/tree/v5.1.4
 post_install_message:
 rdoc_options: []
 require_paths: