spree_core 4.3.0 → 4.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7b01cdb9b4fae7dbc504ec200b0ac4fad4c3d6f025879bfb8ff1204a39843cf
-  data.tar.gz: aef3c6e29b38409ad11305d669b56b5dabae08d0a653783dfab0230ce89bc5c6
+  metadata.gz: 4e5c1992fb7f20f237e3d088cc7c0c79692efb72eaec1e654069ee5b8aeeb846
+  data.tar.gz: 7dd674422290e6570f1b8bb116bd541cac61cbb403402a5996d829b304dac604
 SHA512:
-  metadata.gz: a221ccc5207cd316ff2102787e55f22ff9ade341d0d882ae4a2a2b476c2b62d8fba6463ab71af894b28eb9edc0fa98ee63fac1b03610e419d25d2845568faf77
-  data.tar.gz: d1086b0e7216ff453df0197c6a9c7620cee71340cefed09aea7fccbcd2b5be679bb8e0d34656231209bb7dc587ab757594a64809670c898805280ee4a19567bf
+  metadata.gz: 586c58de60df801c9f4e54983a929f8c507cb8b05c8161ff3f82bc0780a3a64ee33cc42d1ffa01dbea9ed7dce9dda4ced801ba0298b326e255d38314d1286539
+  data.tar.gz: 1aeebb1b70bd971a5589f265903a00cd9d6d3c38843968668000d7bf5277832280a2f3b6d7774d73845f2d45f72166873bfc01c493171f0bce973c4cc374c458

data/app/finders/spree/option_values/find_available.rb

@@ -9,12 +9,20 @@ module Spree
       end
 
       def execute
-        find_available(scope, products_scope)
+        find_available(scope, products_scope).includes(:translations).select(select_args).order(order_args)
       end
 
       private
 
       attr_reader :scope, :products_scope
+
+      def select_args
+        "#{OptionValue.table_name}.*, #{OptionType.table_name}.position AS option_type_position"
+      end
+
+      def order_args
+        "option_type_position, #{OptionValue.table_name}.position"
+      end
     end
   end
 end

data/app/finders/spree/product_properties/find_available.rb

@@ -9,7 +9,7 @@ module Spree
       end
 
       def execute
-        find_available(scope, products_scope)
+        find_available(scope, products_scope).includes(:translations)
       end
 
       private

data/app/finders/spree/products/find.rb

@@ -4,8 +4,6 @@ module Spree
       def initialize(scope:, params:, current_currency: nil)
         @scope = scope
 
-        ActiveSupport::Deprecation.warn('`current_currency` param is deprecated and will be removed in Spree 5') if current_currency
-
         if current_currency.present?
           ActiveSupport::Deprecation.warn(<<-DEPRECATION, caller)
             `current_currency` param is deprecated and will be removed in Spree 5.
@@ -148,13 +146,16 @@ module Spree
       def by_name(products)
         return products unless name?
 
-        products.like_any([:name], [name])
+        product_name = name
+
+        # i18n mobility scope doesn't automatically get set for query blocks (Mobility issue #599) - set it explicitly
+        products.i18n { name.matches("%#{product_name}%") }
       end
 
       def by_options(products)
         return products unless options?
 
-        products_ids = options.map { |key, value| products.with_option_value(key, value).ids }
+        products_ids = options.map { |key, value| products.with_option_value(key, value)&.ids }.compact.uniq
         products.where(id: products_ids.reduce(&:intersection))
       end
 
@@ -185,7 +186,7 @@ module Spree
 
           next if values.empty?
 
-          ids = products.with_property_values(property_filter_param, values).ids
+          ids = scope.unscope(:order, :includes).with_property_values(property_filter_param, values).ids
           product_ids = index == 0 ? ids : product_ids & ids
           index += 1
         end
@@ -211,21 +212,19 @@ module Spree
             products
           end
         when 'name-a-z'
-          products.order(name: :asc)
+          # workaround for Mobility issue #596 - explicitly select fields to avoid error when selecting distinct
+          products.i18n.
+            select("#{Product.table_name}.*").select(:name).order(name: :asc)
         when 'name-z-a'
-          products.order(name: :desc)
+          # workaround for Mobility issue #596
+          products.i18n.
+            select("#{Product.table_name}.*").select(:name).order(name: :desc)
         when 'newest-first'
           products.order(available_on: :desc)
         when 'price-high-to-low'
-          products.
-            select("#{Product.table_name}.*, #{Spree::Price.table_name}.amount").
-            reorder('').
-            send(:descend_by_master_price)
+          order_by_price(products, :descend_by_master_price)
         when 'price-low-to-high'
-          products.
-            select("#{Product.table_name}.*, #{Spree::Price.table_name}.amount").
-            reorder('').
-            send(:ascend_by_master_price)
+          order_by_price(products, :ascend_by_master_price)
         end
       end
 
@@ -257,7 +256,7 @@ module Spree
 
       def map_prices(prices)
         prices.map do |price|
-          price == 'Infinity' ? Float::INFINITY : price.to_f
+          price == 'Infinity' ? BigDecimal::INFINITY : price.to_f
         end
       end
 
@@ -267,6 +266,13 @@ module Spree
         taxons = store.taxons.where(id: taxons_ids.to_s.split(','))
         taxons.map(&:cached_self_and_descendants_ids).flatten.compact.uniq.map(&:to_s)
       end
+
+      def order_by_price(scope, order_type)
+        scope.
+          select("#{Product.table_name}.*, #{Spree::Price.table_name}.amount").
+          reorder('').
+          send(order_type)
+      end
     end
   end
 end

data/app/finders/spree/taxons/find.rb

@@ -19,7 +19,7 @@ module Spree
         taxons = by_roots(taxons)
         taxons = by_name(taxons)
 
-        taxons
+        taxons.distinct
       end
 
       private
@@ -50,10 +50,6 @@ module Spree
         name.present?
       end
 
-      def name_matcher
-        Spree::Taxon.arel_table[:name].matches("%#{name}%")
-      end
-
       def by_ids(taxons)
         return taxons unless ids?
 
@@ -70,9 +66,13 @@ module Spree
         return taxons unless parent_permalink?
 
         if Rails::VERSION::STRING >= '6.1'
-          taxons.joins(:parent).where(parent: { permalink: parent_permalink })
+          taxons.joins(:parent).
+            join_translation_table(Taxon, 'parents_spree_taxons').
+            where(["#{Taxon.translation_table_alias}.permalink = ?", parent_permalink])
         else
-          taxons.joins("INNER JOIN #{Spree::Taxon.table_name} AS parent_taxon ON parent_taxon.id = #{Spree::Taxon.table_name}.parent_id").where(["parent_taxon.permalink = ?", parent_permalink])
+          taxons.joins("INNER JOIN #{Spree::Taxon.table_name} AS parent_taxon ON parent_taxon.id = #{Spree::Taxon.table_name}.parent_id").
+            join_translation_table(Taxon, 'parent_taxon').
+            where(["#{Taxon.translation_table_alias}.permalink = ?", parent_permalink])
         end
       end
 
@@ -91,7 +91,10 @@ module Spree
       def by_name(taxons)
         return taxons unless name?
 
-        taxons.where(name_matcher)
+        taxon_name = name
+
+        # i18n mobility scope doesn't automatically get set for query blocks (Mobility issue #599) - set it explicitly
+        taxons.i18n { name.matches("%#{taxon_name}%") }
       end
     end
   end

data/app/helpers/spree/base_helper.rb

@@ -61,11 +61,11 @@ module Spree
       DEPRECATION
 
       image_path ||= if current_store.logo.attached? && current_store.logo.variable?
-                       main_app.url_for(current_store.logo.variant(resize: '244x104>'))
+                       main_app.cdn_image_url(current_store.logo.variant(resize_to_limit: [244, 104]))
                      elsif current_store.logo.attached? && current_store.logo.image?
-                       main_app.url_for(current_store.logo)
+                       main_app.cdn_image_url(current_store.logo)
                      else
-                       Spree::Config[:logo]
+                       'logo/spree_50.png'
                      end
 
       path = spree.respond_to?(:root_path) ? spree.root_path : main_app.root_path
@@ -76,7 +76,11 @@ module Spree
     end
 
     def spree_favicon_path
-      main_app.url_for(current_store.favicon || 'favicon.ico')
+      if current_store.favicon.present?
+        main_app.cdn_image_url(current_store.favicon)
+      else
+        url_for('favicon.ico')
+      end
     end
 
     def object
@@ -88,7 +92,7 @@ module Spree
 
       if object.is_a? Spree::Product
         image                             = default_image_for_product_or_variant(object)
-        og_meta['og:image']               = main_app.url_for(image.attachment) if image&.attachment
+        og_meta['og:image']               = main_app.cdn_image_url(image.attachment) if image&.attachment
 
         og_meta['og:url']                 = spree.url_for(object) if frontend_available? # url_for product needed
         og_meta['og:type']                = object.class.name.demodulize.downcase
@@ -109,8 +113,8 @@ module Spree
       meta = {}
 
       if object.is_a? ApplicationRecord
-        meta[:keywords] = object.meta_keywords if object[:meta_keywords].present?
-        meta[:description] = object.meta_description if object[:meta_description].present?
+        meta[:keywords] = object.meta_keywords if object.try(:meta_keywords).present?
+        meta[:description] = object.meta_description if object.try(:meta_description).present?
       end
 
       if meta[:description].blank? && object.is_a?(Spree::Product)
@@ -163,8 +167,7 @@ module Spree
     end
 
     def seo_url(taxon, options = {})
-      options.merge(locale: locale_param)
-      spree.nested_taxons_path(taxon.permalink, options)
+      spree.nested_taxons_path(taxon.permalink, options.merge(locale: locale_param))
     end
 
     def frontend_available?
@@ -238,7 +241,7 @@ module Spree
 
     def create_product_image_tag(image, product, options, style)
       options[:alt] = image.alt.blank? ? product.name : image.alt
-      image_tag main_app.url_for(image.url(style)), options
+      image_tag main_app.cdn_image_url(image.url(style)), options
     end
 
     def define_image_method(style)
@@ -249,7 +252,7 @@ module Spree
         img = if image_path.present?
                 create_product_image_tag image_path, product, options, style
               else
-               inline_svg_tag "noimage/backend-missing-image.svg", class: "noimage", size: "60%*60%"
+                inline_svg_tag 'noimage/backend-missing-image.svg', class: 'noimage', size: '60%*60%'
               end
 
         content_tag(:div, img, class: "admin-product-image-container #{style}-img")
@@ -269,9 +272,5 @@ module Spree
 
       tag('meta', name: 'robots', content: current_store.seo_robots)
     end
-
-    def taxon_wysiwyg_editor_enabled?
-      Spree::Config[:taxon_wysiwyg_editor_enabled]
-    end
   end
 end

data/app/helpers/spree/currency_helper.rb

@@ -1,7 +1,7 @@
 module Spree
   module CurrencyHelper
     def currency_options(selected_value = nil)
-      selected_value ||= Spree::Config[:currency]
+      selected_value ||= Spree::Store.default.default_currency
       currencies = ::Money::Currency.table.map do |_code, details|
         iso = details[:iso_code]
         [iso, "#{details[:name]} (#{iso})"]

data/app/helpers/spree/locale_helper.rb

@@ -15,10 +15,14 @@ module Spree
     end
 
     def locale_presentation(locale)
-      if I18n.exists?('spree.i18n.this_file_language', locale: locale)
+      if I18n.exists?('spree.i18n.this_file_language', locale: locale, fallback: false)
         [locale_full_name(locale), locale.to_s]
+      elsif defined?(SpreeI18n::Locale) && (language_name = SpreeI18n::Locale.local_language_name(locale))
+        ["#{language_name} (#{locale})", locale.to_s]
+      elsif locale.to_s == 'en'
+        ['English (US)', 'en']
       else
-        locale.to_s == 'en' ? ['English (US)', 'en'] : [locale, locale.to_s]
+        [locale, locale.to_s]
       end
     end
 

data/app/helpers/spree/products_helper.rb

@@ -44,20 +44,6 @@ module Spree
       variants_option_types_presenter(variants, product).options
     end
 
-    def product_wysiwyg_editor_enabled?
-      Spree::Config[:product_wysiwyg_editor_enabled]
-    end
-
-    # converts line breaks in product description into <p> tags (for html display purposes)
-    def product_description(product)
-      description = if Spree::Config[:show_raw_product_description] || product_wysiwyg_editor_enabled?
-                      product.description
-                    else
-                      product.description.to_s.gsub(/(.*?)\r?\n\r?\n/m, '<p>\1</p>')
-                    end
-      description.blank? ? Spree.t(:product_has_no_description) : description
-    end
-
     def line_item_description_text(description_text)
       if description_text.present?
         truncate(strip_tags(description_text.gsub('&nbsp;', ' ').squish), length: 100)
@@ -82,7 +68,7 @@ module Spree
       cache_key_elements.compact.join('/')
     end
 
-    def limit_descritpion(string)
+    def limit_description(string)
       return string if string.length <= 450
 
       string.slice(0..449) + '...'
@@ -90,15 +76,20 @@ module Spree
 
     # will return a human readable string
     def available_status(product)
-      return Spree.t(:discontinued) if product.discontinued?
+      ActiveSupport::Deprecation.warn(<<-DEPRECATION, caller)
+        `Spree::ProductsHelper#available_status` method from spree/core is deprecated and will be removed.
+        Please use `Spree::Admin::ProductsHelper#available_status` from spree_backend instead.
+      DEPRECATION
+
+      return Spree.t(:archived) if product.discontinued?
       return Spree.t(:deleted) if product.deleted?
 
       if product.available?
-        Spree.t(:available)
-      elsif product.available_on&.future?
+        Spree.t(:active)
+      elsif product.make_active_at&.future?
         Spree.t(:pending_sale)
       else
-        Spree.t(:no_available_date_set)
+        Spree.t(:draft)
       end
     end
 

data/app/jobs/spree/base_job.rb

@@ -0,0 +1,4 @@
+module Spree
+  class BaseJob < ApplicationJob
+  end
+end

data/app/jobs/spree/stock_locations/stock_items/create_job.rb

@@ -0,0 +1,13 @@
+module Spree
+  module StockLocations
+    module StockItems
+      class CreateJob < Spree::BaseJob
+        queue_as :spree_stock_location_stock_items
+
+        def perform(stock_location)
+          Spree::StockLocations::StockItems::Create.call(stock_location: stock_location)
+        end
+      end
+    end
+  end
+end

data/app/jobs/spree/variants/remove_from_incomplete_orders_job.rb

@@ -0,0 +1,9 @@
+module Spree
+  module Variants
+    class RemoveFromIncompleteOrdersJob < Spree::BaseJob
+      def perform(variant)
+        Spree::Variants::RemoveLineItems.call(variant: variant)
+      end
+    end
+  end
+end

data/app/jobs/spree/variants/remove_line_item_job.rb

@@ -0,0 +1,9 @@
+module Spree
+  module Variants
+    class RemoveLineItemJob < Spree::BaseJob
+      def perform(line_item:)
+        Spree::Dependencies.cart_remove_line_item_service.constantize.call(order: line_item.order, line_item: line_item)
+      end
+    end
+  end
+end

data/app/models/concerns/spree/calculated_adjustments.rb

@@ -18,7 +18,7 @@ module Spree
 
       def calculator_type=(calculator_type)
         klass = calculator_type.constantize if calculator_type
-        self.calculator = klass.new if klass && !calculator.is_a?(klass)
+        self.calculator = klass.new if klass && !calculator.instance_of?(klass)
       end
 
       private

data/app/models/concerns/spree/default_price.rb

@@ -4,7 +4,7 @@ module Spree
 
     included do
       has_one :default_price,
-              -> { with_deleted.where(currency: Spree::Config[:currency]) },
+              -> { with_deleted.where(currency: Spree::Store.default.default_currency) },
               class_name: 'Spree::Price',
               dependent: :destroy
 

data/app/models/concerns/spree/display_link.rb

@@ -1,42 +1,30 @@
 module Spree
   module DisplayLink
-    def link
-      case linked_resource_type
-      when 'Spree::Taxon'
-        return if linked_resource&.permalink.blank?
+    extend ActiveSupport::Concern
+
+    included do
+      belongs_to :linked_resource, polymorphic: true
+
+      def link
+        case linked_resource_type
+        when 'Spree::Taxon'
+          return if linked_resource&.permalink.blank?
 
-        if spree_routes.method_defined?(:nested_taxons_path)
-          spree_routes.nested_taxons_path(linked_resource.permalink)
-        else
           "/#{Spree::Config[:storefront_taxons_path]}/#{linked_resource.permalink}"
-        end
-      when 'Spree::Product'
-        return if linked_resource&.slug.blank?
+        when 'Spree::Product'
+          return if linked_resource&.slug.blank?
 
-        if spree_routes.method_defined?(:products_path)
-          spree_routes.product_path(linked_resource)
-        else
           "/#{Spree::Config[:storefront_products_path]}/#{linked_resource.slug}"
-        end
-      when 'Spree::CmsPage'
-        return if linked_resource&.slug.blank?
+        when 'Spree::CmsPage'
+          return if linked_resource&.slug.blank?
 
-        if spree_routes.method_defined?(:page_path)
-          spree_routes.page_path(linked_resource.slug)
-        else
           "/#{Spree::Config[:storefront_pages_path]}/#{linked_resource.slug}"
+        when 'Spree::Linkable::Homepage'
+          '/'
+        when 'Spree::Linkable::Uri'
+          destination
         end
-      when 'Home Page'
-        '/'
-      when 'URL'
-        destination
       end
     end
-
-    private
-
-    def spree_routes
-      Spree::Core::Engine.routes.url_helpers
-    end
   end
 end

data/app/models/concerns/spree/display_money.rb

@@ -27,7 +27,9 @@ module Spree
           define_method("display_#{method_name}") do |**args_list|
             default_opts = respond_to?(:currency) ? { currency: currency } : {}
 
-            Spree::Money.new(send(method_name, **args_list), default_opts.merge(opts).merge(args_list.slice(:currency)))
+            amount = args_list.blank? ? send(method_name) : send(method_name, **args_list)
+
+            Spree::Money.new(amount, default_opts.merge(opts).merge(args_list.slice(:currency)))
           end
         end
       end

data/app/models/concerns/spree/image_methods.rb

@@ -2,23 +2,35 @@ module Spree
   module ImageMethods
     extend ActiveSupport::Concern
 
-    def generate_url(size:, gravity: 'center', quality: 80, background: 'show')
+    def generate_url(size:, gravity: 'centre', quality: 80, background: [0, 0, 0])
       return if size.blank?
+
       size = size.gsub(/\s+/, '')
 
       return unless size.match(/(\d+)x(\d+)/)
 
-      polymorphic_path(attachment.variant(
-        gravity: gravity,
-        resize: size,
-        extent: size,
-        background: background,
-        quality: quality.to_i
-      ), only_path: true)
+      width, height = size.split('x').map(&:to_i)
+      gravity = translate_gravity_for_mini_magick(gravity)
+
+      # FIXME: bring back support for background color
+
+      cdn_image_url(attachment.variant(resize_and_pad: [width, height, { gravity: gravity }], saver: { quality: quality }))
     end
 
     def original_url
-      polymorphic_path(attachment, only_path: true)
+      cdn_image_url(attachment)
+    end
+
+    private
+
+    def translate_gravity_for_mini_magick(gravity)
+      variant_processor = Rails.application.config.active_storage.variant_processor
+
+      if gravity.downcase == 'centre' && [:mini_magick, nil].include?(variant_processor)
+        'center'
+      else
+        gravity
+      end
     end
   end
 end

data/app/models/concerns/spree/memoized_data.rb

@@ -3,7 +3,7 @@ module Spree
     extend ActiveSupport::Concern
 
     included do
-      # reset cache on save inside trasaction and transaction commit
+      # reset cache on save inside transaction and transaction commit
       after_save :reset_memoized_data
       after_commit :reset_memoized_data
 

data/app/models/concerns/spree/metadata.rb

@@ -0,0 +1,23 @@
+module Spree
+  module Metadata
+    extend ActiveSupport::Concern
+
+    included do
+      attribute :public_metadata, default: {}
+      attribute :private_metadata, default: {}
+      serialize :public_metadata, HashSerializer
+      serialize :private_metadata, HashSerializer
+    end
+
+    # https://nandovieira.com/using-postgresql-and-jsonb-with-ruby-on-rails
+    class HashSerializer
+      def self.dump(hash)
+        hash
+      end
+
+      def self.load(hash)
+        (hash || {}).with_indifferent_access
+      end
+    end
+  end
+end

data/app/models/concerns/spree/multi_store_resource.rb

@@ -16,7 +16,7 @@ module Spree
       errors.add(:stores, Spree.t(:must_have_one_store))
     end
 
-    # this can be overriden on model basis
+    # this can be overridden on model basis
     def disable_store_presence_validation?
       Spree::Config[:disable_store_presence_validation]
     end

data/app/models/concerns/spree/named_type.rb

@@ -6,7 +6,7 @@ module Spree
       scope :active, -> { where(active: true) }
       default_scope { order(Arel.sql("LOWER(#{table_name}.name)")) }
 
-      validates :name, presence: true, uniqueness: { case_sensitive: false }
+      include UniqueName
     end
   end
 end

data/app/models/concerns/spree/number_identifier.rb

@@ -0,0 +1,18 @@
+module Spree
+  module NumberIdentifier
+    extend ActiveSupport::Concern
+
+    included do
+      before_validation :uppercase_number
+
+      validates :number, presence: true, length: { maximum: 32, allow_blank: true },
+                         uniqueness: { allow_blank: true, case_sensitive: true, scope: spree_base_uniqueness_scope }
+    end
+
+    protected
+
+    def uppercase_number
+      number&.to_s&.upcase!
+    end
+  end
+end