spree_core 4.2.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a59c1e362e580d2884f8c82e1c15d2cdf057e21b1efc66e1ede10ef4e41883a8
-  data.tar.gz: cfe5bc95ed8d23c91c0c19dace8fe3d96b015cbcd97af1c38524b73c94797cac
+  metadata.gz: a07abab7dbe8d8b60a019e561b5668c3f336a7eb6970336b6a94b47046837fc1
+  data.tar.gz: 212b678f9f9df3a4de9de428bd9291fc87cd1f7020ed0c7f50b97c81fbd68a08
 SHA512:
-  metadata.gz: 420dbd7fdd44e2a4fa1d68d4d9e78a2fc42062757fc9470e57277bb7599fc3883b9e01a8052e5d0c34fb784361a5bc2b1b0b8e0e7bd7342860412e09e5799e70
-  data.tar.gz: 6b45c3c66e49701c0830b59e51ecb1776563abf078fc0728080479799dbbda443b4191c5f3af934cb663cdda6e824564b5891ec805950e87f949f0011b34430c
+  metadata.gz: 81e442e30106ce5756519d41717004ebcff0e6219f0e6fcfb563b3133b5635e5bde772ea3939edffac037f55f2eda42ca8ee69da69feb6f44f79d96f60fc4392
+  data.tar.gz: 02dd0236576e01b96c237d1989fee5a4ef669f4f4e39764b0a2ebbae26ad3847aca21915e0c6196a60088aa5f76bb817d6b478f9b04459d873f8508c00814b66

data/app/finders/concerns/spree/product_filterable.rb

@@ -0,0 +1,9 @@
+module Spree
+  module ProductFilterable
+    private
+
+    def find_available(scope, products_scope)
+      scope.filterable.for_products(products_scope)
+    end
+  end
+end

data/app/finders/spree/cms_pages/find.rb

@@ -0,0 +1,41 @@
+module Spree
+  module CmsPages
+    class Find < ::Spree::BaseFinder
+      ALLOWED_KINDS = %w[standard home feature].freeze
+
+      def initialize(scope:, params:)
+        @scope = scope
+        @title = params.dig(:filter, :title)
+        @kind  = params.dig(:filter, :type)
+      end
+
+      def execute
+        pages = by_title(scope)
+        pages = by_kind(pages)
+
+        pages
+      end
+
+      private
+
+      attr_reader :scope, :title, :kind
+
+      def title_matcher
+        Spree::CmsPage.arel_table[:title].matches("%#{title}%")
+      end
+
+      def by_title(pages)
+        return pages if title.blank?
+
+        pages.where(title_matcher)
+      end
+
+      def by_kind(pages)
+        return pages if kind.blank?
+        return pages if ALLOWED_KINDS.exclude?(kind)
+
+        pages.send(kind)
+      end
+    end
+  end
+end

data/app/finders/spree/menus/find.rb

@@ -0,0 +1,11 @@
+module Spree
+  module Menus
+    class Find < ::Spree::BaseFinder
+      def execute
+        return scope.where(location: params[:filter]['location']) if params[:filter].present? && params[:filter]['location'].present?
+
+        scope
+      end
+    end
+  end
+end

data/app/finders/spree/option_values/find_available.rb

@@ -0,0 +1,28 @@
+module Spree
+  module OptionValues
+    class FindAvailable
+      include ProductFilterable
+
+      def initialize(scope: OptionValue.spree_base_scopes, products_scope: Product.spree_base_scopes)
+        @scope = scope
+        @products_scope = products_scope
+      end
+
+      def execute
+        find_available(scope, products_scope).select(select_args).order(order_args)
+      end
+
+      private
+
+      attr_reader :scope, :products_scope
+
+      def select_args
+        "#{OptionValue.table_name}.*, #{OptionType.table_name}.position AS option_type_position"
+      end
+
+      def order_args
+        "option_type_position, #{OptionValue.table_name}.position"
+      end
+    end
+  end
+end

data/app/finders/spree/orders/find_complete.rb

@@ -1,18 +1,20 @@
 module Spree
   module Orders
     class FindComplete
-      attr_reader :user, :number, :token
+      attr_reader :user, :number, :token, :store
 
-      def initialize(user: nil, number: nil, token: nil)
+      def initialize(user: nil, number: nil, token: nil, store: nil)
         @user = user
         @number = number
         @token = token
+        @store = store
       end
 
       def execute
         orders = by_user(scope)
         orders = by_number(orders)
         orders = by_token(orders)
+        orders = by_store(orders)
 
         orders
       end
@@ -35,6 +37,10 @@ module Spree
         token.present?
       end
 
+      def store?
+        store.present?
+      end
+
       def by_user(orders)
         return orders unless user?
 
@@ -53,6 +59,12 @@ module Spree
         orders.where(token: token)
       end
 
+      def by_store(orders)
+        return orders unless store?
+
+        orders.where(store: store)
+      end
+
       def scope_includes
         {
           line_items: [

data/app/finders/spree/orders/find_current.rb

@@ -15,19 +15,7 @@ module Spree
       private
 
       def incomplete_orders
-        Spree::Order.incomplete.not_canceled.includes(scope_includes)
-      end
-
-      def scope_includes
-        {
-          line_items: [
-            variant: [
-              :images,
-              option_values: :option_type,
-              product: :product_properties,
-            ]
-          ]
-        }
+        Spree::Order.incomplete.not_canceled
       end
     end
   end

data/app/finders/spree/product_properties/find_available.rb

@@ -0,0 +1,20 @@
+module Spree
+  module ProductProperties
+    class FindAvailable
+      include ProductFilterable
+
+      def initialize(scope: ProductProperty.spree_base_scopes, products_scope: Product.spree_base_scopes)
+        @scope = scope
+        @products_scope = products_scope
+      end
+
+      def execute
+        find_available(scope, products_scope)
+      end
+
+      private
+
+      attr_reader :scope, :products_scope
+    end
+  end
+end

data/app/finders/spree/products/find.rb

@@ -1,13 +1,23 @@
 module Spree
   module Products
     class Find
-      def initialize(scope:, params:, current_currency:)
+      def initialize(scope:, params:, current_currency: nil)
         @scope = scope
 
+        ActiveSupport::Deprecation.warn('`current_currency` param is deprecated and will be removed in Spree 5') if current_currency
+
+        if current_currency.present?
+          ActiveSupport::Deprecation.warn(<<-DEPRECATION, caller)
+            `current_currency` param is deprecated and will be removed in Spree 5.
+            Please pass `:currency` in `params` hash instead.
+          DEPRECATION
+        end
+
         @ids              = String(params.dig(:filter, :ids)).split(',')
         @skus             = String(params.dig(:filter, :skus)).split(',')
-        @price            = String(params.dig(:filter, :price)).split(',').map(&:to_f)
-        @currency         = current_currency
+        @store            = params[:store] || Spree::Store.default
+        @price            = map_prices(String(params.dig(:filter, :price)).split(','))
+        @currency         = current_currency || params.dig(:filter, :currency) || params[:currency]
         @taxons           = taxon_ids(params.dig(:filter, :taxons))
         @concat_taxons    = taxon_ids(params.dig(:filter, :concat_taxons))
         @name             = params.dig(:filter, :name)
@@ -16,6 +26,10 @@ module Spree
         @sort_by          = params.dig(:sort_by)
         @deleted          = params.dig(:filter, :show_deleted)
         @discontinued     = params.dig(:filter, :show_discontinued)
+        @properties       = params.dig(:filter, :properties)
+        @in_stock         = params.dig(:filter, :in_stock)
+        @backorderable    = params.dig(:filter, :backorderable)
+        @purchasable      = params.dig(:filter, :purchasable)
       end
 
       def execute
@@ -28,8 +42,12 @@ module Spree
         products = by_name(products)
         products = by_options(products)
         products = by_option_value_ids(products)
+        products = by_properties(products)
         products = include_deleted(products)
         products = include_discontinued(products)
+        products = show_only_stock(products)
+        products = show_only_backorderable(products)
+        products = show_only_purchasable(products)
         products = ordered(products)
 
         products.distinct
@@ -37,8 +55,8 @@ module Spree
 
       private
 
-      attr_reader :ids, :skus, :price, :currency, :taxons, :concat_taxons, :name, :options,
-                  :option_value_ids, :scope, :sort_by, :deleted, :discontinued
+      attr_reader :ids, :skus, :price, :currency, :taxons, :concat_taxons, :name, :options, :option_value_ids, :scope,
+                  :sort_by, :deleted, :discontinued, :properties, :store, :in_stock, :backorderable, :purchasable
 
       def ids?
         ids.present?
@@ -80,8 +98,8 @@ module Spree
         sort_by.present?
       end
 
-      def name_matcher
-        Spree::Product.arel_table[:name].matches("%#{name}%")
+      def properties?
+        properties.present? && properties.values.reject(&:empty?).present?
       end
 
       def by_ids(products)
@@ -99,19 +117,13 @@ module Spree
       def by_price(products)
         return products unless price?
 
-        products.joins(master: :prices).
-          where(
-            spree_prices: {
-              amount: price.min..price.max,
-              currency: currency&.upcase
-            }
-          )
+        products.price_between(price.min, price.max)
       end
 
       def by_currency(products)
         return products unless currency?
 
-        products.joins(master: :prices).where(spree_prices: { currency: currency.upcase })
+        products.with_currency(currency)
       end
 
       def by_taxons(products)
@@ -136,17 +148,14 @@ module Spree
       def by_name(products)
         return products unless name?
 
-        products.where(name_matcher)
+        products.like_any([:name], [name])
       end
 
       def by_options(products)
         return products unless options?
 
-        products.where(
-          id: options.map do |key, value|
-            products.with_option_value(key, value).ids
-          end.flatten.compact.uniq
-        )
+        products_ids = options.map { |key, value| products.with_option_value(key, value)&.ids }.compact.uniq
+        products.where(id: products_ids.reduce(&:intersection))
       end
 
       def by_option_value_ids(products)
@@ -163,6 +172,27 @@ module Spree
         products.where(id: product_ids)
       end
 
+      def by_properties(products)
+        return products unless properties?
+
+        product_ids = []
+        index = 0
+
+        properties.to_unsafe_hash.each do |property_filter_param, product_properties_values|
+          next if property_filter_param.blank? || product_properties_values.empty?
+
+          values = product_properties_values.split(',').reject(&:empty?).uniq.map(&:parameterize)
+
+          next if values.empty?
+
+          ids = products.with_property_values(property_filter_param, values).ids
+          product_ids = index == 0 ? ids : product_ids & ids
+          index += 1
+        end
+
+        products.where(id: product_ids)
+      end
+
       def option_types_count(option_value_ids)
         Spree::OptionValue.
           where(id: option_value_ids).
@@ -176,12 +206,14 @@ module Spree
         case sort_by
         when 'default'
           if taxons?
-            products.
-              select("#{Product.table_name}.*, #{Classification.table_name}.position").
-              order("#{Classification.table_name}.position" => :asc)
+            products.ascend_by_taxons_min_position(taxons)
           else
             products
           end
+        when 'name-a-z'
+          products.order(name: :asc)
+        when 'name-z-a'
+          products.order(name: :desc)
         when 'newest-first'
           products.order(available_on: :desc)
         when 'price-high-to-low'
@@ -202,13 +234,37 @@ module Spree
       end
 
       def include_discontinued(products)
-        discontinued ? products : products.available
+        discontinued ? products : products.active(currency)
+      end
+
+      def show_only_stock(products)
+        return products unless in_stock.to_s == 'true'
+
+        products.in_stock
+      end
+
+      def show_only_backorderable(products)
+        return products unless backorderable.to_s == 'true'
+
+        products.backorderable
+      end
+
+      def show_only_purchasable(products)
+        return products unless purchasable.to_s == 'true'
+
+        products.in_stock_or_backorderable
+      end
+
+      def map_prices(prices)
+        prices.map do |price|
+          price == 'Infinity' ? Float::INFINITY : price.to_f
+        end
       end
 
       def taxon_ids(taxons_ids)
         return if taxons_ids.nil? || taxons_ids.to_s.blank?
 
-        taxons = Spree::Taxon.where(id: taxons_ids.to_s.split(','))
+        taxons = store.taxons.where(id: taxons_ids.to_s.split(','))
         taxons.map(&:cached_self_and_descendants_ids).flatten.compact.uniq.map(&:to_s)
       end
     end

data/app/finders/spree/stores/find_current.rb

@@ -0,0 +1,24 @@
+module Spree
+  module Stores
+    class FindCurrent
+      def initialize(scope: nil, url: nil)
+        @scope = scope || Spree::Store
+        @url = url
+      end
+
+      def execute
+        by_url(scope) || scope.default
+      end
+
+      protected
+
+      attr_reader :scope, :url
+
+      def by_url(scope)
+        return if url.blank?
+
+        scope.by_url(url).first
+      end
+    end
+  end
+end

data/app/finders/spree/taxons/find.rb

@@ -3,16 +3,18 @@ module Spree
     class Find
       def initialize(scope:, params:)
         @scope = scope
-        @ids      = String(params.dig(:filter, :ids)).split(',')
-        @parent   = params.dig(:filter, :parent_id)
-        @taxonomy = params.dig(:filter, :taxonomy_id)
-        @name     = params.dig(:filter, :name)
-        @roots    = params.dig(:filter, :roots)
+        @ids              = String(params.dig(:filter, :ids)).split(',')
+        @parent           = params.dig(:filter, :parent_id)
+        @parent_permalink = params.dig(:filter, :parent_permalink)
+        @taxonomy         = params.dig(:filter, :taxonomy_id)
+        @name             = params.dig(:filter, :name)
+        @roots            = params.dig(:filter, :roots)
       end
 
       def execute
         taxons = by_ids(scope)
         taxons = by_parent(taxons)
+        taxons = by_parent_permalink(taxons)
         taxons = by_taxonomy(taxons)
         taxons = by_roots(taxons)
         taxons = by_name(taxons)
@@ -22,7 +24,7 @@ module Spree
 
       private
 
-      attr_reader :ids, :parent, :taxonomy, :roots, :name, :scope
+      attr_reader :ids, :parent, :parent_permalink, :taxonomy, :roots, :name, :scope
 
       def ids?
         ids.present?
@@ -32,6 +34,10 @@ module Spree
         parent.present?
       end
 
+      def parent_permalink?
+        parent_permalink.present?
+      end
+
       def taxonomy?
         taxonomy.present?
       end
@@ -60,6 +66,16 @@ module Spree
         taxons.where(parent_id: parent)
       end
 
+      def by_parent_permalink(taxons)
+        return taxons unless parent_permalink?
+
+        if Rails::VERSION::STRING >= '6.1'
+          taxons.joins(:parent).where(parent: { permalink: parent_permalink })
+        else
+          taxons.joins("INNER JOIN #{Spree::Taxon.table_name} AS parent_taxon ON parent_taxon.id = #{Spree::Taxon.table_name}.parent_id").where(["parent_taxon.permalink = ?", parent_permalink])
+        end
+      end
+
       def by_taxonomy(taxons)
         return taxons unless taxonomy?
 

data/app/helpers/spree/base_helper.rb

@@ -9,6 +9,25 @@ module Spree
       end.sort_by { |c| c.name.parameterize }
     end
 
+    def all_countries
+      countries = Spree::Country.all
+
+      countries.collect do |country|
+        country.name = Spree.t(country.iso, scope: 'country_names', default: country.name)
+        country
+      end.sort_by { |c| c.name.parameterize }
+    end
+
+    def spree_resource_path(resource)
+      last_word = resource.class.name.split('::', 10).last
+
+      spree_class_name_as_path(last_word)
+    end
+
+    def spree_class_name_as_path(class_name)
+      class_name.underscore.humanize.parameterize(separator: '_')
+    end
+
     def display_price(product_or_variant)
       product_or_variant.
         price_in(current_currency).
@@ -36,12 +55,17 @@ module Spree
     end
 
     def logo(image_path = nil, options = {})
+      ActiveSupport::Deprecation.warn(<<-DEPRECATION, caller)
+        `BaseHelper#logo` is deprecated and will be removed in Spree 5.0.
+        Please use `FrontendHelper#logo` instead
+      DEPRECATION
+
       image_path ||= if current_store.logo.attached? && current_store.logo.variable?
                        main_app.url_for(current_store.logo.variant(resize: '244x104>'))
                      elsif current_store.logo.attached? && current_store.logo.image?
                        main_app.url_for(current_store.logo)
                      else
-                       Spree::Config[:logo]
+                      'logo/spree_50.png'
                      end
 
       path = spree.respond_to?(:root_path) ? spree.root_path : main_app.root_path
@@ -51,6 +75,10 @@ module Spree
       end
     end
 
+    def spree_favicon_path
+      main_app.url_for(current_store.favicon || 'favicon.ico')
+    end
+
     def object
       instance_variable_get('@' + controller_name.singularize)
     end
@@ -95,7 +123,7 @@ module Spree
                               description: [object.name, current_store.meta_description].reject(&:blank?).join(', '))
         else
           meta.reverse_merge!(keywords: (current_store.meta_keywords || current_store.seo_title),
-                              description: (current_store.meta_description || current_store.seo_title))
+                              description: (current_store.homepage(I18n.locale)&.seo_meta_description || current_store.seo_meta_description))
         end
       end
       meta
@@ -143,6 +171,34 @@ module Spree
       Spree::Core::Engine.frontend_available?
     end
 
+    def rails_5?
+      Rails::VERSION::STRING < '6.0'
+    end
+
+    def spree_storefront_resource_url(resource, options = {})
+      if defined?(locale_param) && locale_param.present?
+        options.merge!(locale: locale_param)
+      end
+
+      localize = if options[:locale].present?
+                   "/#{options[:locale]}"
+                 else
+                   ''
+                 end
+
+      if resource.instance_of?(Spree::Product)
+        "#{current_store.formatted_url + localize}/#{Spree::Config[:storefront_products_path]}/#{resource.slug}"
+      elsif resource.instance_of?(Spree::Taxon)
+        "#{current_store.formatted_url + localize}/#{Spree::Config[:storefront_taxons_path]}/#{resource.permalink}"
+      elsif resource.instance_of?(Spree::Cms::Pages::FeaturePage) || resource.instance_of?(Spree::Cms::Pages::StandardPage)
+        "#{current_store.formatted_url + localize}/#{Spree::Config[:storefront_pages_path]}/#{resource.slug}"
+      elsif localize.blank?
+        current_store.formatted_url
+      else
+        current_store.formatted_url + localize
+      end
+    end
+
     # we should always try to render image of the default variant
     # same as it's done on PDP
     def default_image_for_product(product)
@@ -170,7 +226,8 @@ module Spree
     end
 
     def base_cache_key
-      [I18n.locale, current_currency]
+      [I18n.locale, current_currency, defined?(try_spree_current_user) && try_spree_current_user.present?,
+       defined?(try_spree_current_user) && try_spree_current_user.try(:has_spree_role?, 'admin')]
     end
 
     def maximum_quantity
@@ -189,11 +246,13 @@ module Spree
         options = options.first || {}
         options[:alt] ||= product.name
         image_path = default_image_for_product_or_variant(product)
-        if image_path.present?
-          create_product_image_tag image_path, product, options, style
-        else
-          image_tag "noimage/#{style}.png", options
-        end
+        img = if image_path.present?
+                create_product_image_tag image_path, product, options, style
+              else
+               inline_svg_tag "noimage/backend-missing-image.svg", class: "noimage", size: "60%*60%"
+              end
+
+        content_tag(:div, img, class: "admin-product-image-container #{style}-img")
       end
     end
 

data/app/helpers/spree/currency_helper.rb

@@ -1,7 +1,7 @@
 module Spree
   module CurrencyHelper
     def currency_options(selected_value = nil)
-      selected_value ||= Spree::Config[:currency]
+      selected_value ||= Spree::Store.default.default_currency
       currencies = ::Money::Currency.table.map do |_code, details|
         iso = details[:iso_code]
         [iso, "#{details[:name]} (#{iso})"]
@@ -12,7 +12,7 @@ module Spree
     def supported_currency_options
       return if current_store.nil?
 
-      current_store.supported_currencies_list.map(&:iso_code)
+      current_store.supported_currencies_list.map(&:iso_code).map { |currency| currency_presentation(currency) }
     end
 
     def should_render_currency_dropdown?
@@ -20,5 +20,15 @@ module Spree
 
       current_store.supported_currencies_list.size > 1
     end
+
+    def currency_symbol(currency)
+      ::Money::Currency.find(currency).symbol
+    end
+
+    def currency_presentation(currency)
+      label = [currency_symbol(currency), currency].compact.join(' ')
+
+      [label, currency]
+    end
   end
 end

data/app/helpers/spree/locale_helper.rb

@@ -16,12 +16,16 @@ module Spree
 
     def locale_presentation(locale)
       if I18n.exists?('spree.i18n.this_file_language', locale: locale)
-        [Spree.t('i18n.this_file_language', locale: locale), locale.to_s]
+        [locale_full_name(locale), locale.to_s]
       else
         locale.to_s == 'en' ? ['English (US)', 'en'] : [locale, locale.to_s]
       end
     end
 
+    def locale_full_name(locale)
+      Spree.t('i18n.this_file_language', locale: locale)
+    end
+
     def should_render_locale_dropdown?
       return false if current_store.nil?