spree_core 3.0.9 → 3.2.0

data/spec/models/spree/calculator_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
-describe Spree::Calculator, :type => :model do
+describe Spree::Calculator, type: :model do
 
   let(:order) { create(:order) }
-  let!(:line_item) { create(:line_item, :order => order) }
-  let(:shipment) { create(:shipment, :order => order, :stock_location => create(:stock_location_with_items)) }
+  let!(:line_item) { create(:line_item, order: order) }
+  let(:shipment) { create(:shipment, order: order, stock_location: create(:stock_location_with_items)) }
 
   context "with computable" do
     context "and compute methods stubbed out" do

data/spec/models/spree/classification_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module Spree
-  describe Classification, :type => :model do
+  describe Classification, type: :model do
     # Regression test for #3494
     it "cannot link the same taxon to the same product more than once" do
       product = create(:product)

data/spec/models/spree/concerns/user_methods_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe Spree::UserMethods do
+  let(:test_user) { create :user }
+
+  describe 'Associations' do
+    subject { test_user }
+
+    it 'should have many promotion_rule_users' do
+      is_expected.to have_many(:promotion_rule_users).with_foreign_key(:user_id).
+        class_name('Spree::PromotionRuleUser').dependent(:destroy)
+    end
+
+    it 'should have many role_users' do
+      is_expected.to have_many(:role_users).class_name('Spree::RoleUser').
+        with_foreign_key(:user_id).dependent(:destroy)
+    end
+  end
+
+  describe '#has_spree_role?' do
+    subject { test_user.has_spree_role? name }
+
+    let(:role) { Spree::Role.create(name: name) }
+    let(:name) { 'test' }
+
+    context 'with a role' do
+      before { test_user.spree_roles << role }
+      it { is_expected.to be_truthy }
+    end
+
+    context 'without a role' do
+      it { is_expected.to be_falsy }
+    end
+  end
+
+  describe '#last_incomplete_spree_order' do
+    subject { test_user.last_incomplete_spree_order }
+
+    context 'with an incomplete order' do
+      let(:last_incomplete_order) { create :order, user: test_user }
+
+      before do
+        create(:order, user: test_user, created_at: 1.day.ago)
+        create(:order, user: create(:user))
+        last_incomplete_order
+      end
+
+      it { is_expected.to eq last_incomplete_order }
+    end
+
+    context 'without an incomplete order' do
+      it { is_expected.to be_nil }
+    end
+  end
+
+  context '#check_completed_orders' do
+    let(:possible_promotion) { create(:promotion, advertise: true, starts_at: 1.day.ago) }
+    context 'rstrict t delete dependent destroyed' do
+      before do
+        test_user.promotion_rules.create!(promotion: possible_promotion)
+        create(:order, user: test_user, completed_at: Time.current)
+      end
+
+      it 'should not destroy dependent destroy items' do
+        expect { test_user.destroy }.to raise_error(Spree::Core::DestroyWithOrdersError)
+        expect(test_user.promotion_rule_users.any?).to be(true)
+      end
+    end
+
+    context 'allow to destroy dependent destroy' do
+      before do
+        test_user.promotion_rules.create!(promotion: possible_promotion)
+        create(:order, user: test_user, created_at: 1.day.ago)
+        test_user.destroy
+      end
+
+      it 'should not destroy dependent destroy items' do
+        expect(test_user.promotion_rule_users.any?).to be(false)
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/vat_price_calculation_spec.rb

@@ -0,0 +1,66 @@
+require "spec_helper"
+
+module Spree
+  describe VatPriceCalculation do
+    let(:test_class) do
+      Class.new do
+        include VatPriceCalculation
+        def total; 10.0; end
+      end
+    end
+
+    describe "#gross_amount" do
+      let(:zone) { Zone.new }
+      let(:tax_category) { TaxCategory.new }
+      let(:price_options) do
+        {
+          tax_zone: zone,
+          tax_category: tax_category
+        }
+      end
+      let(:amount) { 100 }
+
+      subject(:gross_amount) { test_class.new.gross_amount(amount, price_options) }
+
+      context "with no default zone set" do
+        it "does not call TaxRate.included_tax_amount_for" do
+          expect(TaxRate).not_to receive(:included_tax_amount_for)
+          gross_amount
+        end
+      end
+
+      context "with no zone given" do
+        let(:zone) { nil }
+        it "does not call TaxRate.included_tax_amount_for" do
+          expect(TaxRate).not_to receive(:included_tax_amount_for)
+          gross_amount
+        end
+      end
+
+      context "with a default zone set" do
+        let(:default_zone) { Spree::Zone.new }
+        before do
+          allow(Spree::Zone).to receive(:default_tax).and_return(default_zone)
+        end
+
+        context "and zone equal to the default zone" do
+          let(:zone) { default_zone }
+
+          it "does not call 'TaxRate.included_tax_amount_for'" do
+            expect(TaxRate).not_to receive(:included_tax_amount_for)
+            gross_amount
+          end
+        end
+
+        context "and zone not equal to default zone" do
+          let(:zone) { Spree::Zone.new }
+
+          it "calls TaxRate.included_tax_amount_for two times" do
+            expect(TaxRate).to receive(:included_tax_amount_for).twice
+            gross_amount
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/country_spec.rb

@@ -1,18 +1,55 @@
 require 'spec_helper'
 
 describe Spree::Country, type: :model do
+  let(:america) { create :country }
+  let(:canada)  { create :country, name: 'Canada', iso_name: 'CANADA', numcode: '124' }
+
+  describe 'Callbacks' do
+    it { is_expected.to callback(:ensure_not_default).before(:destroy) }
+  end
+
+  describe 'Associations' do
+    it { is_expected.to have_many(:addresses).dependent(:restrict_with_error) }
+  end
+
+  describe 'Validations' do
+    it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_presence_of(:iso_name) }
+    it { is_expected.to validate_uniqueness_of(:iso_name).case_insensitive }
+    it { is_expected.to validate_uniqueness_of(:name).case_insensitive }
+  end
+
   describe '.default' do
-    let(:america) { create :country }
-    let(:canada)  { create :country, name: 'Canada' }
+    context 'when default_country_id config is set' do
+      before { Spree::Config[:default_country_id] = canada.id }
+      it 'will return the country from the config' do
+        expect(described_class.default.id).to eql canada.id
+      end
+    end
+
+    context 'config is not set though record for america exists' do
+      before { america.touch }
+      it 'will return the US' do
+        expect(described_class.default.id).to eql america.id
+      end
+    end
+  end
+
+  describe 'ensure default country in not deleted' do
+    before { Spree::Config[:default_country_id] = america.id }
+
+    context 'will not destroy country if it is default' do
+      subject { america.destroy }
+      it { is_expected.to be_falsy }
 
-    it 'will return the country from the config' do
-      Spree::Config[:default_country_id] = canada.id
-      expect(described_class.default.id).to eql canada.id
+      context 'error should be default country cannot be deleted' do
+        before { subject }
+        it { expect(america.errors[:base]).to include(Spree.t(:default_country_cannot_be_deleted)) }
+      end
     end
 
-    it 'will return the US if config is not set' do
-      america.touch
-      expect(described_class.default.id).to eql america.id
+    context 'will destroy if it is not a default' do
+      it { expect(canada.destroy).to be_truthy }
     end
   end
 end

data/spec/models/spree/credit_card_spec.rb

@@ -5,7 +5,7 @@ describe Spree::CreditCard, type: :model do
     {
       number: '4111111111111111',
       verification_value: '123',
-      expiry: "12 / #{(Time.now.year + 1).to_s.last(2)}",
+      expiry: "12 / #{(Time.current.year + 1).to_s.last(2)}",
       name: 'Spree Commerce'
     }
   end
@@ -19,7 +19,7 @@ describe Spree::CreditCard, type: :model do
   before(:each) do
 
     @order = create(:order)
-    @payment = Spree::Payment.create(:amount => 100, :order => @order)
+    @payment = Spree::Payment.create(amount: 100, order: @order)
 
     @success_response = double('gateway_response', success?: true, authorization: '123', avs_result: { 'code' => 'avs-code' })
     @fail_response = double('gateway_response', success?: false)
@@ -42,12 +42,12 @@ describe Spree::CreditCard, type: :model do
 
   context "#can_capture?" do
     it "should be true if payment is pending" do
-      payment = mock_model(Spree::Payment, pending?: true, created_at: Time.now)
+      payment = mock_model(Spree::Payment, pending?: true, created_at: Time.current)
       expect(credit_card.can_capture?(payment)).to be true
     end
 
     it "should be true if payment is checkout" do
-      payment = mock_model(Spree::Payment, pending?: false, checkout?: true, created_at: Time.now)
+      payment = mock_model(Spree::Payment, pending?: false, checkout?: true, created_at: Time.current)
       expect(credit_card.can_capture?(payment)).to be true
     end
   end
@@ -222,6 +222,10 @@ describe Spree::CreditCard, type: :model do
       credit_card.cc_type = ''
       expect(credit_card.cc_type).to eq('master')
 
+      credit_card.number = '2223000010309703'
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('master')
+
       credit_card.number = '378282246310005'
       credit_card.cc_type = ''
       expect(credit_card.cc_type).to eq('american_express')
@@ -273,8 +277,8 @@ describe Spree::CreditCard, type: :model do
   context "#to_active_merchant" do
     before do
       credit_card.number = "4111111111111111"
-      credit_card.year = Time.now.year
-      credit_card.month = Time.now.month
+      credit_card.year = Time.current.year
+      credit_card.month = Time.current.month
       credit_card.name = "Ludwig van Beethoven"
       credit_card.verification_value = 123
     end
@@ -282,8 +286,8 @@ describe Spree::CreditCard, type: :model do
     it "converts to an ActiveMerchant::Billing::CreditCard object" do
       am_card = credit_card.to_active_merchant
       expect(am_card.number).to eq("4111111111111111")
-      expect(am_card.year).to eq(Time.now.year)
-      expect(am_card.month).to eq(Time.now.month)
+      expect(am_card.year).to eq(Time.current.year)
+      expect(am_card.month).to eq(Time.current.month)
       expect(am_card.first_name).to eq("Ludwig")
       expect(am_card.last_name).to eq("van Beethoven")
       expect(am_card.verification_value).to eq(123)
@@ -317,7 +321,7 @@ describe Spree::CreditCard, type: :model do
     user = FactoryGirl.create(:user)
     first = FactoryGirl.create(:credit_card, user: user, default: true)
     second = FactoryGirl.create(:credit_card, user: user, default: false)
-    first.update_columns(year: DateTime.now.year, month: 1.month.ago.month)
+    first.update_columns(year: DateTime.current.year, month: 1.month.ago.month)
 
     expect { second.update_attributes!(default: true) }.not_to raise_error
   end

data/spec/models/spree/customer_return_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::CustomerReturn, :type => :model do
+describe Spree::CustomerReturn, type: :model do
   before do
     allow_any_instance_of(Spree::Order).to receive_messages(return!: true)
   end
@@ -79,30 +79,8 @@ describe Spree::CustomerReturn, :type => :model do
     end
   end
 
-  describe ".before_create" do
-    describe "#generate_number" do
-      context "number is assigned" do
-        let(:customer_return) { Spree::CustomerReturn.new(number: '123') }
-
-        it "should return the assigned number" do
-          customer_return.save
-          expect(customer_return.number).to eq('123')
-        end
-      end
-
-      context "number is not assigned" do
-        let(:customer_return) { Spree::CustomerReturn.new(number: nil) }
-
-        before do
-          allow(customer_return).to receive_messages(valid?: true, process_return!: true)
-        end
-
-        it "should assign number with random CR number" do
-          customer_return.save
-          expect(customer_return.number).to match(/CR\d{9}/)
-        end
-      end
-    end
+  describe 'whitelisted_ransackable_attributes' do
+    it { expect(Spree::CustomerReturn.whitelisted_ransackable_attributes).to eq(%w(number)) }
   end
 
   describe "#pre_tax_total" do
@@ -194,7 +172,7 @@ describe Spree::CustomerReturn, :type => :model do
     end
 
     context "to a different stock location" do
-      let(:new_stock_location) { create(:stock_location, :name => "other") }
+      let(:new_stock_location) { create(:stock_location, name: "other") }
 
       it "should update the stock item counts in new stock location" do
         expect {

data/spec/models/spree/exchange_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module Spree
-  describe Exchange, :type => :model do
+  describe Exchange, type: :model do
     let(:order) { Spree::Order.new }
 
     let(:return_item_1) { build(:exchange_return_item) }

data/spec/models/spree/gateway/bogus_simple.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::Gateway::BogusSimple, :type => :model do
+describe Spree::Gateway::BogusSimple, type: :model do
 
   subject { Spree::Gateway::BogusSimple.new }
 

data/spec/models/spree/gateway/bogus_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module Spree
-  describe Gateway::Bogus, :type => :model do
+  describe Gateway::Bogus, type: :model do
     let(:bogus) { create(:credit_card_payment_method) }
     let!(:cc) { create(:credit_card, payment_method: bogus, gateway_customer_profile_id: "BGS-RERTERT") }
 

data/spec/models/spree/gateway_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spree::Gateway, :type => :model do
+describe Spree::Gateway, type: :model do
   class Provider
     def initialize(options)
     end
@@ -51,4 +51,11 @@ describe Spree::Gateway, :type => :model do
       expect(has_card.reusable_sources(payment.order)).not_to be_empty
     end
   end
+
+  it "returns exchange multiplier for gateway" do
+    gateway = TestGateway.new
+
+    rate = Spree::Gateway::FROM_DOLLAR_TO_CENT_RATE
+    expect(gateway.exchange_multiplier).to eq rate
+  end
 end

data/spec/models/spree/image_spec.rb

@@ -1,5 +1,8 @@
 require 'spec_helper'
 
-describe Spree::Image, :type => :model do
+describe Spree::Image, type: :model do
 
+  describe 'callbacks' do
+    it { is_expected.to callback(:find_dimensions).before(:save).if(:attachment_updated_at_changed?) }
+  end
 end

data/spec/models/spree/inventory_unit_spec.rb

@@ -1,13 +1,40 @@
 require 'spec_helper'
 
-describe Spree::InventoryUnit, :type => :model do
+describe Spree::InventoryUnit, type: :model do
   let(:stock_location) { create(:stock_location_with_items) }
   let(:stock_item) { stock_location.stock_items.order(:id).first }
 
+  describe 'scopes' do
+    let!(:inventory_unit_1) { create(:inventory_unit, state: 'on_hand') }
+    let!(:inventory_unit_2) { create(:inventory_unit, state: 'backordered') }
+    let!(:inventory_unit_3) { create(:inventory_unit, state: 'shipped') }
+    let!(:inventory_unit_4) { create(:inventory_unit, state: 'returned') }
+
+    describe '.backordered' do
+      it { expect(Spree::InventoryUnit.backordered).to eq([inventory_unit_2]) }
+    end
+
+    describe '.on_hand' do
+      it { expect(Spree::InventoryUnit.on_hand).to eq([inventory_unit_1]) }
+    end
+
+    describe '.on_hand_or_backordered' do
+      it { expect(Spree::InventoryUnit.on_hand_or_backordered).to match_array([inventory_unit_1, inventory_unit_2]) }
+    end
+
+    describe '.shipped' do
+      it { expect(Spree::InventoryUnit.shipped).to eq([inventory_unit_3]) }
+    end
+
+    describe '.returned' do
+      it { expect(Spree::InventoryUnit.returned).to eq([inventory_unit_4]) }
+    end
+  end
+
   context "#backordered_for_stock_item" do
     let(:order) do
       order = create(:order, state: 'complete', ship_address: create(:ship_address))
-      order.completed_at = Time.now
+      order.completed_at = Time.current
       create(:shipment, order: order, stock_location: stock_location)
       order.shipments.reload
       create(:line_item, order: order, variant: stock_item.variant)
@@ -102,34 +129,21 @@ describe Spree::InventoryUnit, :type => :model do
 
   end
 
-  context "variants deleted" do
-    let!(:unit) do
-      Spree::InventoryUnit.create(variant: stock_item.variant)
-    end
-
-    it "can still fetch variant" do
-      unit.variant.destroy
-      expect(unit.reload.variant).to be_a Spree::Variant
-    end
-
-    it "can still fetch variants by eager loading (remove default_scope)" do
-      skip "find a way to remove default scope when eager loading associations"
-      unit.variant.destroy
-      expect(Spree::InventoryUnit.joins(:variant).includes(:variant).first.variant).to be_a Spree::Variant
-    end
-  end
-
   context "#finalize_units!" do
     let!(:stock_location) { create(:stock_location) }
     let(:variant) { create(:variant) }
+    let (:shipment) { create(:shipment) }
     let(:inventory_units) { [
       create(:inventory_unit, variant: variant),
       create(:inventory_unit, variant: variant)
     ] }
+    before do
+      shipment.inventory_units = inventory_units
+    end
 
     it "should create a stock movement" do
-      Spree::InventoryUnit.finalize_units!(inventory_units)
-      expect(inventory_units.any?(&:pending)).to be false
+      expect { shipment.inventory_units.finalize_units! }.
+        to change { shipment.inventory_units.where(pending: false).count }.by 2
     end
   end