spree_core 3.0.10 → 3.1.0.rc1

data/spec/lib/spree/core/number_generator_spec.rb

@@ -0,0 +1,175 @@
+require 'spec_helper'
+
+describe Spree::Core::NumberGenerator do
+  let(:number_generator) { described_class.new(options) }
+  let(:random)           { instance_double(Random)      }
+
+  let(:model) do
+    mod = number_generator
+
+    Class.new(ActiveRecord::Base) do
+      self.table_name = 'spree_orders'
+      include mod
+    end
+  end
+
+  before do
+    expect(Random).to receive(:new).and_return(random)
+  end
+
+  let(:options) { { prefix: 'R' } }
+
+  %i[prefix length].each do |name|
+    describe "##{name}" do
+      let(:value) { double('Generic Value') }
+
+      it 'returns attribute value from options' do
+        expect(described_class.new(options.merge(name => value)).public_send(name)).to be(value)
+      end
+    end
+
+    describe "##{name}=" do
+      let(:value_a) { double('Generic Value A') }
+      let(:value_b) { double('Generic Value B') }
+
+      it 'writes attribute value' do
+        object = described_class.new(options.merge(name => value_a))
+        expect { object.public_send(:"#{name}=", value_b) }
+          .to change { object.public_send(name) }
+          .from(value_a)
+          .to(value_b)
+      end
+    end
+  end
+
+  shared_examples_for 'duplicate without length increment' do
+    before do
+      expect(random).to receive(:rand).
+        with(expected_rand_limit).
+        and_return(next_candidate_index).
+        exactly(expected_length).times
+    end
+
+    it 'sets permalink field' do
+      expect { subject }.to change(resource, :number).from(nil).to(next_candidate)
+    end
+  end
+
+  shared_examples_for 'generating permalink'do
+    let(:resource) { model.new }
+
+    before do
+      expect(random).to receive(:rand).
+        with(expected_rand_limit).
+        and_return(first_candidate_index).
+        exactly(expected_length).times
+    end
+
+    context 'and generated candidate is unique' do
+      before do
+        expect(model).to receive(:exists?).with(number: first_candidate).and_return(false)
+      end
+
+      it 'sets permalink field' do
+        expect { subject }.to change(resource, :number).from(nil).to(first_candidate)
+      end
+    end
+
+    context 'and generated candidate is NOT unique' do
+      before do
+        expect(model).to receive(:exists?).with(number: first_candidate).and_return(true).ordered
+        expect(model).to receive(:count).and_return(record_count).ordered
+        expect(model).to receive(:exists?).with(number: next_candidate).and_return(false)
+      end
+
+      context 'and less than half of the value space taken' do
+        let(:next_candidate) { next_candidate_low            }
+        let(:record_count)   { 10 ** expected_length / 2 - 1 }
+
+        include_examples 'duplicate without length increment'
+      end
+
+      context 'and exactly half of the value space taken' do
+        let(:next_candidate) { next_candidate_low        }
+        let(:record_count)   { 10 ** expected_length / 2 }
+
+        include_examples 'duplicate without length increment'
+      end
+
+      context 'and more than half of the value space is taken' do
+        let(:record_count)   { 10 ** expected_length / 2 + 1 }
+        let(:next_candidate) { next_candidate_high           }
+
+        before do
+          expect(random).to receive(:rand).
+            with(expected_rand_limit).
+            and_return(next_candidate_index).
+            exactly(expected_length.succ).times
+        end
+
+        it 'sets permalink field' do
+          expect { subject }.to change(resource, :number).from(nil).to(next_candidate)
+        end
+      end
+    end
+  end
+
+  describe '#included' do
+    context 'generates .number_generator on host' do
+      it 'returns number generator' do
+        expect(model.number_generator).to be(number_generator)
+      end
+    end
+
+    context 'generates validation hooks on host' do
+      subject { resource.valid? }
+
+      let(:first_candidate_index) { 0  }
+      let(:next_candidate_index)  { 1  }
+      let(:expected_rand_limit)   { 10 }
+      let(:expected_length)       { 9  }
+
+      context 'when permalink field value is nil' do
+        context 'on defaults' do
+          let(:first_candidate)     { 'R000000000'  }
+          let(:next_candidate_low)  { 'R111111111'  }
+          let(:next_candidate_high) { 'R1111111111' }
+
+          include_examples 'generating permalink'
+        end
+
+        context 'with length: option' do
+          let(:options)         { super().merge(length: 10) }
+          let(:expected_length) { 10 }
+
+          let(:first_candidate)     { 'R0000000000'  }
+          let(:next_candidate_low)  { 'R1111111111'  }
+          let(:next_candidate_high) { 'R11111111111' }
+
+          include_examples 'generating permalink'
+        end
+
+        context 'with letters option' do
+          let(:options)             { super().merge(letters: true) }
+          let(:expected_rand_limit) { 36                           }
+
+          let(:first_candidate)       { 'RAAAAAAAAA'  }
+          let(:first_candidate_index) { 10            }
+          let(:next_candidate_index)  { 11            }
+          let(:next_candidate_low)    { 'RBBBBBBBBB'  }
+          let(:next_candidate_high)   { 'RBBBBBBBBBB' }
+
+          include_examples 'generating permalink'
+        end
+      end
+
+      context 'when permalink field value is present' do
+        let(:resource) { model.new(number: 'Test') }
+
+        it 'does not touch field' do
+          expect { subject }.not_to change(resource, :number)
+        end
+      end
+    end
+  end
+end

data/spec/lib/spree/core_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Spree do
+  describe '.admin_path' do
+    it { expect(Spree.admin_path).to eq(Spree::Config[:admin_path]) }
+  end
+
+  describe '.admin_path=' do
+    let!(:original_admin_path) { Spree.admin_path }
+    let(:new_admin_path) { '/admin-secret-path' }
+
+    before do
+      Spree.admin_path = new_admin_path
+    end
+
+    it { expect(Spree.admin_path).to eq(new_admin_path) }
+    it { expect(Spree::Config[:admin_path]).to eq(new_admin_path) }
+
+    after do
+      Spree.admin_path = original_admin_path
+    end
+  end
+end

data/spec/lib/spree/localized_number_spec.rb

@@ -33,6 +33,16 @@ describe Spree::LocalizedNumber do
         expect(subject.class.parse(1599.99)).to eql 1599.99
       end
     end
+
+    context "string argument" do
+      it "should not be modified" do
+        I18n.locale = :de
+        number = '1.599,99'
+        number_bak = number.dup
+        subject.class.parse(number)
+        expect(number).to eql(number_bak)
+      end
+    end
   end
 
 end

data/spec/mailers/order_mailer_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'email_spec'
 
-describe Spree::OrderMailer, :type => :mailer do
+describe Spree::OrderMailer, type: :mailer do
   include EmailSpec::Helpers
   include EmailSpec::Matchers
 
@@ -9,12 +9,12 @@ describe Spree::OrderMailer, :type => :mailer do
 
   let(:order) do
     order = stub_model(Spree::Order)
-    product = stub_model(Spree::Product, :name => %Q{The "BEST" product})
-    variant = stub_model(Spree::Variant, :product => product)
-    price = stub_model(Spree::Price, :variant => variant, :amount => 5.00)
-    line_item = stub_model(Spree::LineItem, :variant => variant, :order => order, :quantity => 1, :price => 4.99)
-    allow(variant).to receive_messages(:default_price => price)
-    allow(order).to receive_messages(:line_items => [line_item])
+    product = stub_model(Spree::Product, name: %{The "BEST" product})
+    variant = stub_model(Spree::Variant, product: product)
+    price = stub_model(Spree::Price, variant: variant, amount: 5.00)
+    line_item = stub_model(Spree::LineItem, variant: variant, order: order, quantity: 1, price: 4.99)
+    allow(variant).to receive_messages(default_price: price)
+    allow(order).to receive_messages(line_items: [line_item])
     order
   end
 
@@ -46,8 +46,8 @@ describe Spree::OrderMailer, :type => :mailer do
 
   context "only shows eligible adjustments in emails" do
     before do
-      create(:adjustment, :order => order, :eligible => true, :label => "Eligible Adjustment")
-      create(:adjustment, :order => order, :eligible => false, :label => "Ineligible Adjustment")
+      create(:adjustment, order: order, eligible: true, label: "Eligible Adjustment")
+      create(:adjustment, order: order, eligible: false, label: "Ineligible Adjustment")
     end
 
     let!(:confirmation_email) { Spree::OrderMailer.confirm_email(order) }
@@ -81,12 +81,11 @@ describe Spree::OrderMailer, :type => :mailer do
   end
 
   context "emails must be translatable" do
-
     context "pt-BR locale" do
       before do
         I18n.enforce_available_locales = false
-        pt_br_confirm_mail = { :spree => { :order_mailer => { :confirm_email => { :dear_customer => 'Caro Cliente,' } } } }
-        pt_br_cancel_mail = { :spree => { :order_mailer => { :cancel_email => { :order_summary_canceled => 'Resumo da Pedido [CANCELADA]' } } } }
+        pt_br_confirm_mail = { spree: { order_mailer: { confirm_email: { dear_customer: 'Caro Cliente,' } } } }
+        pt_br_cancel_mail = { spree: { order_mailer: { cancel_email: { order_summary_canceled: 'Resumo da Pedido [CANCELADA]' } } } }
         I18n.backend.store_translations :'pt-BR', pt_br_confirm_mail
         I18n.backend.store_translations :'pt-BR', pt_br_cancel_mail
         I18n.locale = :'pt-BR'
@@ -120,5 +119,4 @@ describe Spree::OrderMailer, :type => :mailer do
       expect(message.body).to be_blank
     end
   end
-
 end

data/spec/mailers/shipment_mailer_spec.rb

@@ -1,20 +1,22 @@
 require 'spec_helper'
 require 'email_spec'
 
-describe Spree::ShipmentMailer, :type => :mailer do
+describe Spree::ShipmentMailer, type: :mailer do
   include EmailSpec::Helpers
   include EmailSpec::Matchers
 
   before { create(:store) }
 
+  let(:order) { stub_model(Spree::Order, number: 'R12345') }
+  let(:shipping_method) { stub_model(Spree::ShippingMethod, name: 'USPS') }
+  let(:product) { stub_model(Spree::Product, name: %{The "BEST" product}, sku: 'SKU0001') }
+  let(:variant) { stub_model(Spree::Variant, product: product) }
+  let(:line_item) { stub_model(Spree::LineItem, variant: variant, order: order, quantity: 1, price: 5) }
   let(:shipment) do
-    order = stub_model(Spree::Order)
-    product = stub_model(Spree::Product, :name => %Q{The "BEST" product})
-    variant = stub_model(Spree::Variant, :product => product)
-    line_item = stub_model(Spree::LineItem, :variant => variant, :order => order, :quantity => 1, :price => 5)
     shipment = stub_model(Spree::Shipment)
-    allow(shipment).to receive_messages(:line_items => [line_item], :order => order)
-    allow(shipment).to receive_messages(:tracking_url => "TRACK_ME")
+    allow(shipment).to receive_messages(line_items: [line_item], order: order)
+    allow(shipment).to receive_messages(tracking_url: "http://track.com/me")
+    allow(shipment).to receive_messages(shipping_method: shipping_method)
     shipment
   end
 
@@ -43,7 +45,7 @@ describe Spree::ShipmentMailer, :type => :mailer do
       context "pt-BR locale" do
         before do
           I18n.enforce_available_locales = false
-          pt_br_shipped_email = { :spree => { :shipment_mailer => { :shipped_email => { :dear_customer => 'Caro Cliente,' } } } }
+          pt_br_shipped_email = { spree: { shipment_mailer: { shipped_email: { dear_customer: 'Caro Cliente,' } } } }
           I18n.backend.store_translations :'pt-BR', pt_br_shipped_email
           I18n.locale = :'pt-BR'
         end
@@ -60,4 +62,20 @@ describe Spree::ShipmentMailer, :type => :mailer do
       end
     end
   end
+
+  context "shipped_email" do
+    let(:shipped_email) { Spree::ShipmentMailer.shipped_email(shipment) }
+
+    specify do
+      expect(shipped_email).to have_body_text(order.number)
+    end
+
+    specify do
+      expect(shipped_email).to have_body_text(shipping_method.name)
+    end
+
+    specify do
+      expect(shipped_email).to have_body_text("href=\"#{shipment.tracking_url}\"")
+    end
+  end
 end

data/spec/mailers/test_mailer_spec.rb

@@ -18,7 +18,21 @@ describe Spree::TestMailer, :type => :mailer do
 
   it "confirm_email accepts a user id as an alternative to a User object" do
     expect {
-      test_email = Spree::TestMailer.test_email('test@example.com')
+      Spree::TestMailer.test_email('test@example.com')
     }.not_to raise_error
   end
+
+  context "action mailer host" do
+    it "falls back to spree store url" do
+      ActionMailer::Base.default_url_options = {}
+      Spree::TestMailer.test_email('test@example.com').deliver_now
+      expect(ActionMailer::Base.default_url_options[:host]).to eq(Spree::Store.current.url)
+    end
+
+    it "uses developer set host" do
+      ActionMailer::Base.default_url_options[:host] = 'test.test'
+      Spree::TestMailer.test_email('test@example.com').deliver_now
+      expect(ActionMailer::Base.default_url_options[:host]).to eq('test.test')
+    end
+  end
 end

data/spec/models/option_type_prototype_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Spree::OptionTypePrototype do
+  describe 'Validations' do
+    it { is_expected.to validate_presence_of(:prototype) }
+    it { is_expected.to validate_presence_of(:option_type) }
+    it { is_expected.to validate_uniqueness_of(:prototype_id).scoped_to(:option_type_id).allow_nil }
+  end
+end

data/spec/models/spree/ability_spec.rb

@@ -18,19 +18,12 @@ class FooAbility
 end
 
 describe Spree::Ability, :type => :model do
-  let(:user) { create(:user) }
+  let(:user) { build(:user) }
   let(:ability) { Spree::Ability.new(user) }
   let(:token) { nil }
 
-  before do
-    user.spree_roles.clear
-  end
-
-  TOKEN = 'token123'
-
   after(:each) {
     Spree::Ability.abilities = Set.new
-    user.spree_roles = []
   }
 
   context 'register_ability' do
@@ -64,9 +57,9 @@ describe Spree::Ability, :type => :model do
     let(:resource) { Object.new }
     let(:resource_shipment) { Spree::Shipment.new }
     let(:resource_product) { Spree::Product.new }
-    let(:resource_user) { Spree.user_class.new }
+    let(:resource_user) { create :user }
     let(:resource_order) { Spree::Order.new }
-    let(:fakedispatch_user) { Spree.user_class.new }
+    let(:fakedispatch_user) { Spree.user_class.create }
     let(:fakedispatch_ability) { Spree::Ability.new(fakedispatch_user) }
 
     context 'with admin user' do
@@ -161,14 +154,14 @@ describe Spree::Ability, :type => :model do
 
       context 'requested with proper token' do
         let(:token) { 'TOKEN123' }
-        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        before(:each) { allow(resource).to receive_messages guest_token: token }
         it_should_behave_like 'access granted'
         it_should_behave_like 'no index allowed'
       end
 
       context 'requested with inproper token' do
         let(:token) { 'FAIL' }
-        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        before(:each) { allow(resource).to receive_messages guest_token: token }
         it_should_behave_like 'create only'
       end
     end
@@ -222,7 +215,7 @@ describe Spree::Ability, :type => :model do
         it_should_behave_like 'no index allowed'
       end
       context 'requested by other user' do
-        let(:resource) { Spree.user_class.new }
+        let(:resource) { create(:user) }
         it_should_behave_like 'create only'
       end
     end

data/spec/models/spree/address_spec.rb

@@ -227,7 +227,7 @@ describe Spree::Address, :type => :model do
     end
 
     context "user given" do
-      let(:bill_address) { Spree::Address.new(phone: Time.now.to_i) }
+      let(:bill_address) { Spree::Address.new(phone: Time.current.to_i) }
       let(:ship_address) { double("ShipAddress") }
       let(:user) { double("User", bill_address: bill_address, ship_address: ship_address) }
 

data/spec/models/spree/adjustable/adjuster/base_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+describe Spree::Adjustable::Adjuster::Base, type: :model do
+  let(:line_item) { create(:line_item) }
+  let(:subject) { Spree::Adjustable::Adjuster::Base }
+
+  it "raises missing update method" do
+    expect { subject.adjust(line_item, {}) }.to raise_error(NotImplementedError)
+  end
+end