spree_cm_commissioner 2.8.3.pre.pre14 → 2.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e14575f7ac52d9cfa8c454de179107ec31f080a9b8bdc2ff1bfdebeeb5a42f46
-  data.tar.gz: fde706a204a681e6c94931be9dfc915ed5090f3abd81d2481120d598b1e168dd
+  metadata.gz: 0774f6d0c4fad7ae396f14326fd6d0965164b74d89f355c3966bc8d1fd9563f9
+  data.tar.gz: 002d84c9f1273b54f01d5a25bdecc5f3b475a12e07b32d8e1846c19107fe776f
 SHA512:
-  metadata.gz: c69e06e635df7a5259a6fbcab7d1fba55b93eac89ed5c12592e0070baf1bfbaa3ad442754604fd7cffe435d069c340a0f6b427abf39049d5fa5855b5a68fc64f
-  data.tar.gz: 33bf29761d4ee458f559c067c5872db8e381c0f9de7805ce02efaa76bde07229e97a5c20f42ba81a77eb585820dc4360eadbcd035cb4be740364ff1d2d947440
+  metadata.gz: 260d54db1f9dd63dbfef02edf2944d02e2c582972b8903815462e438be9cbfb6f5561a7b4a4b64c2cda4af18908c8c7a91958213c06764d1f7ee4d8e2c16dec3
+  data.tar.gz: 003d6ecd547b0215851266f06e823f2f7c5e7a8da35f5b4a8051784855a4d095d088b79f700dcadca8820d561d7a9989a3ee0d9eb7940943c3c5777cc7a4742c

data/.github/workflows/test_and_build_gem.yml

@@ -164,8 +164,7 @@ jobs:
         env:
           DATABASE_URL: postgres://myuser:mypassword@localhost:5432/test_db
         run: |
-          # Using --no-threads to bypass a known Ruby 3.2.0 GC segmentation fault in CI.
-          bundle exec brakeman --no-threads --no-exit-on-warn
+          bundle exec brakeman --no-exit-on-warn
 
   test:
     needs: [setup]

data/.gitignore

@@ -34,9 +34,3 @@ vendor/bundle/
 # Cursor
 .cursor
 dump.rdb
-# Added by code-review-graph
-.code-review-graph/
-.cursorrules
-.claude
-CLAUDE.md
-AGENTS.md

data/Gemfile.lock

@@ -34,7 +34,7 @@ GIT
 PATH
   remote: .
   specs:
-    spree_cm_commissioner (2.8.3.pre.pre14)
+    spree_cm_commissioner (2.8.3)
       activerecord-multi-tenant
       activerecord_json_validator (~> 2.1, >= 2.1.3)
       aws-sdk-cloudfront

data/app/controllers/concerns/spree_cm_commissioner/content_cachable.rb

@@ -16,7 +16,6 @@ module SpreeCmCommissioner
       GuestCardClassesController
       SeatLayoutController
       CmsPagesController
-      AdvertisementsController
     ].freeze
 
     # Priority 2: Semi-Static (1 hour)
@@ -26,7 +25,6 @@ module SpreeCmCommissioner
       HomepageDataController
       PopularRoutesController
       RoutePlacesController
-      ShowsController
     ].freeze
 
     # Priority 3: Moderate Freshness (30 minutes)

data/app/controllers/spree/admin/guests_controller.rb

@@ -55,7 +55,7 @@ module Spree
         if result.success?
           flash[:success] = "Guest #{@guest.full_name} has been checked in."
         else
-          flash[:error] = result.error.value.to_s.titleize
+          flash[:error] = result.message.to_s.titleize
         end
 
         redirect_to collection_url

data/app/controllers/spree/admin/homepage_section_controller.rb

@@ -51,10 +51,7 @@ module Spree
       def permitted_resource_params
         segment_value = helpers.calculate_segment_value(params[:spree_cm_commissioner_homepage_section])
 
-        params
-          .require(:spree_cm_commissioner_homepage_section)
-          .permit(:title, :description, :active, :tenant_id, :preview)
-          .merge(segment: segment_value)
+        params.require(:spree_cm_commissioner_homepage_section).permit(:title, :description, :active, :tenant_id).merge(segment: segment_value)
       end
 
       def load_tenants

data/app/controllers/spree/admin/stock_managements_controller.rb

@@ -92,7 +92,7 @@ module Spree
                                                                                                 .call
                                                                                                 .index_by(&:inventory_item_id)
         @reserved_stocks = Spree::LineItem
-                           .affecting_inventory
+                           .complete
                            .where(variant_id: @variants.pluck(:id))
                            .group('spree_line_items.variant_id')
                            .sum(:quantity)

data/app/controllers/spree/admin/system/waiting_room_controller.rb

@@ -4,10 +4,7 @@ module Spree
       class WaitingRoomController < Spree::Admin::BaseController
         def show
           @fetcher = SpreeCmCommissioner::WaitingRoomSystemMetadataFetcher.new
-          @lobby_fetcher = SpreeCmCommissioner::WaitingRoomLobbyMetadataFetcher.new
-
           @fetcher.load_document_data
-          @lobby_fetcher.load_document_data
 
           @active_sesions_count = SpreeCmCommissioner::WaitingRoomSession.active.count
         end
@@ -32,18 +29,6 @@ module Spree
 
           redirect_back fallback_location: admin_system_waiting_room_path
         end
-
-        def publish_lobby_path
-          result = SpreeCmCommissioner::WaitingRoom::PublishLobbyPath.call
-
-          if result.success?
-            flash[:success] = "Published waiting guests records path: #{result.value[:records_path]}"
-          else
-            flash[:error] = result.error.to_s
-          end
-
-          redirect_back fallback_location: admin_system_waiting_room_path
-        end
       end
     end
   end

data/app/controllers/spree/admin/taxons_controller_decorator.rb

@@ -3,7 +3,6 @@ module Spree
     module TaxonsControllerDecorator
       def self.prepended(base)
         base.before_action :build_assets, only: %i[create update]
-        base.before_action :normalize_sti_taxon_params, only: %i[create update]
       end
 
       # override
@@ -51,24 +50,6 @@ module Spree
         @taxon.build_home_banner(attachment: permitted_resource_params.delete(:home_banner)) if permitted_resource_params[:home_banner]
         @taxon.build_video_banner(attachment: permitted_resource_params.delete(:video_banner)) if permitted_resource_params[:video_banner]
       end
-
-      # Some admin forms submit STI records under their class key
-      # (e.g. :spree_cm_commissioner_show) while Spree update reads :taxon.
-      # Merge both into :taxon so all edited fields are persisted.
-      def normalize_sti_taxon_params
-        return unless @taxon
-
-        sti_key = @taxon.class.model_name.param_key.to_sym
-        sti_params = params[sti_key]
-        return unless sti_params.is_a?(::ActionController::Parameters)
-
-        base_params = params[:taxon]
-        base_hash = base_params.is_a?(::ActionController::Parameters) ? base_params.to_unsafe_h : {}
-        sti_hash = sti_params.to_unsafe_h
-        merged_params = ::ActionController::Parameters.new(base_hash.merge(sti_hash))
-
-        params[:taxon] = merged_params
-      end
     end
   end
 end

data/app/controllers/spree/api/v2/storefront/homepage_sections_controller.rb

@@ -19,7 +19,6 @@ module Spree
             @collection ||= model_class.filter_by_segment(params[:homepage_id] || :general)
                                        .active
                                        .where(tenant_id: nil)
-                                       .where(preview: false)
                                        .order(position: :asc)
           end
         end

data/app/controllers/spree/api/v2/storefront/transit/draft_orders_controller.rb

@@ -11,7 +11,6 @@ module Spree
             # - inbound_date: Date of inbound transit (optional)
             # - outbound_legs: Array of outbound leg details (required)
             # - inbound_legs: Array of inbound leg details (optional)
-            # - include_return: Whether to add the trip's "return included" add-on as a line item (optional)
             def create
               @outbound_legs = params[:outbound_legs].is_a?(Array) && params[:outbound_legs].any? ? build_legs(:outbound, params[:outbound_legs]) : []
               @inbound_legs  = params[:inbound_legs].is_a?(Array) && params[:inbound_legs].any? ? build_legs(:inbound, params[:inbound_legs]) : []
@@ -21,8 +20,7 @@ module Spree
                 inbound_date: params[:inbound_date]&.to_date,
                 outbound_legs: @outbound_legs,
                 inbound_legs: @inbound_legs,
-                user: spree_current_user,
-                include_return: ActiveModel::Type::Boolean.new.cast(params[:include_return])
+                user: spree_current_user
               )
 
               if result.success?

data/app/controllers/spree/api/v2/tenant/base_controller.rb

@@ -16,10 +16,6 @@ module Spree
             set_current_tenant(@tenant)
           end
 
-          def current_vendor
-            @current_vendor ||= @tenant.active_vendor
-          end
-
           def render_serialized_payload(status = 200)
             render json: yield, status: status, content_type: content_type
           end

data/app/controllers/spree/api/v2/tenant/homepage_sections_controller.rb

@@ -5,7 +5,6 @@ module Spree
         class HomepageSectionsController < BaseController
           def collection
             @collection ||= scope.filter_by_segment(params[:homepage_id] || :general)
-                                 .where(preview: false)
                                  .active
                                  .order(position: :asc)
           end

data/app/controllers/spree/api/v2/tenant/products_controller.rb

@@ -21,7 +21,7 @@ module Spree
 
           def scope
             MultiTenant.with(@tenant) do
-              model_class.where(tenant_id: MultiTenant.current_tenant_id, preview: false)
+              model_class.where(tenant_id: MultiTenant.current_tenant_id)
             end
           end
 

data/app/controllers/spree/api/v2/tenant/taxons_controller.rb

@@ -31,7 +31,7 @@ module Spree
 
           def scope
             MultiTenant.with(@tenant) do
-              model_class.where(preview: false)
+              model_class
             end
           end
 

data/app/controllers/spree/api/v2/tenant/transit/draft_orders_controller.rb

@@ -11,7 +11,6 @@ module Spree
             # - inbound_date: Date of inbound transit (optional)
             # - outbound_legs: Array of outbound leg details (required)
             # - inbound_legs: Array of inbound leg details (optional)
-            # - include_return: Whether to add the trip's "return included" add-on as a line item (optional)
             def create
               @outbound_legs = params[:outbound_legs].is_a?(Array) && params[:outbound_legs].any? ? build_legs(:outbound, params[:outbound_legs]) : []
               @inbound_legs  = params[:inbound_legs].is_a?(Array) && params[:inbound_legs].any? ? build_legs(:inbound, params[:inbound_legs]) : []
@@ -21,8 +20,7 @@ module Spree
                 inbound_date: params[:inbound_date]&.to_date,
                 outbound_legs: @outbound_legs,
                 inbound_legs: @inbound_legs,
-                user: spree_current_user,
-                include_return: ActiveModel::Type::Boolean.new.cast(params[:include_return])
+                user: spree_current_user
               )
 
               if result.success?

data/app/controllers/spree/api/v2/tenant/trips_controller.rb

@@ -25,17 +25,6 @@ module Spree
           def resource_serializer
             Spree::V2::Tenant::TripSerializer
           end
-
-          # override
-          def serializer_params
-            super.merge(
-              include_details: include_details?
-            )
-          end
-
-          def include_details?
-            params.fetch(:include_details, 'true') == 'true'
-          end
         end
       end
     end

data/app/controllers/spree_cm_commissioner/admin/orders_controller_decorator.rb

@@ -40,13 +40,9 @@ module SpreeCmCommissioner
 
       # override
       def cancel
-        if @order.guests_in_transfer?
-          flash[:error] = Spree.t('admin.orders.cannot_cancel_guest_transfer')
-        else
-          internal_note = params.dig(:order, :internal_note)
-          @order.canceled_by(try_spree_current_user, cancellation_reason: internal_note)
-          flash[:success] = Spree.t(:order_canceled)
-        end
+        internal_note = params.dig(:order, :internal_note)
+        @order.canceled_by(try_spree_current_user, cancellation_reason: internal_note)
+        flash[:success] = Spree.t(:order_canceled)
         redirect_back fallback_location: spree.edit_admin_order_url(@order)
       end
 

data/app/controllers/spree_cm_commissioner/admin/products_controller_decorator.rb

@@ -6,7 +6,6 @@ module SpreeCmCommissioner
         base.around_action :set_writing_role, only: %i[index]
         base.after_action :set_tenant_after_update, only: %i[update]
         base.before_action :merge_industry_taxons_into_taxons, only: [:update]
-        base.before_action :normalize_sti_product_params, only: %i[create update]
       end
 
       # Override
@@ -52,24 +51,6 @@ module SpreeCmCommissioner
 
       protected
 
-      # Some admin forms submit STI records under their class key while
-      # Spree update reads :product. Merge both into :product so all edited
-      # fields are persisted for STI product subclasses.
-      def normalize_sti_product_params
-        return unless @product
-
-        sti_key = @product.class.model_name.param_key.to_sym
-        sti_params = params[sti_key]
-        return unless sti_params.is_a?(::ActionController::Parameters)
-
-        base_params = params[:product]
-        base_hash = base_params.is_a?(::ActionController::Parameters) ? base_params.to_unsafe_h : {}
-        sti_hash = sti_params.to_unsafe_h
-        merged_params = ::ActionController::Parameters.new(base_hash.merge(sti_hash))
-
-        params[:product] = merged_params
-      end
-
       def merge_industry_taxons_into_taxons
         return if params[:product].blank?
 

data/app/finders/spree_cm_commissioner/events/find_matches.rb

@@ -7,7 +7,6 @@ module SpreeCmCommissioner
       def execute
         scope.joins(:integration_mappings).where(
           kind: :event,
-          preview: false,
           integration_mappings: { status: :active }
         ).distinct
       end

data/app/helpers/spree_cm_commissioner/admin/guest_helper.rb

@@ -61,16 +61,6 @@ module SpreeCmCommissioner
           'badge-info'
         end
       end
-
-      def guest_state_badge(guest)
-        badge_class = case guest.state
-                      when 'active' then 'badge-success'
-                      when 'locked' then 'badge-warning'
-                      when 'transferred' then 'badge-secondary'
-                      else 'badge-info'
-                      end
-        content_tag(:span, guest.state.humanize, class: "badge #{badge_class}")
-      end
     end
   end
 end

data/app/helpers/spree_cm_commissioner/admin/homepage_segment_helper.rb

@@ -15,8 +15,6 @@ module SpreeCmCommissioner
           'badge badge-success text-uppercase'
         when :football
           'badge badge-dark text-uppercase'
-        when :show
-          'badge badge-danger text-uppercase'
         else
           'badge'
         end

data/app/interactors/spree_cm_commissioner/pin_code_sender.rb

@@ -6,7 +6,7 @@ module  SpreeCmCommissioner
       context.fail!(message: I18n.t('pincode_sender.pincode.blank')) if context.pin_code.nil?
 
       if context.pin_code.phone_number?
-        send_phone_otp
+        send_sms
       else
         send_email
       end
@@ -16,73 +16,18 @@ module  SpreeCmCommissioner
 
     private
 
-    # Channel selection for phone-number OTPs lives here so the routing is
-    # easy to find and reason about. Telegram Gateway is primary; SMS is the fallback.
-    def send_phone_otp
-      if telegram_gateway_available?
-        send_via_telegram_gateway
-      else
-        send_via_sms
-      end
-    end
-
-    def telegram_gateway_available?
-      return false unless telegram_gateway_enabled?
-      return false if telegram_gateway_api_key.blank?
-
-      ability = telegram_gateway_adapter.check_send_ability(context.pin_code.contact)
-      context.telegram_gateway_request_id = ability.request_id if ability.ok?
-      ability.ok?
-    rescue TelegramGatewayAdapter::Error, Faraday::Error
-      false
-    end
-
-    def send_via_telegram_gateway
+    def send_sms
       from_number = sms_from_number
       return if from_number.blank?
 
-      # Save the chosen channel + the Telegram request_id synchronously so
-      # (a) the API response already reflects the channel for the mobile UI,
-      # (b) verification can reach Telegram even if the user submits the OTP
-      #     before the async send job has run. For Telegram-delivered codes
-      #     the `code` column stores Telegram's request_id (Telegram generates
-      #     and holds the actual OTP).
-      context.pin_code.update!(
-        delivery_channel: :telegram_gateway,
-        code: context.telegram_gateway_request_id
-      )
-
-      SpreeCmCommissioner::TelegramGateway::PinCodeSenderJob.perform_later(
-        pin_code_id: context.pin_code.id,
-        from: from_number,
-        request_id: context.telegram_gateway_request_id,
-        tenant_id: context.pin_code&.application&.tenant_id
-      )
-    end
-
-    def send_via_sms
-      from_number = sms_from_number
-      return if from_number.blank?
-
-      SpreeCmCommissioner::SmsPinCodeJob.perform_later(
-        pin_code_id: context.pin_code.id,
+      options = {
         from: from_number,
         to: context.pin_code.contact,
         body: I18n.t('pincode_sender.sms.body', code: context.pin_code.code, readable_type: context.pin_code.readable_type),
         tenant_id: context.pin_code&.application&.tenant_id
-      )
-    end
-
-    def telegram_gateway_enabled?
-      ENV['TELEGRAM_GATEWAY_ENABLED'] == 'yes'
-    end
-
-    def telegram_gateway_api_key
-      @telegram_gateway_api_key ||= ENV.fetch('TELEGRAM_GATEWAY_API_KEY', nil)
-    end
+      }
 
-    def telegram_gateway_adapter
-      @telegram_gateway_adapter ||= TelegramGatewayAdapter::Client.new
+      SpreeCmCommissioner::SmsPinCodeJob.perform_later(options)
     end
 
     def sms_from_number
@@ -93,8 +38,6 @@ module  SpreeCmCommissioner
     end
 
     def send_email
-      context.pin_code.update!(delivery_channel: :email)
-
       SpreeCmCommissioner::PinCodeMailer.send_pin_code(
         context.pin_code.id,
         context.pin_code.readable_type,

data/app/interactors/spree_cm_commissioner/waiting_guests_caller.rb

@@ -19,47 +19,18 @@ module SpreeCmCommissioner
       max_sessions - active_sessions
     end
 
-    # This query requires an index; create it in Firebase beforehand.
-    # Client must create waiting_guests documents with :queued_at and :allow_to_enter_room_at set to nil to allow filter + order queries.
-    #
-    # Yesterday's guests are always older than today's, so fill from yesterday first, then use any
-    # leftover slots for today. This way no one queued before the midnight rollover gets skipped.
-    #   e.g. 5 slots, 2 waiting in yesterday -> take both, then take 3 from today.
+    # This query required index. create them in Firebase beforehand.
+    # Client side must create waiting_guests document with :queued_at & :allow_to_enter_room_at to null to allow fillter & order.
     def fetch_long_waiting_guests(available_slots)
-      previous_guests = eligible_guests_in(previous_records_path, available_slots)
-
-      # Pre-flip window: the lobby pointer still points at yesterday, so both paths resolve to the
-      # same partition — return now to avoid querying (and double-counting) it twice.
-      return previous_guests if records_path == previous_records_path
-
-      remaining_slots = available_slots - previous_guests.size
-      return previous_guests if remaining_slots <= 0
-
-      previous_guests + eligible_guests_in(records_path, remaining_slots)
-    end
-
-    def eligible_guests_in(records_path, limit)
-      firestore.col(records_path)
+      firestore.col('waiting_guests')
+               .doc(current_date)
+               .col('records')
                .where('allow_to_enter_room_at', '==', nil)
                .order('queued_at')
-               .limit(limit)
+               .limit(available_slots)
                .get.to_a
     end
 
-    # Published path is authoritative; fall back to the server's own date if not yet published.
-    def records_path
-      lobby_data&.dig(:waiting_guests_records_path).presence || default_records_path(current_date)
-    end
-
-    # Drain target is derived from the server date, never the (possibly stale) lobby pointer.
-    def previous_records_path
-      default_records_path(previous_date)
-    end
-
-    def default_records_path(date)
-      "waiting_guests/#{date}/records"
-    end
-
     # For alert waiting guests to enter room, we just update :allow_to_enter_room_at.
     # App will listen to firebase & start refresh session token to enter room.
     def calling_all(waiting_guests)
@@ -74,22 +45,9 @@ module SpreeCmCommissioner
       Time.zone.now.strftime('%Y-%m-%d')
     end
 
-    def previous_date
-      1.day.ago.strftime('%Y-%m-%d')
-    end
-
     # When open app, app request to check whether room is full or not via Firebase instead of server to minimize server requests.
-    # merge: true so we preserve the published `waiting_guests_records_path` on the lobby doc.
     def mark_as(full:, available_slots:)
-      lobby_document.set({ full: full, available_slots: available_slots }, merge: true)
-    end
-
-    def lobby_data
-      @lobby_data ||= lobby_document.get.data
-    end
-
-    def lobby_document
-      @lobby_document ||= firestore.col('waiting_rooms').doc('lobby')
+      firestore.col('waiting_rooms').doc('lobby').set({ full: full, available_slots: available_slots })
     end
 
     def fetch_max_sessions

data/app/models/concerns/spree_cm_commissioner/homepage_section_bitwise.rb

@@ -8,8 +8,7 @@ module SpreeCmCommissioner
       tour: 0b00100,
       accommodation: 0b01000,
       things_to_do: 0b10000,
-      football: 0b100000,
-      show: 0b1000000
+      football: 0b100000
     }.freeze
 
     BIT_SEGMENT.each do |segment, bit_value|

data/app/models/concerns/spree_cm_commissioner/line_item_open_dated_trippable.rb

@@ -1,28 +1,13 @@
 module SpreeCmCommissioner
-  # Makes an open-return entitlement line item redeemable.
-  #
-  # New design: the open return is no longer a fake open-dated *trip* line item. It is a plain
-  # ecommerce add-on (a Spree::Product linked to the outbound trip's product via an
-  # `open_dated_pair` ProductRelation) sold as a regular ecommerce line item at checkout.
-  #
-  # Redemption swaps that ecommerce line item in place into a concrete transit ticket on a chosen
-  # return trip (see SpreeCmCommissioner::OpenDatedTrips::Redeem). Once swapped, the line item is a
-  # `transit` item.
   module LineItemOpenDatedTrippable
     extend ActiveSupport::Concern
 
     included do
       include SpreeCmCommissioner::StoreMetadata
 
-      store_private_metadata :open_dated_product_id, :integer
-
-      # The endpoints (Place ids) the *return* trip must run between — already reversed from the
-      # outbound journey at purchase time (return origin = outbound destination, and vice versa).
-      # Storing the return direction means every consumer reads it directly: redemption is a plain
-      # id match and the search needs no flip. Endpoints rather than a trip keep this
-      # leg-count-independent: a multi-leg outbound still has exactly one origin and one destination.
-      store_private_metadata :open_dated_return_origin_place_id, :integer
-      store_private_metadata :open_dated_return_destination_place_id, :integer
+      # Open dated trip metadata
+      store_public_metadata :is_open_dated, :boolean, default: false
+      store_public_metadata :original_trip_id, :integer # Original template trip ID BEFORE redemption
 
       # Alias existing columns for better semantic meaning
       alias_attribute :valid_until, :to_date        # Expiration date
@@ -34,47 +19,19 @@ module SpreeCmCommissioner
       accepter
     end
 
-    def open_dated?
-      open_dated_return_origin_place_id.present? && open_dated_return_destination_place_id.present?
-    end
-
-    def open_dated_product
-      return nil if open_dated_product_id.blank?
-
-      @open_dated_product ||= Spree::Product.find_by(id: open_dated_product_id)
-    end
-
-    # Origin place the return trip must depart from (= outbound destination).
-    def open_dated_return_origin_place
-      return nil if open_dated_return_origin_place_id.blank?
-
-      @open_dated_return_origin_place ||= SpreeCmCommissioner::Place.find_by(id: open_dated_return_origin_place_id)
-    end
-
-    # Destination place the return trip must arrive at (= outbound origin).
-    def open_dated_return_destination_place
-      return nil if open_dated_return_destination_place_id.blank?
-
-      @open_dated_return_destination_place ||= SpreeCmCommissioner::Place.find_by(id: open_dated_return_destination_place_id)
-    end
-
-    # Human-readable return journey, e.g. "Siem Reap → Phnom Penh". Nil when endpoints are missing.
-    def open_dated_route_label
-      return nil if open_dated_return_origin_place.blank? || open_dated_return_destination_place.blank?
-
-      "#{open_dated_return_origin_place.full_path_name} → #{open_dated_return_destination_place.full_path_name}"
-    end
-
+    # Check if ticket has been redeemed
     def redeemed?
       redeemed_at.present?
     end
 
+    # Check if ticket is expired
     def expired?
       valid_until.present? && valid_until.to_date < Date.current
     end
 
+    # Check if ticket can be redeemed
     def can_redeem?
-      open_dated? && !redeemed? && !expired?
+      is_open_dated? && !redeemed? && !expired?
     end
   end
 end

data/app/models/concerns/spree_cm_commissioner/line_item_transitable.rb

@@ -138,6 +138,7 @@ module SpreeCmCommissioner
 
       trip = SpreeCmCommissioner::Trip.find_by(id: trip_id)
       return unless trip # Skip if trip doesn't exist (will be caught by other validations)
+      return if trip.open_dated? # Skip validation for open-dated trips
 
       # For scheduled trips, require valid trip stops
       errors.add(:boarding_trip_stop_id, 'must be greater than 0') if boarding_trip_stop_id.present? && boarding_trip_stop_id <= 0

data/app/models/concerns/spree_cm_commissioner/line_items_filter_scope.rb

@@ -10,11 +10,6 @@ module SpreeCmCommissioner
       scope :accepted, -> { joins(:order).merge(Spree::Order.accepted) }
       scope :paid, -> { joins(:order).merge(Spree::Order.paid) }
       scope :with_bib_prefix, -> { joins(:option_types).where(option_types: { name: 'bib-prefix' }) }
-      scope :exclude_ticket_transfer_orders, -> { joins(:order).merge(Spree::Order.not_ticket_transfer) }
-
-      # Centralizes the rule so that adjustments (e.g. excluding new order kinds in the
-      # future) only need to be made here. Use this anywhere inventory is computed.
-      scope :affecting_inventory, -> { complete.exclude_ticket_transfer_orders }
 
       scope :filter_by_event, lambda { |event|
         case event

data/app/models/concerns/spree_cm_commissioner/option_type_attr_type.rb

@@ -45,8 +45,7 @@ module SpreeCmCommissioner
       'color' => 'color',
       'ticket-type' => 'string',
       'seat-type' => 'string',
-      'intercity-taxi' => 'string',
-      'vote-package' => 'integer'
+      'intercity-taxi' => 'string'
     }.freeze
 
     included do