spree_cm_commissioner 2.8.2.pre.pre.2 → 2.8.2

data/db/migrate/20260518094322_create_cm_voting_session_stats.rb

@@ -1,17 +0,0 @@
-class CreateCmVotingSessionStats < ActiveRecord::Migration[7.0]
-  def change
-    create_table :cm_voting_session_stats, if_not_exists: true do |t|
-      t.bigint :voting_session_id,    null: false
-      t.integer :unique_voter_count,  default: 0, null: false
-      t.integer :total_vote_count,    default: 0, null: false
-      t.decimal :vote_velocity,       precision: 8, scale: 2
-      t.bigint  :leading_contestant_id
-
-      t.timestamps
-    end
-
-    add_index :cm_voting_session_stats, :voting_session_id, unique: true, if_not_exists: true
-    add_foreign_key :cm_voting_session_stats, :cm_voting_sessions,    column: :voting_session_id,    if_not_exists: true
-    add_foreign_key :cm_voting_session_stats, :cm_voting_contestants, column: :leading_contestant_id, if_not_exists: true
-  end
-end

data/db/migrate/20260520000001_add_scoring_model_to_cm_voting_sessions.rb

@@ -1,5 +0,0 @@
-class AddScoringModelToCmVotingSessions < ActiveRecord::Migration[7.0]
-  def change
-    add_column :cm_voting_sessions, :scoring_model, :integer, default: 0, null: false, if_not_exists: true
-  end
-end

data/db/migrate/20260520000001_optimize_cm_votes_indexes.rb

@@ -1,22 +0,0 @@
-# Optimizes cm_votes indexes for the leaderboard unique voter queries.
-#
-# Removes two unused indexes:
-#   - voter_identifier: stored on the row for audit purposes but never queried from DB
-#                       (fraud detection is entirely Redis-based)
-#   - created_at: only used in ORDER BY after a user_id filter, so Postgres prefers
-#                 the (user_id, voting_session_id) index over this one — never used
-#
-# Adds one targeted index:
-#   - (voting_session_id, user_id): used by PerContestantCounter#session_unique_voter_count
-#     which runs COUNT(DISTINCT user_id) WHERE voting_session_id = ? AND user_id IS NOT NULL
-#     for the leaderboard total unique voters display
-#
-# Net result: 5 → 4 indexes — fewer write penalties per vote INSERT, better read coverage.
-class OptimizeCmVotesIndexes < ActiveRecord::Migration[7.0]
-  def change
-    remove_index :cm_votes, :voter_identifier, if_exists: true
-    remove_index :cm_votes, :created_at, if_exists: true
-
-    add_index :cm_votes, [:voting_session_id, :user_id], if_not_exists: true
-  end
-end

data/db/migrate/20260525042257_add_vote_number_to_cm_voting_contestants.rb

@@ -1,18 +0,0 @@
-class AddVoteNumberToCmVotingContestants < ActiveRecord::Migration[7.0]
-  def change
-    add_column :cm_voting_contestants, :vote_number, :integer, if_not_exists: true
-    add_index :cm_voting_contestants, :vote_number, if_not_exists: true, name: 'index_cm_voting_contestants_on_vote_number'
-
-    # Composite unique index: ensures vote_number is unique per contestant per session
-    add_index :cm_voting_contestants, [:show_contestant_id, :voting_session_id, :vote_number],
-              unique: true,
-              if_not_exists: true,
-              name: 'idx_voting_contestants_show_session_vote'
-
-    # Remove duplicate index on advanced_to_type, advanced_to_id
-    remove_index :cm_voting_contestants,
-                 column: [:advanced_to_type, :advanced_to_id],
-                 name: 'idx_voting_contestants_advanced_to',
-                 if_exists: true
-  end
-end

data/db/migrate/20260527035430_add_confirmed_rank_to_cm_voting_contestants.rb

@@ -1,5 +0,0 @@
-class AddConfirmedRankToCmVotingContestants < ActiveRecord::Migration[7.0]
-  def change
-    add_column :cm_voting_contestants, :confirmed_rank, :integer, if_not_exists: true
-  end
-end

data/db/migrate/20260527062005_add_eliminated_at_to_cm_show_contestants.rb

@@ -1,5 +0,0 @@
-class AddEliminatedAtToCmShowContestants < ActiveRecord::Migration[7.0]
-  def change
-    add_column :cm_show_contestants, :eliminated_at, :datetime, default: nil
-  end
-end

data/docs/sql/jsonb_query_guide.md

@@ -1,57 +0,0 @@
-# PostgreSQL Query Guide: Double-Encoded JSONB Metadata
-
-This document explains how to perform SQL queries on the `private_metadata` and `public_metadata` columns in the `SpreeCmCommissioner` system, addressing the double-encoded JSON issue.
-
-## The Problem: Double-Encoding
-
-In some models, the `jsonb` metadata columns contain data that has been double-serialized. Instead of a native JSON object, the database stores a JSON string scalar.
-
-**Example of raw database content:**
-```json
-"{\"scheduled_at\":\"2026-03-25 07:40:17 UTC\",\"ends_at\":\"2026-03-27 07:40:17 UTC\"}"
-```
-Because this is stored as a "string" inside the `jsonb` column, standard JSON operators like `->>` will return `NULL` when attempting to access keys directly (e.g., `private_metadata ->> 'scheduled_at'`).
-
-## The SQL Workaround: `#>> '{}'`
-
-To query this data at the database level, you must first "unwrap" the string and cast it back to `jsonb`.
-
-### 1. Unwrap and Cast to JSONB
-Use the `#>> '{}'` operator to extract the top-level string content, then cast it to `::jsonb`. 
-
-```sql
-(private_metadata #>> '{}')::jsonb
-```
-
-### 2. Access Specific Keys
-Once casted, you can use the standard `->>` operator.
-
-```sql
-(private_metadata #>> '{}')::jsonb ->> 'scheduled_at'
-```
-
-### 3. Handle Timestamps (with Casting)
-Since values are extracted as text, you must cast them to `timestamp` or `timestamptz` for comparison.
-
-```sql
-WHERE CAST((private_metadata #>> '{}')::jsonb ->> 'scheduled_at' AS timestamp) <= '2026-03-26 15:00:00'
-```
-
-## Example: ActiveRecord Scopes
-
-When implementing this in Rails models, use `Arel.sql` or string fragments within your scopes:
-
-```ruby
-scope :current, ->(now = Time.current) {
-  where("CAST((private_metadata #>> '{}')::jsonb ->> 'scheduled_at' AS timestamp) <= ?", now)
-    .where("(private_metadata #>> '{}')::jsonb ->> 'ends_at' IS NULL OR CAST((private_metadata #>> '{}')::jsonb ->> 'ends_at' AS timestamp) >= ?", now)
-}
-```
-
-## Why this happens?
-This occurs because `ActiveRecord::Store` is used with a manual `coder` on a column that is already defined as `jsonb` in the database. 
-1. The coder converts the Hash to a JSON string.
-2. ActiveRecord sees the `jsonb` type and encodes that string into a JSON scalar to ensure it fits the column type, resulting in the double-encoded format.
-
-> [!TIP]
-> This workaround is safer than a system-wide data migration as it works correctly regardless of whether the data is single-encoded or double-encoded (PostgreSQL's `#>> '{}'` is idempotent for already-correct JSONB objects).

data/lib/spree_cm_commissioner/test_helper/factories/show_episode_factory.rb

@@ -1,12 +0,0 @@
-FactoryBot.define do
-  factory :show_episode, class: 'SpreeCmCommissioner::ShowEpisode', parent: :cm_product do
-    sequence(:name) { |n| "episode_#{n}" }
-
-    association :event, factory: :show
-    product_type { :vote_package }
-    available_on { 1.day.ago }
-
-    shipping_category { Spree::ShippingCategory.first || create(:shipping_category) }
-    price { 10.0 }
-  end
-end

data/lib/spree_cm_commissioner/test_helper/factories/show_factory.rb

@@ -1,120 +0,0 @@
-FactoryBot.define do
-  factory :cm_show, class: 'SpreeCmCommissioner::Show' do
-    sequence(:name) { |n| "Show #{n}" }
-    vendor { Spree::Vendor.first || create(:cm_vendor) }
-
-    before(:create) do |show|
-      taxonomy = Spree::Taxonomy.shows
-      show.taxonomy_id ||= taxonomy.id
-      show.parent_id ||= taxonomy.root.id
-      show.type = 'SpreeCmCommissioner::Show'
-      show.kind = :event
-    end
-
-    factory :cm_show_with_season do
-      after(:create) do |show|
-        create(:cm_show_season, parent: show)
-      end
-    end
-  end
-
-  factory :cm_show_season, class: 'SpreeCmCommissioner::Show' do
-    sequence(:name) { |n| "Season #{n}" }
-    association :parent, factory: :cm_show
-    vendor { parent.vendor }
-    season_number { 1 }
-    season_year { Time.current.year }
-
-    before(:create) do |season|
-      season.taxonomy_id = season.parent.taxonomy_id
-      season.type = 'SpreeCmCommissioner::Show'
-      season.kind = :event
-    end
-  end
-
-  factory :cm_show_episode, class: 'SpreeCmCommissioner::ShowEpisode', parent: :cm_product do
-    sequence(:name) { |n| "Episode #{n}" }
-    event { association :cm_show }
-    vendor { event.vendor }
-
-    before(:create) do |episode|
-      episode.type = 'SpreeCmCommissioner::ShowEpisode'
-      episode.scheduled_at ||= Time.current
-      episode.ends_at ||= 1.day.from_now
-      episode.shipping_category ||= Spree::ShippingCategory.first_or_create!(name: 'Default')
-    end
-
-    trait :current do
-      after(:build) do |episode|
-        episode.scheduled_at = 1.day.ago
-        episode.ends_at = 1.day.from_now
-      end
-    end
-
-    trait :upcoming do
-      after(:build) do |episode|
-        episode.scheduled_at = 1.day.from_now
-      end
-    end
-  end
-
-  factory :cm_show_person, class: 'SpreeCmCommissioner::ShowPerson' do
-    sequence(:name) { |n| "Show Person #{n}" }
-  end
-
-  factory :cm_show_person_assignment, class: 'SpreeCmCommissioner::ShowPersonAssignment' do
-    association :show_person, factory: :cm_show_person
-    association :show, factory: :cm_show
-    role { :coach }
-  end
-
-  factory :cm_show_contestant, class: 'SpreeCmCommissioner::ShowContestant' do
-    sequence(:name) { |n| "Contestant #{n}" }
-    association :show, factory: :cm_show
-    sequence(:contestant_number) { |n| "CON-#{n}" }
-    status { :active }
-    position { 0 }
-    video_highlights { [] }
-  end
-
-  factory :cm_voting_session, class: 'SpreeCmCommissioner::VotingSession' do
-    sequence(:name) { |n| "Session #{n}" }
-    association :episode, factory: :cm_show_episode
-    show { episode.event }
-    vendor { episode.vendor }
-    opens_at { 1.hour.ago }
-    closes_at { 1.hour.from_now }
-    status { :enabled }
-  end
-
-  factory :cm_voting_session_stat, class: 'SpreeCmCommissioner::VotingSessionStat' do
-    association :voting_session, factory: :cm_voting_session
-    unique_voter_count { 0 }
-    total_vote_count   { 0 }
-    vote_velocity      { 0.0 }
-    leading_contestant { nil }
-  end
-
-  factory :cm_voting_contestant, class: 'SpreeCmCommissioner::VotingContestant' do
-    show { create(:cm_show) }
-    show_contestant { create(:cm_show_contestant, show: show) }
-    voting_session { create(:cm_voting_session, episode: create(:cm_show_episode, event: show), show: show, vendor: show.vendor) }
-    show_id { show.id }
-    eliminated { false }
-
-    trait :eliminated do
-      eliminated { true }
-      eliminated_via { :public_vote }
-    end
-
-    trait :eliminated_by_judges do
-      eliminated { true }
-      eliminated_via { :judges_deadlock }
-    end
-
-    trait :eliminated_by_coach do
-      eliminated { true }
-      eliminated_via { :coach_decision }
-    end
-  end
-end

data/lib/spree_cm_commissioner/test_helper/factories/vote_credit_factory.rb

@@ -1,37 +0,0 @@
-FactoryBot.define do
-  factory :voting_credit, class: 'SpreeCmCommissioner::VotingCredit' do
-    tenant_id { 1 }
-    association :user
-    created_by { nil }
-
-    category { :purchase }
-    credit_type { nil }
-
-    votable { nil }
-
-    free_votes_amount { 0 }
-    free_votes_used { 0 }
-    paid_votes_amount { 10 }
-    paid_votes_used { 0 }
-    last_free_reset_at { nil }
-
-    deleted_at { nil }
-
-    trait :promo do
-      category { :promo }
-    end
-
-    trait :bonus do
-      category { :bonus }
-    end
-
-    trait :soft_deleted do
-      deleted_at { Time.current }
-    end
-
-    trait :partially_used do
-      paid_votes_amount { 10 }
-      paid_votes_used { 3 }
-    end
-  end
-end

data/lib/spree_cm_commissioner/test_helper/factories/vote_factory.rb

@@ -1,28 +0,0 @@
-FactoryBot.define do
-  factory :vote, class: 'SpreeCmCommissioner::Vote' do
-    tenant_id { 1 }
-    association :voting_session, factory: :cm_voting_session
-    contestant { create(:cm_voting_contestant, voting_session: voting_session) }
-    association :user
-    vote_credit { nil }
-    channel { :web }
-    quantity { 1 }
-    voter_identifier { nil }
-    device_fingerprint { nil }
-    ip_address { nil }
-    public_metadata { {} }
-
-    trait :with_credit do
-      association :vote_credit, factory: :voting_credit
-    end
-
-    trait :anonymous do
-      user { nil }
-      voter_identifier { SecureRandom.hex(8) }
-    end
-
-    trait :mobile do
-      channel { :mobile }
-    end
-  end
-end

data/lib/spree_cm_commissioner/test_helper/factories/voting_credit_transaction_factory.rb

@@ -1,11 +0,0 @@
-FactoryBot.define do
-  factory :voting_credit_transaction, class: 'SpreeCmCommissioner::VotingCreditTransaction' do
-    association :vote_credit, factory: :voting_credit
-    tenant_id { 1 }
-    action { :use }
-    amount { 10 }
-    user_total_amount { 0 }
-    idempotency_key { nil }
-    deleted_at { nil }
-  end
-end

data/lib/spree_cm_commissioner/test_helper/factories/voting_session_factory.rb

@@ -1,11 +0,0 @@
-FactoryBot.define do
-  factory :voting_session, class: 'SpreeCmCommissioner::VotingSession' do
-    association :episode, factory: :show_episode
-    sequence(:session_key) { |n| "session_key_#{n}" }
-    opens_at { 1.hour.ago }
-    closes_at { 1.hour.from_now }
-    status { :active }
-    voting_config { {} }
-    fraud_config { {} }
-  end
-end