spree_cm_commissioner 2.3.0.pre.pre15 → 2.3.0.pre.pre17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de0699d1dc713a380bc232895c2662c173b22e6d01e93f2fc2d0f2d18b723bde
-  data.tar.gz: 82a2a10e8ff8b9f7bd2786ebc5004fb44cb2133d819db1012b3179b1f2fe0b80
+  metadata.gz: 76d6f1a36e751b1723a6a6f7d6ba016dcf6df4c24d4e66322fadd7cb6d99f133
+  data.tar.gz: 5ee3fb8b1c36b92b04b349218a72db179b9e5afffe18342b73c6bafea2375600
 SHA512:
-  metadata.gz: e4613e0a9d0b52f781a2d2c1f89de0078d4b5c65ef16f1a26090ffbddda0c4c9494f9ca8458264f6023fbf949ea4e4228111116153da1b6e3be6dec51af7715a
-  data.tar.gz: 608e42e844de2015b7a94de6e350034b7a2b74d63998834fbff71fc599f77ffac57385e65a70df53a10a34582f7bb2d13deff9c44773ddbe4661b28bbb9238b9
+  metadata.gz: d402702c7778ddf7a44be7b6370fb943c7e091ee1d9cc5214ac4ffa97fde73a2347f072692661a815daf85fd1a18441d44b79c2e4246fce686b5f9822554a5b5
+  data.tar.gz: 3adbb3c9b40e612c65be67ae0853047bd5f1b1c82ac5daf7e91dc494a1f16d51f005eca9dbc48adf83467d3edb25e466114d9716abec8d43b0e7edff1b0753f2

data/Gemfile.lock

@@ -34,7 +34,7 @@ GIT
 PATH
   remote: .
   specs:
-    spree_cm_commissioner (2.3.0.pre.pre15)
+    spree_cm_commissioner (2.3.0.pre.pre17)
       activerecord-multi-tenant
       activerecord_json_validator (~> 2.1, >= 2.1.3)
       aws-sdk-cloudfront

data/README.md

@@ -32,6 +32,39 @@ If your server was running, restart it so that it can find the assets properly.
 
 Update the semantic version number in `lib/spree_cm_commissioner/version.rb`, then create and push a new tag to GitHub. When the tag is pushed, the GitHub Actions workflow will automatically build the gem and publish it to RubyGems.
 
+Here's a cleaner and more polished version of your section:
+
+## PostgreSQL Configuration
+
+By default, this Rails engine uses your current system login to connect to the PostgreSQL database. To allow passwordless connections, you need to configure PostgreSQL to trust local connections by editing `pg_hba.conf`:
+
+```conf
+# pg_hba.conf
+local   all             all                                     trust
+```
+
+With this `trust` configuration, PostgreSQL expects a role that matches your current system username.
+
+To check your system username:
+
+```sh
+whoami  # e.g., superdev
+```
+
+Then create a matching PostgreSQL role:
+
+```sh
+createuser -U postgres -s superdev
+```
+
+Or simply run the following to create a role matching your current system user:
+
+```sh
+createuser -U postgres -s $(whoami)
+```
+
+> 💡 We recommend using [Postgres.app](https://postgresapp.com) for local development. It supports multiple PostgreSQL versions and provides a developer-friendly setup out of the box.
+
 ## Config
 
 ### Rake tasks

data/app/controllers/blazer/base_controller_decorator.rb

@@ -12,11 +12,30 @@ module Blazer
     end
 
     def restrict_organizer_access
-      return unless spree_current_user.organizer? && !spree_current_user.admin?
+      return if spree_current_user.admin?
+
+      return unless spree_current_user.organizer? || vendor_permissions?
       return if controller_name == 'queries' && %w[show run].include?(action_name)
 
       raise ActionController::RoutingError, 'Unauthorized'
     end
+
+    private
+
+    def current_vendor
+      @current_vendor ||= vendors&.find_by(id: session[:vendor_id]) || vendors&.first
+    end
+
+    def vendors
+      @vendors ||= spree_current_user&.vendors
+    end
+
+    def vendor_permissions?
+      return false unless current_vendor
+
+      permissions = spree_current_user.permissions_for_vendor(current_vendor.id)
+      permissions.exists?(entry: 'shared_console/reports', action: 'view_reports')
+    end
   end
 end
 

data/app/controllers/spree/api/v2/storefront/intercity_taxi/draft_orders_controller.rb

@@ -0,0 +1,40 @@
+module Spree
+  module Api
+    module V2
+      module Storefront
+        module IntercityTaxi
+          class DraftOrdersController < ::Spree::Api::V2::ResourceController
+            def create
+              order = SpreeCmCommissioner::IntercityTaxiOrder::Create.call(
+                trip_id: params[:trip_id],
+                from_date: params[:from_date],
+                to_date: params[:to_date],
+                user_id: params[:user_id],
+                quantity: params[:quantity]
+              )
+
+              render_serialized_payload { serialize_resource(order) }
+            rescue StandardError => e
+              render_error_payload(e.message)
+            end
+
+            def update
+              order = SpreeCmCommissioner::IntercityTaxiOrder::Update.call(
+                order_number: params[:id],
+                params: params
+              )
+
+              render_serialized_payload { serialize_resource(order) }
+            rescue StandardError => e
+              render_error_payload(e.message)
+            end
+
+            def resource_serializer
+              SpreeCmCommissioner::V2::Storefront::IntercityTaxiCartSerializer
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/app/controllers/spree/api/v2/storefront/trip_search_controller.rb

@@ -3,21 +3,59 @@ module Spree
     module V2
       module Storefront
         class TripSearchController < ::Spree::Api::V2::ResourceController
+          CACHE_EXPIRES_IN = 5.minutes
+
           def index
-            trips = SpreeCmCommissioner::TripQuery.new(
-              origin_id: params[:origin_id],
-              destination_id: params[:destination_id],
-              date: params[:date],
-              vendor_id: params[:vendor_id],
-              number_of_guests: params[:number_of_guests],
-              params: params
-            ).call
+            render_serialized_payload do
+              Rails.cache.fetch(collection_cache_key, collection_cache_opts) do
+                trips = SpreeCmCommissioner::TripQuery.new(
+                  origin_id: params[:origin_id],
+                  destination_id: params[:destination_id],
+                  date: params[:date],
+                  vendor_id: params[:vendor_id],
+                  number_of_guests: params[:number_of_guests],
+                  params: params
+                ).call
 
-            render_serialized_payload { serialize_collection(trips) }
+                serialize_collection(trips)
+              end
+            end
           end
 
           private
 
+          # override from ContentCacheable
+          def max_age
+            CACHE_EXPIRES_IN.to_i
+          end
+
+          # override
+          def collection_cache_key
+            cache_key_parts = [
+              'trip_search',
+              params[:origin_id],
+              params[:destination_id],
+              params[:date],
+              params[:vendor_id],
+              params[:number_of_guests],
+              resource_includes&.sort&.join(','),
+              sparse_fields&.sort&.join(','),
+              serializer_params.to_json,
+              params[:page]&.to_s&.strip,
+              params[:per_page]&.to_s&.strip
+            ].compact.join('-')
+
+            Digest::MD5.hexdigest(cache_key_parts)
+          end
+
+          # override
+          def collection_cache_opts
+            {
+              namespace: Spree::Api::Config[:api_v2_collection_cache_namespace],
+              expires_in: CACHE_EXPIRES_IN
+            }
+          end
+
           # override
           def default_resource_includes
             [

data/app/controllers/spree_cm_commissioner/admin/variants_controller_decorator.rb

@@ -17,7 +17,7 @@ module SpreeCmCommissioner
       end
 
       # construct option values base on name & create new option value when not exist.
-      # then set to variant.
+      # then set to variant. Empty values will remove the option value from variant.
       def build_option_values
         option_values = permitted_resource_params.delete(:option_values_attributes).to_h.values
         return if option_values.blank?

data/app/factory/spree_cm_commissioner/vendor_telegram_message_factory.rb

@@ -0,0 +1,65 @@
+# 📋 ---[New Vendor]---
+#
+# 📝 Name: {{vendor.name}}
+#
+# ✉️ Email: <code>{{vendor.notification_email || vendor.support_email}}</code>
+# 📱 Phone Number: {{vendor.phone_number}}
+#
+# 👤 Created by: {{first_user.name || 'Admin'}}
+# 🗓️ Created at: {{vendor.created_at}}
+#
+# 🔗 URL: {{vendor.organizer_url}}
+module SpreeCmCommissioner
+  class VendorTelegramMessageFactory < TelegramMessageFactory
+    attr_reader :vendor
+
+    def initialize(vendor:)
+      @vendor = vendor
+
+      title = '✨ New Vendor ✨'
+
+      super(title: title)
+    end
+
+    def body
+      [
+        "📝 Name: #{vendor.name}",
+        '',
+        email_line,
+        phone_line,
+        '',
+        creator_line,
+        created_at_line,
+        '',
+        url_line
+      ].compact.join("\n")
+    end
+
+    private
+
+    def email_line
+      return unless vendor.notification_email.present? || vendor.support_email.present?
+
+      "✉️ Email: #{inline_code(vendor.notification_email || vendor.support_email)}"
+    end
+
+    def phone_line
+      return if vendor.contact_us.blank?
+
+      "📱 Phone Number: #{vendor.contact_us}"
+    end
+
+    def creator_line
+      creator_email = vendor.users.first&.email
+      "👤 Created by: #{creator_email}" if creator_email.present?
+    end
+
+    def created_at_line
+      "🗓️ Created at: #{pretty_date(vendor.created_at)}" if vendor.created_at.present?
+    end
+
+    def url_line
+      "🔗 URL: #{vendor.organizer_url}" if vendor.organizer_url.present?
+    end
+  end
+end

data/app/helpers/spree/base_helper_decorator.rb

@@ -20,25 +20,8 @@ module Spree
       end
     end
 
-    def custom_product_line_item_url(line_item, options = {})
-      if defined?(locale_param) && locale_param.present?
-        options.merge!(locale: locale_param)
-      end
-
-      localize = if options[:locale].present?
-                   "/#{options[:locale]}"
-                 else
-                   ''
-                 end
-
-      line_item = Spree::LineItem.find(line_item.id)
-      payload = { order_number: line_item.order.number, line_item_id: line_item.id }
-
-      jwt_token = SpreeCmCommissioner::LineItemJwtToken.encode(payload, line_item.order.token)
-
-      return if line_item.number.blank? && jwt_token.blank?
-
-      "#{current_store.formatted_url + localize}/a/#{line_item.qr_data}"
+    def custom_product_line_item_url(line_item)
+      main_app.url_for("/a/#{line_item.qr_data}")
     end
   end
 end

data/app/interactors/spree_cm_commissioner/vendor_creation_telegram_alert_sender.rb

@@ -0,0 +1,28 @@
+module SpreeCmCommissioner
+  class VendorCreationTelegramAlertSender < BaseInteractor
+    delegate :vendor, to: :context
+
+    def call
+      return if admin_chat_id.blank?
+
+      send_alert
+    end
+
+    def send_alert
+      TelegramNotificationSender.call(
+        chat_id: admin_chat_id,
+        message: alert_message,
+        parse_mode: 'HTML'
+      )
+    end
+
+    def alert_message
+      factory = SpreeCmCommissioner::VendorTelegramMessageFactory.new(vendor: vendor)
+      factory.message
+    end
+
+    def admin_chat_id
+      ENV.fetch('EXCEPTION_NOTIFIER_TELEGRAM_CHANNEL_ID', nil)
+    end
+  end
+end

data/app/jobs/spree_cm_commissioner/transit/route_fulfilled_order_count_incrementer_job.rb

@@ -3,7 +3,7 @@ module SpreeCmCommissioner
     class RouteFulfilledOrderCountIncrementerJob < ApplicationUniqueJob
       def perform(order_id:)
         order = Spree::Order.find(order_id)
-        SpreeCmCommissioner::Transit::RouteFulfilledOrderCountIncrementerService.call(order: order)
+        SpreeCmCommissioner::Routes::IncrementFulfilledOrderCount.call(order: order)
       end
     end
   end

data/app/jobs/spree_cm_commissioner/transit/route_order_count_incrementer_job.rb

@@ -3,7 +3,7 @@ module SpreeCmCommissioner
     class RouteOrderCountIncrementerJob < ApplicationUniqueJob
       def perform(order_id:)
         order = Spree::Order.find(order_id)
-        SpreeCmCommissioner::Transit::RouteOrderCountIncrementerService.call(order: order)
+        SpreeCmCommissioner::Routes::IncrementOrderCount.call(order: order)
       end
     end
   end

data/app/jobs/spree_cm_commissioner/transit/route_previous_trip_count_decrementer_job.rb

@@ -6,7 +6,7 @@ module SpreeCmCommissioner
       queue_as :default
 
       def perform(previous_route_id:)
-        SpreeCmCommissioner::Transit::RoutePreviousTripCountDecrementerService.call(previous_route_id: previous_route_id)
+        SpreeCmCommissioner::Routes::DecrementPreviousTripCount.call(previous_route_id: previous_route_id)
       end
     end
   end

data/app/jobs/spree_cm_commissioner/transit/route_trip_count_decrementer_job.rb

@@ -3,7 +3,7 @@ module SpreeCmCommissioner
     class RouteTripCountDecrementerJob < ApplicationUniqueJob
       def perform(trip_id:)
         trip = SpreeCmCommissioner::Trip.find(trip_id)
-        SpreeCmCommissioner::Transit::RouteTripCountDecrementerService.call(trip: trip)
+        SpreeCmCommissioner::Routes::DecrementTripCount.call(trip: trip)
       end
     end
   end

data/app/jobs/spree_cm_commissioner/transit/route_trip_count_incrementer_job.rb

@@ -3,7 +3,7 @@ module SpreeCmCommissioner
     class RouteTripCountIncrementerJob < ApplicationUniqueJob
       def perform(trip_id:)
         trip = SpreeCmCommissioner::Trip.find(trip_id)
-        SpreeCmCommissioner::Transit::RouteTripCountIncrementerService.call(trip: trip)
+        SpreeCmCommissioner::Routes::IncrementTripCount.call(trip: trip)
       end
     end
   end

data/app/jobs/spree_cm_commissioner/vendor_creation_telegram_alert_sender_job.rb

@@ -0,0 +1,10 @@
+module SpreeCmCommissioner
+  class VendorCreationTelegramAlertSenderJob < ApplicationUniqueJob
+    queue_as :telegram_bot
+
+    def perform(vendor_id)
+      vendor = Spree::Vendor.find(vendor_id)
+      SpreeCmCommissioner::VendorCreationTelegramAlertSender.call(vendor: vendor)
+    end
+  end
+end

data/app/models/concerns/spree_cm_commissioner/line_item_transitable.rb

@@ -63,11 +63,22 @@ module SpreeCmCommissioner
 
     def pickup_place_name = public_metadata['pickup_place_name']
     def drop_off_place_name = public_metadata['drop_off_place_name']
+
     def pickup_lat = public_metadata['pickup_lat']&.to_f
     def pickup_lng = public_metadata['pickup_lng']&.to_f
     def drop_off_lat = public_metadata['drop_off_lat']&.to_f
     def drop_off_lng = public_metadata['drop_off_lng']&.to_f
     def passenger_count = public_metadata['passenger_count']&.to_i
+    def distance_km = public_metadata['distance_km']&.to_f
+    def ordered_points = public_metadata['ordered_points']
+    def base_km = public_metadata['base_km']&.to_f
+    def detour_pickup_km = public_metadata['detour_pickup_km']&.to_f
+    def detour_dropoff_km = public_metadata['detour_dropoff_km']&.to_f
+    def extra_pickup_km = public_metadata['extra_pickup_km']&.to_f
+    def extra_dropoff_km = public_metadata['extra_dropoff_km']&.to_f
+    def extra_pickup_charge_usd = public_metadata['extra_pickup_charge_usd']&.to_f
+    def extra_dropoff_charge_usd = public_metadata['extra_dropoff_charge_usd']&.to_f
+    def estimated_time_minutes = public_metadata['estimated_time_minutes']&.to_i
     def pickup_oob_confirmed = private_metadata['pickup_oob_confirmed']
     def drop_off_oob_confirmed = private_metadata['drop_off_oob_confirmed']
 
@@ -123,6 +134,46 @@ module SpreeCmCommissioner
       set_public_metadata_value('passenger_count', value)
     end
 
+    def distance_km=(value)
+      set_public_metadata_value('distance_km', value)
+    end
+
+    def ordered_points=(value)
+      set_public_metadata_value('ordered_points', value)
+    end
+
+    def base_km=(value)
+      set_public_metadata_value('base_km', value)
+    end
+
+    def detour_pickup_km=(value)
+      set_public_metadata_value('detour_pickup_km', value)
+    end
+
+    def detour_dropoff_km=(value)
+      set_public_metadata_value('detour_dropoff_km', value)
+    end
+
+    def extra_pickup_km=(value)
+      set_public_metadata_value('extra_pickup_km', value)
+    end
+
+    def extra_dropoff_km=(value)
+      set_public_metadata_value('extra_dropoff_km', value)
+    end
+
+    def extra_pickup_charge_usd=(value)
+      set_public_metadata_value('extra_pickup_charge_usd', value)
+    end
+
+    def extra_dropoff_charge_usd=(value)
+      set_public_metadata_value('extra_dropoff_charge_usd', value)
+    end
+
+    def estimated_time_minutes=(value)
+      set_public_metadata_value('estimated_time_minutes', value)
+    end
+
     private
 
     def set_public_metadata_value(key, value)

data/app/models/concerns/spree_cm_commissioner/option_type_attr_type.rb

@@ -10,6 +10,7 @@ module SpreeCmCommissioner
       array
       date
       time
+      color
       coordinate
       state_selection
       payment_option
@@ -41,6 +42,8 @@ module SpreeCmCommissioner
       'bib-display-prefix' => 'boolean',
       'bib-pre-generation-on-create' => 'boolean',
       'seat-number-positions' => 'array',
+      'color' => 'color',
+      'ticket-type' => 'string',
       'seat-type' => 'string',
       'intercity-taxi' => 'string'
     }.freeze
@@ -71,6 +74,10 @@ module SpreeCmCommissioner
       name.in?(RESERVED_OPTIONS.keys)
     end
 
+    def ticket_type?
+      name == 'ticket-type'
+    end
+
     def set_reverved_options_attributes
       self.attr_type = RESERVED_OPTIONS[name]
       self.kind = :variant

data/app/models/concerns/spree_cm_commissioner/option_value_attr_type.rb

@@ -13,6 +13,8 @@ module SpreeCmCommissioner
 
       before_validation :construct_time, if: :attr_type_time?
       before_validation :construct_date, if: :attr_type_date?
+      before_validation :construct_color, if: :attr_type_color?
+      before_validation :construct_ticket_type, if: :ticket_type?
       before_validation :normalize_items, if: :attr_type_array?
 
       after_save :update_variants_metadata, if: :saved_change_to_name?
@@ -27,6 +29,10 @@ module SpreeCmCommissioner
       end
     end
 
+    def ticket_type?
+      option_type.present? && option_type&.ticket_type?
+    end
+
     def items
       return nil unless attr_type_array?
       return nil if name.nil?
@@ -92,6 +98,13 @@ module SpreeCmCommissioner
       self.name = name.split(',').map(&:strip).join(',')
     end
 
+    # Ticket types are case-sensitive: "STANDARD" and "Standard" are distinct ticket types.
+    # Only strip whitespace; preserve the exact case entered by the user.
+    def construct_ticket_type
+      self.name = name&.strip&.presence
+      self.presentation = name&.strip&.presence
+    end
+
     def construct_time
       hour, minute = extract_time_from_time_select
       hour, minute = extract_time_from_default_format if hour.nil? || minute.nil?
@@ -141,5 +154,17 @@ module SpreeCmCommissioner
       self.name = nil if parse_date(name).blank?
       self.presentation = name if parse_date(presentation) != parse_date(name)
     end
+
+    def construct_color
+      self.name = parse_hex_color(name)
+      self.presentation = name if parse_hex_color(presentation) != parse_hex_color(name)
+    end
+
+    def parse_hex_color(value)
+      return nil if value.nil?
+      return nil unless value.match?(/^#[0-9A-Fa-f]{6}$/)
+
+      value.upcase
+    end
   end
 end

data/app/models/concerns/spree_cm_commissioner/order_seatable.rb

@@ -23,13 +23,26 @@ module SpreeCmCommissioner
     # Makes sure seat blocks are held if not held yet or if the hold has expired.
     # Called before moving to payment state to ensure seats are held properly,
     # even if hold was started from :address state or an old hold expired.
-    def ensure_blocks_held!
+    def ensure_blocks_held
       return unless should_manage_blocks?
       return if hold_expires_at.present? && hold_expires_at > Time.zone.now
 
+      hold_blocks
+    end
+
+    def hold_blocks
       hold_blocks!
+    rescue SpreeCmCommissioner::Seats::BlocksAreReservedByOtherGuestError,
+           SpreeCmCommissioner::Seats::BlocksAreOnHoldByOtherGuestError,
+           SpreeCmCommissioner::Seats::BlocksAreReservedBySameGuestError,
+           SpreeCmCommissioner::Seats::UnableToSaveReservedBlockRecordError => e
+      errors.add(:seats, e.message)
+      false
     end
 
+    # Hold blocks for the order. Called during checkout (user-initiated).
+    # Catches seat errors and adds them to order.errors to prevent state transition.
+    # Returns false if error occurs, true otherwise.
     def hold_blocks!
       return unless should_manage_blocks?
 
@@ -46,6 +59,8 @@ module SpreeCmCommissioner
       end
     end
 
+    # Cancel blocks for the order. Called from system (order cancellation/archive).
+    # Raises errors to alert the system if something goes wrong.
     def cancel_blocks!
       return unless should_manage_blocks?
 
@@ -55,6 +70,8 @@ module SpreeCmCommissioner
       end
     end
 
+    # Reserve blocks for the order. Called from system (order completion).
+    # Raises errors to alert the system if something goes wrong.
     def reserve_blocks!
       return unless should_manage_blocks?
 

data/app/models/concerns/spree_cm_commissioner/order_state_machine.rb

@@ -5,8 +5,8 @@ module SpreeCmCommissioner
     extend ActiveSupport::Concern
 
     included do
-      state_machine.before_transition to: :address, do: :hold_blocks!
-      state_machine.before_transition to: :payment, do: :ensure_blocks_held!
+      state_machine.before_transition to: :address, do: :hold_blocks
+      state_machine.before_transition to: :payment, do: :ensure_blocks_held
 
       state_machine.before_transition to: :complete, do: :request, if: :need_confirmation?
       state_machine.before_transition to: :complete, do: :generate_bib_number

data/app/models/concerns/spree_cm_commissioner/route_order_countable.rb

@@ -1,30 +1,19 @@
 module SpreeCmCommissioner
   module RouteOrderCountable
-    def should_update_count?
+    def has_trip_ids? # rubocop:disable Naming/PredicateName
       preload_trip_ids.any?
     end
 
     def increment_route_fulfilled_order_count
-      return unless should_update_count?
+      return unless has_trip_ids?
 
       SpreeCmCommissioner::Transit::RouteFulfilledOrderCountIncrementerJob.perform_later(order_id: id)
     end
 
     def increment_route_order_count
-      return unless should_update_count?
+      return unless has_trip_ids?
 
       SpreeCmCommissioner::Transit::RouteOrderCountIncrementerJob.perform_later(order_id: id)
     end
-
-    # Calling `.trip_ids` directly can cause many slow database queries (N+1 problem)
-    # every time `.should_update_trip_ids?` or `.preload_trip_ids` runs.
-    # To avoid this, we store a precomputed list of trip IDs in `private_metadata`.
-    def preload_trip_ids=(preload_trip_ids = [])
-      self.private_metadata = (private_metadata || {}).merge('preload_trip_ids' => preload_trip_ids)
-    end
-
-    def preload_trip_ids
-      private_metadata&.fetch('preload_trip_ids', []) || []
-    end
   end
 end