spree_cm_commissioner 2.3.0.pre.pre13 → 2.3.0.pre.pre16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 73859341eaf0edcf92dac1f96263e96851c6bcf3abdcc1fbe9a7932e5f54b87e
-  data.tar.gz: 789a5ae8b0c79b0eee1edc1baa6ab3edcb4c8d00a8a17926621c62e868b53203
+  metadata.gz: 654baee3237bba36ebcc85458b09f73b076c6d1ffb782351cf697fa7ab287c7d
+  data.tar.gz: ef9275e9c3d748cdd7947780dca206ea2ae75b4362731e9d9d1b04b2eab04aee
 SHA512:
-  metadata.gz: e2f36f2e4874baaa20f5d5cd6b5ea1a68fee7c7cb859b02f9f423491e731523116fa4b0daf55b55d6006db67dd2fde0c27e41ebf05d27f0f28c5694b96bdd99f
-  data.tar.gz: 89af65da272aecd3820f0fadd0b7863db306b6d14d7eba9ef1ac38959a1b8f0c2f4b22cb201be747ef2312a74f685468a1dfce36673a928ef1a655c9812c903d
+  metadata.gz: b35dd2fe6fc1815f72f0c1e33a88eb629437040de5ea73fc48f8cb249b6f322aedfe2be423847b74ef609a78783f62de13399b0c17c6fdebdf0c54c4a826cdf8
+  data.tar.gz: 11131275c0fc9afec3d0ed082e10ac0471490e07fc04ebbc64ccb10d01ac1442acb102fd4178bfedad3a0e685939df1ad42459f5c62494dd168c699cbb105b57

data/Gemfile.lock

@@ -34,7 +34,7 @@ GIT
 PATH
   remote: .
   specs:
-    spree_cm_commissioner (2.3.0.pre.pre13)
+    spree_cm_commissioner (2.3.0.pre.pre16)
       activerecord-multi-tenant
       activerecord_json_validator (~> 2.1, >= 2.1.3)
       aws-sdk-cloudfront

data/app/jobs/spree_cm_commissioner/waiting_room_session_firebase_logger_job.rb

@@ -1,5 +1,28 @@
 module SpreeCmCommissioner
-  class WaitingRoomSessionFirebaseLoggerJob < ApplicationJob
+  # Logs waiting room session data to Firebase asynchronously.
+  #
+  # Called from WaitingRoomSessionCreator#log_to_firebase after user enters waiting room.
+  # Allows main request to complete without waiting for Firebase I/O.
+  #
+  # == Retry Configuration
+  #
+  # Retries on StandardError with exponential backoff: 4 attempts total (1 initial + 3 retries)
+  #
+  #   retry_on StandardError, wait: :exponentially_longer, attempts: 4
+  #
+  # Wait times: ~1s, ~10s, ~100s
+  # Rationale: Balances reliability vs resources. Firebase is generally reliable, so 3 retries
+  # is sufficient. Exponential backoff gives service time to recover and reduces load during outages.
+  #
+  # == Implementation Details
+  #
+  # - Uses ActiveJob's retry_on (works with any queue adapter: Sidekiq, Resque, etc.)
+  # - Inherits from ApplicationUniqueJob (prevents duplicate Firebase writes)
+  # - On failure after 4 attempts: moved to dead letter queue, logged for investigation
+  #
+  class WaitingRoomSessionFirebaseLoggerJob < ApplicationUniqueJob
+    retry_on StandardError, wait: :exponentially_longer, attempts: 4
+
     def perform(options)
       room_session = SpreeCmCommissioner::WaitingRoomSession.find(options[:room_session_id])
       waiting_guest_firebase_doc_id = options[:waiting_guest_firebase_doc_id]

data/app/models/concerns/spree_cm_commissioner/order_seatable.rb

@@ -23,13 +23,26 @@ module SpreeCmCommissioner
     # Makes sure seat blocks are held if not held yet or if the hold has expired.
     # Called before moving to payment state to ensure seats are held properly,
     # even if hold was started from :address state or an old hold expired.
-    def ensure_blocks_held!
+    def ensure_blocks_held
       return unless should_manage_blocks?
       return if hold_expires_at.present? && hold_expires_at > Time.zone.now
 
+      hold_blocks
+    end
+
+    def hold_blocks
       hold_blocks!
+    rescue SpreeCmCommissioner::Seats::BlocksAreReservedByOtherGuestError,
+           SpreeCmCommissioner::Seats::BlocksAreOnHoldByOtherGuestError,
+           SpreeCmCommissioner::Seats::BlocksAreReservedBySameGuestError,
+           SpreeCmCommissioner::Seats::UnableToSaveReservedBlockRecordError => e
+      errors.add(:seats, e.message)
+      false
     end
 
+    # Hold blocks for the order. Called during checkout (user-initiated).
+    # Catches seat errors and adds them to order.errors to prevent state transition.
+    # Returns false if error occurs, true otherwise.
     def hold_blocks!
       return unless should_manage_blocks?
 
@@ -46,6 +59,8 @@ module SpreeCmCommissioner
       end
     end
 
+    # Cancel blocks for the order. Called from system (order cancellation/archive).
+    # Raises errors to alert the system if something goes wrong.
     def cancel_blocks!
       return unless should_manage_blocks?
 
@@ -55,6 +70,8 @@ module SpreeCmCommissioner
       end
     end
 
+    # Reserve blocks for the order. Called from system (order completion).
+    # Raises errors to alert the system if something goes wrong.
     def reserve_blocks!
       return unless should_manage_blocks?
 

data/app/models/concerns/spree_cm_commissioner/order_state_machine.rb

@@ -5,8 +5,8 @@ module SpreeCmCommissioner
     extend ActiveSupport::Concern
 
     included do
-      state_machine.before_transition to: :address, do: :hold_blocks!
-      state_machine.before_transition to: :payment, do: :ensure_blocks_held!
+      state_machine.before_transition to: :address, do: :hold_blocks
+      state_machine.before_transition to: :payment, do: :ensure_blocks_held
 
       state_machine.before_transition to: :complete, do: :request, if: :need_confirmation?
       state_machine.before_transition to: :complete, do: :generate_bib_number

data/app/services/spree_cm_commissioner/checkout/advance_decorator.rb

@@ -1,12 +1,16 @@
 module SpreeCmCommissioner
   module Checkout
     module AdvanceDecorator
-      # override
+      # override to capture seats error only, other errors is fine we can return success with latest order object instead of throw error.
+      # seat is special case because we want to return error message.
       def call(order:)
         Spree::Dependencies.checkout_next_service.constantize.call(order: order) until cannot_make_transition?(order)
-        success(order)
-      rescue StandardError => e
-        failure(order, e.message)
+
+        if order.errors[:seats].present?
+          failure(order)
+        else
+          success(order)
+        end
       end
     end
   end

data/lib/spree_cm_commissioner/version.rb

@@ -1,5 +1,5 @@
 module SpreeCmCommissioner
-  VERSION = '2.3.0-pre13'.freeze
+  VERSION = '2.3.0-pre16'.freeze
 
   module_function
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spree_cm_commissioner
 version: !ruby/object:Gem::Version
-  version: 2.3.0.pre.pre13
+  version: 2.3.0.pre.pre16
 platform: ruby
 authors:
 - You
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-31 00:00:00.000000000 Z
+date: 2025-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree