spree_cm_commissioner 2.13.1 → 2.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 709925b9130644b3e39ef1bb01415692019bc72643176593877c42f1a710ff0f
-  data.tar.gz: a336bae1ac6555051a4d6c718d8cce7bb1fcbed67b8bea0a2accb5b96cb8ae1b
+  metadata.gz: 7c3bda3e011d6d81a2efce6c425673eafe576265fff3622d9d33134412b9ef8a
+  data.tar.gz: 38694b945396bbef5db96d065b9aabfe3da3b114a1769d16e1999969b4019215
 SHA512:
-  metadata.gz: '0769de948ff5436227d88a348a051a7992956deca52f0a165c4cfa885750b9d672c9192482070d922b52921ded1b080a08c004eb6d33206ae67638ee4eec3a61'
-  data.tar.gz: '09affaee452bf8a04579f43999a2beb71282b0d369109085fa59b63a8851d0c6fb80ad67b9ffc3930542ab6fe9e6b9c500c17b243380b5d33440225e30d8cc02'
+  metadata.gz: 5c34f6c30a980c3bf941d3b2ca569e603b27f8ee6020fa2369142ae8b52a909716f549820dd3aa189d5e1b7d095488c5e193dc41206b0ef2e6f7b9b8684e37e3
+  data.tar.gz: 36673f6411111297fb715c4280ac5d44a0c2c55576c377d4a68b5fb72d887060d585863a1abbbca1b2b53a0184a288317c00185fec722ec466c3bd7b23e95348

data/Gemfile.lock

@@ -34,7 +34,7 @@ GIT
 PATH
   remote: .
   specs:
-    spree_cm_commissioner (2.13.1)
+    spree_cm_commissioner (2.13.2)
       activerecord-multi-tenant
       activerecord_json_validator (~> 2.1, >= 2.1.3)
       aws-sdk-cloudfront

data/app/services/spree_cm_commissioner/waiting_room/admission/call_guests.rb

@@ -165,10 +165,22 @@ module SpreeCmCommissioner
         # the lobby pointer flips) into a single query, matching #fetch_long_waiting_guests's guard.
         # Order matters for read count only (not correctness): yesterday-first exits after one read on
         # the cross-midnight stragglers the caller drains first.
+        #
+        # left_at == nil matters as much here as it does in #eligible_guests_in: without it, any doc
+        # that was never admitted -- including every guest who already left the queue on their own or
+        # got swept, the overwhelmingly common case in a partition with real traffic -- reads as "still
+        # waiting" forever. That's what was making has_queue stick at true even with nobody left in
+        # line, needlessly forcing every fresh arrival into the queue (see shouldQueue on the client).
+        #
+        # No new composite index needed: (allow_to_enter_room_at ==, left_at ==) is a leading prefix of
+        # the (allow_to_enter_room_at ==, left_at ==, last_ping_at ==) index already tracked in
+        # firebase/firestore.indexes.json, and Firestore serves a query off a prefix of an existing
+        # composite index for free.
         def waiting_exists?(records_paths)
           records_paths.uniq.any? do |records_path|
             firestore.col(records_path)
                      .where('allow_to_enter_room_at', '==', nil)
+                     .where('left_at', '==', nil)
                      .limit(1)
                      .get.any?
           end

data/lib/spree_cm_commissioner/version.rb

@@ -1,5 +1,5 @@
 module SpreeCmCommissioner
-  VERSION = '2.13.1'.freeze
+  VERSION = '2.13.2'.freeze
 
   module_function
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_cm_commissioner
 version: !ruby/object:Gem::Version
-  version: 2.13.1
+  version: 2.13.2
 platform: ruby
 authors:
 - You