spree_cm_commissioner 2.0.3.pre.pre3 → 2.0.3.pre.pre4

data/app/models/concerns/spree_cm_commissioner/order_state_machine.rb

@@ -5,8 +5,6 @@ module SpreeCmCommissioner
     extend ActiveSupport::Concern
 
     included do
-      state_machine.before_transition to: :payment, do: :hold_blocks!
-
       state_machine.before_transition to: :complete, do: :request, if: :need_confirmation?
       state_machine.before_transition to: :complete, do: :generate_bib_number
 
@@ -16,14 +14,10 @@ module SpreeCmCommissioner
       state_machine.after_transition to: :complete, do: :send_order_complete_telegram_alert_to_vendors, unless: :need_confirmation?
       state_machine.after_transition to: :complete, do: :send_order_complete_telegram_alert_to_store, unless: :need_confirmation?
 
-      state_machine.around_transition to: :complete, do: :unstock_inventory!
-
       state_machine.after_transition to: :complete, do: :send_transaction_email_to_user, if: :user_has_email?
       state_machine.after_transition to: :resumed, do: :precalculate_conversion
-      state_machine.around_transition to: :resumed, do: :unstock_inventory!
 
       state_machine.after_transition to: :canceled, do: :precalculate_conversion
-      state_machine.after_transition to: :canceled, do: :restock_inventory!
 
       scope :accepted, -> { where(request_state: 'accepted') }
 
@@ -73,39 +67,6 @@ module SpreeCmCommissioner
       end
     end
 
-    def unstock_inventory!
-      ActiveRecord::Base.transaction do
-        yield # Equal to block.call
-
-        # After the transition is complete, the following code will execute first before proceeding to other `after_transition` callbacks.
-        # This ensures that if `reserve_blocks!` or `unstock_inventory_in_redis!` fails, the state will be rolled back,
-        # and neither the `finalize!` method nor any notifications will be triggered.
-        # The payment will be reversed in vPago gem, and `Spree::Checkout::Complete` will be called, which checks `order.reload.complete?`.
-        # This is critical because if the order state is complete, the payment will be marked as paid.
-
-        reserve_blocks!
-        unstock_inventory_in_redis!
-
-        # We rollback only order state, and we keep payment state as it is.
-        # We implement payment in vPago gem, and it will be reversed in the gem.
-        # Some bank has api for refund, but some don't have the api to refund yet. So we keep the payment state as it is and refund manually.
-      end
-    rescue StandardError => e
-      CmAppLogger.log(
-        label: 'SpreeCmCommissioner::OrderStateMachine#reserve_inventory failed',
-        data: { order_id: id, error: e.message, type: e.class.name, backtrace: e.backtrace&.first(5)&.join("\n") }
-      )
-
-      raise e
-    end
-
-    def restock_inventory!
-      ActiveRecord::Base.transaction do
-        cancel_blocks!
-        restock_inventory_in_redis!
-      end
-    end
-
     def generate_bib_number
       line_items.find_each(&:generate_remaining_guests)
 

data/app/models/concerns/spree_cm_commissioner/product_delegation.rb

@@ -3,10 +3,12 @@ module SpreeCmCommissioner
     extend ActiveSupport::Concern
 
     included do
-      delegate :subscribable?,
+      delegate :product_type,
+               :subscribable?,
                :allowed_upload_later?,
                :need_confirmation?, :need_confirmation,
                :allow_anonymous_booking,
+               :accommodation?, :service?, :ecommerce?,
                :allow_self_check_in,
                :allow_self_check_in?,
                :required_self_check_in_location,

data/app/models/concerns/spree_cm_commissioner/product_type.rb

@@ -6,20 +6,10 @@ module SpreeCmCommissioner
     extend ActiveSupport::Concern
 
     PRODUCT_TYPES = %i[accommodation service ecommerce transit].freeze
-    PERMANENT_STOCK_PRODUCT_TYPES = %w[accommodation service transit].freeze
-    PRE_INVENTORY_DAYS = { 'transit' => 90, 'accommodation' => 365, 'service' => 30 }.freeze
 
     included do
       enum product_type: PRODUCT_TYPES if table_exists? && column_names.include?('product_type')
       enum primary_product_type: PRODUCT_TYPES if table_exists? && column_names.include?('primary_product_type')
     end
-
-    def permanent_stock?
-      PERMANENT_STOCK_PRODUCT_TYPES.include?(product_type)
-    end
-
-    def pre_inventory_days
-      PRE_INVENTORY_DAYS[product_type]
-    end
   end
 end

data/app/models/concerns/spree_cm_commissioner/route_type.rb

@@ -2,7 +2,7 @@ module SpreeCmCommissioner
   module RouteType
     extend ActiveSupport::Concern
 
-    ROUTE_TYPES = %i[bus intercity_taxi airport_shuttle rails ferry].freeze
+    ROUTE_TYPES = %i[automobile subway rails ferry].freeze
 
     included do
       enum route_type: ROUTE_TYPES if table_exists? && column_names.include?('route_type')

data/app/models/concerns/spree_cm_commissioner/taxon_kind.rb

@@ -3,7 +3,7 @@ module SpreeCmCommissioner
     extend ActiveSupport::Concern
 
     included do
-      enum kind: { category: 0, cms: 1, event: 2, occupation: 3, nationality: 4, organization: 5 }
+      enum kind: { category: 0, cms: 1, event: 2, occupation: 3, nationality: 4, organization: 5, transit: 6 }
     end
   end
 end

data/app/models/spree_cm_commissioner/branch.rb

@@ -0,0 +1,12 @@
+require_dependency 'spree_cm_commissioner'
+
+module SpreeCmCommissioner
+  class Branch < SpreeCmCommissioner::Place
+    belongs_to :state,  class_name: 'Spree::State', optional: true
+    belongs_to :vendor, class_name: 'Spree::Vendor'
+
+    def validate_reference?
+      false
+    end
+  end
+end

data/app/models/spree_cm_commissioner/guest.rb

@@ -24,16 +24,10 @@ module SpreeCmCommissioner
     scope :none_bib, -> { where(bib_prefix: [nil, '']) }
 
     belongs_to :line_item, class_name: 'Spree::LineItem'
-
     has_one :variant, class_name: 'Spree::Variant', through: :line_item
-
     belongs_to :user, class_name: 'Spree::User'
     belongs_to :occupation, class_name: 'Spree::Taxon'
     belongs_to :nationality, class_name: 'Spree::Taxon'
-    belongs_to :block, class_name: 'SpreeCmCommissioner::Block', optional: true
-
-    has_one :reserved_block, class_name: 'SpreeCmCommissioner::ReservedBlock'
-
     scope :checked_ins, -> { joins(:check_in) }
     scope :no_show, -> { left_outer_joins(:check_in).where(cm_check_ins: { id: nil }) }
 
@@ -54,10 +48,6 @@ module SpreeCmCommissioner
 
     before_create :generate_bib, if: -> { line_item.reload && variant.bib_pre_generation_on_create? }
 
-    after_create :preload_order_block_ids, if: -> { block_id.present? }
-    after_update :preload_order_block_ids, if: :saved_change_to_block_id?
-    after_destroy :preload_order_block_ids
-
     validates :seat_number, uniqueness: { scope: :event_id }, allow_nil: true, if: -> { event_id.present? }
     validates :bib_index, uniqueness: true, allow_nil: true
 
@@ -293,14 +283,6 @@ module SpreeCmCommissioner
         filled_bib_number
       end
     end
-
-    def preload_order_block_ids
-      return if line_item.blank?
-      return if line_item.order.blank?
-
-      block_ids = line_item.order.blocks.pluck(:id)
-      line_item.order.update(preload_block_ids: block_ids)
-    end
   end
 end
 # rubocop:enable Metrics/ClassLength

data/app/models/spree_cm_commissioner/line_item_decorator.rb

@@ -1,6 +1,6 @@
 module SpreeCmCommissioner
   module LineItemDecorator
-    def self.prepended(base) # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
+    def self.prepended(base) # rubocop:disable Metrics/MethodLength
       include_modules(base)
 
       base.belongs_to :accepter, class_name: 'Spree::User', optional: true
@@ -10,32 +10,31 @@ module SpreeCmCommissioner
       base.has_one :google_wallet, class_name: 'SpreeCmCommissioner::GoogleWallet', through: :product
 
       base.has_many :option_types, through: :product
-
-      base.has_many :inventory_items, lambda { |line_item|
-        where(inventory_date: nil).or(where(inventory_date: line_item.date_range))
-      }, through: :variant
-
       base.has_many :taxons, class_name: 'Spree::Taxon', through: :product
       base.has_many :guests, class_name: 'SpreeCmCommissioner::Guest', dependent: :destroy
-      base.has_many :guests_with_blocks, -> { where.not(block_id: nil) }, class_name: 'SpreeCmCommissioner::Guest'
-      base.has_many :reserved_blocks, through: :guests, class_name: 'SpreeCmCommissioner::ReservedBlock'
       base.has_many :pending_guests, pending_guests_query, class_name: 'SpreeCmCommissioner::Guest', dependent: :destroy
       base.has_many :product_completion_steps, class_name: 'SpreeCmCommissioner::ProductCompletionStep', through: :product
+      base.has_many :line_item_seats, class_name: 'SpreeCmCommissioner::LineItemSeat', dependent: :destroy
 
       base.before_save :update_vendor_id
+      base.before_save :update_quantity, if: :transit?
+
+      base.validate :validate_seats_reservation, if: :transit?
 
       base.before_create :add_due_date, if: :subscription?
-      base.before_save -> { self.product_type = variant.product_type }, if: -> { product_type.nil? }
 
       base.validate :ensure_not_exceed_max_quantity_per_order, if: -> { variant&.max_quantity_per_order.present? }
 
       base.whitelisted_ransackable_associations |= %w[guests order]
       base.whitelisted_ransackable_attributes |= %w[number to_date from_date vendor_id]
 
-      base.delegate :delivery_required?, :high_demand,
+      base.delegate :delivery_required?, :permanent_stock?, :high_demand, :transit?,
                     to: :variant
+      base.delegate :discontinue_on, :product_type, :accommodation?, :service?, :ecommerce?, :need_confirmation,
+                    to: :product
 
       base.accepts_nested_attributes_for :guests, allow_destroy: true
+      base.accepts_nested_attributes_for :line_item_seats, allow_destroy: true
 
       def base.json_api_columns
         json_api_columns = column_names.reject { |c| c.match(/_id$|id|preferences|(.*)password|(.*)token|(.*)api_key/) }
@@ -43,10 +42,6 @@ module SpreeCmCommissioner
         json_api_columns << :vendor_id
       end
 
-      def discontinue_on
-        variant.discontinue_on || product.discontinue_on
-      end
-
       def base.search_by_qr_data!(data)
         matches = data.match(/(R\d+)-([A-Za-z0-9_\-]+)-(L\d+)/)&.captures
 
@@ -65,7 +60,6 @@ module SpreeCmCommissioner
       base.include SpreeCmCommissioner::LineItemDurationable
       base.include SpreeCmCommissioner::LineItemsFilterScope
       base.include SpreeCmCommissioner::LineItemGuestsConcern
-      base.include SpreeCmCommissioner::ProductType
       base.include SpreeCmCommissioner::ProductDelegation
       base.include SpreeCmCommissioner::KycBitwise
     end
@@ -81,39 +75,24 @@ module SpreeCmCommissioner
       }
     end
 
-    # override to calculate price per date for permanent stock
-    def update_price_from_modifier(currency, opts)
-      self.currency = currency
-
-      # these fields can be null during this process below.
-      # it is needed for permanent_stock?, date_range to work.
-      self.product_type = variant.product_type
-      self.from_date = opts.delete(:from_date)&.to_date
-      self.to_date = opts.delete(:to_date)&.to_date
-
-      base_price = variant.price_in(currency)
-
-      self.price = if permanent_stock?
-                     date_range.map do |date|
-                       selected_price = variant.price_for_date(date: date, currency: currency) || base_price
-                       (selected_price.amount || 0) + variant.price_modifier_amount_in(currency, opts.merge(date: date))
-                     end.sum
-                   else
-                     (base_price.amount || 0) + variant.price_modifier_amount_in(currency, opts)
-                   end
+    def reservation?
+      date_present? && !subscription?
     end
 
-    # override to calculate price per date for permanent stock
-    def update_price
-      base_price = variant.price_in(order.currency)
-      self.price = if permanent_stock?
-                     date_range.map do |date|
-                       selected_price = variant.price_for_date(date: date, currency: order.currency) || base_price
-                       selected_price.amount || 0
-                     end.sum
-                   else
-                     base_price.amount || 0
-                   end
+    # date_unit could be number of nights, or days or hours depending on usecases
+    # For example:
+    # - accomodation uses number of nights.
+    # - appointment uses number of hours, etc.
+    #
+    # override
+    def amount
+      base_price = price * quantity
+
+      if permanent_stock? && date_unit.present?
+        base_price * date_unit
+      else
+        base_price
+      end
     end
 
     def allowed_self_check_in?
@@ -200,6 +179,8 @@ module SpreeCmCommissioner
 
     # override
     def sufficient_stock?
+      return transit_sufficient_stock? if variant.product.product_type == 'transit'
+
       SpreeCmCommissioner::Stock::LineItemAvailabilityChecker.new(self).can_supply?(quantity)
     end
 
@@ -218,6 +199,18 @@ module SpreeCmCommissioner
       errors.add(:quantity, 'exceeded_max_quantity_per_order') if quantity > variant.max_quantity_per_order
     end
 
+    def transit_sufficient_stock?
+      return selected_seats_available? if reservation_trip.allow_seat_selection
+
+      seat_quantity_available?(reservation_trip)
+    end
+
+    def update_quantity
+      return if line_item_seats.blank?
+
+      self.quantity = line_item_seats.size
+    end
+
     def update_vendor_id
       self.vendor_id = variant.vendor_id
     end
@@ -240,6 +233,45 @@ module SpreeCmCommissioner
 
       from_date + variant.month.month + day.days
     end
+
+    def validate_seats_reservation
+      if reservation_trip.allow_seat_selection && !selected_seats_available?
+        errors.add(:base, :some_seats_are_booked, message: 'Some seats are already booked')
+      elsif !reservation_trip.allow_seat_selection && !seat_quantity_available?(reservation_trip)
+        errors.add(:quantity, :exceeded_available_quantity, message: 'exceeded available quantity')
+      end
+    end
+
+    def selected_seats_available?
+      selected_seat_ids = line_item_seats.map(&:seat_id)
+      !selected_seat_ids_occupied?(selected_seat_ids)
+    end
+
+    def seat_quantity_available?(trip)
+      booked_quantity = Spree::LineItem.joins(:order)
+                                       .where(variant_id: variant_id, date: date, spree_orders: { state: 'complete' })
+                                       .where.not(spree_line_items: { id: id })
+                                       .sum(:quantity)
+      remaining_quantity = trip.vehicle.number_of_seats - booked_quantity
+      remaining_quantity >= quantity
+    end
+
+    def reservation_trip
+      return @trip if defined? @trip
+
+      route = Spree::Variant.find_by(id: variant_id).product
+      @trip = route.trip
+    end
+
+    def selected_seat_ids_occupied?(selected_seat_ids)
+      # check to see if there are any selected_ids exist in the line_item_seats and belongs to completed order
+      SpreeCmCommissioner::LineItemSeat.joins(line_item: :order)
+                                       .where(seat_id: selected_seat_ids, date: date, variant_id: variant_id, spree_orders: { state: 'complete',
+                                                                                                                              canceled_at: nil
+}
+                                       )
+                                       .present?
+    end
   end
 end
 

data/app/models/spree_cm_commissioner/line_item_seat.rb

@@ -0,0 +1,10 @@
+require_dependency 'spree_cm_commissioner'
+module SpreeCmCommissioner
+  class LineItemSeat < SpreeCmCommissioner::Base
+    belongs_to :line_item, class_name: 'Spree::LineItem'
+    belongs_to :seat, class_name: 'SpreeCmCommissioner::VehicleSeat'
+    belongs_to :variant, class_name: 'Spree::Variant'
+
+    validates :date, presence: true
+  end
+end

data/app/models/spree_cm_commissioner/notification_taxon.rb

@@ -1,5 +1,5 @@
 module SpreeCmCommissioner
-  class NotificationTaxon < Base
+  class NotificationTaxon < SpreeCmCommissioner::Base
     belongs_to :customer_notification, class_name: 'SpreeCmCommissioner::CustomerNotification'
     belongs_to :taxon, class_name: 'Spree::Taxon'
   end

data/app/models/spree_cm_commissioner/option_type_decorator.rb

@@ -6,7 +6,7 @@ module SpreeCmCommissioner
       base.include SpreeCmCommissioner::ParameterizeName
       base.include SpreeCmCommissioner::OptionTypeAttrType
 
-      base.enum kind: %i[variant product vendor vehicle]
+      base.enum kind: %i[variant product vendor vehicle_type transit]
 
       base.validates :name, presence: true
 
@@ -19,6 +19,16 @@ module SpreeCmCommissioner
       base.scope :promoted, -> { where(promoted: true) }
       base.whitelisted_ransackable_attributes = %w[kind]
 
+      def base.amenities
+        Spree::OptionType.where(kind: 'vehicle_type', name: 'amenities', presentation: 'Amenities', attr_type: 'amenity').first_or_create
+      end
+
+      def base.vehicle
+        Spree::OptionType.where(presentation: 'vehicle', attr_type: 'vehicle_id', kind: 'variant',
+                                name: 'vehicle'
+        ).first_or_create
+      end
+
       def base.rules_option_type
         Spree::OptionType.find_by(name: RULES_OPTION_TYPE_NAME)
       end

data/app/models/spree_cm_commissioner/option_value_vehicle_type.rb

@@ -0,0 +1,8 @@
+require_dependency 'spree_cm_commissioner'
+
+module SpreeCmCommissioner
+  class OptionValueVehicleType < ApplicationRecord
+    belongs_to :vehicle_type, class_name: 'SpreeCmCommissioner::VehicleType', dependent: :destroy
+    belongs_to :option_value, class_name: 'Spree::OptionValue', dependent: :destroy
+  end
+end

data/app/models/spree_cm_commissioner/order_decorator.rb

@@ -2,7 +2,6 @@ module SpreeCmCommissioner
   module OrderDecorator
     def self.prepended(base) # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
       base.include SpreeCmCommissioner::PhoneNumberSanitizer
-      base.include SpreeCmCommissioner::OrderSeatable
       base.include SpreeCmCommissioner::OrderStateMachine
 
       base.scope :subscription, -> { where.not(subscription_id: nil) }
@@ -43,8 +42,6 @@ module SpreeCmCommissioner
       base.has_many :vendors, through: :products, class_name: 'Spree::Vendor'
       base.has_many :taxons, through: :products, class_name: 'Spree::Taxon'
       base.has_many :guests, through: :line_items, class_name: 'SpreeCmCommissioner::Guest'
-      base.has_many :blocks, through: :guests, class_name: 'SpreeCmCommissioner::Block', source: :block
-      base.has_many :reserved_blocks, through: :guests, class_name: 'SpreeCmCommissioner::ReservedBlock'
       base.has_many :guest_card_classes, class_name: 'SpreeCmCommissioner::GuestCardClass', through: :variants
 
       base.delegate :customer, to: :user, allow_nil: true
@@ -61,13 +58,6 @@ module SpreeCmCommissioner
       end
     end
 
-    # override
-    # spree use this method to check stock availability & consider whether :order can continue to next state.
-    def insufficient_stock_lines
-      checker = SpreeCmCommissioner::Stock::OrderAvailabilityChecker.new(self)
-      checker.insufficient_stock_lines
-    end
-
     def ticket_seller_user?
       return false if user.nil?
 
@@ -116,14 +106,7 @@ module SpreeCmCommissioner
     end
 
     def mark_as_archive
-      blocks_canceled = begin
-        cancel_blocks!
-        true
-      rescue StandardError
-        false
-      end
-
-      update(archived_at: Time.current) if blocks_canceled
+      update(archived_at: Time.current)
     end
 
     # overrided
@@ -216,18 +199,6 @@ module SpreeCmCommissioner
 
     private
 
-    def unstock_inventory_in_redis!
-      CmAppLogger.log(label: "#{self.class.name}#unstock_inventory_in_redis!", data: { order_id: id }) do
-        SpreeCmCommissioner::RedisStock::InventoryUpdater.new(line_item_ids).unstock!
-      end
-    end
-
-    def restock_inventory_in_redis!
-      CmAppLogger.log(label: "#{self.class.name}#restock_inventory_in_redis!", data: { order_id: id }) do
-        SpreeCmCommissioner::RedisStock::InventoryUpdater.new(line_item_ids).restock!
-      end
-    end
-
     # override :spree_api
     def webhook_payload_body
       resource_serializer.new(

data/app/models/spree_cm_commissioner/place.rb

@@ -1,5 +1,7 @@
+require_dependency 'spree_cm_commissioner'
+
 module SpreeCmCommissioner
-  class Place < Base
+  class Place < ApplicationRecord
     acts_as_nested_set
 
     validates :reference, presence: true, if: :validate_reference?
@@ -15,6 +17,7 @@ module SpreeCmCommissioner
     has_many :products, through: :product_places
 
     has_many :children, -> { order(:lft) }, class_name: 'SpreeCmCommissioner::Place', foreign_key: :parent_id, dependent: :destroy
+    has_many :vendor_stops, class_name: 'SpreeCmCommissioner::VendorStop', dependent: :destroy, foreign_key: :stop_id
 
     has_many :taxon_places, class_name: 'SpreeCmCommissioner::TaxonPlace', dependent: :destroy
     has_many :taxons, through: :taxon_places

data/app/models/spree_cm_commissioner/product_decorator.rb

@@ -6,6 +6,7 @@ module SpreeCmCommissioner
       base.include SpreeCmCommissioner::KycBitwise
       base.include SpreeCmCommissioner::Metafield
       base.include SpreeCmCommissioner::TenantUpdatable
+      base.include SpreeCmCommissioner::RouteType
 
       base.has_many :variant_kind_option_types, -> { where(kind: :variant).order(:position) },
                     through: :product_option_types, source: :option_type
@@ -32,7 +33,6 @@ module SpreeCmCommissioner
       base.has_one :google_wallet, class_name: 'SpreeCmCommissioner::GoogleWallet', dependent: :destroy
 
       base.has_many :complete_line_items, through: :classifications, source: :line_items
-      base.has_many :inventory_items, through: :variants
       base.has_many :guests, through: :line_items
 
       base.has_many :product_places, class_name: 'SpreeCmCommissioner::ProductPlace', dependent: :destroy
@@ -64,17 +64,20 @@ module SpreeCmCommissioner
       base.before_validation :set_event_id
 
       base.validate :validate_event_taxons, if: -> { taxons.event.present? }
+
       base.validate :validate_product_date, if: -> { available_on.present? && discontinue_on.present? }
-      base.validate :product_type_unchanged, on: :update
+
       base.validates :commission_rate, numericality: { greater_than_or_equal_to: 0, less_than_or_equal_to: 100 }, allow_nil: true
 
-      base.whitelisted_ransackable_attributes = %w[description name slug discontinue_on status vendor_id short_name]
+      base.whitelisted_ransackable_attributes = %w[description name slug discontinue_on status vendor_id short_name route_type]
 
       base.after_update :update_variants_vendor_id, if: :saved_change_to_vendor_id?
       base.after_update :sync_event_id_to_children, if: :saved_change_to_event_id?
 
       base.enum purchasable_on: { both: 0, web: 1, app: 2 }
 
+      base.accepts_nested_attributes_for :trip, allow_destroy: true
+
       base.multi_tenant :tenant, class_name: 'SpreeCmCommissioner::Tenant'
       base.before_save :set_tenant
     end
@@ -133,13 +136,6 @@ module SpreeCmCommissioner
 
       errors.add(:discontinue_on, 'must be after the available on date')
     end
-
-    def product_type_unchanged
-      return if product_type_was.nil?
-      return unless product_type_changed?
-
-      errors.add(:product_type, 'cannot be changed once set')
-    end
   end
 end
 

data/app/models/spree_cm_commissioner/service_calendar.rb

@@ -1,3 +1,5 @@
+require_dependency 'spree_cm_commissioner'
+
 module SpreeCmCommissioner
   class ServiceCalendar < SpreeCmCommissioner::Base
     # exception_rules = [

data/app/models/spree_cm_commissioner/state_decorator.rb

@@ -3,6 +3,7 @@ module SpreeCmCommissioner
     def self.prepended(base)
       base.whitelisted_ransackable_attributes |= %w[name abbr country_id]
       base.has_many :vendors, foreign_key: 'default_state_id', class_name: 'Spree::Vendor', inverse_of: :default_state, dependent: :nullify
+      base.has_many :stops, class_name: 'SpreeCmCommissioner::Place'
 
       def update_total_inventory
         update(total_inventory: vendors.pluck(:total_inventory).compact.sum)

data/app/models/spree_cm_commissioner/stock/availability_checker.rb

@@ -1,48 +1,47 @@
 module SpreeCmCommissioner
   module Stock
     class AvailabilityChecker
-      attr_reader :variant, :options, :error_message
+      attr_reader :variant, :error_message
 
-      def initialize(variant, options = {})
+      def initialize(variant)
         @variant = variant
-        @options = options
         @error_message = nil
       end
 
-      def can_supply?(quantity = 1)
+      def can_supply?(quantity = 1, options = {})
         return false unless variant.available?
         return true unless variant.should_track_inventory?
         return true if variant.backorderable?
         return true if variant.need_confirmation?
 
-        variant_available?(quantity)
-      end
-
-      def variant_available?(quantity = 1)
-        return false if cached_inventory_items.empty?
-
-        cached_inventory_items.all? do |cached_inventory_item|
-          cached_inventory_item.active? && cached_inventory_item.quantity_available >= quantity
-        end
-      end
-
-      def cached_inventory_items
-        return @cached_inventory_items if defined?(@cached_inventory_items)
+        # when delivery required, shipment will dynamically add / remove unit from stock item.
+        # so we can directly check can_supply with stock items directly.
+        return variant.stock_items.sum(:count_on_hand) >= quantity if variant.delivery_required?
 
         if variant.permanent_stock?
-          return [] if options[:from_date].blank? || options[:to_date].blank?
-
-          dates = options[:from_date].to_date..options[:to_date].to_date
-          @cached_inventory_items = builder_klass.new(variant_id: variant.id, dates: dates).call
-          @cached_inventory_items = [] if @cached_inventory_items.size != dates.count
-          @cached_inventory_items
+          permanent_stock_variant_available?(quantity, options)
         else
-          @cached_inventory_items = builder_klass.new(variant_id: variant.id).call
+          variant_available?(quantity, options)
         end
       end
 
-      def builder_klass
-        ::SpreeCmCommissioner::RedisStock::VariantCachedInventoryItemsBuilder
+      def variant_available?(quantity = 1, options = {})
+        query = SpreeCmCommissioner::VariantAvailability::NonPermanentStockQuery.new(
+          variant: variant,
+          except_line_item_id: options[:except_line_item_id]
+        )
+        result = query.available?(quantity)
+        @error_message = query.error_message unless result
+        result
+      end
+
+      def permanent_stock_variant_available?(quantity = 1, options = {})
+        SpreeCmCommissioner::VariantAvailability::PermanentStockQuery.new(
+          variant: variant,
+          from_date: options[:from_date].to_date,
+          to_date: options[:to_date].to_date,
+          except_line_item_id: options[:except_line_item_id]
+        ).available?(quantity)
       end
     end
   end

data/app/models/spree_cm_commissioner/stock/availability_validator_decorator.rb

@@ -3,8 +3,7 @@ module SpreeCmCommissioner
     module AvailabilityValidatorDecorator
       # override
       def item_available?(line_item, quantity)
-        SpreeCmCommissioner::Stock::LineItemAvailabilityChecker.new(line_item)
-                                                               .can_supply?(quantity)
+        SpreeCmCommissioner::Stock::LineItemAvailabilityChecker.new(line_item).can_supply?(quantity)
       end
     end
   end