spree_billing_sisow 0.9.0 → 0.9.1

data/spec/models/spree/payment_method/sisow_billing/sisow_payment_method_spec.rb

@@ -0,0 +1,19 @@
+require "spec_helper"
+
+describe Spree::PaymentMethod::SisowBilling::SisowPaymentMethod, type: :model do
+  it "should respond with false when calling payment_profiles_supported?" do
+    expect(subject.payment_profiles_supported?).to be false
+  end
+
+  it "should respond with true when calling auto_capture?" do
+    expect(subject.auto_capture?).to be true
+  end
+
+  describe "#purchase" do
+    it "should initiate a new Purchase with source" do
+      sisow_transaction = double("Spree::SisowTransaction", status: "Success")
+      purchase_class = Spree::PaymentMethod::SisowBilling::Purchase
+      expect(subject.purchase(0, sisow_transaction, {})).to be_a purchase_class
+    end
+  end
+end

data/spec/models/spree/payment_method/sisow_billing/sofort_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe Spree::PaymentMethod::SisowBilling::Sofort, type: :model do
+  let(:order) { double("Spree::Order") }
+  let(:payment){ double("Spree::Payment") }
+
+  let(:options) {
+    {
+        return_url: 'http://www.example.com',
+        cancel_url: 'http://www.example.com',
+        notify_url: 'http://www.example.com',
+        issuer_id: 99
+    }
+  }
+
+  before do
+    allow(Spree::PaymentMethod).to receive(:find_by!).with(type: subject.class.to_s).and_return(subject)
+  end
+
+  it "should return a payment URL to the Sisow API" do
+    stub_request(:get, "http://www.sisow.nl/Sisow/iDeal/RestHandler.ashx/TransactionRequest?amount=300&callbackurl=&cancelurl=http://www.example.com&description=Spree%20Demo%20Site%20-%20Order:%20O12345678&entrancecode=R12345678&issuerid=99&merchantid=2537407799&notifyurl=http://www.example.com&payment=sofort&purchaseid=O12345678&returnurl=http://www.example.com&sha1=876b2c3c20b56f34cad4a9108bd42dd16885baeb&shop_id=&test=true").
+      to_return(stored_response("sofort_redirect_url_output"))
+    allow(payment).to receive(:number) { "R12345678" }
+    allow(order).to receive(:total) { 3 }
+    allow(order).to receive(:number) { "O12345678" }
+    allow(order).to receive_message_chain(:payments, :create).and_return(payment)
+    allow(Spree::Store).to receive(:current).and_return double(Spree::Store, name: "Spree Demo Site")
+
+    #payment.should_receive(:started_processing!)
+    #payment.should_receive(:pend!)
+
+    expect(subject.redirect_url(order, options)).to match(/https:\/\/www\.sisow\.nl\/Sisow\/iDeal\/Simulator\.aspx/)
+  end
+end

data/spec/models/spree/payment_method/sisow_billing_spec.rb

@@ -0,0 +1,268 @@
+require "spec_helper"
+
+shared_examples 'sisow payment' do |transaction_type, sisow_class, billing_class|
+  before do
+    allow(sisow_class).to receive(:new).and_return(sisow_payment)
+    allow(sisow_transaction).to receive(:transaction_type).and_return(transaction_type)
+  end
+
+  it "creates a sisow transaction with transaction_type #{transaction_type}" do
+    expect(Spree::SisowTransaction).to receive(:create).
+      with(hash_including(transaction_type: transaction_type))
+    subject.start_transaction(transaction_type)
+  end
+
+  describe "creates a payment" do
+    it "sets first SisowBilling::Ideal PaymentMethod as payment_method" do
+      payment_method = double(:payment_method)
+      expect(Spree::PaymentMethod).to receive(:find_by!).
+        with(type: billing_class.to_s).
+        and_return(payment_method)
+
+      expect(payments_arel).to receive(:create).
+        with(hash_including(payment_method: payment_method))
+      subject.start_transaction(transaction_type)
+    end
+  end
+
+  describe "initializes a #{sisow_class}" do
+    it "passes in options for start_transaction" do
+      expect(sisow_class).to receive(:new).with(hash_including(option: :value))
+      subject.start_transaction(transaction_type, option: :value)
+    end
+
+    it "passes in description with the store and order-number" do
+      store = double(:store, name: 'Example Shop')
+      allow(Spree::Store).to receive(:current).and_return(store)
+      expect(sisow_class).to receive(:new).
+        with(hash_including(description: "Example Shop - Order: O1337"))
+      subject.start_transaction(transaction_type)
+    end
+
+    it "passes the order-number as purchase_id" do
+      expect(sisow_class).to receive(:new).
+        with(hash_including(purchase_id: 'O1337'))
+      subject.start_transaction(transaction_type)
+    end
+
+    it "passes the order-total in cents as amount" do
+      expect(sisow_class).to receive(:new).
+        with(hash_including(amount: 1337))
+      subject.start_transaction(transaction_type)
+    end
+
+    it "passes payment number as entrance_code" do
+      expect(sisow_class).to receive(:new).
+        with(hash_including(entrance_code: 'P1337'))
+      subject.start_transaction(transaction_type)
+    end
+  end
+
+  it "sets transaction_id and entrance_code" do
+    expect(sisow_transaction).to receive(:update_attributes).
+      with({transaction_id: "ABC", entrance_code: "P1337"})
+
+    subject.start_transaction(transaction_type)
+  end
+end
+
+describe Spree::PaymentMethod::SisowBilling, type: :model do
+  let(:order) { double(:order, number: 'O1337', total: 13.37) }
+  let(:sisow_transaction) do
+    double(:sisow_transaction,
+           transaction_type: "ideal",
+           update: nil,
+           update_attributes: nil)
+  end
+  let(:payment) { mock_model(Spree::Payment, number: 'P1337') }
+  let(:subject) { Spree::PaymentMethod::SisowBilling.new(order) }
+  let(:sisow_api_callback) do
+    double(Sisow::Api::Callback,
+           status: "Any Status",
+           sha1: "1234567890",
+           valid?: false,
+           cancelled?: false)
+  end
+  let (:payments_arel) { double(:payments) }
+
+  context "when payment is not initialized" do
+    it "should respond to .success? with false" do
+      expect(subject.success?).to be false
+    end
+
+    it "should respond to .failed? with false" do
+      expect(subject.failed?).to be true
+    end
+
+    it "should respond to .cancelled? with false" do
+      expect(subject.cancelled?).to be false
+    end
+  end
+
+  before do
+    allow(Spree::PaymentMethod).to receive(:find_by!).and_return(subject)
+  end
+
+  describe "#start_transaction" do
+    let(:sisow_payment) do
+      double(:sisow_payment,
+             transaction_id: 'ABC',
+             payment_url: '')
+    end
+
+    before do
+      allow(order).to receive(:payments).and_return(payments_arel)
+      allow(payments_arel).to receive(:create).and_return(payment)
+
+      allow(Spree::SisowTransaction).to receive(:create).and_return(sisow_transaction)
+      allow(Sisow::Payment).to receive(:new).and_return(sisow_payment)
+    end
+
+    it "returns payment_url" do
+      url = "http://example.com"
+      allow(sisow_payment).to receive(:payment_url).and_return(url)
+      # Could be any payment method, using ideal to avoid unrelated errors
+      expect(subject.start_transaction("ideal")).to eq url
+    end
+
+    it "creates a sisow transaction with status pending" do
+      expect(Spree::SisowTransaction).to receive(:create).
+        with(hash_including(status: "pending"))
+      subject.start_transaction("ideal")
+    end
+
+    describe "creates a payment" do
+      it "sets order total as amount" do
+        expect(payments_arel).to receive(:create).
+          with(hash_including(amount: 13.37))
+        subject.start_transaction("ideal")
+      end
+
+      it "sets sisow_transaction as source" do
+        expect(payments_arel).to receive(:create).
+          with(hash_including(source: sisow_transaction))
+        subject.start_transaction("ideal")
+      end
+    end
+
+    context "when transaction_type is ideal" do
+      include_examples "sisow payment",
+        "ideal",
+        Sisow::IdealPayment,
+        Spree::PaymentMethod::SisowBilling::Ideal
+    end
+
+    context 'when transaction_type is sofort' do
+      include_examples "sisow payment",
+        "sofort",
+        Sisow::SofortPayment,
+        Spree::PaymentMethod::SisowBilling::Sofort
+    end
+
+    context 'when transaction_type is bancontact' do
+      include_examples "sisow payment",
+        "bancontact",
+        Sisow::BancontactPayment,
+        Spree::PaymentMethod::SisowBilling::Bancontact
+    end
+
+    context 'when transaction_type is paypalec' do
+      include_examples "sisow payment",
+        "paypalec",
+        Sisow::PaypalPayment,
+        Spree::PaymentMethod::SisowBilling::Paypalec
+    end
+  end
+
+  describe "#process_response" do
+    before do
+      allow(Sisow::Api::Callback).to receive(:new).and_return(sisow_api_callback)
+      allow(Spree::SisowTransaction).to receive_message_chain(:where, :first).and_return(sisow_transaction)
+
+      allow(order).to receive_message_chain(:payments, :where, :present?).and_return(true)
+      allow(order).to receive_message_chain(:payments, :where, :first).and_return(payment)
+    end
+
+    context "when callback is valid" do
+      before { allow(sisow_api_callback).to receive(:valid?).and_return(true) }
+
+      it "updates sisow transaction with a transaction sha" do
+        expect(sisow_transaction).to receive(:update_attributes).with(
+          hash_including(sha1: "1234567890"))
+        subject.process_response({})
+      end
+
+      context "when response is success" do
+        before do
+          allow(sisow_api_callback).to receive(:status).and_return("Success")
+          allow(payment).to receive(:completed?).and_return(true)
+        end
+
+        it "updates sisow transaction with a transaction sha" do
+          expect(sisow_transaction).to receive(:update_attributes).with(
+            hash_including(sha1: "1234567890"))
+          subject.process_response({})
+        end
+
+        it "updates sisow transaction with status Success" do
+          expect(sisow_transaction).to receive(:update_attributes).with(
+            hash_including(status: "Success"))
+          subject.process_response({})
+        end
+      end
+
+      context "when response is failure" do
+        before do
+          allow(sisow_api_callback).to receive(:status).and_return("Cancel")
+          allow(sisow_api_callback).to receive(:cancelled?).and_return(true)
+
+          allow(payment).to receive(:void?).and_return(false)
+          allow(payment).to receive(:void!)
+          allow(sisow_transaction).to receive(:update_attributes)
+        end
+
+        it "voids payment" do
+          expect(payment).to receive(:void!)
+          subject.process_response({})
+        end
+
+        it "updates sisow transaction with a transaction sha" do
+          expect(sisow_transaction).to receive(:update_attributes).with(
+            hash_including(sha1: "1234567890"))
+          subject.process_response({})
+        end
+
+        it "updates sisow transaction with status Cancel" do
+          expect(sisow_transaction).to receive(:update_attributes).with(
+            hash_including(status: "Cancel"))
+          subject.process_response({})
+        end
+      end
+    end
+  end
+
+  describe "#success?" do
+    context "with payment" do
+      # TODO: change the implementation to allow outsiders to set payments too.
+      before { subject.instance_variable_set(:@payment, payment) }
+
+      context "which is completed" do
+        before do
+          allow(payment).to receive(:completed?).and_return(true)
+          allow(order).to receive(:completed?).and_return(false)
+        end
+
+        it { expect(subject.success?).to be false }
+
+        context "when order is also completed" do
+          before { allow(order).to receive(:completed?).and_return(true) }
+          it { expect(subject.success?).to be true }
+        end
+      end
+    end
+
+    context "without payment" do
+      it { expect(subject.success?).to be false }
+    end
+  end
+end

data/spec/models/spree/sisow_transaction.rb

@@ -0,0 +1,4 @@
+require 'spec_helper'
+
+describe Spree::SisowTransaction, type: :model do
+end

data/spec/sisow.yml

@@ -0,0 +1,4 @@
+merchant_id: '2537407799'
+merchant_key: '0f9b49d384b4836c543f76d23a923e2cd2cfaec6'
+test_mode: true
+debug_mode: false

data/spec/spec_helper.rb

@@ -0,0 +1,99 @@
+# Run Coverage report
+require 'simplecov'
+SimpleCov.start
+
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
+
+require File.expand_path('../dummy/config/environment.rb',  __FILE__)
+
+require 'rspec/rails'
+require 'database_cleaner'
+require 'ffaker'
+require 'webmock/rspec'
+require 'rspec/active_model/mocks'
+require 'byebug'
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+
+# Requires factories defined in spree_core
+require 'spree/testing_support/factories'
+require 'spree/testing_support/controller_requests'
+require 'spree/testing_support/authorization_helpers'
+require 'spree/testing_support/url_helpers'
+require 'spree/testing_support/order_walkthrough'
+require 'spree/testing_support/preferences'
+
+# Requires factories defined in lib/spree_billing_sisow/factories.rb
+require 'spree_billing_sisow/factories'
+
+# Override autogenerated spec/dummy/config/environments/test.rb
+# We need to disable caching of classes, because otherwise
+# the loading of the menu-item Deface::Override won't apply.
+Dummy::Application.configure do
+  config.cache_classes = false
+end
+
+RSpec.configure do |config|
+  config.include FactoryBot::Syntax::Methods
+
+  # == URL Helpers
+  #
+  # Allows access to Spree's routes in specs:
+  #
+  # visit spree.admin_path
+  # current_path.should eql(spree.products_path)
+  config.include Spree::TestingSupport::UrlHelpers
+
+  config.include SpreeStubs
+  config.include WebMockFixtureHelpers
+
+  config.include Spree::TestingSupport::ControllerRequests, :type => :controller
+  config.include Devise::Test::ControllerHelpers, :type => :controller
+
+  # Allow resetting of config.
+  config.include Spree::TestingSupport::Preferences
+
+  # == Mock Framework
+  #
+  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
+  #
+  # config.mock_with :mocha
+  # config.mock_with :flexmock
+  # config.mock_with :rr
+  config.mock_with :rspec
+  config.color = true
+
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+
+  # Capybara javascript drivers require transactional fixtures set to false, and we use DatabaseCleaner
+  # to cleanup after each test instead.  Without transactional fixtures set to false the records created
+  # to setup a test will be unavailable to the browser, which runs under a seperate server instance.
+  config.use_transactional_fixtures = false
+
+  # Ensure Suite is set to use transactions for speed.
+  config.before :suite do
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with :truncation
+
+    WebMock.disable_net_connect!(allow: "codeclimate.com")
+  end
+
+  # Before each spec check if it is a Javascript test and switch between using database transactions or not where necessary.
+  config.before :each do |example|
+    DatabaseCleaner.strategy = example.metadata[:js] ? :truncation : :transaction
+    DatabaseCleaner.start
+
+    reset_spree_preferences
+  end
+
+  # After each spec clean the database.
+  config.after :each do
+    DatabaseCleaner.clean
+  end
+
+  config.fail_fast = ENV['FAIL_FAST'] || false
+end

data/spec/support/spree/spree_stubs.rb

@@ -0,0 +1,17 @@
+# Helpers to stub out parts of Spree
+module SpreeStubs
+  # Fakes a user with an order.
+  # It allows us to not have to click through the entire checkout process
+  # just to get a user with a session and an order.
+  def stub_user_with_order(user, order)
+    allow_any_instance_of(Spree::CheckoutController).
+      to receive(:current_order).
+      and_return(order)
+    allow_any_instance_of(Spree::CheckoutController).
+      to receive(:try_spree_current_user).
+      and_return(user)
+    allow_any_instance_of(Spree::OrdersController).
+      to receive(:try_spree_current_user).
+      and_return(user)
+  end
+end

data/spec/support/webmock/web_mock_fixture_helpers.rb

@@ -0,0 +1,6 @@
+# Helpers to deal with webmock stored fixtures
+module WebMockFixtureHelpers
+  def stored_response(filename)
+    File.new(File.join('spec', 'webmock_files', filename))
+  end
+end

data/spec/webmock_files/bancontact_redirect_url_output

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+Cache-Control: private
+Content-Type: text/xml; charset=utf-8
+Server: Microsoft-IIS/7.0
+X-AspNet-Version: 2.0.50727
+X-Powered-By: ASP.NET
+Date: Tue, 28 May 2013 13:12:23 GMT
+Content-Length: 451
+
+<?xml version="1.0" encoding="UTF-8"?><transactionrequest xmlns="https://www.sisow.nl/Sisow/REST" version="1.0.0"><transaction><issuerurl>https%3a%2f%2fwww.sisow.nl%2fSisow%2fiDeal%2fSimulator.aspx%3fmerchantid%3d2537407799%26txid%3dTEST90488925390%26sha1%3dbcd4de11b84ed32fe9dbc463b6c22be269a206ed</issuerurl><trxid>TEST90488925390</trxid></transaction><signature><sha1>35cb4a9b7234fea29270ac49254935125a53c39d</sha1></signature></transactionrequest>

data/spec/webmock_files/creditcard_redirect_url_output

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+Cache-Control: private
+Content-Type: text/xml; charset=utf-8
+Server: Microsoft-IIS/7.0
+X-AspNet-Version: 4.0.30319
+X-Powered-By: ASP.NET
+Date: Fri, 01 May 2015 08:27:14 GMT
+Content-Length: 451
+
+<?xml version="1.0" encoding="UTF-8"?><transactionrequest xmlns="https://www.sisow.nl/Sisow/REST" version="1.0.0"><transaction><issuerurl>https%3a%2f%2fwww.sisow.nl%2fSisow%2fiDeal%2fSimulator.aspx%3fmerchantid%3d2537407799%26txid%3dTEST90488925266%26sha1%3d1eb7cba3b911839f7431ec39103f2c2967399580</issuerurl><trxid>TEST90488925266</trxid></transaction><signature><sha1>0f3236350878aa51d9ec09973ee50175cd99076a</sha1></signature></transactionrequest>

data/spec/webmock_files/ideal_issuer_output

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+Cache-Control: private
+Content-Type: text/xml; charset=utf-8
+Server: Microsoft-IIS/7.0
+X-AspNet-Version: 2.0.50727
+X-Powered-By: ASP.NET
+Date: Tue, 28 May 2013 12:53:01 GMT
+Content-Length: 906
+
+<?xml version="1.0" encoding="UTF-8"?><directoryresponse xmlns="https://www.sisow.nl/Sisow/REST" version="1.0.0"><directory><issuer><issuerid>01</issuerid><issuername>ABN Amro Bank</issuername></issuer><issuer><issuerid>02</issuerid><issuername>ASN Bank</issuername></issuer><issuer><issuerid>04</issuerid><issuername>Friesland Bank</issuername></issuer><issuer><issuerid>05</issuerid><issuername>ING</issuername></issuer><issuer><issuerid>06</issuerid><issuername>Rabobank</issuername></issuer><issuer><issuerid>07</issuerid><issuername>SNS Bank</issuername></issuer><issuer><issuerid>08</issuerid><issuername>RegioBank</issuername></issuer><issuer><issuerid>09</issuerid><issuername>Triodos Bank</issuername></issuer><issuer><issuerid>10</issuerid><issuername>Van Lanschot Bankiers</issuername></issuer><issuer><issuerid>11</issuerid><issuername>Knab</issuername></issuer></directory></directoryresponse>

data/spec/webmock_files/ideal_redirect_url_output

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+Cache-Control: private
+Content-Type: text/xml; charset=utf-8
+Server: Microsoft-IIS/7.0
+X-AspNet-Version: 2.0.50727
+X-Powered-By: ASP.NET
+Date: Tue, 28 May 2013 13:01:52 GMT
+Content-Length: 453
+
+<?xml version="1.0" encoding="UTF-8"?><transactionrequest xmlns="https://www.sisow.nl/Sisow/REST" version="1.0.0"><transaction><issuerurl>https%3a%2f%2fwww.sisow.nl%2fSisow%2fiDeal%2fSimulator.aspx%3fmerchantid%3d2537407799%26txid%3dTEST080487604203%26sha1%3d7d632226dbc872b15e2933fecb3f755fec0a1742</issuerurl><trxid>TEST080487604203</trxid></transaction><signature><sha1>59535898c4a9f28882c284b181ba83ea5e890c0d</sha1></signature></transactionrequest>

data/spec/webmock_files/paypal_redirect_url_output

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+Cache-Control: private
+Content-Type: text/xml; charset=utf-8
+Server: Microsoft-IIS/7.0
+X-AspNet-Version: 4.0.30319
+X-Powered-By: ASP.NET
+Date: Fri, 01 May 2015 08:27:14 GMT
+Content-Length: 451
+
+<?xml version="1.0" encoding="UTF-8"?><transactionrequest xmlns="https://www.sisow.nl/Sisow/REST" version="1.0.0"><transaction><issuerurl>https%3a%2f%2fwww.sisow.nl%2fSisow%2fiDeal%2fSimulator.aspx%3fmerchantid%3d2537407799%26txid%3dTEST90488925266%26sha1%3d1eb7cba3b911839f7431ec39103f2c2967399580</issuerurl><trxid>TEST90488925266</trxid></transaction><signature><sha1>0f3236350878aa51d9ec09973ee50175cd99076a</sha1></signature></transactionrequest>

data/spec/webmock_files/sofort_redirect_url_output

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+Cache-Control: private
+Content-Type: text/xml; charset=utf-8
+Server: Microsoft-IIS/7.0
+X-AspNet-Version: 2.0.50727
+X-Powered-By: ASP.NET
+Date: Tue, 28 May 2013 13:09:12 GMT
+Content-Length: 451
+
+<?xml version="1.0" encoding="UTF-8"?><transactionrequest xmlns="https://www.sisow.nl/Sisow/REST" version="1.0.0"><transaction><issuerurl>https%3a%2f%2fwww.sisow.nl%2fSisow%2fiDeal%2fSimulator.aspx%3fmerchantid%3d2537407799%26txid%3dTEST90488925266%26sha1%3d1eb7cba3b911839f7431ec39103f2c2967399580</issuerurl><trxid>TEST90488925266</trxid></transaction><signature><sha1>0f3236350878aa51d9ec09973ee50175cd99076a</sha1></signature></transactionrequest>