spree_backend 3.2.9 → 3.3.0.rc1

data/spec/controllers/spree/admin/stock_items_controller_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+module Spree
+  module Admin
+    describe StockItemsController, type: :controller do
+      stub_authorization!
+
+      context "formats" do
+        let!(:stock_item) { create(:variant).stock_items.first }
+
+        it "destroy stock item via js" do
+          expect {
+            spree_delete :destroy, format: :js, id: stock_item
+          }.to change{ StockItem.count }.by(-1)
+        end
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/stock_locations_controller_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+module Spree
+  module Admin
+    describe StockLocationsController, type: :controller do
+      stub_authorization!
+      
+      # Regression for #4272
+      context "with no countries present" do
+        it "cannot create a new stock location" do
+          spree_get :new
+          expect(flash[:error]).to eq(Spree.t(:stock_locations_need_a_default_country))
+          expect(response).to redirect_to(spree.admin_stock_locations_path)
+        end
+      end
+
+      context "with a default country present" do
+        before do
+          country = FactoryGirl.create(:country)
+          Spree::Config[:default_country_id] = country.id
+        end
+
+        it "can create a new stock location" do
+          spree_get :new
+          expect(response).to be_success
+        end
+      end
+
+      context "with a country with the ISO code of 'US' existing" do
+        before do
+          FactoryGirl.create(:country, iso: 'US')
+        end
+
+        it "can create a new stock location" do
+          spree_get :new
+          expect(response).to be_success
+        end 
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/stock_transfers_controller_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+module Spree
+  describe Admin::StockTransfersController, type: :controller do
+    stub_authorization!
+
+    let!(:stock_transfer1) {
+      StockTransfer.create do |transfer|
+        transfer.source_location_id = 1
+        transfer.destination_location_id = 2
+        transfer.reference = 'PO 666'
+      end }
+
+    let!(:stock_transfer2) {
+      StockTransfer.create do |transfer|
+        transfer.source_location_id = 3
+        transfer.destination_location_id = 4
+        transfer.reference = 'PO 666'
+      end }
+
+
+    context "#index" do
+      it "gets all transfers without search criteria" do
+        spree_get :index
+        expect(assigns[:stock_transfers].count).to eq 2
+      end
+
+      it "searches by source location" do
+        spree_get :index, q: { source_location_id_eq: 1 }
+        expect(assigns[:stock_transfers].count).to eq 1
+        expect(assigns[:stock_transfers]).to include(stock_transfer1)
+      end
+
+      it "searches by destination location" do
+        spree_get :index, q: { destination_location_id_eq: 4 }
+        expect(assigns[:stock_transfers].count).to eq 1
+        expect(assigns[:stock_transfers]).to include(stock_transfer2)
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/tax_categories_controller_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+module Spree
+  module Admin
+    describe TaxCategoriesController, type: :controller do
+      stub_authorization!
+
+      describe 'GET #index' do
+        subject { spree_get :index }
+
+        it 'should be successful' do
+          expect(subject).to be_success
+        end
+      end
+
+      describe 'PUT #update' do
+        let(:tax_category) { create :tax_category }
+    
+        subject { spree_put :update, {id: tax_category.id, tax_category: { name: 'Foo', tax_code: 'Bar' }}}
+
+        it 'should redirect' do
+          expect(subject).to be_redirect
+        end
+
+        it 'should update' do
+          subject
+          tax_category.reload
+          expect(tax_category.name).to eq('Foo')
+          expect(tax_category.tax_code).to eq('Bar')
+        end
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/users_controller_spec.rb

@@ -0,0 +1,161 @@
+require 'spec_helper'
+require 'spree/testing_support/bar_ability'
+
+describe Spree::Admin::UsersController, type: :controller do
+  let(:user) { create(:user) }
+  let(:mock_user) { mock_model Spree.user_class }
+
+  before do
+    allow(controller).to receive_messages spree_current_user: user
+    user.spree_roles.clear
+    stub_const('Spree::User', user.class)
+  end
+
+  context "#show" do
+    before do
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+    end
+
+    it "redirects to edit" do
+      spree_get :show, id: user.id
+      expect(response).to redirect_to spree.edit_admin_user_path(user)
+    end
+  end
+
+  context '#authorize_admin' do
+    before { use_mock_user }
+
+    it 'grant access to users with an admin role' do
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+      spree_post :index
+      expect(response).to render_template :index
+    end
+
+    it "allows admins to update a user's API key" do
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+      expect(mock_user).to receive(:generate_spree_api_key!).and_return(true)
+      spree_put :generate_api_key, id: mock_user.id
+      expect(response).to redirect_to(spree.edit_admin_user_path(mock_user))
+    end
+
+    it "allows admins to clear a user's API key" do
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+      expect(mock_user).to receive(:clear_spree_api_key!).and_return(true)
+      spree_put :clear_api_key, id: mock_user.id
+      expect(response).to redirect_to(spree.edit_admin_user_path(mock_user))
+    end
+
+    it 'deny access to users with an bar role' do
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'bar')
+      Spree::Ability.register_ability(BarAbility)
+      spree_post :index
+      expect(response).to redirect_to(spree.forbidden_path)
+    end
+
+    it 'deny access to users with an bar role' do
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'bar')
+      Spree::Ability.register_ability(BarAbility)
+      spree_post :update, { id: '9' }
+      expect(response).to redirect_to(spree.forbidden_path)
+    end
+
+    it 'deny access to users without an admin role' do
+      allow(user).to receive_messages has_spree_role?: false
+      spree_post :index
+      expect(response).to redirect_to(spree.forbidden_path)
+    end
+  end
+
+  describe "#create" do
+    before do
+      use_mock_user
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+    end
+
+    it "can create a shipping_address" do
+      expect(Spree.user_class).to receive(:new).with(ActionController::Parameters.new(
+        "ship_address_attributes" => { "city" => "New York" }
+      ).permit(ship_address_attributes: permitted_address_attributes))
+      spree_post :create, user: { ship_address_attributes: { city: "New York" } }
+    end
+
+    it "can create a billing_address" do
+      expect(Spree.user_class).to receive(:new).with(ActionController::Parameters.new(
+        "bill_address_attributes" => { "city" => "New York" }
+      ).permit(bill_address_attributes: permitted_address_attributes))
+      spree_post :create, user: { bill_address_attributes: { city: "New York" } }
+    end
+  end
+
+  describe "#update" do
+    before do
+      use_mock_user
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+    end
+
+    it "allows shipping address attributes through" do
+      expect(mock_user).to receive(:update_attributes).with(ActionController::Parameters.new(
+        "ship_address_attributes" => { "city" => "New York" }
+      ).permit(ship_address_attributes: permitted_address_attributes))
+      spree_put :update, id: mock_user.id, user: { ship_address_attributes: { city: "New York" } }
+    end
+
+    it "allows billing address attributes through" do
+      expect(mock_user).to receive(:update_attributes).with(ActionController::Parameters.new(
+        "bill_address_attributes" => { "city" => "New York" }
+      ).permit(bill_address_attributes: permitted_address_attributes))
+      spree_put :update, id: mock_user.id, user: { bill_address_attributes: { city: "New York" } }
+    end
+
+    it "allows updating without password resetting" do
+      expect(mock_user).to receive(:update_attributes).with(hash_not_including(password: '', password_confirmation: ''))
+      spree_put :update, id: mock_user.id, user: { password: '', password_confirmation: '', email: 'spree@example.com' }
+    end
+  end
+
+  describe "#orders" do
+    let(:order) { create(:order) }
+    before do
+      user.orders << order
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+    end
+
+    it "assigns a list of the users orders" do
+      spree_get :orders, { id: user.id }
+      expect(assigns[:orders].count).to eq 1
+      expect(assigns[:orders].first).to eq order
+    end
+
+    it "assigns a ransack search for Spree::Order" do
+      spree_get :orders, { id: user.id }
+      expect(assigns[:search]).to be_a Ransack::Search
+      expect(assigns[:search].klass).to eq Spree::Order
+    end
+  end
+
+  describe "#items" do
+    let(:order) { create(:order) }
+    before do
+      user.orders << order
+      user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+    end
+
+    it "assigns a list of the users orders" do
+      spree_get :items, { id: user.id }
+      expect(assigns[:orders].count).to eq 1
+      expect(assigns[:orders].first).to eq order
+    end
+
+    it "assigns a ransack search for Spree::Order" do
+      spree_get :items, { id: user.id }
+      expect(assigns[:search]).to be_a Ransack::Search
+      expect(assigns[:search].klass).to eq Spree::Order
+    end
+  end
+end
+
+def use_mock_user
+  allow(mock_user).to receive(:save).and_return(true)
+  allow(Spree.user_class).to receive(:find).with(mock_user.id.to_s).and_return(mock_user)
+  allow(Spree.user_class).to receive(:new).and_return(mock_user)
+end

data/spec/controllers/spree/admin/variants_controller_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+module Spree
+  module Admin
+    describe VariantsController, type: :controller do
+      stub_authorization!
+
+      describe "#index" do
+        let(:product) { create(:product) }
+        let!(:variant_1) { create(:variant, product: product) }
+        let!(:variant_2) { create(:variant, product: product) }
+
+        context "deleted is not requested" do
+          it "assigns the variants for a requested product" do
+            spree_get :index, product_id: product.slug
+            expect(assigns(:collection)).to include variant_1
+            expect(assigns(:collection)).to include variant_2
+          end
+        end
+
+        context "deleted is requested" do
+          before { variant_2.destroy }
+          it "assigns only deleted variants for a requested product" do
+            spree_get :index, product_id: product.slug, deleted: "on"
+            expect(assigns(:collection)).not_to include variant_1
+            expect(assigns(:collection)).to include variant_2
+          end
+        end
+      end
+    end
+  end
+end

data/spec/features/admin/configuration/analytics_tracker_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe "Analytics Tracker", type: :feature do
+  stub_authorization!
+
+  context "index" do
+    before(:each) do
+      create(:tracker)
+      create(:tracker, analytics_id: 'A200')
+      visit spree.admin_trackers_path
+    end
+
+    it "should have the right content" do
+      expect(page).to have_content("Analytics Trackers")
+    end
+
+    it "should have the right tabular values displayed" do
+      within_row(1) do
+        expect(column_text(1)).to eq("A100")
+        expect(column_text(2)).to eq("Yes")
+      end
+
+      within_row(2) do
+        expect(column_text(1)).to eq("A200")
+        expect(column_text(2)).to eq("Yes")
+      end
+    end
+   end
+
+  context "create" do
+    before(:each) do
+      visit spree.admin_trackers_path
+    end
+
+    it "should be able to create a new analytics tracker" do
+      click_link "admin_new_tracker_link"
+      fill_in "tracker_analytics_id", with: "A100"
+      click_button "Create"
+
+      expect(page).to have_content("successfully created!")
+      within_row(1) do
+        expect(column_text(1)).to eq("A100")
+        expect(column_text(2)).to eq("Yes")
+      end
+    end
+  end
+end

data/spec/features/admin/configuration/countries_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module Spree
+  describe "Countries", type: :feature do
+    stub_authorization!
+
+    it "deletes a state", js: true do
+      visit spree.admin_countries_path
+      click_link "New Country"
+
+      fill_in "Name", with: "Brazil"
+      fill_in "Iso Name", with: "BRL"
+      click_button "Create"
+
+      accept_alert do
+        click_icon :delete
+      end
+
+      wait_for_ajax
+
+      expect { Country.find(country.id) }.to raise_error(StandardError)
+    end
+  end
+end

data/spec/features/admin/configuration/general_settings_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe "General Settings", type: :feature do
+  stub_authorization!
+
+  before(:each) do
+    store = create(:store, name: 'Test Store', url: 'test.example.org',
+                           mail_from_address: 'test@example.org')
+    visit spree.edit_admin_general_settings_path
+  end
+
+  context "visiting general settings (admin)" do
+    it "should have the right content" do
+      expect(page).to have_content("General Settings")
+      expect(find("#store_name").value).to eq("Test Store")
+      expect(find("#store_url").value).to eq("test.example.org")
+      expect(find("#store_mail_from_address").value).to eq("test@example.org")
+      expect(page).to_not have_content(Spree.t(:security_settings))
+    end
+  end
+
+  context "editing general settings (admin)" do
+    it "should be able to update the site name" do
+      fill_in "store_name", with: "Spree Demo Site99"
+      fill_in "store_mail_from_address", with: "spree@example.org"
+      click_button "Update"
+
+      assert_successful_update_message(:general_settings)
+      expect(find("#store_name").value).to eq("Spree Demo Site99")
+      expect(find("#store_mail_from_address").value).to eq("spree@example.org")
+    end
+  end
+
+  context "clearing the cache", js: true do
+    it "should clear the cache" do
+      expect(page).to_not have_content(Spree.t(:clear_cache_ok))
+      expect(page).to have_content(Spree.t(:clear_cache_warning))
+
+      click_button "Clear Cache"
+
+      expect(page).to have_content(Spree.t(:clear_cache_ok))
+    end
+  end
+end

data/spec/features/admin/configuration/payment_methods_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+describe "Payment Methods", type: :feature do
+  stub_authorization!
+
+  before(:each) do
+    visit spree.admin_payment_methods_path
+  end
+
+  context "admin visiting payment methods listing page" do
+    it "should display existing payment methods" do
+      create(:check_payment_method)
+      visit current_path
+
+      within("table#listing_payment_methods") do
+        expect(all("th")[1].text).to eq("Name")
+        expect(all("th")[2].text).to eq("Provider")
+        expect(all("th")[3].text).to eq("Display")
+        expect(all("th")[4].text).to eq("Active")
+      end
+
+      within('table#listing_payment_methods') do
+        expect(page).to have_content("Spree::PaymentMethod::Check")
+      end
+    end
+  end
+
+  context "admin creating a new payment method" do
+    it "should be able to create a new payment method" do
+      click_link "admin_new_payment_methods_link"
+      expect(page).to have_content("New Payment Method")
+      fill_in "payment_method_name", with: "check90"
+      fill_in "payment_method_description", with: "check90 desc"
+      select "PaymentMethod::Check", from: "gtwy-type"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+  end
+
+  context "admin editing a payment method", js: true do
+    before(:each) do
+      create(:check_payment_method)
+      visit current_path
+
+      within("table#listing_payment_methods") do
+        click_icon(:edit)
+      end
+    end
+
+    it "should be able to edit an existing payment method" do
+      fill_in "payment_method_name", with: "Payment 99"
+      click_button "Update"
+      expect(page).to have_content("successfully updated!")
+      expect(find_field("payment_method_name").value).to eq("Payment 99")
+    end
+
+    it "should display validation errors" do
+      fill_in "payment_method_name", with: ""
+      click_button "Update"
+      expect(page).to have_content("Name can't be blank")
+    end
+  end
+end

data/spec/features/admin/configuration/roles_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe "Roles", type: :feature do
+  stub_authorization!
+
+  before(:each) do
+    create(:role, name: "admin")
+    create(:role, name: "user")
+    visit spree.admin_path
+    click_link "Configuration"
+    # Crap workaround for animation to finish expanding so click doesn't hit ReimbursementTypes.
+    sleep 1
+    click_link "Roles"
+  end
+
+  context "show" do
+    it "should display existing roles" do
+      within_row(1) { expect(page).to have_content("admin") }
+      within_row(2) { expect(page).to have_content("user") }
+    end
+  end
+
+  context "create" do
+    it "should be able to create a new role" do
+      click_link "admin_new_role_link"
+      expect(page).to have_content("New Role")
+      fill_in "role_name", with: "blogger"
+      click_button "Create"
+      expect(page).to have_content("successfully created!")
+    end
+  end
+
+  context "edit" do
+    it "should not be able to edit the admin role" do
+      within_row(1) do
+        expect(find("td:nth-child(2)")).not_to have_selector(:css, "span.icon-edit")
+        expect(find("td:nth-child(2)")).not_to have_selector(:css, "span.icon-delete")
+      end
+    end
+    it "should be able to edit the user role" do
+      within_row(2) do
+        expect(find("td:nth-child(2)")).to have_selector(:css, "span.icon-edit")
+        expect(find("td:nth-child(2)")).to have_selector(:css, "span.icon-delete")
+      end
+    end
+  end
+end

data/spec/features/admin/configuration/shipping_methods_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe "Shipping Methods", type: :feature do
+  stub_authorization!
+  let!(:zone) { create(:global_zone) }
+  let!(:shipping_method) { create(:shipping_method, zones: [zone]) }
+
+  after do
+    Capybara.ignore_hidden_elements = true
+  end
+
+  before do
+    Capybara.ignore_hidden_elements = false
+    # HACK: To work around no email prompting on check out
+    allow_any_instance_of(Spree::Order).to receive_messages(require_email: false)
+    create(:check_payment_method)
+
+    visit spree.admin_shipping_methods_path
+  end
+
+  context "show" do
+    it "should display existing shipping methods" do
+      within_row(1) do
+        expect(column_text(1)).to eq(shipping_method.name)
+        expect(column_text(2)).to eq(zone.name)
+        expect(column_text(3)).to eq("Flat rate")
+        expect(column_text(4)).to eq("Both")
+      end
+    end
+  end
+
+  context "create" do
+    it "should be able to create a new shipping method" do
+      click_link "New Shipping Method"
+
+      fill_in "shipping_method_name", with: "bullock cart"
+
+      within("#shipping_method_categories_field") do
+        check first("input[type='checkbox']")["name"]
+      end
+
+      click_on "Create"
+      expect(current_path).to eql(spree.edit_admin_shipping_method_path(Spree::ShippingMethod.last))
+    end
+  end
+
+  # Regression test for #1331
+  context "update" do
+    it "can change the calculator", js: true do
+      within("#listing_shipping_methods") do
+        click_icon :edit
+      end
+
+      expect(find(:css, ".calculator-settings-warning")).not_to be_visible
+      select2_search('Flexible Rate', from: 'Calculator')
+      expect(find(:css, ".calculator-settings-warning")).to be_visible
+
+      click_button "Update"
+      expect(page).not_to have_content("Shipping method is not found")
+    end
+  end
+end