spree_auth_devise 1.3.1 → 3.0.5

data/spec/features/confirmation_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+feature 'Confirmation' do
+  before do
+    set_confirmable_option(true)
+    Spree::UserMailer.stub(:confirmation_instructions).and_return(double(deliver: true))
+  end
+
+  after(:each) { set_confirmable_option(false) }
+
+  let!(:store) { create(:store) }
+
+  background do
+    ActionMailer::Base.default_url_options[:host] = 'http://example.com'
+  end
+
+  scenario 'create a new user' do
+    visit spree.signup_path
+
+    fill_in 'Email', with: 'email@person.com'
+    fill_in 'Password', with: 'password'
+    fill_in 'Password Confirmation', with: 'password'
+    click_button 'Create'
+
+    expect(page).to have_text 'You have signed up successfully.'
+    expect(Spree::User.last.confirmed?).to be(false)
+  end
+end

data/spec/features/order_spec.rb

@@ -0,0 +1,62 @@
+RSpec.feature 'Orders', :js, type: :feature do
+
+  scenario 'allow a user to view their cart at any time' do
+    visit spree.cart_path
+    expect(page).to have_text 'Your cart is empty'
+  end
+
+  # regression test for spree/spree#1687
+  scenario 'merge incomplete orders from different sessions' do
+    skip %{
+      TODO: has been broken for ~2 months as of:
+      https://github.com/spree/spree_auth_devise/commit/3157b47b22c559817d34ec34024587d8aa6136dc
+      I dont think we can decode these sessions anymore since Rails 4 switched to encrypted cookies I believe devise stores session encrypted.
+    }
+    create(:product, name: 'RoR Mug')
+    create(:product, name: 'RoR Shirt')
+
+    user = create(:user, email: 'email@person.com', password: 'password', password_confirmation: 'password')
+
+    using_session('first') do
+      visit spree.root_path
+
+      click_link 'RoR Mug'
+      click_button 'Add To Cart'
+
+      visit spree.login_path
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Login'
+
+      click_link 'Cart'
+      expect(page).to have_text 'RoR Mug'
+    end
+
+    using_session('second') do
+      visit spree.root_path
+
+      click_link 'RoR Shirt'
+      click_button 'Add To Cart'
+
+      visit spree.login_path
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Login'
+
+      # Order should have been merged with first session
+      click_link 'Cart'
+      expect(page).to have_text 'RoR Mug'
+      expect(page).to have_text 'RoR Shirt'
+    end
+
+    using_session('first') do
+      visit spree.root_path
+
+      click_link 'Cart'
+
+      # Order should have been merged with second session
+      expect(page).to have_text 'RoR Mug'
+      expect(page).to have_text 'RoR Shirt'
+    end
+  end
+end

data/spec/features/password_reset_spec.rb

@@ -0,0 +1,24 @@
+RSpec.feature 'Reset Password', type: :feature do
+
+  let!(:store) { create(:store) }
+
+  background do
+    ActionMailer::Base.default_url_options[:host] = 'http://example.com'
+  end
+
+  scenario 'allow a user to supply an email for the password reset' do
+    user = create(:user, email: 'foobar@example.com', password: 'secret', password_confirmation: 'secret')
+    visit spree.login_path
+    click_link 'Forgot Password?'
+    fill_in 'Email', with: 'foobar@example.com'
+    click_button 'Reset my password'
+    expect(page).to have_text 'You will receive an email with instructions'
+  end
+
+  scenario 'shows errors if no email is supplied' do
+    visit spree.login_path
+    click_link 'Forgot Password?'
+    click_button 'Reset my password'
+    expect(page).to have_text "Email can't be blank"
+  end
+end

data/spec/features/sign_in_spec.rb

@@ -0,0 +1,54 @@
+RSpec.feature 'Sign In', type: :feature do
+
+  background do
+    @user = create(:user, email: 'email@person.com', password: 'secret', password_confirmation: 'secret')
+    visit spree.login_path
+  end
+
+  scenario 'ask user to sign in' do
+    visit spree.admin_path
+    expect(page).not_to have_text 'Authorization Failure'
+  end
+
+  scenario 'let a user sign in successfully' do
+    fill_in 'Email', with: @user.email
+    fill_in 'Password', with: @user.password
+    click_button 'Login'
+
+    expect(page).to have_text 'Logged in successfully'
+    expect(page).not_to have_text 'Login'
+    expect(page).to have_text 'Logout'
+    expect(current_path).to eq '/'
+  end
+
+  scenario 'show validation erros' do
+    fill_in 'Email', with: @user.email
+    fill_in 'Password', with: 'wrong_password'
+    click_button 'Login'
+
+    expect(page).to have_text 'Invalid email or password'
+    expect(page).to have_text 'Login'
+  end
+
+  scenario 'allow a user to access a restricted page after logging in' do
+    user = create(:admin_user, email: 'admin@person.com', password: 'password', password_confirmation: 'password')
+    visit spree.admin_path
+
+    fill_in 'Email', with: user.email
+    fill_in 'Password', with: user.password
+    click_button 'Login'
+
+    within '.user-menu' do
+      expect(page).to have_text 'admin@person.com'
+    end
+    expect(current_path).to eq '/admin/orders'
+  end
+
+  it "should store the user previous location" do
+    visit spree.account_path
+    fill_in "Email", with: @user.email
+    fill_in "Password", with: @user.password
+    click_button "Login"
+    expect(current_path).to eq "/account"
+  end
+end

data/spec/features/sign_out_spec.rb

@@ -0,0 +1,25 @@
+RSpec.feature 'Sign Out', type: :feature do
+
+  given!(:user) do
+   create(:user,
+          email: 'email@person.com',
+          password: 'secret',
+          password_confirmation: 'secret')
+  end
+
+  background do
+    visit spree.login_path
+    fill_in 'Email', with: user.email
+    fill_in 'Password', with: user.password
+    # Regression test for #1257
+    check 'Remember me'
+    click_button 'Login'
+  end
+
+  scenario 'allow a signed in user to logout' do
+    click_link 'Logout'
+    visit spree.root_path
+    expect(page).to have_text 'Login'
+    expect(page).not_to have_text 'Logout'
+  end
+end

data/spec/features/sign_up_spec.rb

@@ -0,0 +1,30 @@
+RSpec.feature 'Sign Up', type: :feature do
+
+  context 'with valid data' do
+    scenario 'create a new user' do
+      visit spree.signup_path
+
+      fill_in 'Email', with: 'email@person.com'
+      fill_in 'Password', with: 'password'
+      fill_in 'Password Confirmation', with: 'password'
+      click_button 'Create'
+
+      expect(page).to have_text 'You have signed up successfully.'
+      expect(Spree::User.count).to eq(1)
+    end
+  end
+
+  context 'with invalid data' do
+    scenario 'does not create a new user' do
+      visit spree.signup_path
+
+      fill_in 'Email', with: 'email@person.com'
+      fill_in 'Password', with: 'password'
+      fill_in 'Password Confirmation', with: ''
+      click_button 'Create'
+
+      expect(page).to have_css '#errorExplanation'
+      expect(Spree::User.count).to eq(0)
+    end
+  end
+end

data/spec/mailers/user_mailer_spec.rb

@@ -0,0 +1,46 @@
+RSpec.describe Spree::UserMailer, type: :mailer do
+
+  let!(:store) { create(:store) }
+  let(:user) { create(:user) }
+
+  before do
+    user = create(:user)
+    Spree::UserMailer.reset_password_instructions(user, 'token goes here').deliver_later
+    @message = ActionMailer::Base.deliveries.last
+  end
+
+  describe '#reset_password_instructions' do
+    describe 'message contents' do
+      before do
+        described_class.reset_password_instructions(user, 'token goes here').deliver_later
+        @message = ActionMailer::Base.deliveries.last
+      end
+
+      context 'subject includes' do
+        it 'translated devise instructions' do
+          expect(@message.subject).to include(
+            I18n.t(:subject, scope: [:devise, :mailer, :reset_password_instructions])
+          )
+        end
+
+        it 'Spree site name' do
+          expect(@message.subject).to include store.name
+        end
+      end
+
+      context 'body includes' do
+        it 'password reset url' do
+          expect(@message.body.raw_source).to include "http://#{store.url}/user/spree_user/password/edit"
+        end
+      end
+    end
+
+    describe 'legacy support for User object' do
+      it 'sends an email' do
+        expect {
+          described_class.reset_password_instructions(user, 'token goes here').deliver_later
+        }.to change(ActionMailer::Base.deliveries, :size).by(1)
+      end
+    end
+  end
+end

data/spec/models/order_spec.rb

@@ -0,0 +1,26 @@
+RSpec.describe Spree::Order, type: :model do
+
+  let(:order) { described_class.new }
+
+  context '#associate_user!' do
+    let(:user) { build_stubbed(:user, email: 'spree@example.com') }
+    before { allow(order).to receive(:save!) { true } }
+
+    it 'associates the order with the specified user' do
+      order.associate_user! user
+      expect(order.user).to eq user
+    end
+
+    it "sets the order's email attribute to that of the specified user" do
+      order.associate_user! user
+      expect(order.email).to eq user.email
+    end
+
+    it 'destroys any previous association with a guest user' do
+      guest_user = build_stubbed(:user)
+      order.user = guest_user
+      order.associate_user! user
+      expect(order.user).not_to eq guest_user
+    end
+  end
+end

data/spec/models/user_spec.rb

@@ -0,0 +1,58 @@
+RSpec.describe Spree::User, type: :model do
+
+  before(:all) { Spree::Role.create name: 'admin' }
+
+  it '#admin?' do
+    expect(create(:admin_user).admin?).to be true
+    expect(create(:user).admin?).to be false
+  end
+
+  it 'generates the reset password token' do
+    user = build(:user)
+    expect(Spree::UserMailer).to receive(:reset_password_instructions).with(user, anything, {}).and_return(double(deliver: true))
+    user.send_reset_password_instructions
+    expect(user.reset_password_token).not_to be_nil
+  end
+
+  context '#destroy' do
+    it 'will soft delete' do
+      order = build(:order, completed_at: Time.now)
+      order.save
+      user = order.user
+      user.destroy
+      expect(Spree::User.find_by_id(user.id)).to be_nil
+      expect(Spree::User.with_deleted.find_by_id(user.id).id).to eq(user.id)
+      expect(Spree::User.with_deleted.find_by_id(user.id).orders.first).to eq(order)
+
+      expect(Spree::Order.find_by_user_id(user.id)).not_to be_nil
+      expect(Spree::Order.where(user_id: user.id).first).to eq(order)
+    end
+
+    it 'will allow users to register later with same email address as previously deleted account' do
+      user1 = build(:user)
+      user1.save
+
+      user2 = build(:user)
+      user2.email = user1.email
+      expect(user2.save).to be false
+      expect(user2.errors.messages[:email].first).to eq "has already been taken"
+
+      user1.destroy
+      expect(user2.save).to be true
+    end
+  end
+
+  describe "confirmable" do
+    it "is confirmable if the confirmable option is enabled" do
+      set_confirmable_option(true)
+      Spree::UserMailer.stub(:confirmation_instructions).and_return(double(deliver: true))
+      expect(Spree::User.devise_modules).to include(:confirmable)
+      set_confirmable_option(false)
+    end
+
+    it "is not confirmable if the confirmable option is disabled" do
+      set_confirmable_option(false)
+      expect(Spree::User.devise_modules).to_not include(:confirmable)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,24 @@
+require 'simplecov'
+SimpleCov.start 'rails'
+
+ENV['RAILS_ENV'] ||= 'test'
+
+require File.expand_path('../dummy/config/environment', __FILE__)
+
+require 'rspec/rails'
+require 'shoulda-matchers'
+require 'ffaker'
+
+RSpec.configure do |config|
+  config.filter_run focus: true
+  config.infer_spec_type_from_file_location!
+  config.raise_errors_for_deprecations!
+  config.run_all_when_everything_filtered = true
+  config.use_transactional_fixtures = false
+
+  config.mock_with :rspec do |mock|
+    mock.syntax = [:should, :expect]
+  end
+end
+
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }

data/spec/support/ability.rb

@@ -0,0 +1,15 @@
+RSpec.configure do |config|
+  config.after do
+    Spree::Ability.abilities.delete(AbilityDecorator) if Spree::Ability.abilities.include?(AbilityDecorator)
+  end
+end
+
+if defined? CanCan::Ability
+  class AbilityDecorator
+    include CanCan::Ability
+
+    def initialize(user)
+      cannot :manage, Spree::Order
+    end
+  end
+end

data/spec/support/authentication_helpers.rb

@@ -0,0 +1,14 @@
+module AuthenticationHelpers
+  def sign_in_as!(user)
+    visit '/login'
+    fill_in 'Email', with: user.email
+    fill_in 'Password', with: 'secret'
+    click_button 'Login'
+  end
+end
+
+RSpec.configure do |config|
+  config.include AuthenticationHelpers, type: :feature
+  config.include Devise::TestHelpers,   type: :controller
+  config.include Rack::Test::Methods,   type: :feature
+end

data/spec/support/capybara.rb

@@ -0,0 +1,7 @@
+require 'capybara/rspec'
+require 'capybara/rails'
+require 'capybara/poltergeist'
+
+RSpec.configure do |config|
+  Capybara.javascript_driver = :poltergeist
+end

data/spec/support/confirm_helpers.rb

@@ -0,0 +1,11 @@
+module ConfirmHelpers
+  def set_confirmable_option(value)
+    Spree::Auth::Config[:confirmable] = value
+    Spree.send(:remove_const, 'User')
+    load File.expand_path("../../../app/models/spree/user.rb", __FILE__)
+  end
+end
+
+RSpec.configure do |c|
+  c.include ConfirmHelpers
+end