spree_api 2.4.7 → 2.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99560ebdaf455a59e76c64abf84ae1d2da1adb30
-  data.tar.gz: e9d198bf6d7a8a2131a7db49d55c61ae4d231b63
+  metadata.gz: 40d01a3bf09919e41497e15452a188bac206a1c2
+  data.tar.gz: 0096ccb1856282fa76364037044d210be2b33071
 SHA512:
-  metadata.gz: 94c7b6c9613e7ee865c0cc6cc0e0b761d4b077b76d7013677dacab09b032b15dccabdb3b1cb8d746557f6b66c82864bfcfedd688848c7a16da50c94a99375ba5
-  data.tar.gz: 1f4b86560857b5170b7566f641ace8b91d58f367d23dcc5bb4dfe8db02de637b19191825f3722ee378c96e02e53279e054d2f054fda207bb072f635acc070466
+  metadata.gz: 1ccecb22f194fee13d0524e7fd3c5715d5f953e93f8470d11795c60ae8b11df04af4d5ae32de2190c3823573aba944caeaaf9ba36acc019790df8f96b38b5652
+  data.tar.gz: 90aed06d9f038a35a86d7b07107f6b4f960de1dbae48a2f894f8ffa4cffec1347057ade007d158c5f423a50b6b791aba82225c91fbe29fed719d366ca11af1ad

data/app/controllers/spree/api/payments_controller.rb

@@ -26,7 +26,7 @@ module Spree
 
       def update
         authorize! params[:action], @payment
-        if ! @payment.pending?
+        if !@payment.editable?
           render 'update_forbidden', status: 403
         elsif @payment.update_attributes(payment_params)
           respond_with(@payment, default_template: :show)

data/lib/spree/api/responders/rabl_template.rb

@@ -14,7 +14,7 @@ module Spree
         end
 
         def template
-          request.headers['X-Spree-Template'] || controller.params[:template] || options[:default_template]
+          options[:default_template]
         end
 
         def api_behavior(error)

data/spec/controllers/spree/api/payments_controller_spec.rb

@@ -105,26 +105,37 @@ module Spree
 
       context "for a given payment" do
         context "updating" do
-          it "can update" do
-            payment.update_attributes(:state => 'pending')
-            api_put :update, :id => payment.to_param, :payment => { :amount => 2.01 }
-            expect(response.status).to eq(200)
-            expect(payment.reload.amount).to eq(2.01)
+          context "when the state is checkout" do
+            it "can update" do
+              payment.update_attributes(state: 'checkout')
+              api_put(:update, id: payment.to_param, payment: { amount: 2.01 })
+              expect(response.status).to be(200)
+              expect(payment.reload.amount).to eq(2.01)
+            end
+          end
+
+          context "when the state is pending" do
+            it "can update" do
+              payment.update_attributes(state: 'pending')
+              api_put(:update, id: payment.to_param, payment: { amount: 2.01 })
+              expect(response.status).to be(200)
+              expect(payment.reload.amount).to eq(2.01)
+            end
           end
 
           context "update fails" do
             it "returns a 422 status when the amount is invalid" do
-              payment.update_attributes(:state => 'pending')
-              api_put :update, :id => payment.to_param, :payment => { :amount => 'invalid' }
-              expect(response.status).to eq(422)
-              expect(json_response["error"]).to eq("Invalid resource. Please fix errors and try again.")
+              payment.update_attributes(state: 'pending')
+              api_put(:update, id: payment.to_param, payment: { amount: 'invalid' })
+              expect(response.status).to be(422)
+              expect(json_response['error']).to eql('Invalid resource. Please fix errors and try again.')
             end
 
             it "returns a 403 status when the payment is not pending" do
-              payment.update_attributes(:state => 'completed')
-              api_put :update, :id => payment.to_param, :payment => { :amount => 2.01 }
-              expect(response.status).to eq(403)
-              expect(json_response["error"]).to eq("This payment cannot be updated because it is completed.")
+              payment.update_attributes(state: 'completed')
+              api_put(:update, id: payment.to_param, payment: { amount: 2.01 })
+              expect(response.status).to be(403)
+              expect(json_response['error']).to eql('This payment cannot be updated because it is completed.')
             end
           end
         end

data/spec/controllers/spree/api/products_controller_spec.rb

@@ -67,34 +67,6 @@ module Spree
         expect(json_response["per_page"]).to eq(Kaminari.config.default_per_page)
       end
 
-      context "specifying a rabl template for a custom action" do
-        before do
-          Spree::Api::ProductsController.class_eval do
-            def custom_show
-              @product = find_product(params[:id])
-              respond_with(@product)
-            end
-          end
-        end
-
-        it "uses the specified custom template through the request header" do
-          request.headers['X-Spree-Template'] = 'show'
-          api_get :custom_show, :id => product.id
-          expect(response).to render_template('spree/api/products/show')
-        end
-
-        it "uses the specified custom template through the template URL parameter" do
-          api_get :custom_show, :id => product.id, :template => 'show'
-          expect(response).to render_template('spree/api/products/show')
-        end
-
-        it "falls back to the default template if the specified template does not exist" do
-          request.headers['X-Spree-Template'] = 'invoice'
-          api_get :show, :id => product.id
-          expect(response).to render_template('spree/api/products/show')
-        end
-      end
-
       context "product has more than one price" do
         before { product.master.prices.create currency: "EUR", amount: 22 }
 

data/spec/controllers/spree/api/zones_controller_spec.rb

@@ -38,28 +38,6 @@ module Spree
       expect(json_response['zone_members'].size).to eq @zone.zone_members.count
     end
 
-    context "specifying a rabl template to use" do
-      before do
-        Spree::Api::ZonesController.class_eval do
-          def custom_show
-            respond_with(zone)
-          end
-        end
-      end
-
-      it "uses the specified template" do
-        request.headers['X-Spree-Template'] = 'show'
-        api_get :custom_show, :id => @zone.id
-        expect(response).to render_template('spree/api/zones/show')
-      end
-
-      it "falls back to the default template if the specified template does not exist" do
-        request.headers['X-Spree-Template'] = 'invoice'
-        api_get :show, :id => @zone.id
-        expect(response).to render_template('spree/api/zones/show')
-      end
-    end
-
     context "as an admin" do
       sign_in_as_admin!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spree_api
 version: !ruby/object:Gem::Version
-  version: 2.4.7
+  version: 2.4.8
 platform: ruby
 authors:
 - Ryan Bigg
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2015-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.7
+        version: 2.4.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.7
+        version: 2.4.8
 - !ruby/object:Gem::Dependency
   name: rabl
   requirement: !ruby/object:Gem::Requirement