spree_api 2.3.13 → 2.4.0.rc1

data/spec/controllers/spree/api/orders_controller_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'spree/testing_support/bar_ability'
 
 module Spree
-  describe Api::OrdersController, :type => :controller do
+  describe Api::OrdersController do
     render_views
 
     let!(:order) { create(:order) }
@@ -46,7 +46,7 @@ module Spree
 
       it "returns a 401" do
         api_get :mine
-        expect(response.status).to eq(401)
+        response.status.should == 401
       end
     end
 
@@ -57,110 +57,123 @@ module Spree
       it "can view all of their own orders" do
         api_get :mine
 
-        expect(response.status).to eq(200)
-        expect(json_response["pages"]).to eq(1)
-        expect(json_response["current_page"]).to eq(1)
-        expect(json_response["orders"].length).to eq(1)
-        expect(json_response["orders"].first["number"]).to eq(order.number)
-        expect(json_response["orders"].first["line_items"].length).to eq(1)
-        expect(json_response["orders"].first["line_items"].first["id"]).to eq(line_item.id)
+        response.status.should == 200
+        json_response["pages"].should == 1
+        json_response["current_page"].should == 1
+        json_response["orders"].length.should == 1
+        json_response["orders"].first["number"].should == order.number
+        json_response["orders"].first["line_items"].length.should == 1
+        json_response["orders"].first["line_items"].first["id"].should == line_item.id
       end
 
       it "can filter the returned results" do
         api_get :mine, q: {completed_at_not_null: 1}
 
-        expect(response.status).to eq(200)
-        expect(json_response["orders"].length).to eq(0)
+        response.status.should == 200
+        json_response["orders"].length.should == 0
       end
 
-      it "returns orders in reverse chronological order" do
-        order2 = create(:order, line_items: [line_item], user: order.user)
-        expect(order2.created_at).to be > order.created_at
+      it "returns orders in reverse chronological order by completed_at" do
+        order.update_columns completed_at: Time.now
+
+        order2 = Order.create user: order.user, completed_at: Time.now - 1.day
+        order2.created_at.should > order.created_at
+        order3 = Order.create user: order.user, completed_at: nil
+        order3.created_at.should > order2.created_at
+        order4 = Order.create user: order.user, completed_at: nil
+        order4.created_at.should > order3.created_at
 
         api_get :mine
-        expect(response.status).to eq(200)
-        expect(json_response["pages"]).to eq(1)
-        expect(json_response["orders"].length).to eq(2)
-        expect(json_response["orders"][0]["number"]).to eq(order2.number)
-        expect(json_response["orders"][1]["number"]).to eq(order.number)
+        response.status.should == 200
+        json_response["pages"].should == 1
+        json_response["orders"].length.should == 4
+        json_response["orders"][0]["number"].should == order.number
+        json_response["orders"][1]["number"].should == order2.number
+        json_response["orders"][2]["number"].should == order4.number
+        json_response["orders"][3]["number"].should == order3.number
       end
     end
 
-    it "can view their own order" do
-      allow_any_instance_of(Order).to receive_messages :user => current_api_user
-      api_get :show, :id => order.to_param
-      expect(response.status).to eq(200)
-      expect(json_response).to have_attributes(attributes)
-      expect(json_response["adjustments"]).to be_empty
-    end
-
-    describe 'GET #show' do
-      let(:order) { create :order_with_line_items }
-      let(:adjustment) { FactoryGirl.create(:adjustment, order: order) }
+    describe 'current' do
+      let(:current_api_user) { order.user }
+      let!(:order) { create(:order, line_items: [line_item]) }
 
-      subject { api_get :show, id: order.to_param }
+      subject do
+        api_get :current, format: 'json'
+      end
 
-      before do
-        allow_any_instance_of(Order).to receive_messages :user => current_api_user
+      context "an incomplete order exists" do
+        it "returns that order" do
+          expect(JSON.parse(subject.body)['id']).to eq order.id
+          expect(subject).to be_success
+        end
       end
 
-      context 'when inventory information is present' do
-        it 'contains stock information on variant' do
-          subject
-          variant = json_response['line_items'][0]['variant']
-          expect(variant).to_not be_nil
-          expect(variant['in_stock']).to eq(false)
-          expect(variant['total_on_hand']).to eq(0)
-          expect(variant['is_backorderable']).to eq(true)
+      context "multiple incomplete orders exist" do
+        it "returns the latest incomplete order" do
+          new_order = Spree::Order.create! user: order.user
+          expect(new_order.created_at).to be > order.created_at
+          expect(JSON.parse(subject.body)['id']).to eq new_order.id
         end
       end
 
-      context 'when shipment adjustments are present' do
+      context "an incomplete order does not exist" do
+
         before do
-          order.shipments.first.adjustments << adjustment
+          order.update_attribute(:state, order_state)
+          order.update_attribute(:completed_at, 5.minutes.ago)
         end
 
-        it 'contains adjustments on shipment' do
-          subject
+        ["complete", "returned", "awaiting_return"].each do |order_state|
+          context "order is in the #{order_state} state" do
+            let(:order_state) { order_state }
 
-          # Test to insure shipment has adjustments
-          shipment = json_response['shipments'][0]
-          expect(shipment).to_not be_nil
-          expect(shipment['adjustments'][0]).not_to be_empty
-          expect(shipment['adjustments'][0]['label']).to eq(adjustment.label)
+            it "returns no content" do
+              expect(subject.status).to eq 204
+              expect(subject.body).to be_blank
+            end
+          end
         end
       end
     end
 
+    it "can view their own order" do
+      Order.any_instance.stub :user => current_api_user
+      api_get :show, :id => order.to_param
+      response.status.should == 200
+      json_response.should have_attributes(attributes)
+      json_response["adjustments"].should be_empty
+    end
+
     it "orders contain the basic checkout steps" do
-      allow_any_instance_of(Order).to receive_messages :user => current_api_user
+      Order.any_instance.stub :user => current_api_user
       api_get :show, :id => order.to_param
-      expect(response.status).to eq(200)
-      expect(json_response["checkout_steps"]).to eq(["address", "delivery", "complete"])
+      response.status.should == 200
+      json_response["checkout_steps"].should == ["address", "delivery", "complete"]
     end
 
     # Regression test for #1992
     it "can view an order not in a standard state" do
-      allow_any_instance_of(Order).to receive_messages :user => current_api_user
+      Order.any_instance.stub :user => current_api_user
       order.update_column(:state, 'shipped')
       api_get :show, :id => order.to_param
     end
 
     it "can not view someone else's order" do
-      allow_any_instance_of(Order).to receive_messages :user => stub_model(Spree::LegacyUser)
+      Order.any_instance.stub :user => stub_model(Spree::LegacyUser)
       api_get :show, :id => order.to_param
       assert_unauthorized!
     end
 
     it "can view an order if the token is known" do
       api_get :show, :id => order.to_param, :order_token => order.guest_token
-      expect(response.status).to eq(200)
+      response.status.should == 200
     end
 
     it "can view an order if the token is passed in header" do
       request.headers["X-Spree-Order-Token"] = order.guest_token
       api_get :show, :id => order.to_param
-      expect(response.status).to eq(200)
+      response.status.should == 200
     end
 
     context "with BarAbility registered" do
@@ -169,12 +182,12 @@ module Spree
 
       it "can view an order" do
         user = mock_model(Spree::LegacyUser)
-        allow(user).to receive_message_chain(:spree_roles, :pluck).and_return(["bar"])
-        allow(user).to receive(:has_spree_role?).with('bar').and_return(true)
-        allow(user).to receive(:has_spree_role?).with('admin').and_return(false)
-        allow(Spree.user_class).to receive_messages find_by: user
+        user.stub_chain(:spree_roles, :pluck).and_return(["bar"])
+        user.stub(:has_spree_role?).with('bar').and_return(true)
+        user.stub(:has_spree_role?).with('admin').and_return(false)
+        controller.stub try_spree_current_user: user
         api_get :show, :id => order.to_param
-        expect(response.status).to eq(200)
+        response.status.should == 200
       end
     end
 
@@ -192,19 +205,19 @@ module Spree
 
     it "can create an order" do
       api_post :create, :order => { :line_items => { "0" => { :variant_id => variant.to_param, :quantity => 5 } } }
-      expect(response.status).to eq(201)
+      response.status.should == 201
 
       order = Order.last
-      expect(order.line_items.count).to eq(1)
-      expect(order.line_items.first.variant).to eq(variant)
-      expect(order.line_items.first.quantity).to eq(5)
-
-      expect(json_response['number']).to be_present
-      expect(json_response["token"]).not_to be_blank
-      expect(json_response["state"]).to eq("cart")
-      expect(order.user).to eq(current_api_user)
-      expect(order.email).to eq(current_api_user.email)
-      expect(json_response["user_id"]).to eq(current_api_user.id)
+      order.line_items.count.should == 1
+      order.line_items.first.variant.should == variant
+      order.line_items.first.quantity.should == 5
+
+      json_response['number'].should be_present
+      json_response["token"].should_not be_blank
+      json_response["state"].should == "cart"
+      order.user.should == current_api_user
+      order.email.should == current_api_user.email
+      json_response["user_id"].should == current_api_user.id
     end
 
     it "assigns email when creating a new order" do
@@ -215,12 +228,12 @@ module Spree
 
     # Regression test for #3404
     it "can specify additional parameters for a line item" do
-      expect(Order).to receive(:create!).and_return(order = Spree::Order.new)
-      allow(order).to receive(:associate_user!)
-      allow(order).to receive_message_chain(:contents, :add).and_return(line_item = double('LineItem'))
-      expect(line_item).to receive(:update_attributes!).with("special" => true)
+      Order.should_receive(:create!).and_return(order = Spree::Order.new)
+      order.stub(:associate_user!)
+      order.stub_chain(:contents, :add).and_return(line_item = double('LineItem'))
+      line_item.should_receive(:update_attributes!).with("special" => true)
 
-      allow(controller).to receive_messages(permitted_line_item_attributes: [:id, :variant_id, :quantity, :special])
+      controller.stub(permitted_line_item_attributes: [:id, :variant_id, :quantity, :special])
       api_post :create, :order => {
         :line_items => {
           "0" => {
@@ -228,7 +241,7 @@ module Spree
           }
         }
       }
-      expect(response.status).to eq(201)
+      response.status.should == 201
     end
 
     it "cannot arbitrarily set the line items price" do
@@ -246,8 +259,8 @@ module Spree
 
     context "admin user imports order" do
       before do
-        allow(current_api_user).to receive_messages has_spree_role?: true
-        allow(current_api_user).to receive_message_chain :spree_roles, pluck: ["admin"]
+        current_api_user.stub has_spree_role?: true
+        current_api_user.stub_chain :spree_roles, pluck: ["admin"]
       end
 
       it "is able to set any default unpermitted attribute" do
@@ -259,10 +272,10 @@ module Spree
 
     # Regression test for #3404
     it "does not update line item needlessly" do
-      expect(Order).to receive(:create!).and_return(order = Spree::Order.new)
-      allow(order).to receive(:associate_user!)
-      allow(order).to receive_message_chain(:contents, :add).and_return(line_item = double('LineItem'))
-      expect(line_item).not_to receive(:update_attributes)
+      Order.should_receive(:create!).and_return(order = Spree::Order.new)
+      order.stub(:associate_user!)
+      order.stub_chain(:contents, :add).and_return(line_item = double('LineItem'))
+      line_item.should_not_receive(:update_attributes)
       api_post :create, :order => {
         :line_items => {
           "0" => {
@@ -273,10 +286,10 @@ module Spree
     end
 
     it "can create an order without any parameters" do
-      expect { api_post :create }.not_to raise_error
-      expect(response.status).to eq(201)
+      lambda { api_post :create }.should_not raise_error
+      response.status.should == 201
       order = Order.last
-      expect(json_response["state"]).to eq("cart")
+      json_response["state"].should == "cart"
     end
 
     context "working with an order" do
@@ -294,12 +307,13 @@ module Spree
                                  :country_id => Country.first.id, :state_id => State.first.id} }
 
       before do
-        allow_any_instance_of(Order).to receive_messages :user => current_api_user
+        Spree::LineItem.stub(:find_by_id).and_return(Spree::LineItem.new)
+        Order.any_instance.stub :user => current_api_user
         order.next # Switch from cart to address
         order.bill_address = nil
         order.ship_address = nil
         order.save
-        expect(order.state).to eq("address")
+        order.state.should == "address"
       end
 
       def clean_address(address)
@@ -325,9 +339,9 @@ module Spree
           }
         }
 
-        expect(response.status).to eq(200)
-        expect(json_response['line_items'].count).to eq(1)
-        expect(json_response['line_items'].first['quantity']).to eq(10)
+        response.status.should == 200
+        json_response['line_items'].count.should == 1
+        json_response['line_items'].first['quantity'].should == 10
       end
 
       it "adds an extra line item" do
@@ -339,11 +353,11 @@ module Spree
           }
         }
 
-        expect(response.status).to eq(200)
-        expect(json_response['line_items'].count).to eq(2)
-        expect(json_response['line_items'][0]['quantity']).to eq(10)
-        expect(json_response['line_items'][1]['variant_id']).to eq(variant2.id)
-        expect(json_response['line_items'][1]['quantity']).to eq(1)
+        response.status.should == 200
+        json_response['line_items'].count.should == 2
+        json_response['line_items'][0]['quantity'].should == 10
+        json_response['line_items'][1]['variant_id'].should == variant2.id
+        json_response['line_items'][1]['quantity'].should == 1
       end
 
       it "cannot change the price of an existing line item" do
@@ -353,8 +367,8 @@ module Spree
           }
         }
 
-        expect(response.status).to eq(200)
-        expect(json_response['line_items'].count).to eq(1)
+        response.status.should == 200
+        json_response['line_items'].count.should == 1
         expect(json_response['line_items'].first['price'].to_f).to_not eq(0)
         expect(json_response['line_items'].first['price'].to_f).to eq(line_item.variant.price)
       end
@@ -362,7 +376,7 @@ module Spree
       it "can add billing address" do
         api_put :update, :id => order.to_param, :order => { :bill_address_attributes => billing_address }
 
-        expect(order.reload.bill_address).not_to be_nil
+        order.reload.bill_address.should_not be_nil
       end
 
       it "receives error message if trying to add billing address with errors" do
@@ -370,28 +384,28 @@ module Spree
 
         api_put :update, :id => order.to_param, :order => { :bill_address_attributes => billing_address }
 
-        expect(json_response['error']).not_to be_nil
-        expect(json_response['errors']).not_to be_nil
-        expect(json_response['errors']['bill_address.firstname'].first).to eq "can't be blank"
+        json_response['error'].should_not be_nil
+        json_response['errors'].should_not be_nil
+        json_response['errors']['bill_address.firstname'].first.should eq "can't be blank"
       end
 
       it "can add shipping address" do
-        expect(order.ship_address).to be_nil
+        order.ship_address.should be_nil
 
         api_put :update, :id => order.to_param, :order => { :ship_address_attributes => shipping_address }
 
-        expect(order.reload.ship_address).not_to be_nil
+        order.reload.ship_address.should_not be_nil
       end
 
       it "receives error message if trying to add shipping address with errors" do
-        expect(order.ship_address).to be_nil
+        order.ship_address.should be_nil
         shipping_address[:firstname] = ""
 
         api_put :update, :id => order.to_param, :order => { :ship_address_attributes => shipping_address }
 
-        expect(json_response['error']).not_to be_nil
-        expect(json_response['errors']).not_to be_nil
-        expect(json_response['errors']['ship_address.firstname'].first).to eq "can't be blank"
+        json_response['error'].should_not be_nil
+        json_response['errors'].should_not be_nil
+        json_response['errors']['ship_address.firstname'].first.should eq "can't be blank"
       end
 
       it "cannot set the user_id for the order" do
@@ -399,7 +413,7 @@ module Spree
         original_id = order.user_id
         api_post :update, :id => order.to_param, :order => { user_id: user.id }
         expect(response.status).to eq 200
-        expect(json_response["user_id"]).to eq(original_id)
+        json_response["user_id"].should == original_id
       end
 
       context "order has shipments" do
@@ -419,17 +433,17 @@ module Spree
       context "with a line item" do
         let(:order_with_line_items) do
           order = create(:order_with_line_items)
-          create(:adjustment, order: order, adjustable: order)
+          create(:adjustment, :adjustable => order)
           order
         end
 
         it "can empty an order" do
-          expect(order_with_line_items.adjustments.count).to eq(1)
+          order_with_line_items.adjustments.count.should be == 1
           api_put :empty, :id => order_with_line_items.to_param
-          expect(response.status).to eq(200)
+          response.status.should == 204
           order_with_line_items.reload
-          expect(order_with_line_items.line_items).to be_empty
-          expect(order_with_line_items.adjustments).to be_empty
+          order_with_line_items.line_items.should be_empty
+          order_with_line_items.adjustments.should be_empty
         end
 
         it "can list its line items with images" do
@@ -437,22 +451,22 @@ module Spree
 
           api_get :show, :id => order.to_param
 
-          expect(json_response['line_items'].first['variant']).to have_attributes([:images])
+          json_response['line_items'].first['variant'].should have_attributes([:images])
         end
 
         it "lists variants product id" do
           api_get :show, :id => order.to_param
 
-          expect(json_response['line_items'].first['variant']).to have_attributes([:product_id])
+          json_response['line_items'].first['variant'].should have_attributes([:product_id])
         end
 
         it "includes the tax_total in the response" do
           api_get :show, :id => order.to_param
 
-          expect(json_response['included_tax_total']).to eq('0.0')
-          expect(json_response['additional_tax_total']).to eq('0.0')
-          expect(json_response['display_included_tax_total']).to eq('$0.00')
-          expect(json_response['display_additional_tax_total']).to eq('$0.00')
+          json_response['included_tax_total'].should == '0.0'
+          json_response['additional_tax_total'].should == '0.0'
+          json_response['display_included_tax_total'].should == '$0.00'
+          json_response['display_additional_tax_total'].should == '$0.00'
         end
 
         it "lists line item adjustments" do
@@ -464,8 +478,8 @@ module Spree
           api_get :show, :id => order.to_param
 
           adjustment = json_response['line_items'].first['adjustments'].first
-          expect(adjustment['label']).to eq("10% off!")
-          expect(adjustment['amount']).to eq("5.0")
+          adjustment['label'].should == "10% off!"
+          adjustment['amount'].should == "5.0"
         end
 
         it "lists payments source without gateway info" do
@@ -506,31 +520,33 @@ module Spree
 
           it "returns available shipments for an order" do
             api_get :show, :id => order.to_param
-            expect(response.status).to eq(200)
-            expect(json_response["shipments"]).not_to be_empty
+            response.status.should == 200
+            json_response["shipments"].should_not be_empty
             shipment = json_response["shipments"][0]
             # Test for correct shipping method attributes
             # Regression test for #3206
-            expect(shipment["shipping_methods"]).not_to be_nil
+            shipment["shipping_methods"].should_not be_nil
             json_shipping_method = shipment["shipping_methods"][0]
-            expect(json_shipping_method["id"]).to eq(shipping_method.id)
-            expect(json_shipping_method["name"]).to eq(shipping_method.name)
-            expect(json_shipping_method["zones"]).not_to be_empty
-            expect(json_shipping_method["shipping_categories"]).not_to be_empty
+            json_shipping_method["id"].should == shipping_method.id
+            json_shipping_method["name"].should == shipping_method.name
+            json_shipping_method["code"].should == shipping_method.code
+            json_shipping_method["zones"].should_not be_empty
+            json_shipping_method["shipping_categories"].should_not be_empty
 
             # Test for correct shipping rates attributes
             # Regression test for #3206
-            expect(shipment["shipping_rates"]).not_to be_nil
+            shipment["shipping_rates"].should_not be_nil
             shipping_rate = shipment["shipping_rates"][0]
-            expect(shipping_rate["name"]).to eq(json_shipping_method["name"])
-            expect(shipping_rate["cost"]).to eq("10.0")
-            expect(shipping_rate["selected"]).to be true
-            expect(shipping_rate["display_cost"]).to eq("$10.00")
+            shipping_rate["name"].should == json_shipping_method["name"]
+            shipping_rate["cost"].should == "10.0"
+            shipping_rate["selected"].should be true
+            shipping_rate["display_cost"].should == "$10.00"
+            shipping_rate["shipping_method_code"].should == json_shipping_method["code"]
 
-            expect(shipment["stock_location_name"]).not_to be_blank
+            shipment["stock_location_name"].should_not be_blank
             manifest_item = shipment["manifest"][0]
-            expect(manifest_item["quantity"]).to eq(1)
-            expect(manifest_item["variant_id"]).to eq(order.line_items.first.variant_id)
+            manifest_item["quantity"].should == 1
+            manifest_item["variant_id"].should == order.line_items.first.variant_id
           end
         end
       end
@@ -543,7 +559,7 @@ module Spree
         before { Spree::Order.delete_all }
         it "still returns a root :orders key" do
           api_get :index
-          expect(json_response["orders"]).to eq([])
+          json_response["orders"].should == []
         end
       end
 
@@ -596,20 +612,20 @@ module Spree
 
         it "can view all orders" do
           api_get :index
-          expect(json_response["orders"].first).to have_attributes(attributes)
-          expect(json_response["count"]).to eq(2)
-          expect(json_response["current_page"]).to eq(1)
-          expect(json_response["pages"]).to eq(1)
+          json_response["orders"].first.should have_attributes(attributes)
+          json_response["count"].should == 2
+          json_response["current_page"].should == 1
+          json_response["pages"].should == 1
         end
 
         # Test for #1763
         it "can control the page size through a parameter" do
           api_get :index, :per_page => 1
-          expect(json_response["orders"].count).to eq(1)
-          expect(json_response["orders"].first).to have_attributes(attributes)
-          expect(json_response["count"]).to eq(1)
-          expect(json_response["current_page"]).to eq(1)
-          expect(json_response["pages"]).to eq(2)
+          json_response["orders"].count.should == 1
+          json_response["orders"].first.should have_attributes(attributes)
+          json_response["count"].should == 1
+          json_response["current_page"].should == 1
+          json_response["pages"].should == 2
         end
       end
 
@@ -623,21 +639,21 @@ module Spree
 
         it "can query the results through a parameter" do
           api_get :index, :q => { :email_cont => 'spree' }
-          expect(json_response["orders"].count).to eq(1)
-          expect(json_response["orders"].first).to have_attributes(attributes)
-          expect(json_response["orders"].first["email"]).to eq(expected_result.email)
-          expect(json_response["count"]).to eq(1)
-          expect(json_response["current_page"]).to eq(1)
-          expect(json_response["pages"]).to eq(1)
+          json_response["orders"].count.should == 1
+          json_response["orders"].first.should have_attributes(attributes)
+          json_response["orders"].first["email"].should == expected_result.email
+          json_response["count"].should == 1
+          json_response["current_page"].should == 1
+          json_response["pages"].should == 1
         end
       end
 
       context "creation" do
         it "can create an order without any parameters" do
-          expect { api_post :create }.not_to raise_error
-          expect(response.status).to eq(201)
+          lambda { api_post :create }.should_not raise_error
+          response.status.should == 201
           order = Order.last
-          expect(json_response["state"]).to eq("cart")
+          json_response["state"].should == "cart"
         end
 
         it "can arbitrarily set the line items price" do
@@ -656,7 +672,7 @@ module Spree
           user = Spree.user_class.create
           api_post :create, :order => { user_id: user.id }
           expect(response.status).to eq 201
-          expect(json_response["user_id"]).to eq(user.id)
+          json_response["user_id"].should == user.id
         end
       end
 
@@ -665,7 +681,7 @@ module Spree
           user = Spree.user_class.create
           api_post :update, :id => order.number, :order => { user_id: user.id }
           expect(response.status).to eq 200
-          expect(json_response["user_id"]).to eq(user.id)
+          json_response["user_id"].should == user.id
         end
       end
 
@@ -681,7 +697,7 @@ module Spree
 
         specify do
           api_put :cancel, :id => order.to_param
-          expect(json_response["state"]).to eq("canceled")
+          json_response["state"].should == "canceled"
         end
       end
     end