spree_admin 5.1.5 → 5.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a44b861bdad4ce0d03b3225344461ced14b8dea71fec7a839beca7d19bac3c9
-  data.tar.gz: 7efaca5c31054109ea94d9f867ba0ce820db0fded92e1cc7ddfa5a52763ba645
+  metadata.gz: ced4e88139c2415b6773c33a5a61745fd66c3785038bd2bedbf393e2123eaed6
+  data.tar.gz: 9e3017a0cb8ded68fe31d44f0031fae27ae11eee6a85e299467434086a449f47
 SHA512:
-  metadata.gz: 5022e147047a7c8e1bdb0484420a4d7f9a461763974b0d1a4b517e676201fdc801bba89a65bb1b244688bccf2d0e404f04e1cbef517a0366c10b7dde5d417561
-  data.tar.gz: 8291066c622ef1d32385470823dd9b343e58cda7534e3547d3c26ad32c815d922a21225c700f1c23f920a6b2bfd2c7c5a42bda4f5e1c57a0b74eab2467dfdaa0
+  metadata.gz: 031ac7b75b3e3ae2d1772d1a85f09f6ad0de3fedb198199e49799868cb8d037b44a6c0267448eba5dbc920b944680ccff9f685fb3afe8b4307dae2b5ca3849aa
+  data.tar.gz: 2836282801798b9f0a493002735342e31f387af928158566bf8c7773776ebf36de0a579bb5898ce86873fa257752b7dc9df0043991fead981ac7a3bee142b0e5

data/app/controllers/spree/admin/line_items_controller.rb

@@ -6,7 +6,7 @@ module Spree
       layout 'turbo_rails/frame'
 
       def create
-        @variant = Spree::Variant.accessible_by(current_ability, :manage).find(params[:line_item][:variant_id])
+        @variant = variant_scope.find(params.dig(:line_item, :variant_id))
 
         @order.transaction do
           line_item_result = create_service.call(order: @order, line_item_attributes: permitted_resource_params)
@@ -120,6 +120,10 @@ module Spree
       def permitted_resource_params
         params.require(:line_item).permit(permitted_line_item_attributes)
       end
+
+      def variant_scope
+        Spree::Variant.accessible_by(current_ability, :manage)
+      end
     end
   end
 end

data/app/controllers/spree/admin/products_controller.rb

@@ -173,7 +173,7 @@ module Spree
           joins(option_type: :product_option_types).
           includes(option_type: :option_values).
           merge(@product.product_option_types).
-          reorder("#{Spree::ProductOptionType.table_name}.position").
+          reorder("#{Spree::ProductOptionType.table_name}.position", "#{Spree::Variant.table_name}.position").
           uniq.group_by(&:option_type).each_with_index do |option, index|
             option_type, option_values = option
 

data/app/controllers/spree/admin/resource_controller.rb

@@ -145,7 +145,7 @@ class Spree::Admin::ResourceController < Spree::Admin::BaseController
       # call authorize! a third time (called twice already in Admin::BaseController)
       # this time we pass the actual instance so fine-grained abilities can control
       # access to individual records, not just entire models.
-      authorize! action, @object
+      authorize! action, @object if @object.present?
 
       instance_variable_set("@#{resource.object_name}", @object)
     else

data/app/controllers/spree/admin/taxons_controller.rb

@@ -52,6 +52,10 @@ module Spree
         spree.edit_admin_taxonomy_taxon_path(@taxon.taxonomy_id, @taxon.id)
       end
 
+      def update_turbo_stream_enabled?
+        true
+      end
+
       def destroy_turbo_stream_enabled?
         true && !params[:force_redirect].to_b
       end

data/app/helpers/spree/admin/stores_helper.rb

@@ -4,7 +4,7 @@ module Spree
       include Spree::ImagesHelper
 
       def available_stores
-        @available_stores ||= Spree::Store.accessible_by(current_ability).includes(:logo_attachment, :favicon_image_attachment, :default_custom_domain)
+        @available_stores ||= Spree::Store.accessible_by(current_ability, :manage).includes(:logo_attachment, :favicon_image_attachment, :default_custom_domain)
       end
 
       DEFAULT_ICON_SIZE = 40

data/app/javascript/spree/admin/controllers/variants_form_controller.js

@@ -128,25 +128,29 @@ export default class extends CheckboxSelectAll {
 
       const nestingLevel = internalName.split('/').length
       if (nestingLevel === 1) {
-        const firstOptionKey = Object.keys(this.optionsValue)[0]
-        const newOptionValues = this.optionsValue[firstOptionKey].values.filter((value) => value.text !== internalName)
-        if (newOptionValues.length === 0) {
-          const newOptionsValue = this.optionsValue
-          delete newOptionsValue[firstOptionKey]
-          this.optionsValue = newOptionsValue
-          this.optionsContainerTarget.querySelector(`#option-${firstOptionKey}`).remove()
-        } else {
-          this.optionsValue = {
-            ...this.optionsValue,
-            [firstOptionKey]: {
-              ...this.optionsValue[firstOptionKey],
-              values: newOptionValues
+        const sortedOptions = Object.entries(this.optionsValue).sort((a, b) => a[1].position - b[1].position)
+        const firstOptionKey = sortedOptions[0]?.[0]
+
+        if (firstOptionKey !== undefined) {
+          const newOptionValues = this.optionsValue[firstOptionKey].values.filter((value) => value.text !== internalName)
+          if (newOptionValues.length === 0) {
+            const newOptionsValue = this.optionsValue
+            delete newOptionsValue[firstOptionKey]
+            this.optionsValue = newOptionsValue
+            this.removeOption(firstOptionKey)
+          } else {
+            this.optionsValue = {
+              ...this.optionsValue,
+              [firstOptionKey]: {
+                ...this.optionsValue[firstOptionKey],
+                values: newOptionValues
+              }
             }
-          }
 
-          this.optionsContainerTarget.querySelector(`#option-${firstOptionKey} [data-name="${internalName}"]`).remove()
+            this.optionsContainerTarget.querySelector(`#option-${firstOptionKey} [data-name="${internalName}"]`).remove()
+          }
+          checkbox.checked = false
         }
-        checkbox.checked = false
       }
 
       delete newStockValue[internalName]
@@ -463,25 +467,42 @@ export default class extends CheckboxSelectAll {
       this.variantsTableTarget.classList.remove('d-none')
 
       const nestingLevel = Math.min(keys.length, 2)
-      let idx = 0
+
+      // This is the index for the product variant attributes
+      // We only want to count nested options if we have more than one option type
+      let idx
+      if (nestingLevel > 1) {
+        idx = this.variantsContainerTarget.querySelectorAll('.nested').length
+      } else {
+        idx = this.variantsContainerTarget.querySelectorAll('[data-variants-form-target="variant"]').length
+      }
 
       for (let i = 0; i < nestingLevel; i++) {
         this.variantsValue.forEach((variant) => {
           const { name, internalName } = this.calculateVariantName(variant, keys, i)
           if (currentVariants.has(internalName) || this.ignoredVariants.has(internalName)) {
-            idx++
             return
           }
           currentVariants.add(internalName)
 
           const existingVariant = this.variantsContainerTarget.querySelector(`[data-variant-name="${internalName}"]`)
           if (existingVariant) {
-            if (i === 0 && nestingLevel > 1) {
-              existingVariant.querySelectorAll("input[type='hidden']").forEach((input) => input.remove())
-
-              this.prepareParentVariant(existingVariant, internalName)
+            if (i === 0) {
+              if (nestingLevel > 1) {
+                existingVariant.querySelectorAll("input[type='hidden']").forEach((input) => input.remove())
+
+                this.prepareParentVariant(existingVariant, internalName)
+              } else if (nestingLevel === 1) {
+                // We need to generate hidden inputs when we only have a single option left
+                // And there are no inputs already
+                if (existingVariant.querySelectorAll("input[type='hidden']").length === 0) {
+                  const inputs = this.createInputsForVariant(keys, variant, idx)
+                  inputs.forEach((input) => existingVariant.appendChild(input))
+                  idx++
+                }
+              }
             }
-            idx++
+
             return
           }
 
@@ -537,10 +558,10 @@ export default class extends CheckboxSelectAll {
             }
 
             this.preparePriceInputs(variantTarget, internalName, idx)
-
             this.prepareStockInputs(variantTarget, internalName, idx)
+
+            idx++
           }
-          idx++
 
           variantNameContainer.textContent = name
           if (previousVariant) {
@@ -570,7 +591,9 @@ export default class extends CheckboxSelectAll {
   }
 
   refreshParentInputs() {
-    const firstOption = Object.values(this.optionsValue)[0]
+    const sortedOptions = Object.entries(this.optionsValue).sort((a, b) => a[1].position - b[1].position)
+    const firstOption = sortedOptions[0]?.[1]
+
     if (firstOption) {
       firstOption.values.forEach((option) => {
         this.currenciesValue.forEach((currency) => {
@@ -899,12 +922,25 @@ export default class extends CheckboxSelectAll {
     let { optionId } = event.params
     optionId = String(optionId)
 
-    const option = this.optionsContainerTarget.querySelector(`#option-${optionId}`)
-    option.remove()
-    this.optionsValue = { ...this.optionsValue, [optionId]: null }
+    this.removeOption(optionId)
+
+    const newOptionsValue = {}
+    Object.entries(this.optionsValue).filter((option) => option[0] !== optionId).forEach((option) => {
+      newOptionsValue[option[0]] = option[1]
+    })
+
+    this.optionsValue = newOptionsValue
     this.refreshParentInputs()
   }
 
+  removeOption(optionId) {
+    const option = this.optionsContainerTarget.querySelector(`#option-${optionId}`)
+    if (option) option.remove()
+
+    const optionTypeInput = this.optionsContainerTarget.querySelector(`#product_option_type_ids_${optionId}`)
+    if (optionTypeInput) optionTypeInput.remove()
+  }
+
   optionFormTemplate(optionName, optionValues, id, availableOptions) {
     const template = this.optionFormTemplateTarget.content.cloneNode(true)
 
@@ -1045,14 +1081,24 @@ export default class extends CheckboxSelectAll {
 
   priceForVariant(variantName, currency) {
     const existingPrice = this.pricesValue[variantName]?.[currency.toLowerCase()]
+
     if (existingPrice) {
       return {
         ...existingPrice,
         amount: existingPrice.amount ? parseFloat(existingPrice.amount) : existingPrice.amount
       }
-    }
+    } else {
+      const parentName = variantName.split('/')[0]
+      const parentPrices = Object.entries(this.pricesValue)
+        .filter(([internalName, prices]) => internalName.startsWith(parentName) && prices[currency.toLowerCase()] !== undefined)
+        .map(([_key, prices]) => parseFloat(prices[currency.toLowerCase()].amount))
+        .sort((priceAmountA, priceAmountB) => priceAmountA - priceAmountB)
 
-    return { amount: null, id: null }
+      return {
+        amount: parentPrices[0] ?? null,
+        id: null
+      }
+    }
   }
 
   updatePriceForVariant(variantName, newPrice, currency) {

data/app/views/spree/admin/orders/_header.html.erb

@@ -1,6 +1,7 @@
 <% content_for :page_title do %>
   <% if controller_name == 'orders' %>
-    <%= page_header_back_button spree.admin_orders_path, @order %>
+    <% back_url = @order.present? && !@order.completed? ? spree.admin_checkouts_path : spree.admin_orders_path %>
+    <%= page_header_back_button back_url, @order %>
   <% else %>
     <%= page_header_back_button spree.edit_admin_order_path(@order) %>
   <% end %>

data/app/views/spree/admin/page_builder/_pages_dropdown.html.erb

@@ -8,7 +8,7 @@
   </button>
   <div class="dropdown-menu" style="min-width: 300px">
     <% @theme.pages.standard.order(name: :asc).find_all(&:customizable?).each do |page| %>
-      <%= active_link_to spree.edit_admin_theme_path(@theme, theme_preview_id: @theme_preview.id, page_id: page.id), class: 'dropdown-item', active: @page == page do %>
+      <%= active_link_to spree.edit_admin_theme_path(@theme, theme_preview_id: @theme_preview.id, page_id: page.id), class: 'dropdown-item', active: @page == page, data: { turbo_prefetch: false } do %>
         <%= icon page.icon_name, class: 'mr-2' %>
         <%= page.display_name %>
       <% end %>

data/app/views/spree/admin/page_links/_list.html.erb

@@ -31,6 +31,6 @@
       <% add_url = spree.admin_page_section_block_links_path(parent.section, parent) %>
     <% end %>
 
-    <%= link_to_with_icon 'plus', 'Add link', add_url, class: 'btn btn-primary w-100', data: { turbo_method: :post } if add_url && can?(:create, Spree::PageLink.new(parent: parent)) %>
+    <%= link_to_with_icon 'plus', Spree.t(:add_link), add_url, class: 'btn btn-primary w-100', data: { turbo_method: :post } if add_url && can?(:create, Spree::PageLink.new(parent: parent)) %>
   <% end %>
 </div>

data/app/views/spree/admin/products/form/_variants.html.erb

@@ -27,7 +27,6 @@
           <div data-variants-form-target="optionsContainer" class="options-creator__options_container">
             <% @product.product_option_types.includes(:option_type).reorder('spree_product_option_types.position').each do |product_option_type| %>
               <% option_type = product_option_type.option_type %>
-              <%= hidden_field_tag "product[option_type_ids][]", option_type.id %>
               <div class="options-creator__option" data-variants-form-target="option" id="option-<%= option_type.id %>">
                 <% if can?(:manage_option_types, @product) %>
                   <button class="draggable" type="button">
@@ -161,7 +160,7 @@
             </div>
           </div>
           <%= render 'spree/admin/products/form/variants/variant_template', default_stock_location: default_stock_location_for_product(@product) %>
-          <div class="variants-table__body" data-variants-form-target="variantsContainer">
+          <div class="variants-table__body" data-variants-form-target="variantsContainer" data-test-id="product-variants-table">
           </div>
           <div class="variants-table__footer">
             <%= Spree.t('admin.variants_form.total_inventory_html', stock_location: current_store.default_stock_location.name, count: raw("<span data-variants-form-target='stockItemsCount'>#{@product.total_on_hand}</span>") )%>

data/app/views/spree/admin/shared/_head.html.erb

@@ -37,6 +37,8 @@
 <%= tinymce_assets %>
 <link rel="stylesheet" type="text/css" href="https://unpkg.com/trix@2.1.12/dist/trix.css">
 
+<script async src="https://ga.jspm.io/npm:es-module-shims@1.8.2/dist/es-module-shims.js" data-turbo-track="reload"></script>
+
 <%= javascript_importmap_tags 'application-spree-admin', importmap: Rails.application.config.spree_admin.importmap %>
 
 <%= yield :head %>

data/app/views/spree/admin/shared/sidebar/_store_nav.html.erb

@@ -66,13 +66,15 @@
   </ul>
 <% else %>
   <ul class="nav flex-column">
-    <% unless current_store.setup_completed? %>
-      <%= nav_item(nil, spree.admin_getting_started_path, icon: 'map') do %>
-        <%= icon 'map' %>
-        <%= Spree.t('admin.getting_started') %>
-        <span class="badge ml-auto badge-info">
-          <%= current_store.setup_tasks_done %><span class="opacity-50">/<%= current_store.setup_tasks_total %></span>
-        </span>
+    <% if can?(:manage, current_store) %>
+      <% unless current_store.setup_completed? %>
+        <%= nav_item(nil, spree.admin_getting_started_path, icon: 'map') do %>
+          <%= icon 'map' %>
+          <%= Spree.t('admin.getting_started') %>
+          <span class="badge ml-auto badge-info">
+            <%= current_store.setup_tasks_done %><span class="opacity-50">/<%= current_store.setup_tasks_total %></span>
+          </span>
+        <% end %>
       <% end %>
     <% end %>
 

data/app/views/spree/admin/taxons/_form.html.erb

@@ -80,7 +80,7 @@
         <div class="card-body border-bottom">
           <div class="d-flex align-items-center">
             <%= f.label :sort_order, class: 'text-nowrap mr-2 mb-0' %>
-            <%= f.select :sort_order, taxon_sort_options_for_select, {}, { class: 'custom-select custom-select-sm w-auto',  data: { action: 'change->auto-submit#submit' } } %>
+            <%= f.select :sort_order, taxon_sort_options_for_select, {}, { class: 'custom-select custom-select-sm w-auto',  data: { action: 'change->auto-submit#submit' } } %>n sort order dropdown in admin (#13030))
           </div>
         </div>
 

data/app/views/spree/admin/taxons/update.turbo_stream.erb

@@ -0,0 +1,7 @@
+<%= turbo_render_alerts %>
+
+<%= turbo_stream.replace :classifications do %>
+  <%= turbo_frame_tag :classifications, src: spree.admin_taxon_classifications_path(@taxon.id) do %>
+    <%= render 'spree/admin/shared/spinner' %>
+  <% end %>
+<% end %>

data/config/importmap.rb

@@ -23,7 +23,6 @@ pin '@stimulus-components/rails-nested-form', to: '@stimulus-components--rails-n
 pin 'stimulus-notification', preload: ['application-spree-admin'] # @2.2.0
 pin 'stimulus-password-visibility', preload: ['application-spree-admin'] # @2.1.1
 pin 'stimulus-sortable', preload: ['application-spree-admin'] # @4.1.1
-pin 'stimulus-textarea-autogrow', preload: ['application-spree-admin'] # @4.1.0
 pin 'hotkeys-js', preload: ['application-spree-admin'] # @3.13.9
 pin 'stimulus-use', preload: ['application-spree-admin'] # @0.51.3
 pin 'stimulus-checkbox-select-all', preload: ['application-spree-admin'] # @5.3.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spree_admin
 version: !ruby/object:Gem::Version
-  version: 5.1.5
+  version: 5.1.6
 platform: ruby
 authors:
 - Vendo Connect Inc.
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-06 00:00:00.000000000 Z
+date: 2025-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree_core
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.5
+        version: 5.1.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.5
+        version: 5.1.6
 - !ruby/object:Gem::Dependency
   name: spree_api
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.5
+        version: 5.1.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.1.5
+        version: 5.1.6
 - !ruby/object:Gem::Dependency
   name: active_link_to
   requirement: !ruby/object:Gem::Requirement
@@ -1029,6 +1029,7 @@ files:
 - app/views/spree/admin/taxons/rule_forms/_available_on.html.erb
 - app/views/spree/admin/taxons/rule_forms/_sale.html.erb
 - app/views/spree/admin/taxons/rule_forms/_tag.html.erb
+- app/views/spree/admin/taxons/update.turbo_stream.erb
 - app/views/spree/admin/themes/_theme.html.erb
 - app/views/spree/admin/themes/_theme_preview_image.html.erb
 - app/views/spree/admin/themes/edit.html.erb
@@ -1132,7 +1133,6 @@ files:
 - vendor/javascript/stimulus-password-visibility.js
 - vendor/javascript/stimulus-reveal-controller.js
 - vendor/javascript/stimulus-sortable.js
-- vendor/javascript/stimulus-textarea-autogrow.js
 - vendor/javascript/stimulus-use.js
 - vendor/javascript/tom-select--dist--esm--tom-select.complete.js.js
 - vendor/javascript/trix@2.1.12.js
@@ -1141,9 +1141,9 @@ licenses:
 - AGPL-3.0-or-later
 metadata:
   bug_tracker_uri: https://github.com/spree/spree/issues
-  changelog_uri: https://github.com/spree/spree/releases/tag/v5.1.5
+  changelog_uri: https://github.com/spree/spree/releases/tag/v5.1.6
   documentation_uri: https://docs.spreecommerce.org/
-  source_code_uri: https://github.com/spree/spree/tree/v5.1.5
+  source_code_uri: https://github.com/spree/spree/tree/v5.1.6
 post_install_message:
 rdoc_options: []
 require_paths:

data/vendor/javascript/stimulus-textarea-autogrow.js

@@ -1,4 +0,0 @@
-// stimulus-textarea-autogrow@4.1.0 downloaded from https://ga.jspm.io/npm:stimulus-textarea-autogrow@4.1.0/dist/stimulus-textarea-autogrow.mjs
-
-import{Controller as e}from"@hotwired/stimulus";function r(e,t){let i;return(...s)=>{const o=this;clearTimeout(i),i=setTimeout((()=>e.apply(o,s)),t)}}class l extends e{initialize(){this.autogrow=this.autogrow.bind(this)}connect(){this.element.style.overflow="hidden";const e=this.resizeDebounceDelayValue;this.onResize=e>0?r(this.autogrow,e):this.autogrow,this.autogrow(),this.element.addEventListener("input",this.autogrow),window.addEventListener("resize",this.onResize)}disconnect(){window.removeEventListener("resize",this.onResize)}autogrow(){this.element.style.height="auto",this.element.style.height=`${this.element.scrollHeight}px`}}l.values={resizeDebounceDelay:{type:Number,default:100}};export{l as default};
-