spree-alpha-card 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6aee0fda699064cead6cf4b404655ba24c44d4a0
-  data.tar.gz: b851ff1e853cb733976894bd86f6b213dce2f5d1
+  metadata.gz: 349006a766b1d844c89a4805dfc579bcf703206e
+  data.tar.gz: 6d4591fcd12425afd13e29edd58d99203d7c3c8e
 SHA512:
-  metadata.gz: d469a6bf940a11ca20590be165f118b389fbc982072696a57b97248dd4ca958ba4a4c70892355d275f80e451356a5e2001806ae1a66bf48c22d405be923af9b3
-  data.tar.gz: 75192a9de0d32d68dce3b5f3bc48b43a63d15e87f9744efb6354871e5d9cc367878a7be718a04234da7332ca721685754d2668293f8e9b8412446ae25ba30585
+  metadata.gz: ff9eeb9d4495ba9355f9133b82cf5360df66bd3405082148b26d4a0f5cd93c0199fd01549a1d9909a00e234f01459bfa53276b5af52a6a04c11effe332712b94
+  data.tar.gz: 93a52368941eaa1a2b768564098fff68cc3111a62f5c600a69ec779c419bf8183e812040c81925ac81dc8f58038a53156e0e59d55304bf4205d56e83d448cc54

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    spree-alpha-card (0.0.2)
+    spree-alpha-card (0.0.3)
       alpha_card (~> 0.2.5)
       spree_core (>= 3.0.0)
 
@@ -189,10 +189,6 @@ GEM
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 3.0)
       netrc (~> 0.7)
-    rspec-activemodel-mocks (1.0.1)
-      activemodel (>= 3.0)
-      activesupport (>= 3.0)
-      rspec-mocks (>= 2.99, < 4.0)
     rspec-core (3.2.3)
       rspec-support (~> 3.2.0)
     rspec-expectations (3.2.1)
@@ -293,7 +289,7 @@ DEPENDENCIES
   factory_girl
   pg
   rake
-  rspec-activemodel-mocks
+  rspec-mocks
   rspec-rails
   sass-rails (~> 4.0.2)
   spree-alpha-card!
@@ -302,4 +298,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   1.10.2
+   1.10.6

data/README.md

@@ -0,0 +1,34 @@
+# spree-alpha-card
+
+An Alpha Card Payment Gateway for [Spree](https://spreecommerce.com/). 
+
+
+## Installation
+
+Add the gem to your `Gemfile`: 
+
+```ruby
+    gem 'spree-alpha-card'
+```
+
+Then run `bundle` & (re-)start your Rails application. 
+
+
+## Configuration
+
+Navigate to your _Spree Administration_ area, then click on _Configurations_, then _Payment Methods_. To add Alpha Card, click on _New Payment Method_, select _Spree::Gateway::AlphaCardGateway_ & give it a display _name_, e.g. "Alpha Card". Click _Create_. 
+
+Now enter your credentials for Alpha Card in the fields _Login_ & _Password_. Click _Update_ & test your new payment method. 
+
+
+## Tests
+
+To run the test suite, you have to have a Rails app with Spree installed. To do so, run the rake task: 
+
+    # only once
+    rake test_app
+
+Run the test suite with: 
+
+    rspec
+

data/Rakefile

@@ -1,3 +1,4 @@
+require 'bundler/gem_tasks'
 require 'spree/testing_support/common_rake'
 
 task :default => [:spec]

data/app/models/spree/gateway/alpha_card_gateway.rb

@@ -2,7 +2,7 @@
 # Alpha Card Payment Gateway
 #
 #
-# TODO include billing and shipping address fields
+# TODO include shipping address fields
 #
 # cvv: not provided by Spree?
 #
@@ -53,6 +53,7 @@ module Spree
       }
       add_money! opts, money, options
       add_credit_card! opts, credit_card
+      add_bill_address! opts
 
       request opts, 'purchase'
     end
@@ -97,12 +98,34 @@ module Spree
       opts.merge!  ccnumber: cc.number, ccexp: exp
     end
 
+    def add_bill_address! opts
+      order_number, _ = opts[:orderid].split('-')
+      order = Spree::Order.find_by number: order_number
+
+      if order
+        address = order.bill_address
+        opts.merge!(
+          firstname: address.firstname,
+          lastname:  address.lastname,
+          address1:  address.address1,
+          address2:  address.address2,
+          city:      address.city,
+          state:     address.state.abbr,
+          zip:       address.zipcode,
+          country:   address.country.iso,
+          phone:     address.phone,
+        )
+      end
+    end
+
     def request opts, originator
       begin
         res = provider.request opts, account
         ActiveMerchant::Billing::Response.new res.success?, "AlphaCardGateway##{originator}: #{res.text}", res.data, response_params(res.data)
       rescue ::AlphaCard::AlphaCardError => e
-        ActiveMerchant::Billing::Response.new false, "AlphaCardGateway##{originator}: #{e.message}", e.response.data, response_params(e.response.data)
+        options = response_params(e.response.data)
+        message = "Alpha Card: #{e.message} #{options[:avs_result].try(:message)}".strip
+        ActiveMerchant::Billing::Response.new false, message, e.response.data, options
       end
     end
 
@@ -110,10 +133,13 @@ module Spree
       options = {
         test: test?,
         authorization: data['authcode'].presence,
-        avs_result: data['avsresponse'].presence,
         cvv_result: data['cvvresponse'].presence,
       }
 
+      if data['avsresponse'].present?
+        options[:avs_result] = ActiveMerchant::Billing::AVSResult.new code: data['avsresponse']
+      end
+
       unless data['response_code'] == '100'
         options[:error_code] = data['response_code']
       end

data/lib/spree/alpha_card/version.rb

@@ -1,6 +1,6 @@
 module Spree
   module AlphaCard
-    VERSION = '0.0.3'
+    VERSION = '0.0.4'
   end
 end
 

data/spec/models/spree/gateway/alpha_card_gateway_spec.rb

@@ -69,6 +69,10 @@ RSpec.describe Spree::Gateway::AlphaCardGateway do
         }
       end
 
+      before :each do
+        allow(Spree::Order).to receive(:find_by!).and_return nil
+      end
+
       it 'purchases successfully' do
         response = VCR.use_cassette("simple purchase") do
           provider.purchase 256_67, cc, opts
@@ -129,7 +133,7 @@ RSpec.describe Spree::Gateway::AlphaCardGateway do
 
     end
 
-    context '#credit' do
+    context '#void' do
 
       it 'fails to void since implementation is missing' do
         response = provider.void

data/spec/spec_helper.rb

@@ -9,7 +9,6 @@ end
 
 require 'rspec/rails'
 require 'ffaker'
-require 'rspec/active_model/mocks'
 require 'vcr'
 require 'webmock'
 

data/spree-alpha-card.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'factory_girl'
   spec.add_development_dependency 'pg'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec-activemodel-mocks'
+  spec.add_development_dependency 'rspec-mocks'
   spec.add_development_dependency 'rspec-rails'
   spec.add_development_dependency 'sass-rails', '~> 4.0.2'
   spec.add_development_dependency 'sqlite3'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spree-alpha-card
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Lars Kluge
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-10 00:00:00.000000000 Z
+date: 2015-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-activemodel-mocks
+  name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -202,6 +202,7 @@ files:
 - ".gitignore"
 - Gemfile
 - Gemfile.lock
+- README.md
 - Rakefile
 - app/models/spree/gateway/alpha_card_gateway.rb
 - lib/spree-alpha-card.rb
@@ -235,7 +236,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Alpha Card Payment Gateway for Spree