spreadsheet 1.1.6 → 1.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 22c554b9c27f9323b7eef974381b3ee34d1b6e56
-  data.tar.gz: d66c64de3f5f9563f9dd2aebfc2dfc03056b16ed
+  metadata.gz: 710a6b1c3595e94076ff8bb8305aa447cd614433
+  data.tar.gz: 65627e4d0d2b4b0ddf8a7d2a35e672bbac16ac8f
 SHA512:
-  metadata.gz: 966be6ab45b1dc2c414589f268337711375bc24c2f446f02701472f59b1bd72452ce86130a54e12f01a319049fef9be4f23dcb9ce7fdf7896b2e725ca8102d79
-  data.tar.gz: 1bcba5210991a0c356b212aa7d96a0413ae920d1780cad142a52e570b2f97fe92ea60640fa6f2e070fd235ccce62ef369e2a087038ae649a424f6e4c9d8c5e5e
+  metadata.gz: a2b050b8a2835b6f1c0570be259cfd512511032aed19e48ef4a5d9d17ad83efaed9d660b394febf815baf995bbf12e999a45912a88d152727a2a4c0687c3471e
+  data.tar.gz: 3b2a18c5496cc5fa6940b144c474de1a760b1394fc82d36fd24a493aa3a991902170a211a6aeb04054c4806325ba61573b558d8f381baf3949fc59c816e2c78a

data/History.md

@@ -1,3 +1,13 @@
+### 1.1.7 / 15.03.2018
+
+commit 34ece5f4e7ab2907c4a8809d96ef2a33b7ccd4b5
+Author: Maarten Brouwers <github@murb.nl>
+Date:   Thu Mar 15 15:10:23 2018 +0100
+
+* shadowing outer local variable - i
+    
+* Running rake resulted in the following warning: `lib/spreadsheet/worksheet.rb:345: warning: shadowing outer local variable - i`; this patch fixes that.
+
 ### 1.1.6 / 12.03.2018
 
 Author: Todd Hambley <thambley@travelleaders.com>

data/lib/spreadsheet.rb

@@ -46,7 +46,7 @@ module Spreadsheet
 
   ##
   # The version of Spreadsheet you are using.
-  VERSION = '1.1.6'
+  VERSION = '1.1.7'
 
   ##
   # Default client Encoding. Change this value if your application uses a

data/lib/spreadsheet/worksheet.rb

@@ -325,19 +325,19 @@ module Spreadsheet
 
       # detect last non-nil non-empty row if given last row is empty or nil
       if row(@dimensions[1] - 1).empty? || row(@dimensions[1] - 1).compact.join('').empty?
-        i = @dimensions[1] - 1
+        row_size = @dimensions[1] - 1
         @dimensions[1] = @dimensions[0]
         # divide and conquer
-        while(i - @dimensions[1] > 1) do
-          if row(i).empty? || row(i).compact.join('').empty?
-            i = @dimensions[1] + (((i - @dimensions[1]) + 1) / 2).to_i
+        while(row_size - @dimensions[1] > 1) do
+          if row(row_size).empty? || row(row_size).compact.join('').empty?
+            row_size = @dimensions[1] + (((row_size - @dimensions[1]) + 1) / 2).to_i
           else
-            _i = ((i - @dimensions[1]) / 2).to_i + 1
-            @dimensions[1] = i
-            i = i + _i
+            _i = ((row_size - @dimensions[1]) / 2).to_i + 1
+            @dimensions[1] = row_size
+            row_size = row_size + _i
           end
         end
-        @dimensions[1] = i + 1
+        @dimensions[1] = row_size + 1
       end
 
       # detect first non-empty non-nil column if first column is empty or nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreadsheet
 version: !ruby/object:Gem::Version
-  version: 1.1.6
+  version: 1.1.7
 platform: ruby
 authors:
 - Hannes F. Wyss, Masaomi Hatakeyama, Zeno R.R. Davatz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-12 00:00:00.000000000 Z
+date: 2018-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-ole