spreadbase 0.1.3 → 0.1.4

data/spec/codecs/open_document_12_spec.rb

@@ -1,25 +1,5 @@
-# encoding: UTF-8
-
-=begin
-Copyright 2012 Saverio Miroddi saverio.pub2 <a-hat!> gmail.com
-
-This file is part of SpreadBase.
-
-SpreadBase is free software: you can redistribute it and/or modify it under the
-terms of the GNU Lesser General Public License as published by the Free Software
-Foundation, either version 3 of the License, or (at your option) any later
-version.
-
-SpreadBase is distributed in the hope that it will be useful, but WITHOUT ANY
-WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
-PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more details.
-
-You should have received a copy of the GNU Lesser General Public License along
-with SpreadBase.  If not, see <http://www.gnu.org/licenses/>.
-=end
-
-require File.expand_path( '../../../lib/spreadbase', __FILE__ )
-require File.expand_path( '../../spec_helpers',      __FILE__ )
+require_relative '../../lib/spreadbase'
+require_relative '../spec_helpers'
 
 require 'date'
 require 'bigdecimal'
@@ -33,13 +13,13 @@ describe SpreadBase::Codecs::OpenDocument12 do
   before :each do
     table_1 = SpreadBase::Table.new(
       'abc', [
-        [ 1,      1.1,        T_BIGDECIMAL ],
-        [ T_DATE, T_DATETIME, T_TIME       ],
-        [ nil,    'a',        nil          ]
+        [1,      1.1,        T_BIGDECIMAL],
+        [T_DATE, T_DATETIME, T_TIME],
+        [nil,    'a',        nil]
       ]
     )
 
-    table_2 = SpreadBase::Table.new( 'cde' )
+    table_2 = SpreadBase::Table.new('cde')
 
     @sample_document = SpreadBase::Document.new
 
@@ -49,89 +29,87 @@ describe SpreadBase::Codecs::OpenDocument12 do
   # :encode/:decode
   #
   it "should encode and decode the sample document" do
-    document_archive = SpreadBase::Codecs::OpenDocument12.new.encode_to_archive( @sample_document )
+    document_archive = SpreadBase::Codecs::OpenDocument12.new.encode_to_archive(@sample_document)
 
-    document = SpreadBase::Codecs::OpenDocument12.new.decode_archive( document_archive, :floats_as_bigdecimal => true )
+    document = SpreadBase::Codecs::OpenDocument12.new.decode_archive(document_archive, floats_as_bigdecimal: true)
 
-    assert_size( document.tables, 2 ) do | table_1, table_2 |
+    assert_size(document.tables, 2) do | table_1, table_2 |
 
-      table_1.name.should == 'abc'
+      expect(table_1.name).to eq('abc')
 
-      assert_size( table_1.data, 3 ) do | row_1, row_2, row_3 |
+      assert_size(table_1.data, 3) do | row_1, row_2, row_3 |
 
-        assert_size( row_1, 3 ) do | value_1, value_2, value_3 |
-          value_1.should == 1
-          value_1.should be_a( Fixnum )
-          value_2.should == 1.1
-          value_2.should be_a( BigDecimal )
-          value_3.should == T_BIGDECIMAL
-          value_3.should be_a( BigDecimal )
+        assert_size(row_1, 3) do | value_1, value_2, value_3 |
+          expect(value_1).to eq(1)
+          expect(value_1).to be_a(Integer)
+          expect(value_2).to eq(1.1)
+          expect(value_2).to be_a(BigDecimal)
+          expect(value_3).to eq(T_BIGDECIMAL)
+          expect(value_3).to be_a(BigDecimal)
         end
 
-        assert_size( row_2, 3 ) do | value_1, value_2, value_3 |
-          value_1.should == T_DATE
-          value_2.should == T_DATETIME
-          value_3.should == T_DATETIME
+        assert_size(row_2, 3) do | value_1, value_2, value_3 |
+          expect(value_1).to eq(T_DATE)
+          expect(value_2).to eq(T_DATETIME)
+          expect(value_3).to eq(T_DATETIME)
         end
 
-        assert_size( row_3, 3 ) do | value_1, value_2, value_3 |
-          value_1.should == nil
-          value_2.should == 'a'
-          value_3.should == nil
+        assert_size(row_3, 3) do | value_1, value_2, value_3 |
+          expect(value_1).to eq(nil)
+          expect(value_2).to eq('a')
+          expect(value_3).to eq(nil)
         end
 
       end
 
-      table_2.name.should == 'cde'
+      expect(table_2.name).to eq('cde')
 
-      assert_size( table_2.data, 0 )
+      assert_size(table_2.data, 0)
     end
   end
 
   # Not worth testing in detail; just ensure that the pref
   #
   it "should encode the document with makeup (:prettify) - SMOKE" do
-    formatter = stub_initializer( REXML::Formatters::Pretty )
+    formatter = stub_initializer(REXML::Formatters::Pretty)
 
-    formatter.should_receive( :write )
+    expect(formatter).to receive(:write)
 
-    SpreadBase::Codecs::OpenDocument12.new.encode_to_archive( @sample_document, :prettify => true )
+    SpreadBase::Codecs::OpenDocument12.new.encode_to_archive(@sample_document, prettify: true)
   end
 
   # Those methods are actually "utility" (read: testing) methods.
   #
   it "should encode/decode the content.xml - SMOKE" do
-    content_xml = SpreadBase::Codecs::OpenDocument12.new.encode_to_content_xml( @sample_document )
+    content_xml = SpreadBase::Codecs::OpenDocument12.new.encode_to_content_xml(@sample_document)
 
-    document = SpreadBase::Codecs::OpenDocument12.new.decode_content_xml( content_xml )
+    document = SpreadBase::Codecs::OpenDocument12.new.decode_content_xml(content_xml)
 
-    assert_size( document.tables, 2 )
+    assert_size(document.tables, 2)
   end
 
   # If values are not converted to UTF-8, some encodings cause an error to be
   # raised when assigning a value to a cell.
   #
-  # 1.8 tests can't be done, since the official platform is 1.9
-  #
   it "should convert to utf-8 before saving" do
-    string = "à".encode( 'UTF-16' )
+    string = "à".encode('utf-16')
 
-    @sample_document.tables[ 0 ][ 0,  0 ] = string
+    @sample_document.tables[0][0,  0] = string
 
     # Doesn't encode correctly if the value is not converted
     #
-    SpreadBase::Codecs::OpenDocument12.new.encode_to_content_xml( @sample_document )
+    SpreadBase::Codecs::OpenDocument12.new.encode_to_content_xml(@sample_document)
   end
 
   it "should decode as BigDecimal" do
-    content_xml = SpreadBase::Codecs::OpenDocument12.new.encode_to_content_xml( @sample_document )
+    content_xml = SpreadBase::Codecs::OpenDocument12.new.encode_to_content_xml(@sample_document)
 
-    document = SpreadBase::Codecs::OpenDocument12.new.decode_content_xml( content_xml, :floats_as_bigdecimal => true )
+    document = SpreadBase::Codecs::OpenDocument12.new.decode_content_xml(content_xml, floats_as_bigdecimal: true)
 
-    value = document.tables[ 0 ][ 2, 0 ]
+    value = document.tables[0][2, 0]
 
-    value.should be_a( BigDecimal )
-    value.should == T_BIGDECIMAL
+    expect(value).to be_a(BigDecimal)
+    expect(value).to eq(T_BIGDECIMAL)
   end
 
 end

data/spec/elements/document_spec.rb

@@ -1,25 +1,5 @@
-# encoding: utf-8
-
-=begin
-Copyright 2012 Saverio Miroddi saverio.pub2 <a-hat!> gmail.com
-
-This file is part of SpreadBase.
-
-SpreadBase is free software: you can redistribute it and/or modify it under the
-terms of the GNU Lesser General Public License as published by the Free Software
-Foundation, either version 3 of the License, or (at your option) any later
-version.
-
-SpreadBase is distributed in the hope that it will be useful, but WITHOUT ANY
-WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
-PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more details.
-
-You should have received a copy of the GNU Lesser General Public License along
-with SpreadBase.  If not, see <http://www.gnu.org/licenses/>.
-=end
-
-require File.expand_path( '../../../lib/spreadbase', __FILE__ )
-require File.expand_path( '../../spec_helpers',      __FILE__ )
+require_relative '../../lib/spreadbase'
+require_relative '../spec_helpers'
 
 include SpecHelpers
 
@@ -30,9 +10,9 @@ describe SpreadBase::Document do
     @sample_document.tables = [
       SpreadBase::Table.new(
         'abc', [
-          [ 1,      1.1,        T_BIGDECIMAL ],
-          [ T_DATE, T_DATETIME, T_TIME       ],
-          [ true,   'a',        nil          ]
+          [1,      1.1,        T_BIGDECIMAL],
+          [T_DATE, T_DATETIME, T_TIME],
+          [true,   'a',        nil]
         ]
       )
     ]
@@ -43,61 +23,59 @@ describe SpreadBase::Document do
   it "should initialize out of thin air" do
     document = SpreadBase::Document.new
 
-    document.document_path.should == nil
+    expect(document.document_path).to be(nil)
 
-    document.tables.should be_empty
+    expect(document.tables).to be_empty
   end
 
   # A lazy use of stubs
   #
   it "should initialize from a file" do
-    codec = stub_initializer( SpreadBase::Codecs::OpenDocument12 )
+    codec = stub_initializer(SpreadBase::Codecs::OpenDocument12)
 
-    File.should_receive( :'exists?' ).with( '/pizza/margerita.txt' ).and_return( true )
-    IO.should_receive( :read ).with( '/pizza/margerita.txt' ).and_return( 'abc' )
-    codec.should_receive( :decode_archive ).with( 'abc', {} ).and_return( @sample_document )
+    expect(File).to receive(:'exist?').with('/pizza/margerita.txt').and_return(true)
+    expect(IO).to receive(:read).with('/pizza/margerita.txt').and_return('abc')
+    expect(codec).to receive(:decode_archive).with('abc', {}).and_return(@sample_document)
 
-    document = SpreadBase::Document.new( '/pizza/margerita.txt' )
+    document = SpreadBase::Document.new('/pizza/margerita.txt')
 
-    assert_size( document.tables, 1 ) do | table |
-      table.name.should == 'abc'
-      table.data.size.should == 3
+    assert_size(document.tables, 1) do | table |
+      expect(table.name).to eq('abc')
+      expect(table.data.size).to eq(3)
     end
   end
 
   it "should initialize with a non-existing file" do
-    codec = stub_initializer( SpreadBase::Codecs::OpenDocument12 )
-
-    document = SpreadBase::Document.new( '/pizza/margerita.txt' )
+    document = SpreadBase::Document.new('/pizza/margerita.txt')
 
-    assert_size( document.tables, 0 )
+    assert_size(document.tables, 0)
   end
 
   it "should save to a file" do
-    codec = stub_initializer( SpreadBase::Codecs::OpenDocument12 )
+    codec = stub_initializer(SpreadBase::Codecs::OpenDocument12)
 
     document = SpreadBase::Document.new
-    document.tables << SpreadBase::Table.new( 'Ya-ha!' )
+    document.tables << SpreadBase::Table.new('Ya-ha!')
     document.document_path = '/tmp/abc.ods'
 
-    codec.should_receive( :encode_to_archive ).with( document, :prettify => 'abc' ).and_return( 'sob!' )
-    File.should_receive( :open ).with( '/tmp/abc.ods', 'wb' )
+    expect(codec).to receive(:encode_to_archive).with(document, prettify: 'abc').and_return('sob!')
+    expect(File).to receive(:open).with('/tmp/abc.ods', 'wb')
 
-    document.save( :prettify => 'abc' )
+    document.save(prettify: 'abc')
   end
 
   it "should raise an error when trying to save without a filename" do
     document = SpreadBase::Document.new
-    document.tables << SpreadBase::Table.new( 'Ya-ha!' )
+    document.tables << SpreadBase::Table.new('Ya-ha!')
 
-    lambda { document.save }.should raise_error( RuntimeError, "Document path not specified" )
+    expect { document.save }.to raise_error(RuntimeError, "Document path not specified")
   end
 
   it "should raise an error when trying to save without tables" do
     document = SpreadBase::Document.new
     document.document_path = 'abc.ods'
 
-    lambda { document.save }.should raise_error( RuntimeError, "At least one table must be present" )
+    expect { document.save }.to raise_error(RuntimeError, "At least one table must be present")
   end
 
   it "should return the data as string (:to_s)" do
@@ -105,14 +83,14 @@ describe SpreadBase::Document do
 abc:
 
   +------------+---------------------------+---------------------------+
-  | 1          | 1.1                       | 0.133E1                   |
-  | 2012-04-10 | 2012-04-11T23:33:42+00:00 | 2012-04-11 23:33:42 +0200 |
-  | true       | a                         |                           |
+  | 1          | 1.1                       | 1.33                      |
+  | 2012-04-10 | 2012-04-11 23:33:42 +0000 | 2012-04-11 23:33:42 +0200 |
+  | true       | a                         | NIL                       |
   +------------+---------------------------+---------------------------+
 
 "
 
-    @sample_document.to_s.should == expected_string
+    expect(@sample_document.to_s).to eq(expected_string)
   end
 
   it "should return the data as string, with headers (:to_s)" do
@@ -120,15 +98,15 @@ abc:
 abc:
 
   +------------+---------------------------+---------------------------+
-  | 1          | 1.1                       | 0.133E1                   |
+  | 1          | 1.1                       | 1.33                      |
   +------------+---------------------------+---------------------------+
-  | 2012-04-10 | 2012-04-11T23:33:42+00:00 | 2012-04-11 23:33:42 +0200 |
-  | true       | a                         |                           |
+  | 2012-04-10 | 2012-04-11 23:33:42 +0000 | 2012-04-11 23:33:42 +0200 |
+  | true       | a                         | NIL                       |
   +------------+---------------------------+---------------------------+
 
 "
 
-    @sample_document.to_s( :with_headers => true ).should == expected_string
+    expect(@sample_document.to_s(with_headers: true)).to eq(expected_string)
   end
 
 end