spout 0.8.0.beta9 → 0.8.0.beta10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae215d264230df5dc8b19ac9bf3171aff5ec76bd
-  data.tar.gz: 3db245444043d9402a4b12b9ab11694c400545d0
+  metadata.gz: 85db9e44c8437edc8bf46ba106ec1030ce1adf06
+  data.tar.gz: 453e7af390a7cd5ec6fff0a0ca79bd10cb97e93e
 SHA512:
-  metadata.gz: 6f5de9cb6e08addb835e356a59c08e9686c8841569c45c83473cf3edcc20b43cc47de62b6fc928514d0d275c35efc2a26d4bce4f1619bb7e383336a4ee809baf
-  data.tar.gz: 7d1edd8284fed5cc5674a56b807530294bcb412f796313694e22125d85d03c47a44ae0180df598e223286167e83ae28da805fd6193d450bee69152da42c735d2
+  metadata.gz: 65fb80564f823a0539222ac7080ee782c88dd7859854f2c6f96d0413335a5fe1ffe1cdc04f43491431593728e8928db8a0c9b5b2bce947ef65043576719ec96e
+  data.tar.gz: b657059a6c7536a1e4166782c08100c564a5c79b6cef99afcc4bfe33211222a17ad2ab9ed65ea0fc63c8e9eef85de5a25d77bb7d7f0e4bb2548871824997ff63

data/CHANGELOG.md

@@ -7,6 +7,7 @@
     - `charts`: Array of choices, numeric, or integer variables for charts
 - The `spout pngs` command now renders the histogram form for each variable
 - The `spout coverage` command now lists variables that are defined in the data dictionary and that do not exist in any CSV dataset
+- The `spout coverage` command now lists domains that are defined in the data dictionary and not referenced by any variable
 - Added `spout outliers` command that returns a list of integer or numeric variables that contain major and minor outliers
 - Removed the deprecated `spout hybrid` command
 - **Gem Changes**

data/lib/spout/commands/coverage.rb

@@ -9,7 +9,7 @@ module Spout
       def initialize(standard_version)
         @standard_version = standard_version
 
-        @variable_files = []
+        @variable_files = Dir.glob("variables/**/*.json")
         @valid_ids = []
         @number_of_rows = nil
 
@@ -34,6 +34,10 @@ module Spout
         variable_ids = Dir.glob("variables/**/*.json").collect{ |file| file.gsub(/^(.*)\/|\.json$/, '').downcase }
         @extra_variable_ids = (variable_ids - @subject_loader.all_methods.keys).sort
 
+        @subject_loader.load_variable_domains!
+        domain_ids = Dir.glob("domains/**/*.json").collect{ |file| file.gsub(/^(.*)\/|\.json$/, '').downcase }
+        @extra_domain_ids = (domain_ids - @subject_loader.all_domains).sort
+
         @matching_results.sort!{|a,b| [b[2].number_of_errors, a[0].to_s, a[1].to_s] <=> [a[2].number_of_errors, b[0].to_s, b[1].to_s]}
 
         @coverage_results = []

data/lib/spout/helpers/subject_loader.rb

@@ -5,7 +5,7 @@ module Spout
   module Helpers
     class SubjectLoader
       attr_accessor :subjects
-      attr_reader :all_methods
+      attr_reader :all_methods, :all_domains
 
       def initialize(variable_files, valid_ids, standard_version, number_of_rows, visit)
         @subjects = []
@@ -15,6 +15,7 @@ module Spout
         @number_of_rows = number_of_rows
         @visit = visit
         @all_methods = {}
+        @all_domains = []
       end
 
       def load_subjects_from_csvs!
@@ -51,7 +52,6 @@ module Spout
               end
             end
             # puts "Memory Used: " + (`ps -o rss -p #{$$}`.strip.split.last.to_i / 1024).to_s + " MB" if count % 1000 == 0
-            # break if count >= 1000
             break if @number_of_rows != nil and count >= @number_of_rows
           end
         end
@@ -70,6 +70,17 @@ module Spout
         end
         @subjects
       end
+
+      def load_variable_domains!
+        @variable_files.each do |variable_file|
+          json = JSON.parse(File.read(variable_file)) rescue json = nil
+          next unless json
+          next unless ["choices"].include?(json["type"])
+          domain = json['domain'].to_s.downcase
+          @all_domains << domain
+        end
+        @all_domains = @all_domains.compact.uniq.sort
+      end
     end
   end
 end

data/lib/spout/version.rb

@@ -3,7 +3,7 @@ module Spout
     MAJOR = 0
     MINOR = 8
     TINY = 0
-    BUILD = "beta9" # nil, "pre", "rc", "rc2"
+    BUILD = "beta10" # nil, "pre", "rc", "rc2"
 
     STRING = [MAJOR, MINOR, TINY, BUILD].compact.join('.')
   end

data/lib/spout/views/index.html.erb

@@ -90,6 +90,15 @@ tfoot td {
                 <td></td>
               </tr>
             <% end %>
+            <% if @extra_domain_ids.size > 0 %>
+              <tr>
+                <td class="text-muted">Domains Not Referenced by Any Variable</td>
+                <td></td>
+                <td><code class="default"><%= number_with_delimiter( @extra_domain_ids.size ) %></code></td>
+                <td></td>
+                <td></td>
+              </tr>
+            <% end %>
             <% @coverage_results.each do |csv, total_column_count, mapped_column_count| %>
               <tr>
                 <td><%= csv %></td>
@@ -108,6 +117,29 @@ tfoot td {
           </tbody>
         </table>
 
+        <% if @extra_domain_ids.size > 0 %>
+          <table class="table">
+            <thead>
+              <tr>
+                <th>Error</th>
+                <th>Domain</th>
+                <th>File</th>
+                <th>Solution</th>
+              </tr>
+            </thead>
+            <tbody>
+              <% @extra_domain_ids.each do |domain_id| %>
+                <tr>
+                  <td class="text-muted">Not referenced by any variable</td>
+                  <td><%= domain_id %></td>
+                  <td><code class="default"><%= domain_id %>.json</code></td>
+                  <td class="text-muted">Recommend to remove this domain from data dictionary as no existing variable references the domain.</td>
+                </tr>
+              <% end %>
+            </tbody>
+          </table>
+        <% end %>
+
         <table class="table table-bordered table-hover">
           <thead>
             <tr>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spout
 version: !ruby/object:Gem::Version
-  version: 0.8.0.beta9
+  version: 0.8.0.beta10
 platform: ruby
 authors:
 - Remo Mueller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-30 00:00:00.000000000 Z
+date: 2014-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake