spotlite 0.8.2 → 0.8.3

data/spec/spec_helper.rb

@@ -25,11 +25,11 @@ IMDB_SAMPLES = {
   'http://www.imdb.com/title/tt0002186/'                              => 'tt0002186/index',
   'http://www.imdb.com/title/tt1134629/fullcredits'                   => 'tt1134629/fullcredits',
   'http://www.imdb.com/find?q=conan&s=tt&ttype=ft'                    => 'movie_find_conan',
-  'http://www.imdb.com/find?q=wappadoozle+swambling&s=tt&ttype=ft'    => 'movie_find_no_results',
-  'http://www.imdb.com/find?q=herpinson+derpington&s=nm'              => 'person_find_no_results',
+  'http://www.imdb.com/find?q=wappadoozle%20swambling&s=tt&ttype=ft'  => 'movie_find_no_results',
+  'http://www.imdb.com/find?q=herpinson%20derpington&s=nm'            => 'person_find_no_results',
   'http://www.imdb.com/find?q=conan&s=nm'                             => 'person_find_conan',
-  'http://www.imdb.com/search/title?count=50&title_type=feature&view=simple&start=1&sort=moviemeter,asc' => 'search_title_count_50',
-  'http://www.imdb.com/search/name?count=50&view=simple&start=1&gender=male,female&sort=starmeter,asc' => 'search_name_count_50',
+  'http://www.imdb.com/search/title?count=50&title_type=feature&view=simple&start=1&sort=moviemeter%2Casc' => 'search_title_count_50',
+  'http://www.imdb.com/search/name?count=50&view=simple&start=1&gender=male%2Cfemale&sort=starmeter%2Casc' => 'search_name_count_50',
   'http://www.imdb.com/name/nm0000233/?nmdp=1'                        => 'nm0000233/index',
   'http://www.imdb.com/name/nm0005132/?nmdp=1'                        => 'nm0005132/index',
   'http://www.imdb.com/name/nm1659547/?nmdp=1'                        => 'nm1659547/index',

data/spec/spotlite/find_spec.rb

@@ -11,14 +11,14 @@ describe "Find feature" do
       first.title.should eql("Conan the Barbarian")
       first.year.should eql(2011)
     end
-    
+
     it "should return emtpy array with no results" do
       results = Spotlite::Movie.find("wappadoozle swambling")
       results.should be_an(Array)
       results.should be_empty
     end
   end
-  
+
   context "Person" do
     it "should find people" do
       results = Spotlite::Person.find("conan")
@@ -28,7 +28,7 @@ describe "Find feature" do
       first.imdb_id.should eql("0000192")
       first.name.should eql("Alyssa Milano")
     end
-    
+
     it "should return emtpy array with no results" do
       results = Spotlite::Person.find("herpinson derpington")
       results.should be_an(Array)

data/spec/spotlite/movie_spec.rb

@@ -1,133 +1,129 @@
 require 'spec_helper'
 
 describe "Spotlite::Movie" do
-  
+
   describe "valid movie" do
-    
+
     before(:each) do
       # The Matrix (1999)
       @movie = Spotlite::Movie.new("0133093")
     end
-    
+
     it "should return title" do
       @movie.title.should eql("The Matrix")
     end
-    
+
     describe "original title" do
       it "should return original title if it exists" do
         # City of God (2002)
         @movie = Spotlite::Movie.new("0317248")
         @movie.original_title.should eql("Cidade de Deus")
       end
-      
+
       it "should return nil if it doesn't exist" do
         @movie.original_title.should be_nil
       end
     end
-    
+
     it "should return alternative titles" do
       @movie.alternative_titles.should be_an(Array)
-      @movie.alternative_titles.size.should eql(35)
-      @movie.alternative_titles.should include({:title => "The Matrix", :comment => "(original title)"})
+      @movie.alternative_titles.size.should be_within(10).of(40)
       @movie.alternative_titles.should include({:title => "Maatriks", :comment => "Estonia"})
       @movie.alternative_titles.should include({:title => "Матрица", :comment => "Russia"})
     end
-    
+
     it "should return original release year" do
       @movie.year.should eql(1999)
     end
-    
+
     it "should return IMDb rating" do
       @movie.rating.should eql(8.7)
     end
-    
+
     it "should return number of votes" do
       @movie.votes.should be_within(150000).of(900000)
     end
-    
+
     it "should return Metascore rating" do
       @movie.metascore.should eql(73)
     end
-    
+
     it "should return description" do
       # A Story about Love (1995)
       @movie = Spotlite::Movie.new("0112873")
       @movie.description.should eql("Two young people stand on a street corner in a run-down part of New York, kissing. Despite the lawlessness of the district they are left unmolested. A short distance away walk Maria and ...")
     end
-    
+
     it "should return storyline" do
       @movie.storyline.should eql("Thomas A. Anderson is a man living two lives. By day he is an average computer programmer and by night a hacker known as Neo. Neo has always questioned his reality, but the truth is far beyond his imagination. Neo finds himself targeted by the police when he is contacted by Morpheus, a legendary computer hacker branded a terrorist by the government. Morpheus awakens Neo to the real world, a ravaged wasteland where most of humanity have been captured by a race of machines that live off of the humans' body heat and electrochemical energy and who imprison their minds within an artificial reality known as the Matrix. As a rebel against the machines, Neo must return to the Matrix and confront the agents: super-powerful computer programs devoted to snuffing out Neo and the entire human rebellion.")
     end
-    
+
     describe "content rating" do
       it "should return MPAA content rating if it's given" do
         @movie.content_rating.should eql("R")
       end
-    
+
       it "should return nil if it's missing" do
         # Rear Window (1954)
         @movie = Spotlite::Movie.new("0047396")
         @movie.content_rating.should be_nil
       end
     end
-    
+
     it "should return genres" do
       @movie.genres.should be_an(Array)
       @movie.genres.size.should eql(2)
       @movie.genres.should include("Action")
       @movie.genres.should include("Sci-Fi")
     end
-    
+
     it "should return countries" do
       @movie.countries.should be_an(Array)
       @movie.countries.size.should eql(2)
       @movie.countries.should include({:code => "us", :name => "USA"})
       @movie.countries.should include({:code => "au", :name => "Australia"})
     end
-    
+
     it "should return languages" do
       @movie.languages.should be_an(Array)
       @movie.languages.size.should eql(1)
       @movie.languages.should include({:code => "en", :name => "English"})
     end
-    
+
     it "should return runtime in minutes" do
       @movie.runtime.should eql(136)
     end
-    
+
     describe "poster URL" do
       it "should return old style poster URL" do
         @movie.poster_url.should eql("http://ia.media-imdb.com/images/M/MV5BMTkxNDYxOTA4M15BMl5BanBnXkFtZTgwNTk0NzQxMTE@.jpg")
       end
-      
+
       it "should return new style poster URL" do
         # American Beauty (1999)
         @movie = Spotlite::Movie.new("0169547")
         @movie.poster_url.should eql("http://ia.media-imdb.com/images/M/MV5BMjM4NTI5NzYyNV5BMl5BanBnXkFtZTgwNTkxNTYxMTE@.jpg")
       end
-      
+
       it "should return nil if poster doesn't exist" do
         # The Flying Circus (1912)
         @movie = Spotlite::Movie.new("0002186")
         @movie.poster_url.should be_nil
       end
     end
-    
+
     it "should return an array of recommended movies as an array of initialized objects of Movie class" do
       @movie.recommended_movies.should be_an(Array)
       @movie.recommended_movies.size.should eql(12)
       @movie.recommended_movies.each {|movie| movie.should be_a(Spotlite::Movie)}
-      @movie.recommended_movies.first.imdb_id.should eql("0234215")
-      @movie.recommended_movies.first.title.should eql("The Matrix Reloaded")
-      @movie.recommended_movies.first.year.should eql(2003)
     end
-    
+
     it "should return plot keywords" do
       @movie.keywords.should be_an(Array)
       @movie.keywords.size.should be_within(50).of(250)
       @movie.keywords.should include("computer", "artificial reality", "hand to hand combat", "white rabbit", "chosen one")
     end
-    
+
     it "should return trivia" do
       @movie.trivia.should be_an(Array)
       @movie.trivia.size.should be_within(10).of(100)
@@ -135,24 +131,24 @@ describe "Spotlite::Movie" do
       @movie.trivia.should include("Carrie-Anne Moss twisted her ankle while shooting one of her scenes but decided not to tell anyone until after filming, so they wouldn't re-cast her.")
       @movie.trivia.should include("Gary Oldman was considered as Morpheus at one point, as well as Samuel L. Jackson.")
     end
-    
+
     describe "release dates" do
       it "should return release dates" do
         # Rear Window (1954)
         @movie = Spotlite::Movie.new("0047396")
         @movie.release_dates.should be_an(Array)
         @movie.release_dates.size.should be_within(10).of(50)
-        @movie.release_dates.should include({:code => "us", :region => "USA", :date => Date.new(1954,8,1), :comment => "New York City, New York, premiere"})
+        @movie.release_dates.should include({:code => "us", :region => "USA", :date => Date.new(1954,8,4), :comment => "New York City, New York, premiere"})
         @movie.release_dates.should include({:code => "jp", :region => "Japan", :date => Date.new(1955,1,29), :comment => nil})
         @movie.release_dates.should include({:code => "tr", :region => "Turkey", :date => Date.new(1956,4,1), :comment => nil})
         @movie.release_dates.detect{ |r| r[:region] == "France" }.should eql({:code => "fr", :region => "France", :date => Date.new(1955,4,1), :comment => nil})
       end
-    
+
       it "should return original release date" do
         @movie.release_date.should eql(Date.new(1999,3,31))
       end
     end
-    
+
     it "should return critic reviews" do
       @movie.critic_reviews.should be_an(Array)
       @movie.critic_reviews.size.should be_within(5).of(15)
@@ -172,7 +168,7 @@ describe "Spotlite::Movie" do
           :score => 75
         }
       )
-      
+
       @movie.critic_reviews.should include(
         {
           :source => "Los Angeles Times",
@@ -182,18 +178,19 @@ describe "Spotlite::Movie" do
         }
       )
     end
-    
+
     it "should return technical information as a hash of arrays" do
+      # Titanic (1997)
       @movie = Spotlite::Movie.new("0120338")
       hash = @movie.technical
       hash.should be_a(Hash)
       hash.each{|element| element.should be_an(Array)}
       hash.should include("Runtime" => ["3 hr 14 min (194 min)"])
-      hash.should include("Sound Mix" => ["DTS 70 mm (70 mm prints)", "DTS", "Dolby Digital", "SDDS"])
-      hash.should include("Cinematographic Process" => ["Super 35", "Techniscope (underwater scenes)"])
+      hash.should include("Sound Mix" => ["Dolby Digital (Dolby Digital 5.1) (5.1 Surround Sound) (L-R)", "DTS (DTS 5.1) (5.1 Surround Sound) (L-R)", "DTS 70 mm (70 mm prints) (5.1 Surround Sound) (L-R)", "SDDS (8 channels) (L-R)"])
+      hash.should include("Cinematographic Process" => ["Digital Intermediate (4k) (2012 re-release)", "Super 35", "Techniscope (underwater scenes)"])
       hash.should include("Film Length" => ["5,340 m (Sweden)", "5,426 m (10 reels)"])
     end
-    
+
     it "should return an array of still frames URLs" do
       @movie.images.should be_an(Array)
       @movie.images.size.should eql(12)
@@ -202,7 +199,7 @@ describe "Spotlite::Movie" do
         "http://ia.media-imdb.com/images/M/MV5BMTAyMDc1MTU0MDBeQTJeQWpwZ15BbWU2MDI5MzU3Nw@@.jpg"
       )
     end
-    
+
     describe "movie credits" do
       it "should return crew categories" do
         @movie.crew_categories.should be_an(Array)
@@ -210,10 +207,10 @@ describe "Spotlite::Movie" do
         @movie.crew_categories.should include("Directed by", "Writing Credits", "Cinematography by", "Second Unit Director or Assistant Director", "Casting By", "Other crew")
         @movie.crew_categories.should_not include("Cast")
       end
-      
+
       it "should return movie cast" do
         @movie.cast.should be_an(Array)
-        @movie.cast.size.should eql(37)
+        @movie.cast.size.should be_within(10).of(37)
         @movie.cast.each{ |person| person.should be_a(Spotlite::Person) }
         first = @movie.cast.first
         first.name.should eql("Keanu Reeves")
@@ -221,19 +218,19 @@ describe "Spotlite::Movie" do
         first.credits_category.should eql("Cast")
         first.credits_text.should eql("Neo")
       end
-      
+
       it "should return movie crew" do
         @movie.crew.should be_an(Array)
-        @movie.crew.size.should eql(542)
+        @movie.crew.size.should be_within(50).of(550)
         @movie.crew.each{ |person| person.should be_a(Spotlite::Person) }
       end
-      
+
       it "should return full credits" do
         @movie.credits.should be_an(Array)
         @movie.credits.size.should eql(@movie.cast.size + @movie.crew.size)
         @movie.credits.each{ |person| person.should be_a(Spotlite::Person) }
       end
-      
+
       it "should parse crew category" do
         category = @movie.parse_crew("Transportation Department")
         category.should be_an(Array)
@@ -244,7 +241,7 @@ describe "Spotlite::Movie" do
         first.credits_category.should eql("Transportation Department")
         first.credits_text.should eql("action vehicle coordinator")
       end
-      
+
       it "should return starred actors" do
         @movie.stars.should be_an(Array)
         @movie.stars.size.should eql(3)
@@ -254,9 +251,9 @@ describe "Spotlite::Movie" do
         first.imdb_id.should eql("0000206")
       end
     end
-    
+
   end
-  
+
   describe "#find method" do
     it "should return some movies" do
       results = Spotlite::Movie.find("conan")
@@ -267,14 +264,14 @@ describe "Spotlite::Movie" do
       first.title.should eql("Conan the Barbarian")
       first.imdb_id.should eql("0816462")
     end
-    
+
     it "should return no results" do
       results = Spotlite::Movie.find("wappadoozle swambling")
       results.should be_an(Array)
       results.size.should eql(0)
     end
   end
-  
+
   describe "#search method" do
     it "should return some movies" do
       results = Spotlite::Movie.search({count: 50})
@@ -283,5 +280,5 @@ describe "Spotlite::Movie" do
       results.each{ |movie| movie.should be_a(Spotlite::Movie) }
     end
   end
-  
+
 end

data/spec/spotlite/person_spec.rb

@@ -1,73 +1,73 @@
 require 'spec_helper'
 
 describe "Spotlite::Person" do
-  
+
   describe "valid person" do
-    
+
     before(:each) do
       # Heath Ledger
       @person = Spotlite::Person.new("0005132")
     end
-    
+
     it "should return name" do
       @person.name.should eql("Heath Ledger")
     end
-    
+
     it "should return born name if present" do
       @person.birth_name.should eql("Heath Andrew Ledger")
     end
-    
+
     it "should return birth date" do
       @person.birth_date.should be_a(Date)
       @person.birth_date.should eql(Date.new(1979,4,4))
     end
-    
+
     it "should return death date if present" do
       @person.death_date.should be_a(Date)
       @person.death_date.should eql(Date.new(2008,1,22))
     end
-    
+
     describe "photo URL" do
       it "should return old style photo URL" do
         @person.photo_url.should eql("http://ia.media-imdb.com/images/M/MV5BMTI2NTY0NzA4MF5BMl5BanBnXkFtZTYwMjE1MDE0.jpg")
       end
-      
+
       it "should return new style photo URL" do
         # Carey Mulligan
         @person = Spotlite::Person.new("1659547")
         @person.photo_url.should eql("http://ia.media-imdb.com/images/M/MV5BMTQ2MTQyMzYzMV5BMl5BanBnXkFtZTcwODY0ODI4Mg@@.jpg")
       end
-      
+
       it "should return nil if photo doesn't exist" do
         # Natalie Tjern
         @person = Spotlite::Person.new("0864666")
         @person.photo_url.should be_nil
       end
     end
-    
+
     describe "filmography" do
       before(:each) do
         # Quentin Tarantino
         @person = Spotlite::Person.new("0000233")
       end
-      
+
       context "with basic jobs (director, actor, writer, producer), flattened to array" do
-        it "should return an array of 76..86 movies" do
+        it "should return an array of 75..85 movies" do
           @person.filmography.should be_an(Array)
-          @person.filmography.size.should be_within(5).of(81)
+          @person.filmography.size.should be_within(5).of(80)
           @person.filmography.each{ |movie| movie.should be_a(Spotlite::Movie) }
           @person.filmography.last.title.should eql("My Best Friend's Birthday")
           @person.filmography.last.imdb_id.should eql("0359715")
         end
       end
-      
+
       context "with basic jobs (director, actor, writer, producer), expanded to a hash of arrays" do
         it "should return a hash of 4 arrays" do
           @person.filmography(false, false).should be_an(Hash)
           @person.filmography(false, false).size.should eql(4)
           @person.filmography(false, false).keys.should eql([:director, :actor, :writer, :producer])
         end
-        
+
         it "should be able to retrieve an array of +Spotlite::Movie+ objects by a hash key" do
           @person.filmography(false, false)[:actor].should be_an(Array)
           @person.filmography(false, false)[:actor].size.should be_within(5).of(29)
@@ -76,24 +76,24 @@ describe "Spotlite::Person" do
           @person.filmography(false, false)[:actor].last.imdb_id.should eql("1959459")
         end
       end
-      
+
       context "with all available jobs, flattened to array" do
-        it "should return an array of 176..196 movies" do
+        it "should return an array of 175..195 movies" do
           @person.filmography(true, true).should be_an(Array)
-          @person.filmography(true, true).size.should be_within(10).of(186)
+          @person.filmography(true, true).size.should be_within(10).of(185)
           @person.filmography(true, true).each{ |movie| movie.should be_a(Spotlite::Movie) }
           @person.filmography(true, true).last.title.should eql("The Typewriter, the Rifle & the Movie Camera")
           @person.filmography(true, true).last.imdb_id.should eql("0118004")
         end
       end
-      
+
       context "with all available jobs, expanded to a hash of arrays" do
         it "should return a hash of 11 arrays" do
           @person.filmography(true, false).should be_an(Hash)
           @person.filmography(true, false).size.should eql(11)
-          @person.filmography(true, false).keys.should eql([:writer, :actor, :director, :producer, :miscellaneous, :soundtrack, :cinematographer, :music_department, :editor, :thanks, :self])
+          @person.filmography(true, false).keys.should eql([:writer, :actor, :producer, :director, :miscellaneous, :soundtrack, :cinematographer, :music_department, :editor, :thanks, :self])
         end
-        
+
         it "should be able to retrieve an array of +Spotlite::Movie+ objects by a hash key" do
           @person.filmography(true, false)[:thanks].should be_an(Array)
           @person.filmography(true, false)[:thanks].size.should be_within(10).of(75)
@@ -104,7 +104,7 @@ describe "Spotlite::Person" do
       end
     end
   end
-  
+
   describe "#find method" do
     it "should return some people" do
       results = Spotlite::Person.find("conan")
@@ -115,14 +115,14 @@ describe "Spotlite::Person" do
       first.name.should eql("Alyssa Milano")
       first.imdb_id.should eql("0000192")
     end
-    
+
     it "should return no results" do
       results = Spotlite::Person.find("herpinson derpington")
       results.should be_an(Array)
       results.size.should eql(0)
     end
   end
-  
+
   describe "#search method" do
     it "should return some people" do
       results = Spotlite::Person.search({count: 50})
@@ -131,5 +131,5 @@ describe "Spotlite::Person" do
       results.each{ |person| person.should be_a(Spotlite::Person) }
     end
   end
-  
+
 end