spotify 12.5.0 → 12.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf64e70f3fd55a846fc2a016a2948cf547e92f54
-  data.tar.gz: 1012f48eb4fcb112b5866d63defe433a0974e2bb
+  metadata.gz: 20694ef78fc1b426595ffabf8d655da1875060fc
+  data.tar.gz: 5b99e59242913e03a3a3c1ef5e8e8f3835fbd4a0
 SHA512:
-  metadata.gz: c6b782905e37db551e1291e1769508d5f0fa0d6f1c6932700b9c0bace51433228e558ea607d99937a6e2f5b26c2a0066e93e069c74a7b2878cd5f315f6c5d376
-  data.tar.gz: b402e97d8772d953ae453b7b1d61a3cd73ad9346f970b739adb23d97cc3740a0677c4c1c14845af482ace77434adef085333bb9b491ba70ee53e3dcb5a29d9f3
+  metadata.gz: 042287392a9ad3ea971eb9110b8654e4e757077d6da762c5f43953632f5e99bee6a26e9f4622a73cbe97cd703df3b1e1f03cb6bd805040cc566ad7b252e796f2
+  data.tar.gz: 1bfc03fd117914dc937e3a5cb247f914287250032630aa763051db5acde55ddb0f2760720ed86ea246023567c8f57d4bb7187969106e29ba68699ba4b3ece2cb

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 [HEAD][]
 -----------
 
+[v12.5.1][]
+-----------
+
+- [b775947d6] Fix retaining class bug on Ruby 1.9.2
+
 [v12.5.0][]
 -----------
 This release *also* breaks backwards-compatibilty, now all functions
@@ -185,8 +190,9 @@ v0.0.0
 ------
 - release to register rubygems.org name
 
-[HEAD]: https://github.com/Burgestrand/spotify/compare/v12.5.0...HEAD
+[HEAD]: https://github.com/Burgestrand/spotify/compare/v12.5.1...HEAD
 
+[v12.5.1]: https://github.com/Burgestrand/spotify/compare/v12.5.0...v12.5.1
 [v12.5.0]: https://github.com/Burgestrand/spotify/compare/v12.4.0...v12.5.0
 [v12.4.0]: https://github.com/Burgestrand/spotify/compare/v12.3.0...v12.4.0
 [v12.3.0]: https://github.com/Burgestrand/spotify/compare/v12.2.0...v12.3.0

data/lib/spotify/managed_pointer.rb

@@ -90,8 +90,9 @@ module Spotify
               end
             end
 
-            def initialize(*)
-              super
+            alias_method :super_initialize, :initialize
+            def initialize(*args, &block)
+              super_initialize(*args, &block)
               self.class.retain(self)
             end
           end

data/lib/spotify/version.rb

@@ -1,7 +1,7 @@
 module Spotify
   # @note See README for versioning policy.
   # @return [String] Spotify gem version.
-  VERSION = '12.5.0'
+  VERSION = '12.5.1'
 
   # @return [String] Compatible libspotify API version.
   API_VERSION = '12.1.51'

data/spec/spotify/managed_pointer_spec.rb

@@ -3,68 +3,61 @@ describe Spotify::ManagedPointer do
   let(:klass) { described_class }
   let(:null) { FFI::Pointer::NULL }
   let(:pointer) { FFI::Pointer.new(1) }
-  let(:subject) do
-    Class.new(Spotify::ManagedPointer) do
-      def initialize(*)
-        super
-        self.autorelease = false
-      end
-
-      def self.name
-        "Anonymous"
-      end
-    end
-  end
+  let(:klass) { Spotify::User }
+  let(:retaining_klass) { klass.retaining_class }
 
   it "adds a ref if it is a retaining class" do
-    api.should_receive(:anonymous_add_ref)
-    subject.retaining_class.new(FFI::Pointer.new(1))
+    api.should_receive(:user_add_ref)
+    ptr = retaining_klass.new(FFI::Pointer.new(1))
+    ptr.autorelease = false
   end
 
   it "does not add or release when the pointer is null" do
-    api.should_not_receive(:anonymous_add_ref)
-    api.should_not_receive(:anonymous_release)
+    api.should_not_receive(:user_add_ref)
+    api.should_not_receive(:user_release)
 
-    ptr = subject.retaining_class.new(FFI::Pointer::NULL)
+    ptr = retaining_klass.new(FFI::Pointer::NULL)
+    ptr.autorelease = false
     ptr.free
   end
 
   describe "#release" do
     it "wraps the release pointer properly to avoid type-failures" do
-      api.should_receive(:anonymous_release).and_return do |pointer|
-        pointer.should be_instance_of(subject)
+      api.should_receive(:user_release).and_return do |pointer|
+        pointer.should be_instance_of(klass)
         pointer.should_not be_autorelease # autorelease should be off
       end
 
-      ptr = subject.new(FFI::Pointer.new(1))
+      ptr = klass.new(FFI::Pointer.new(1))
+      ptr.autorelease = false
       ptr.free
     end
   end
 
   describe ".to_native" do
     it "does not accept null pointers" do
-      expect { subject.to_native(nil, nil) }.to raise_error(TypeError, /cannot be null/)
-      expect { subject.to_native(Spotify::Session.new(null), nil) }.to raise_error(TypeError, /cannot be null/)
+      expect { klass.to_native(nil, nil) }.to raise_error(TypeError, /cannot be null/)
+      expect { klass.to_native(Spotify::Session.new(null), nil) }.to raise_error(TypeError, /cannot be null/)
     end
 
     it "does not accept pointers of another type" do
-      expect { subject.to_native(pointer, nil) }.to raise_error(TypeError, /expected a kind of Anonymous/)
-      expect { subject.to_native(Spotify::Session.new(pointer), nil) }.to raise_error(TypeError, /expected a kind of Anonymous/)
+      expect { klass.to_native(pointer, nil) }.to raise_error(TypeError, /expected a kind of Spotify::User/)
+      expect { klass.to_native(Spotify::Session.new(pointer), nil) }.to raise_error(TypeError, /expected a kind of Spotify::User/)
     end
 
     it "accepts pointers of the same kind, or a subkind" do
-      api.stub(:anonymous_add_ref)
+      api.stub(:user_add_ref)
 
-      retaining = subject.retaining_class.new(pointer)
+      retaining = retaining_klass.new(pointer)
       retaining.autorelease = false
 
-      regular = subject.new(pointer)
+      regular = klass.new(pointer)
       regular.autorelease = false
 
-      expect { subject.to_native(retaining, nil) }.to_not raise_error
-      expect { subject.to_native(regular, nil) }.to_not raise_error
-      expect { subject.retaining_class.to_native(retaining, nil) }.to_not raise_error
-      expect { subject.retaining_class.to_native(regular, nil) }.to_not raise_error
+      expect { klass.to_native(retaining, nil) }.to_not raise_error
+      expect { klass.to_native(regular, nil) }.to_not raise_error
+      expect { retaining_klass.to_native(retaining, nil) }.to_not raise_error
+      expect { retaining_klass.to_native(regular, nil) }.to_not raise_error
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spotify
 version: !ruby/object:Gem::Version
-  version: 12.5.0
+  version: 12.5.1
 platform: ruby
 authors:
 - Kim Burgestrand