spotify 12.0.1 → 12.0.2

data/CHANGELOG.md

@@ -2,6 +2,10 @@ __v12.1.0__
 -----------
 - erroneously released (wrong version number, does not follow version policy)
 
+[v12.0.2][]
+-----------
+- use error checking in Spotify::Pointer add_ref and release
+
 [v12.0.1][]
 -----------
 - add Spotify::Pointer, a FFI::Pointer that manages spotify pointer refcount!
@@ -118,6 +122,7 @@ v0.0.0
 ------
 - release to register rubygems.org name
 
+[v12.0.2]: https://github.com/Burgestrand/libspotify-ruby/compare/v12.0.1...v12.0.2
 [v12.0.1]: https://github.com/Burgestrand/libspotify-ruby/compare/v12.0.0...v12.0.1
 [v12.0.0]: https://github.com/Burgestrand/libspotify-ruby/compare/v11.0.2...v12.0.0
 [v11.0.2]: https://github.com/Burgestrand/libspotify-ruby/compare/v11.0.1...v11.0.2

data/README.markdown

@@ -22,7 +22,7 @@ Finally, if you, for some reason, are having trouble deciding if you should use
 
 Need help installing libspotify?
 --------------------------------
-You’re in luck! I’ve got you covered in the wiki, just [visit its main page](https://github.com/Burgestrand/libspotify-ruby/wiki)!
+You’re in luck! I’ve got you covered in Hallon’s wiki: [How to install libspotify](https://github.com/Burgestrand/Hallon/wiki/How-to-install-libspotify)!
 
 A note about versioning scheme
 ------------------------------

data/lib/spotify/types/pointer.rb

@@ -16,13 +16,13 @@ module Spotify
       # @param [Symbol] type
       # @return [Proc]
       def releaser_for(type)
-        unless Spotify.respond_to?(:"#{type}_release")
+        unless Spotify.respond_to?(:"#{type}_release!")
           raise InvalidTypeError, "#{type} is not a valid Spotify type"
         end
 
         lambda do |pointer|
-          $stdout.puts "Spotify::#{type}_release(#{pointer})" if $DEBUG
-          Spotify.send(:"#{type}_release", pointer) unless pointer.null?
+          $stdout.puts "Spotify::#{type}_release!(#{pointer})" if $DEBUG
+          Spotify.send(:"#{type}_release!", pointer) unless pointer.null?
         end
       end
 
@@ -49,7 +49,7 @@ module Spotify
       super pointer, self.class.releaser_for(@type = type.to_s)
 
       unless pointer.null?
-        Spotify.send(:"#{type}_add_ref", pointer)
+        Spotify.send(:"#{type}_add_ref!", pointer)
       end if add_ref
     end
 

data/lib/spotify/version.rb

@@ -1,4 +1,4 @@
 module Spotify
   # See README for versioning policy.
-  VERSION = [12, 0, 1].join('.')
+  VERSION = [12, 0, 2].join('.')
 end

data/spec/spotify_spec.rb

@@ -49,14 +49,14 @@ end
 
 # Used for checking Spotify::Pointer things.
 module Spotify
-  def bogus_add_ref(pointer)
+  def bogus_add_ref!(pointer)
   end
 
-  def bogus_release(pointer)
+  def bogus_release!(pointer)
   end
 
   # This may be called after our GC test. Randomly.
-  def garbage_release(pointer)
+  def garbage_release!(pointer)
   end
 end
 
@@ -164,7 +164,7 @@ describe Spotify do
       ref_added = false
 
       Spotify.stub(:session_user, FFI::Pointer.new(1)) do
-        Spotify.stub(:user_add_ref, proc { ref_added = true }) do
+        Spotify.stub(:user_add_ref, proc { ref_added = true; :ok }) do
           Spotify.session_user!(session)
         end
       end
@@ -208,7 +208,7 @@ describe Spotify do
       it "adds a reference on the given pointer" do
         ref_added = false
 
-        Spotify.stub(:bogus_add_ref, proc { ref_added = true }) do
+        Spotify.stub(:bogus_add_ref!, proc { ref_added = true; :ok }) do
           Spotify::Pointer.new(FFI::Pointer.new(1), :bogus, true)
         end
 
@@ -218,7 +218,7 @@ describe Spotify do
       it "does not add a reference on the given pointer if it is NULL" do
         ref_added = false
 
-        Spotify.stub(:bogus_add_ref, proc { ref_added = true }) do
+        Spotify.stub(:bogus_add_ref!, proc { ref_added = true; :ok }) do
           Spotify::Pointer.new(FFI::Pointer::NULL, :bogus, true)
         end
 
@@ -247,7 +247,7 @@ describe Spotify do
       it "should work" do
         gc_count = 0
 
-        Spotify.stub(:garbage_release, proc { gc_count += 1 }) do
+        Spotify.stub(:garbage_release!, proc { gc_count += 1 }) do
           5.times { Spotify::Pointer.new(my_pointer, :garbage, false) }
           5.times { GC.start; sleep 0.01 }
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spotify
 version: !ruby/object:Gem::Version
-  version: 12.0.1
+  version: 12.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-06 00:00:00.000000000 Z
+date: 2012-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -140,7 +140,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 876530711000755866
+      hash: -3119347920568123085
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -149,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 876530711000755866
+      hash: -3119347920568123085
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24