spot-gps 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8313cb1f50ceb658a15e2b26ac1cd482866e371f
-  data.tar.gz: 07b18f7b8c85a96e352ae60b06d39459edab4068
+  metadata.gz: 9d8b0903516cfa4fa8380df8b32e4dd8b7b99c48
+  data.tar.gz: 8027a9f30397682700e08ba08697bf4c08fe9105
 SHA512:
-  metadata.gz: 7016d42d4a25ac8d760ce84459526e13b58c570404b410d4b920aa931d3486770b42f77ced2ff3df70fb6db840456f5b056710a935696f89b02045d0f2ac7f02
-  data.tar.gz: 79bb4e3d101b91a5578c9981d4def1bddf78fd27a20df4cf67ae9e50abb9af9173d64248b21306fd36460c6505cb438ae8b0af8e27bf1c1d4f9b789abadb9367
+  metadata.gz: 6af5db30f5ca02f4defd81f2bce76f2664b6b2648d2583e15625ca1f3cec59f7edb55fb635199a69518b1bced687281ab90a81c32da5cfbc0d1f7d7b8cd4097e
+  data.tar.gz: c241257559dd44332de8868db7f7c3fbbca5f02258de2bbb8c20075ab5967e775f5f732eed5becbe13dd97e19891de6d8a470c4cda6019d9b34c35cd4b8ae00b

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## v0.2.2, 17 July 2016
+
+- Don't include password in querystring when it's blank
+- Handle "no-messages" response when asking for latest message
+
 ## v0.2.1, 16 July 2016
 
 - Add support for Ruby 2.2 and 2.1.

data/lib/spot-gps/api_service.rb

@@ -20,7 +20,10 @@ module SPOT
     # Make a GET request to the SPOT API
     def get(path:, params: {})
       params ||= {}
-      params = params.merge(feedPassword: feed_password) if feed_password
+
+      if feed_password && !feed_password.empty?
+        params = params.merge(feedPassword: feed_password)
+      end
 
       response = make_request(:get, path, params)
 

data/lib/spot-gps/services/messages.rb

@@ -29,7 +29,10 @@ module SPOT
 
       def latest
         response = get(path: "latest.json")
-        Resources::Message.new(unenvelope_body(response.body), response)
+        unenveloped_body = unenvelope_body(response.body)
+
+        return nil if unenveloped_body.nil?
+        Resources::Message.new(unenveloped_body, response)
       end
 
       private

data/lib/spot-gps/version.rb

@@ -1,3 +1,3 @@
 module SPOT
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.2.2'.freeze
 end

data/spec/api_service_spec.rb

@@ -29,6 +29,17 @@ describe SPOT::ApiService do
           to have_requested(:get, 'https://example.com/EXAMPLE_ID/messages.json').
           with(query: { feedPassword: 'password' })
       end
+
+      context 'that is blank' do
+        let(:password) { '' }
+
+        it 'is expected to not include the password in the querystring' do
+          service.get(path: 'messages.json')
+          expect(WebMock).
+            to have_requested(:get, 'https://example.com/EXAMPLE_ID/messages.json').
+            with(query: {})
+        end
+      end
     end
   end
 

data/spec/services/messages_spec.rb

@@ -217,5 +217,17 @@ describe SPOT::Services::Messages do
 
     it { is_expected.to be_a(SPOT::Resources::Message) }
     its(:response) { is_expected.to be_a(SPOT::ApiResponse) }
+
+    context "with no records" do
+      before do
+        stub_url = SPOT.endpoint + 'EXAMPLE_ID/latest.json'
+        stub_request(:get, stub_url).to_return(
+          body: load_fixture('no_messages.json'),
+          headers: { 'Content-Type' => 'application/json' }
+        )
+      end
+
+      it { is_expected.to be_nil }
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spot-gps
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-16 00:00:00.000000000 Z
+date: 2016-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock